Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

fix(eve): init - persist pnpm release-age policy (#3510)

Andrew Barba7259b962bbe4
diff --git a/.changeset/fresh-pnpm-dev.md b/.changeset/fresh-pnpm-dev.md
new file mode 100644
index 000000000..e9cd88854
--- /dev/null
+++ b/.changeset/fresh-pnpm-dev.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Set `minimumReleaseAge: 0` in newly generated pnpm workspace files so dependencies installed by `eve init` also pass pnpm's checks when starting the dev server or installing again.
diff --git a/packages/eve/src/setup/primitives/pm/pnpm.ts b/packages/eve/src/setup/primitives/pm/pnpm.ts
index 0fda7ae20..56c4f77b1 100644
--- a/packages/eve/src/setup/primitives/pm/pnpm.ts
+++ b/packages/eve/src/setup/primitives/pm/pnpm.ts
@@ -16,6 +16,7 @@ export const PNPM_WORKSPACE_MEMBERSHIP_ARGUMENTS = ["list", "--depth", "-1", "--
const SHARP_BUILD_POLICY = " sharp: false";
export const PNPM_WORKSPACE_CONTENT = [
+ "minimumReleaseAge: 0",
"minimumReleaseAgeStrict: true",
"allowBuilds:",
SHARP_BUILD_POLICY,
diff --git a/packages/eve/src/setup/scaffold/index.integration.test.ts b/packages/eve/src/setup/scaffold/index.integration.test.ts
index f5a93f56b..917a97e00 100644
--- a/packages/eve/src/setup/scaffold/index.integration.test.ts
+++ b/packages/eve/src/setup/scaffold/index.integration.test.ts
@@ -671,7 +671,7 @@ describe("ensureChannel", () => {
const projectRoot = await createTempDir();
const pnpmWorkspacePath = join(projectRoot, "pnpm-workspace.yaml");
const existingPolicy =
- '"minimumReleaseAgeStrict": &strict false # Keep this comment\notherPolicy: *strict\nallowBuilds:\n sharp: true\n';
+ 'minimumReleaseAge: 2880\n"minimumReleaseAgeStrict": &strict false # Keep this comment\notherPolicy: *strict\nallowBuilds:\n sharp: true\n';
await writeFile(
join(projectRoot, "package.json"),
`${JSON.stringify({ name: "demo", type: "module" }, null, 2)}\n`,
@@ -1155,6 +1155,9 @@ describe("scaffoldBaseProject", () => {
packageManager === "pnpm",
);
if (packageManager === "pnpm") {
+ await expect(readFile(join(projectRoot, "pnpm-workspace.yaml"), "utf8")).resolves.toContain(
+ "minimumReleaseAge: 0",
+ );
await expect(readFile(join(projectRoot, "pnpm-workspace.yaml"), "utf8")).resolves.toContain(
"minimumReleaseAgeStrict: true",
);
@@ -1178,7 +1181,7 @@ describe("scaffoldBaseProject", () => {
);
await writeFile(
join(workspaceRoot, "pnpm-workspace.yaml"),
- "minimumReleaseAgeStrict: false\npackages:\n - apps/*\n",
+ "minimumReleaseAge: 2880\nminimumReleaseAgeStrict: false\npackages:\n - apps/*\n",
"utf8",
);
@@ -1195,7 +1198,7 @@ describe("scaffoldBaseProject", () => {
await expect(pathExists(join(projectRoot, "pnpm-workspace.yaml"))).resolves.toBe(false);
await expect(readFile(join(workspaceRoot, "pnpm-workspace.yaml"), "utf8")).resolves.toBe(
- "minimumReleaseAgeStrict: false\npackages:\n - apps/*\n\nallowBuilds:\n sharp: false\n",
+ "minimumReleaseAge: 2880\nminimumReleaseAgeStrict: false\npackages:\n - apps/*\n\nallowBuilds:\n sharp: false\n",
);
const projectPackageJson = JSON.parse(
await readFile(join(projectRoot, "package.json"), "utf8"),
diff --git a/packages/eve/test/scenarios/eve-init.scenario.test.ts b/packages/eve/test/scenarios/eve-init.scenario.test.ts
index d574546c3..d89d9caa6 100644
--- a/packages/eve/test/scenarios/eve-init.scenario.test.ts
+++ b/packages/eve/test/scenarios/eve-init.scenario.test.ts
@@ -1,5 +1,5 @@
import { execFile, spawn } from "node:child_process";
-import { readFile, realpath, writeFile } from "node:fs/promises";
+import { mkdir, readFile, realpath, writeFile } from "node:fs/promises";
import { basename, join } from "node:path";
import { fileURLToPath } from "node:url";
import { promisify } from "node:util";
@@ -15,7 +15,7 @@ import { useTemporaryDirectories } from "../../src/internal/testing/use-temporar
const EVE_BIN_PATH = fileURLToPath(new URL("../../bin/eve.js", import.meta.url));
const runFile = promisify(execFile);
-const RELEASE_AGE_MINUTES = "2880";
+const RELEASE_AGE_MINUTES = 100_000_000;
const PNPM_INIT_INSTALL_ARGUMENTS = [
"install",
"--no-frozen-lockfile",
@@ -185,7 +185,7 @@ async function createFakeNpmEnvironment(scratch: string): Promise<{
}
describe("eve init smoke", () => {
- it("resolves a standalone pnpm scaffold under the release-age policy", async () => {
+ it("installs and runs a standalone pnpm scaffold under an inherited release-age policy", async () => {
const scratch = await createScratchDirectory("eve-init-release-age-");
const eveTarball = `file:${await ensureScenarioEveTarballPath()}`;
const pnpmfile = join(scratch, "scaffold-pnpmfile.cjs");
@@ -198,22 +198,19 @@ describe("eve init smoke", () => {
"} } };\n",
].join("\n"),
);
- const workspacePolicy = (await loadYaml(
- fileURLToPath(new URL("../../../../pnpm-workspace.yaml", import.meta.url)),
- )) as { minimumReleaseAgeExclude: string[] };
+ const configHome = join(scratch, "config");
+ await mkdir(join(configHome, "pnpm"), { recursive: true });
+ await writeFile(
+ join(configHome, "pnpm", "config.yaml"),
+ `minimumReleaseAge: ${RELEASE_AGE_MINUTES}\nverifyDepsBeforeRun: install\n`,
+ );
const env = {
...withoutCodingAgentMarkers(process.env),
- // The agent path skips the interactive dev handoff, which cannot run
- // against the real pnpm install this scenario performs.
+ // Exercise the package-manager dev handoff separately without opening a TUI.
AI_AGENT: "claude",
CI: "true",
PNPM_CONFIG_GLOBAL_PNPMFILE: pnpmfile,
- PNPM_CONFIG_MINIMUM_RELEASE_AGE: RELEASE_AGE_MINUTES,
- // Use the repository's reviewed dependency exceptions for the current
- // release without adding bypasses to scaffolded projects.
- PNPM_CONFIG_MINIMUM_RELEASE_AGE_EXCLUDE: JSON.stringify(
- workspacePolicy.minimumReleaseAgeExclude,
- ),
+ XDG_CONFIG_HOME: configHome,
};
const result = await runEveBin(scratch, ["init", "policy-agent"], env);
@@ -227,6 +224,17 @@ describe("eve init smoke", () => {
"minimumReleaseAgeStrict: true",
);
+ // pnpm checks the installed lockfile before exec/run and may reinstall.
+ // A one-time install flag must not leave the next command rejecting it.
+ const dev = await runFile("pnpm", ["exec", "eve", "dev", "--help"], {
+ cwd: projectDir,
+ env,
+ });
+ expect(dev.stdout).toContain("Usage: eve dev");
+ await expect(
+ runFile("pnpm", ["install", "--frozen-lockfile"], { cwd: projectDir, env }),
+ ).resolves.toMatchObject({ stdout: expect.any(String) });
+
// Exercise the unpublished eve override independently of the initial
// scaffold install's release-age bypass.
const manifestPath = join(projectDir, "package.json");