The Open Framework for Building Agents
fix(eve): always create schedules active (#4510)
Colton Padden84793edce6d9
diff --git a/.changeset/active-schedule-creation.md b/.changeset/active-schedule-creation.mdnew file mode 100644index 000000000..47275d4cd--- /dev/null+++ b/.changeset/active-schedule-creation.md@@ -0,0 +1,5 @@+---+"eve": patch+---++Schedule creation no longer accepts an initial state: schedules are created active by default (or completed if a one-time schedule is already past). Use the existing enable and disable operations to change a schedule's state after creation.diff --git a/packages/eve/src/public/schedules/providers/in-memory.test.ts b/packages/eve/src/public/schedules/providers/in-memory.test.tsindex 36fbf41cf..4b1faa5f0 100644--- a/packages/eve/src/public/schedules/providers/in-memory.test.ts+++ b/packages/eve/src/public/schedules/providers/in-memory.test.ts@@ -21,11 +21,12 @@ describe("inMemoryScheduleProvider", () => {const deliver = vi.fn(async (delivery: unknown) => {deliveries.push(delivery);});- await provider.create(context("create", { key: "app", deliver }), {+ const created = await provider.create(context("create", { key: "app", deliver }), {name: "daily",expression: { type: "cron", cron: "0 9 * * *" },payload: { request: "do work" },});+ expect(created.state).toBe("active");await provider.invoke(context("invoke-1"), "daily");await provider.invoke(context("invoke-2"), "daily");expect(deliveries).toHaveLength(2);diff --git a/packages/eve/src/public/schedules/providers/in-memory.ts b/packages/eve/src/public/schedules/providers/in-memory.tsindex 0498c6b37..ea7a57e77 100644--- a/packages/eve/src/public/schedules/providers/in-memory.ts+++ b/packages/eve/src/public/schedules/providers/in-memory.ts@@ -48,7 +48,7 @@ export function inMemoryScheduleProvider(state:schedule.expression.type === "single" && Date.parse(schedule.expression.at) <= timestamp? "completed"- : (schedule.state ?? "active"),+ : "active",target: context.target,updatedAt: timestamp,};diff --git a/packages/eve/src/public/schedules/providers/vercel.test.ts b/packages/eve/src/public/schedules/providers/vercel.test.tsindex d0369e33c..5b3a5aeba 100644--- a/packages/eve/src/public/schedules/providers/vercel.test.ts+++ b/packages/eve/src/public/schedules/providers/vercel.test.ts@@ -72,26 +72,6 @@ describe("vercelScheduleProvider", () => {expect(new Headers(init?.headers).get("Authorization")).toBe(`Bearer ${oidcToken}`);});- it("reports when creating an inactive schedule leaves it active after disable fails", async () => {- vi.stubEnv("VERCEL", "1");- vi.stubEnv("VERCEL_ENV", "production");- vi.stubEnv("VERCEL_OIDC_TOKEN", oidcToken);- const fetchImpl = vi- .fn<typeof fetch>()- .mockResolvedValueOnce(Response.json(schedule()))- .mockResolvedValueOnce(new Response("disable failed", { status: 500 }));- const provider = vercelScheduleProvider({ fetch: fetchImpl });-- await expect(- provider.create(context, {- expression: { type: "cron", cron: "0 12 * * *", timezone: "UTC" },- payload: "Review PRs",- name: "review-prs-daily",- state: "inactive",- }),- ).rejects.toThrow("was created active, but disabling it failed; it may remain active");- expect(fetchImpl).toHaveBeenCalledTimes(2);- });it("omits a blank first-page cursor", async () => {vi.stubEnv("VERCEL", "1");vi.stubEnv("VERCEL_ENV", "production");diff --git a/packages/eve/src/public/schedules/providers/vercel.ts b/packages/eve/src/public/schedules/providers/vercel.tsindex 0da5e5ead..212ab868e 100644--- a/packages/eve/src/public/schedules/providers/vercel.ts+++ b/packages/eve/src/public/schedules/providers/vercel.ts@@ -42,7 +42,7 @@ export function vercelScheduleProvider(kind: "vercel",async create(context, input) {const schedules = await client(context.abortSignal);- let schedule: VercelSchedule = await schedules.create({+ const schedule: VercelSchedule = await schedules.create({expression: toVercelExpression(input.expression),jitter: input.expression.type === "cron" ? input.expression.jitter : undefined,name: input.name,@@ -51,16 +51,6 @@ export function vercelScheduleProvider(target: { topic: deriveEveScheduleQueueTopic(context.target.key) },timezone: input.expression.timezone,});- if (input.state === "inactive") {- try {- schedule = await schedules.disable({ name: input.name, namespace: context.namespace });- } catch (error) {- throw new Error(- `Schedule ${JSON.stringify(input.name)} was created active, but disabling it failed; it may remain active.`,- { cause: error },- );- }- }return fromVercelSchedule(schedule);},async list(context, input): Promise<SchedulePage> {diff --git a/packages/eve/src/public/schedules/subscription.ts b/packages/eve/src/public/schedules/subscription.tsindex 64292be61..8814d9786 100644--- a/packages/eve/src/public/schedules/subscription.ts+++ b/packages/eve/src/public/schedules/subscription.ts@@ -127,7 +127,6 @@ export interface ScheduleCreate<TPayload> {readonly expression: ScheduleExpression;readonly payload: TPayload;readonly name: string;- readonly state?: ScheduleState;}export interface ScheduleList {readonly cursor?: string;