Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

test(eve): pin toolResultFrom warning for loaded connections sharing a fallback (#3085) (#4876)

roboeve[bot]8c8b7e8285eb
diff --git a/packages/eve/src/public/tools/result.test.ts b/packages/eve/src/public/tools/result.test.ts
index 5e6ea7703..a4916e6aa 100644
--- a/packages/eve/src/public/tools/result.test.ts
+++ b/packages/eve/src/public/tools/result.test.ts
@@ -263,4 +263,38 @@ describe("toolResultFrom", () => {
});
expect(toolResultFrom(toolResult("first__search", []), second)).toBeUndefined();
});
+
+ // #3085: loaded definitions match by source identity, so a shared fallback
+ // key alone should not warn at registration time.
+ it.fails("does not warn when loaded connections share a fallback identity", () => {
+ const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
+ const key = connectionDefinitionKey("https://api.githubcopilot.com/mcp/", "GitHub");
+ const github = defineMcpClientConnection({
+ url: "https://api.githubcopilot.com/mcp/",
+ description: "GitHub",
+ });
+ const githubWrite = defineMcpClientConnection({
+ url: "https://api.githubcopilot.com/mcp/",
+ description: "GitHub",
+ });
+
+ registerDefinitionSource(
+ github,
+ { kind: "connection", logicalPath: "connections/github.ts", name: "github" },
+ key,
+ );
+ registerDefinitionSource(
+ githubWrite,
+ { kind: "connection", logicalPath: "connections/githubwrite.ts", name: "githubwrite" },
+ key,
+ );
+
+ expect(toolResultFrom(toolResult("github__search", []), github)?.connectionToolName).toBe(
+ "search",
+ );
+ expect(
+ toolResultFrom(toolResult("githubwrite__search", []), githubWrite)?.connectionToolName,
+ ).toBe("search");
+ expect(warn).not.toHaveBeenCalled();
+ });
});