Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

fix(eve): sandbox - keep brokered secrets out of Microsandbox env (#646)

Andrew Barba9087496a0a3c
diff --git a/.changeset/safe-microsandbox-secrets.md b/.changeset/safe-microsandbox-secrets.md
new file mode 100644
index 000000000..746450890
--- /dev/null
+++ b/.changeset/safe-microsandbox-secrets.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Prevent brokered credential values from being exposed to commands running in Microsandbox. Guest Git configuration continues to use broker-managed placeholders for authenticated requests.
diff --git a/packages/eve/src/execution/sandbox/bindings/microsandbox-network.ts b/packages/eve/src/execution/sandbox/bindings/microsandbox-network.ts
index 0fe32bbac..1e17c2f10 100644
--- a/packages/eve/src/execution/sandbox/bindings/microsandbox-network.ts
+++ b/packages/eve/src/execution/sandbox/bindings/microsandbox-network.ts
@@ -269,12 +269,7 @@ export function createTransformBrokerEnvironment(
});
}
- return {
- EVE_MICROSANDBOX_NETWORK_TRANSFORMS: Buffer.from(
- JSON.stringify(plan.transformHeaderRules),
- ).toString("base64"),
- ...gitConfigEnvironment,
- };
+ return gitConfigEnvironment;
}
interface VercelNetworkPolicyRule {
diff --git a/packages/eve/src/execution/sandbox/bindings/microsandbox.test.ts b/packages/eve/src/execution/sandbox/bindings/microsandbox.test.ts
index 21a425bf3..e6ce4e39d 100644
--- a/packages/eve/src/execution/sandbox/bindings/microsandbox.test.ts
+++ b/packages/eve/src/execution/sandbox/bindings/microsandbox.test.ts
@@ -3,6 +3,7 @@ import { beforeEach, describe, expect, it, vi } from "vitest";
import { createMicrosandboxSandboxBackend } from "#execution/sandbox/bindings/microsandbox.js";
import {
createMicrosandboxNetworkPlan,
+ createTransformBrokerEnvironment,
serializeMicrosandboxNetworkPolicyJson,
} from "#execution/sandbox/bindings/microsandbox-network.js";
import {
@@ -163,6 +164,26 @@ describe.skipIf(onWindows)("createMicrosandboxNetworkPlan", () => {
]);
});
+ it("keeps brokered header values out of the guest environment", () => {
+ const plan = createMicrosandboxNetworkPlan({
+ allow: {
+ "github.com": [
+ {
+ transform: [{ headers: { Authorization: "Basic real-secret" } }],
+ },
+ ],
+ },
+ });
+
+ expect(createTransformBrokerEnvironment(plan)).toEqual({
+ GIT_CONFIG_COUNT: "1",
+ GIT_CONFIG_KEY_0: "http.https://github.com/.extraheader",
+ GIT_CONFIG_VALUE_0: expect.stringMatching(
+ /^Authorization: __EVE_MSB_SECRET_[A-Fa-f0-9]{24}__$/u,
+ ),
+ });
+ });
+
it("serializes policy JSON using microsandbox's native snake-case schema", () => {
const plan = createMicrosandboxNetworkPlan({
allow: ["api.example.com", "*.npmjs.org"],