The Open Framework for Building Agents
fix(eve): preserve dynamic tools without durable labels (#3163)
Ben Pankow97fccacfe4c7
diff --git a/.changeset/calm-activity-cancellations.md b/.changeset/calm-activity-cancellations.mdnew file mode 100644index 000000000..5a96a159a--- /dev/null+++ b/.changeset/calm-activity-cancellations.md@@ -0,0 +1,5 @@+---+"eve": patch+---++Dynamic tools with non-durable presentation labels now remain available and fall back to their tool names.diff --git a/packages/eve/src/context/dynamic-tool-lifecycle.test.ts b/packages/eve/src/context/dynamic-tool-lifecycle.test.tsindex 9f541abc3..d481f2cac 100644--- a/packages/eve/src/context/dynamic-tool-lifecycle.test.ts+++ b/packages/eve/src/context/dynamic-tool-lifecycle.test.ts@@ -170,6 +170,44 @@ describe("durable callback capture validation", () => {'Dynamic tool "captured" callback "execute" has a non-serializable capture',);});++ it("falls back to the tool name when presentation callbacks are not durable", () => {+ const entry = defineTool({+ description: "labeled tool",+ inputSchema: { type: "object" },+ label: {+ complete: () => "Completed label",+ delta: () => "Delta label",+ start: () => "Starting label",+ },+ execute: async () => null,+ });+ stampDurableDynamicToolCallbacks(entry, {+ execute: { callback: () => null, closure: {} },+ });++ expect(validateDurableDynamicToolCallbacks("labeled", entry, callbackOwner("labeled"))).toEqual(+ { execute: { closure: {} } },+ );+ });++ it("still requires durable behavioral callbacks", () => {+ const entry = defineTool({+ approval: () => "user-approval",+ description: "guarded tool",+ inputSchema: { type: "object" },+ execute: async () => null,+ });+ stampDurableDynamicToolCallbacks(entry, {+ execute: { callback: () => null, closure: {} },+ });++ expect(() =>+ validateDurableDynamicToolCallbacks("guarded", entry, callbackOwner("guarded")),+ ).toThrow(+ 'Dynamic tool "guarded" callback "approvalRequest" does not have a durable descriptor',+ );+ });});// ---------------------------------------------------------------------------diff --git a/packages/eve/src/context/dynamic-tool-lifecycle.ts b/packages/eve/src/context/dynamic-tool-lifecycle.tsindex 545658b05..6eaaa4426 100644--- a/packages/eve/src/context/dynamic-tool-lifecycle.ts+++ b/packages/eve/src/context/dynamic-tool-lifecycle.ts@@ -199,9 +199,6 @@ export function validateDurableDynamicToolCallbacks();}- const hasLabelComplete = entry.label?.complete !== undefined;- const hasLabelDelta = entry.label?.delta !== undefined;- const hasLabelStart = entry.label?.start !== undefined;const hasApproval = entry.approval !== undefined;const hasApprovalResponse =entry.approval !== undefined &&@@ -219,21 +216,21 @@ export function validateDurableDynamicToolCallbacks(owner,phase: "labelComplete",stamped: raw.label?.complete,- required: hasLabelComplete,+ required: false,});const labelDelta = validateReference({name,owner,phase: "labelDelta",stamped: raw.label?.delta,- required: hasLabelDelta,+ required: false,});const labelStart = validateReference({name,owner,phase: "labelStart",stamped: raw.label?.start,- required: hasLabelStart,+ required: false,});const approvalKey = validateReference({name,diff --git a/packages/eve/src/public/channels/slack/activity-progress.test.ts b/packages/eve/src/public/channels/slack/activity-progress.test.tsindex 0834c851a..28272d9e9 100644--- a/packages/eve/src/public/channels/slack/activity-progress.test.ts+++ b/packages/eve/src/public/channels/slack/activity-progress.test.ts@@ -236,7 +236,7 @@ describe("Slack activity activity", () => {});expect(activityMessages(settled).get("turn")).toContain("✓ tester & reviewer");- expect(activityMessages(settled).get("turn")).toContain("– search <web>");+ expect(activityMessages(settled).get("turn")).toContain("⊘ search <web>");expect(requests.map((request) => request.operation)).toEqual(["conversations.replies","chat.postMessage",diff --git a/packages/eve/src/public/channels/slack/activity.ts b/packages/eve/src/public/channels/slack/activity.tsindex f8c19b4c0..78ff5f6a7 100644--- a/packages/eve/src/public/channels/slack/activity.ts+++ b/packages/eve/src/public/channels/slack/activity.ts@@ -499,7 +499,7 @@ function phaseIcon(phase: ActivityWorkStateV1["phase"] | ActivityActionStateV1["case "rejected":return "✗";case "cancelled":- return "–";+ return "⊘";case "running":return "•";}