Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

fix(eve): capture rest bindings in dynamic tool closures (#4862)

roboeve[bot]a475f2dc61f6
diff --git a/.changeset/dynamic-tool-rest-bindings.md b/.changeset/dynamic-tool-rest-bindings.md
new file mode 100644
index 000000000..1f0d74b8a
--- /dev/null
+++ b/.changeset/dynamic-tool-rest-bindings.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Dynamic tools now capture locals bound by an array rest element (`const [first, ...rest] = ...`) or a rest parameter (`(...args) =>`). Before, the hoisted callback threw `ReferenceError` and the resolver's tools were dropped.
diff --git a/packages/eve/src/internal/workflow-bundle/dynamic-tool-ast-references.ts b/packages/eve/src/internal/workflow-bundle/dynamic-tool-ast-references.ts
index 73684bd47..c2e72814f 100644
--- a/packages/eve/src/internal/workflow-bundle/dynamic-tool-ast-references.ts
+++ b/packages/eve/src/internal/workflow-bundle/dynamic-tool-ast-references.ts
@@ -230,6 +230,9 @@ export function collectPatternNames(pattern: AstNode | null, names: string[]): v
if (pattern.type === "ArrayPattern") {
for (const element of pattern.elements ?? []) collectPatternNames(element, names);
}
+ if (pattern.type === "RestElement") {
+ collectPatternNames(pattern.argument as AstNode | null, names);
+ }
if (pattern.type === "AssignmentPattern") {
collectPatternNames(pattern.left as AstNode | null, names);
}
diff --git a/packages/eve/src/internal/workflow-bundle/dynamic-tool-transform.test.ts b/packages/eve/src/internal/workflow-bundle/dynamic-tool-transform.test.ts
index 728a1b4b5..e36191dca 100644
--- a/packages/eve/src/internal/workflow-bundle/dynamic-tool-transform.test.ts
+++ b/packages/eve/src/internal/workflow-bundle/dynamic-tool-transform.test.ts
@@ -572,7 +572,7 @@ export default defineDynamic({
});
// https://github.com/vercel/eve/issues/4860
- it.fails("captures locals bound by an array rest element", async () => {
+ it("captures locals bound by an array rest element", async () => {
const { callHandler } = await transformAndEval(
"tools/array-rest.ts",
`
@@ -596,7 +596,7 @@ export default defineDynamic({
});
// https://github.com/vercel/eve/issues/4860
- it.fails("captures a rest parameter of the resolver", async () => {
+ it("captures a rest parameter of the resolver", async () => {
const { callHandler } = await transformAndEval(
"tools/rest-param.ts",
`