The Open Framework for Building Agents
feat(eve): propagate authorized approval state through subagents (#1898)
Ben Pankowb863c57a67ee
diff --git a/packages/eve/src/channel/types.ts b/packages/eve/src/channel/types.tsindex bc46efed5..e3a5c6bfb 100644--- a/packages/eve/src/channel/types.ts+++ b/packages/eve/src/channel/types.ts@@ -1,6 +1,6 @@import type { UserContent } from "ai";-import type { UnstampedMessageStreamEvent, MessageStreamEvent } from "#protocol/message.js";+import type { MessageStreamEvent, UnstampedMessageStreamEvent } from "#protocol/message.js";import type { CancelTurnResult as ProtocolCancelTurnResult } from "#protocol/cancel-turn.js";import type { RunMode } from "#shared/run-mode.js";import type { RuntimeSubagentChildResult } from "#runtime/actions/types.js";@@ -274,10 +274,16 @@ export interface SubagentInputRequestHookPayload {readonly subagentName: string;}-/** Authorization lifecycle event forwarded from a delegated child. */+/** Responder-specific lifecycle event forwarded from a delegated child. */export type SubagentAuthorizationEvent = Extract<UnstampedMessageStreamEvent,- { type: "authorization.required" | "authorization.completed" }+ {+ type:+ | "approval.candidate"+ | "approval.settled"+ | "authorization.required"+ | "authorization.completed";+ }>;/**diff --git a/packages/eve/src/execution/subagent-adapter.ts b/packages/eve/src/execution/subagent-adapter.tsindex 17738d034..53a199fe8 100644--- a/packages/eve/src/execution/subagent-adapter.ts+++ b/packages/eve/src/execution/subagent-adapter.ts@@ -24,6 +24,12 @@ const log = createLogger("execution.subagent-adapter");*/export const SUBAGENT_ADAPTER: ChannelAdapter = {kind: SUBAGENT_ADAPTER_KIND,+ async "approval.candidate"(data, ctx) {+ await forwardSubagentAuthorizationEvent({ data, type: "approval.candidate" }, ctx);+ },+ async "approval.settled"(data, ctx) {+ await forwardSubagentAuthorizationEvent({ data, type: "approval.settled" }, ctx);+ },async "authorization.required"(data, ctx) {await forwardSubagentAuthorizationEvent({ data, type: "authorization.required" }, ctx);},diff --git a/packages/eve/src/execution/subagent-auth-proxy.integration.test.ts b/packages/eve/src/execution/subagent-auth-proxy.integration.test.tsindex cfac5bac0..6b5b59c3d 100644--- a/packages/eve/src/execution/subagent-auth-proxy.integration.test.ts+++ b/packages/eve/src/execution/subagent-auth-proxy.integration.test.ts@@ -136,6 +136,52 @@ function decodeEvent(chunk: Uint8Array): MessageStreamEvent {}describe("subagent authorization proxy", () => {+ it("preserves approval candidate and settlement events", async () => {+ const parentSessionId = "parent-approval-session";+ const session = createSession(parentSessionId);+ const { ctx } = buildContext({ adapter: authorizationAdapter, sessionId: parentSessionId });+ const chunks: Uint8Array[] = [];+ const parentWritable = createCapturingWritable(chunks);+ const candidateEvent: SubagentAuthorizationEvent = {+ data: {+ candidateId: "candidate-1",+ outcome: "pending",+ requestId: "approval-1",+ responderPrincipalId: "slack:T1:U1",+ sequence: 0,+ stepIndex: 1,+ turnId: "child-turn",+ },+ type: "approval.candidate",+ };+ const settledEvent: SubagentAuthorizationEvent = {+ data: {+ outcome: "approved",+ requestId: "approval-1",+ responderPrincipalId: "slack:T1:U1",+ sequence: 0,+ stepIndex: 2,+ turnId: "child-turn",+ },+ type: "approval.settled",+ };++ await emitProxiedSubagentEvent({+ ctx,+ durableSession: projectToDurableSession(session),+ hookPayload: authorizationPayload(candidateEvent),+ parentWritable,+ });+ await emitProxiedSubagentEvent({+ ctx,+ durableSession: projectToDurableSession(session),+ hookPayload: authorizationPayload(settledEvent),+ parentWritable,+ });++ expect(decodeEvent(chunks[0]!)).toMatchObject(candidateEvent);+ expect(decodeEvent(chunks[1]!)).toMatchObject(settledEvent);+ });it("preserves events and parent adapter state across required/completed steps", async () => {const parentSessionId = "parent-session";const session = createSession(parentSessionId);