The Open Framework for Building Agents
fix(eve): sandbox image - exit login shells cleanly as vercel-sandbox (#2942)
Andrew Barbabad08131f43a
diff --git a/.changeset/fix-sandbox-image-login-shell.md b/.changeset/fix-sandbox-image-login-shell.mdnew file mode 100644index 000000000..650c268ee--- /dev/null+++ b/.changeset/fix-sandbox-image-login-shell.md@@ -0,0 +1,5 @@+---+"eve": patch+---++Fix the sandbox base image so a non-interactive `bash -lc` login shell exits cleanly as `vercel-sandbox`. Ubuntu's default `.bash_logout` ran `clear_console` on exit, which wrote `TERM environment variable not set.` to stderr and, under `set -e`, turned a successful `exit 0` into exit 1 on Vercel Sandbox. `sudo` no longer warns about unresolvable sandbox hostnames, `$HOME/.local/bin` exists on `PATH` for user-scoped installs, and Node is root-owned on every architecture.diff --git a/.github/workflows/docker-image-size-analysis.yml b/.github/workflows/docker-image-size-analysis.ymlindex e6d28b9b2..ee9cc5b04 100644--- a/.github/workflows/docker-image-size-analysis.yml+++ b/.github/workflows/docker-image-size-analysis.yml@@ -99,11 +99,19 @@ jobs:set -euo pipefailtest "$(id -un)" = vercel-sandboxtest "$(stat -c %U /workspace)" = vercel-sandbox+ test "$(stat -c %U /usr/local/bin/node)" = roottest "$(npm prefix -g)" = "$HOME/.local"test "$(pnpm bin -g)" = "$PNPM_HOME/bin"+ test -d "$HOME/.local/bin"git init --quiet /workspacegit -C /workspace remote add origin https://github.com/vercel/eve.gitsudo -n true+ # Backends run authored commands through a non-interactive `bash -lc`+ # login shell. Exiting it must be silent and preserve the exit status.+ test ! -e "$HOME/.bash_logout"+ test -z "$(bash -lc "exit 0" 2>&1)"+ bash -lc "set -euo pipefail; exit 0"+ bash -lc "exit 3" || test "$?" = 3'- name: Generate Docker image size reportdiff --git a/docs/sandbox.mdx b/docs/sandbox.mdxindex 7eee993b8..c3a4bd0ff 100644--- a/docs/sandbox.mdx+++ b/docs/sandbox.mdx@@ -158,6 +158,8 @@ With `backend` omitted, eve uses `defaultBackend()`, which resolves on first useBy default, Docker and microsandbox pull `ghcr.io/vercel/eve` while Vercel Sandbox pulls `vcr.vercel.com/vercel/eve/base`. Each image tag matches the installed eve version. Set `EVE_SANDBOX_IMAGE_TAG` to replace the version-derived tag for these default images. An explicit `image` passed to `docker()` or `microsandbox()` still takes precedence.+On every backend, authored commands run as the non-root `vercel-sandbox` user through a non-interactive `bash -lc` login shell. `/workspace` and `$HOME` are writable, `$HOME/.local/bin` is on `PATH` for user-scoped executables, and system paths such as `/usr/local` stay root-owned. Use passwordless `sudo` when setup genuinely needs system-wide changes; `sudo` resets the environment, so pass through variables like `NPM_CONFIG_PREFIX` explicitly if a privileged step depends on them.+`defaultBackend()` also accepts a keyed bag so each inner backend gets its own typed create options:```tsdiff --git a/packages/eve/Dockerfile b/packages/eve/Dockerfileindex 5f9d20834..2adcc4ca0 100644--- a/packages/eve/Dockerfile+++ b/packages/eve/Dockerfile@@ -46,7 +46,7 @@ RUN set -eux; \test -n "${node_file}"; \curl -fsSLO "${base_url}/${node_file}"; \grep " ${node_file}$" "${shasums}" | sha256sum -c -; \- tar -xJf "${node_file}" -C /usr/local --strip-components=1; \+ tar -xJf "${node_file}" -C /usr/local --strip-components=1 --no-same-owner; \rm "${node_file}" "${shasums}"; \rm -rf /usr/local/include/node /usr/local/share/doc /usr/local/share/man; \npm install -g "pnpm@${PNPM_VERSION}"; \@@ -73,15 +73,26 @@ RUN set -eux; \if ! id -u vercel-sandbox >/dev/null 2>&1; then \useradd --create-home --shell /bin/bash vercel-sandbox; \fi; \+ # Ubuntu's skel .bash_logout runs `clear_console` when a login shell exits at+ # SHLVL=1. Backends run every command through `bash -lc` with no TTY, so it+ # prints "TERM environment variable not set." and, under `set -e`, turns a+ # successful `exit 0` into exit 1.+ rm -f /home/vercel-sandbox/.bash_logout; \# Keep Node and pnpm root-owned: recursively changing their ownership copies# them into another image layer. A small user-owned prefix retains global installs.install -d --owner=vercel-sandbox --group=vercel-sandbox \/home/vercel-sandbox/.local \+ /home/vercel-sandbox/.local/bin \/home/vercel-sandbox/.local/share/pnpm; \mkdir -p /workspace; \chown vercel-sandbox:vercel-sandbox /workspace; \- printf 'vercel-sandbox ALL=(ALL) NOPASSWD:ALL\n' >/etc/sudoers.d/vercel-sandbox; \- chmod 0440 /etc/sudoers.d/vercel-sandbox+ # !fqdn: sandbox hostnames are not resolvable, so sudo would otherwise warn on stderr.+ printf '%s\n' \+ 'Defaults !fqdn' \+ 'vercel-sandbox ALL=(ALL) NOPASSWD:ALL' \+ >/etc/sudoers.d/vercel-sandbox; \+ chmod 0440 /etc/sudoers.d/vercel-sandbox; \+ visudo -cf /etc/sudoers.d/vercel-sandboxENV NPM_CONFIG_PREFIX=/home/vercel-sandbox/.localENV PNPM_HOME=/home/vercel-sandbox/.local/share/pnpm