The Open Framework for Building Agents
fix(eve): subagents - preserve remote agent base paths (#1125)
Andrew Barbac2079a436739
diff --git a/.changeset/wise-agents-route.md b/.changeset/wise-agents-route.mdnew file mode 100644index 000000000..0d3e4bb39--- /dev/null+++ b/.changeset/wise-agents-route.md@@ -0,0 +1,5 @@+---+"eve": patch+---++Preserve remote agent base paths when creating sessions and cancelling turns, so same-origin agents mounted below a route prefix no longer receive requests at the wrong endpoint.diff --git a/packages/eve/src/execution/remote-agent-dispatch.test.ts b/packages/eve/src/execution/remote-agent-dispatch.test.tsindex 5c0a268ca..9a33c4bc3 100644--- a/packages/eve/src/execution/remote-agent-dispatch.test.ts+++ b/packages/eve/src/execution/remote-agent-dispatch.test.ts@@ -74,6 +74,36 @@ describe("startRemoteAgentSession", () => {});});+ it("preserves a prefixed remote base path on create-session requests", async () => {+ const fetchMock = vi+ .fn()+ .mockResolvedValue(+ new Response(JSON.stringify({ sessionId: "remote-session" }), { status: 202 }),+ );+ vi.stubGlobal("fetch", fetchMock);++ await startRemoteAgentSession({+ action: createAction(),+ callbackBaseUrl: "https://caller.example.com",+ remote: {+ ...createRemoteAgent(),+ url: "https://remote.example.com/eve/agents/researcher",+ },+ session: {+ agent: { modelReference: { id: "mock/test" }, system: "", tools: [] },+ compaction: { recentWindowSize: 10, threshold: 100000 },+ continuationToken: "eve:parent-token",+ history: [],+ sessionId: "parent-session",+ },+ });++ expect(fetchMock).toHaveBeenCalledWith(+ "https://remote.example.com/eve/agents/researcher/eve/v1/session",+ expect.objectContaining({ method: "POST" }),+ );+ });+it("sends a declared outputSchema on the remote create-session request", async () => {const fetchMock = vi.fn().mockResolvedValue(new Response(JSON.stringify({ ok: true, sessionId: "remote-session" }), {@@ -230,6 +260,33 @@ describe("cancelRemoteAgentTurn", () => {});});+ it("preserves a prefixed remote base path on cancel-turn requests", async () => {+ const fetchMock = vi+ .fn()+ .mockResolvedValue(+ Response.json(+ { ok: true, sessionId: "remote/session id", status: "accepted" },+ { status: 202 },+ ),+ );+ vi.stubGlobal("fetch", fetchMock);++ await expect(+ cancelRemoteAgentTurn({+ remote: {+ ...createRemoteAgent(),+ url: "https://remote.example.com/eve/agents/researcher/",+ },+ sessionId: "remote/session id",+ }),+ ).resolves.toEqual({ status: "accepted" });++ expect(fetchMock).toHaveBeenCalledWith(+ "https://remote.example.com/eve/agents/researcher/eve/v1/session/remote%2Fsession%20id/cancel",+ expect.objectContaining({ method: "POST" }),+ );+ });+it("rejects responses for a different session", async () => {vi.stubGlobal("fetch",diff --git a/packages/eve/src/execution/remote-agent-dispatch.ts b/packages/eve/src/execution/remote-agent-dispatch.tsindex 160aa36c2..03a2497f1 100644--- a/packages/eve/src/execution/remote-agent-dispatch.ts+++ b/packages/eve/src/execution/remote-agent-dispatch.ts@@ -139,17 +139,18 @@ export function resolveRemoteAgentForAction(input: {}function createRemoteAgentSessionUrl(remote: ResolvedRuntimeRemoteAgentNode): string {- return new URL(remote.path, `${trimTrailingSlash(remote.url)}/`).toString();+ return createRemoteAgentRouteUrl(remote.url, remote.path);}function createRemoteAgentCancelTurnUrl(remote: ResolvedRuntimeRemoteAgentNode,sessionId: string,): string {- return new URL(- createEveCancelTurnRoutePath(sessionId),- `${trimTrailingSlash(remote.url)}/`,- ).toString();+ return createRemoteAgentRouteUrl(remote.url, createEveCancelTurnRoutePath(sessionId));+}++function createRemoteAgentRouteUrl(baseUrl: string, routePath: string): string {+ return new URL(routePath.replace(/^\/+/, ""), `${trimTrailingSlash(baseUrl)}/`).toString();}function isRetryableRemoteCancelStatus(status: number): boolean {