Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

fix(eve): repair Web Chat service builds and framework selection (#4138)

OwenKepharte1130dd8eab8
diff --git a/.changeset/web-chat-service-build.md b/.changeset/web-chat-service-build.md
new file mode 100644
index 000000000..63b7386b9
--- /dev/null
+++ b/.changeset/web-chat-service-build.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Fix generated Web Chat service builds with root-installed pnpm dependencies, and honor Vercel services configuration during project creation instead of prompting to switch to Next.js or eve. Deployment now shows Vercel build logs in the CLI and TUI and provides a command to retrieve them after a failure.
diff --git a/docs/guides/deployment/vercel.mdx b/docs/guides/deployment/vercel.mdx
index fb2c8260e..4b68b245a 100644
--- a/docs/guides/deployment/vercel.mdx
+++ b/docs/guides/deployment/vercel.mdx
@@ -67,6 +67,7 @@ export default await withEve({
web: {
framework: "nextjs",
root: "apps/web",
+ buildCommand: "node ../../node_modules/next/dist/bin/next build",
},
},
routes: [
@@ -120,7 +121,7 @@ Deploy the linked project to production from its root:
eve deploy
```
-`eve deploy` installs dependencies, runs `vercel deploy --prod`, and pulls the project environment after deployment. You can also push to a Git-connected Vercel project. Hosted Vercel builds set `VERCEL`, so `eve build` writes the deployment bundle under `.vercel/output`.
+`eve deploy` installs dependencies, runs `vercel deploy --prod --logs` to show build logs, and pulls the project environment after deployment. You can also push to a Git-connected Vercel project. Hosted Vercel builds set `VERCEL`, so `eve build` writes the deployment bundle under `.vercel/output`.
When `eve deploy` creates a new Vercel project, it configures trace sampling so traces appear in Agent Runs automatically. See [Agent Runs](../../observability/agent-runs) for details. Pass `--no-trace-sampling` to skip this setting.
diff --git a/packages/eve/src/cli/commands/deploy.integration.test.ts b/packages/eve/src/cli/commands/deploy.integration.test.ts
index ae239fae2..1774039c5 100644
--- a/packages/eve/src/cli/commands/deploy.integration.test.ts
+++ b/packages/eve/src/cli/commands/deploy.integration.test.ts
@@ -180,7 +180,7 @@ describe("runDeployCommand", () => {
expect(logger.errors).toEqual([]);
expect(process.exitCode).toBeUndefined();
expect(deployDeps.runVercel).toHaveBeenCalledWith(
- ["deploy", "--prod", "--yes", "--non-interactive"],
+ expect.arrayContaining(["deploy", "--prod", "--yes", "--non-interactive"]),
expect.objectContaining({ nonInteractive: true }),
);
expect(fake.prompter.outro).toHaveBeenCalledWith("Deployed: https://my-agent.vercel.app");
diff --git a/packages/eve/src/setup/boxes/deploy-project.test.ts b/packages/eve/src/setup/boxes/deploy-project.test.ts
index 8bdb6d215..f75514048 100644
--- a/packages/eve/src/setup/boxes/deploy-project.test.ts
+++ b/packages/eve/src/setup/boxes/deploy-project.test.ts
@@ -112,7 +112,7 @@ describe("deployProject box", () => {
expect(deps.runVercel).toHaveBeenNthCalledWith(
1,
- ["deploy", "--prod", "--yes", "--non-interactive"],
+ ["deploy", "--prod", "--yes", "--logs", "--non-interactive"],
expect.objectContaining({ cwd: "/tmp/project", nonInteractive: true }),
);
});
@@ -128,7 +128,7 @@ describe("deployProject box", () => {
// project.
expect(deps.runVercel).toHaveBeenNthCalledWith(
1,
- ["deploy", "--prod", "--yes"],
+ ["deploy", "--prod", "--yes", "--logs"],
expect.objectContaining({ cwd: "/tmp/project", nonInteractive: false }),
);
});
@@ -167,7 +167,7 @@ describe("deployProject box", () => {
const installOrder = deps.runPackageManagerInstall.mock.invocationCallOrder[0]!;
const deployOrder = deps.runVercel.mock.invocationCallOrder[1]!;
expect(deps.runVercel.mock.calls[0]?.[0]).toEqual(["link"]);
- expect(deps.runVercel.mock.calls[1]?.[0]).toEqual(["deploy", "--prod", "--yes"]);
+ expect(deps.runVercel.mock.calls[1]?.[0]).toEqual(["deploy", "--prod", "--yes", "--logs"]);
expect(linkOrder).toBeLessThan(installOrder);
expect(installOrder).toBeLessThan(deployOrder);
});
@@ -242,7 +242,7 @@ describe("deployProject box", () => {
const box = headlessBox({ deps, prompter });
await expect(runHeadless([box], pendingState(), silentSink)).rejects.toThrow(
- "Deployment failed after channel setup.",
+ "vercel inspect <deployment-url> --logs",
);
// The rail only flushes the captured `vercel deploy --prod` output on a
@@ -347,7 +347,7 @@ describe("deployProject box", () => {
await runHeadless([box], state, silentSink);
expect(deps.runVercel).toHaveBeenCalledWith(
- ["deploy", "--prod", "--yes", "--non-interactive"],
+ ["deploy", "--prod", "--yes", "--logs", "--non-interactive"],
expect.objectContaining({ cwd: "/tmp/project" }),
);
});
diff --git a/packages/eve/src/setup/boxes/deploy-project.ts b/packages/eve/src/setup/boxes/deploy-project.ts
index d59236fd3..4f486030b 100644
--- a/packages/eve/src/setup/boxes/deploy-project.ts
+++ b/packages/eve/src/setup/boxes/deploy-project.ts
@@ -178,6 +178,7 @@ export function deployProject(
"deploy",
"--prod",
"--yes",
+ "--logs",
...(input.headless ? ["--non-interactive"] : []),
];
const success = await withPhase(log, "Deploying the agent to Vercel production...", () =>
@@ -195,9 +196,11 @@ export function deployProject(
// transient until a warning/error settles it) so the build failure is
// visible instead of just the exit code.
log.error(
- "`vercel deploy --prod` failed. The deploy output above shows the cause; fix it, then retry.",
+ "`vercel deploy --prod` failed. Check the build logs above for the first error, then retry. To retrieve the logs again, run `vercel inspect <deployment-url> --logs` from this project.",
+ );
+ throw new Error(
+ "Deployment failed. Check the build logs above, or run `vercel inspect <deployment-url> --logs` from this project.",
);
- throw new Error("Deployment failed after channel setup.");
}
const pulledEnvironment = await withPhase(
diff --git a/packages/eve/src/setup/flows/deploy.test.ts b/packages/eve/src/setup/flows/deploy.test.ts
index cab504534..bb5376554 100644
--- a/packages/eve/src/setup/flows/deploy.test.ts
+++ b/packages/eve/src/setup/flows/deploy.test.ts
@@ -135,7 +135,7 @@ describe("runDeployFlow", () => {
expect(login).toHaveBeenCalledOnce();
expect(fake.selectMessages).toEqual([]);
expect(deployDeps.runVercel).toHaveBeenCalledWith(
- ["deploy", "--prod", "--yes"],
+ expect.arrayContaining(["deploy", "--prod", "--yes"]),
expect.objectContaining({ cwd: APP_ROOT }),
);
});
@@ -206,7 +206,7 @@ describe("runDeployFlow", () => {
{ signal: undefined, traceSampling: false },
);
expect(deployDeps.runVercel).toHaveBeenCalledWith(
- ["deploy", "--prod", "--yes"],
+ expect.arrayContaining(["deploy", "--prod", "--yes"]),
expect.objectContaining({ cwd: APP_ROOT }),
);
});
@@ -255,7 +255,7 @@ describe("runDeployFlow", () => {
expect(result).toEqual({ kind: "deployed", productionUrl: "https://my-agent.vercel.app" });
expect(login).not.toHaveBeenCalled();
expect(deployDeps.runVercel).toHaveBeenCalledWith(
- ["deploy", "--prod", "--yes", "--non-interactive"],
+ expect.arrayContaining(["deploy", "--prod", "--yes", "--non-interactive"]),
expect.objectContaining({ cwd: APP_ROOT, nonInteractive: true }),
);
});
diff --git a/packages/eve/src/setup/integrations/web/setup.ts b/packages/eve/src/setup/integrations/web/setup.ts
index d7bf4b9d3..d76b96d09 100644
--- a/packages/eve/src/setup/integrations/web/setup.ts
+++ b/packages/eve/src/setup/integrations/web/setup.ts
@@ -27,11 +27,16 @@ const nextConfig: NextConfig = {};
export default nextConfig;
`;
+const PEER_SERVICE_WEB_BUILD_COMMAND = "node ../../node_modules/next/dist/bin/next build";
const PEER_SERVICE_VERCEL_CONFIG = `import { withEve } from "eve/vercel";
export default await withEve({
services: {
- web: { framework: "nextjs", root: "apps/web" },
+ web: {
+ framework: "nextjs",
+ root: "apps/web",
+ buildCommand: "${PEER_SERVICE_WEB_BUILD_COMMAND}",
+ },
},
routes: [
{ src: "^(.*)$", destination: { type: "service", service: "web" } },
@@ -178,7 +183,13 @@ export default withEve(nextConfig);
if (plan.hosting === "vercel") {
const vercelTsPath = join(project.environmentRoot, "vercel.ts");
const vercelJsonPath = join(project.environmentRoot, "vercel.json");
- await assertInstallerOwned(vercelTsPath, [PEER_SERVICE_VERCEL_CONFIG]);
+ await assertInstallerOwned(vercelTsPath, [
+ PEER_SERVICE_VERCEL_CONFIG,
+ PEER_SERVICE_VERCEL_CONFIG.replace(
+ / web: \{[^}]+\},/,
+ ' web: { framework: "nextjs", root: "apps/web" },',
+ ),
+ ]);
if (await deps.pathExists(vercelJsonPath)) {
throw new Error(
`Could not configure Vercel services because ${vercelJsonPath} already exists. Preserve it and compose eve/vercel manually.`,
diff --git a/packages/eve/src/setup/vercel-project-framework.test.ts b/packages/eve/src/setup/vercel-project-framework.test.ts
index a1fe6b1fa..125fd57aa 100644
--- a/packages/eve/src/setup/vercel-project-framework.test.ts
+++ b/packages/eve/src/setup/vercel-project-framework.test.ts
@@ -6,7 +6,10 @@ import { captureVercel, type VercelCaptureResult } from "#setup/primitives/index
import { createFakePrompter } from "#internal/testing/fake-prompter.js";
import { readProjectLink } from "./project-resolution.js";
import { resolveVercelHostFrameworkPreset } from "./scaffold/index.js";
-import { syncHostFrameworkPreset } from "./vercel-project-framework.js";
+import {
+ ensureCreatedProjectFramework,
+ syncHostFrameworkPreset,
+} from "./vercel-project-framework.js";
vi.mock("#setup/primitives/index.js", async (importOriginal) => {
const original = await importOriginal<typeof import("#setup/primitives/index.js")>();
@@ -66,6 +69,30 @@ beforeEach(() => {
stubCurrentFramework("eve");
});
+describe("ensureCreatedProjectFramework", () => {
+ it.each(["nextjs", "eve"])(
+ "uses authored services without a host-framework prompt when Vercel detected %s",
+ async (current) => {
+ mockedResolvePreset.mockResolvedValue("services");
+ stubCurrentFramework(current);
+ const { prompter, selectMessages } = createFakePrompter();
+
+ await ensureCreatedProjectFramework(
+ prompter,
+ "/app",
+ LINK.orgId,
+ LINK.projectId,
+ createPromptCommandOutput(prompter.log),
+ {},
+ );
+
+ expect(selectMessages).toEqual([]);
+ expect(patchedFrameworkTo("services")).toBe(true);
+ expect(patchedFrameworkTo("eve")).toBe(false);
+ },
+ );
+});
+
describe("syncHostFrameworkPreset", () => {
it("no-ops when the project declares no host framework", async () => {
mockedResolvePreset.mockResolvedValue(undefined);
diff --git a/packages/eve/src/setup/vercel-project-framework.ts b/packages/eve/src/setup/vercel-project-framework.ts
index a0fd26a53..82a1ce442 100644
--- a/packages/eve/src/setup/vercel-project-framework.ts
+++ b/packages/eve/src/setup/vercel-project-framework.ts
@@ -304,6 +304,13 @@ export async function ensureCreatedProjectFramework(
options: CreatedProjectFrameworkOptions,
): Promise<void> {
const framework = await fetchProjectFramework(projectRoot, team, projectId, options);
+ // vercel.ts owns the service graph; a detected Next.js dependency is only a peer service.
+ if ((await resolveVercelHostFrameworkPreset(projectRoot)) === "services") {
+ if (framework !== "services") {
+ await setProjectFramework(projectRoot, team, projectId, "services", onOutput, options);
+ }
+ return;
+ }
if (framework === EVE_FRAMEWORK_PRESET) return;
const frameworkAction =
framework === undefined
diff --git a/packages/eve/test/scenarios/web-chat-service-build.scenario.test.ts b/packages/eve/test/scenarios/web-chat-service-build.scenario.test.ts
new file mode 100644
index 000000000..4022afab4
--- /dev/null
+++ b/packages/eve/test/scenarios/web-chat-service-build.scenario.test.ts
@@ -0,0 +1,88 @@
+import { exec, execFile } from "node:child_process";
+import { readFile, writeFile } from "node:fs/promises";
+import { delimiter, join } from "node:path";
+import { createRequire } from "node:module";
+import { promisify } from "node:util";
+
+import { expect, it } from "vitest";
+
+import { createFakePrompter } from "../../src/internal/testing/fake-prompter.js";
+import {
+ resolveScenarioPackageVersion,
+ useScenarioApp,
+} from "../../src/internal/testing/scenario-app.js";
+import { headlessAsker } from "../../src/setup/ask.js";
+import { applyWebSetup } from "../../src/setup/integrations/web/setup.js";
+import { integrationSetupEnvironment } from "../../src/setup/integrations/shared/environment.js";
+import { createSetupContexts } from "../../src/setup/integrations/shared/ui.js";
+
+const scenarioApp = useScenarioApp();
+const require = createRequire(import.meta.url);
+const runFile = promisify(execFile);
+const runCommand = promisify(exec);
+
+it("builds the generated Web Chat service with pnpm dependencies installed only at the root", async () => {
+ const { appRoot } = await scenarioApp({
+ name: "web-chat-service-build",
+ installDependencies: true,
+ dependencies: {
+ next: await resolveScenarioPackageVersion("next"),
+ react: await resolveScenarioPackageVersion("react"),
+ "react-dom": await resolveScenarioPackageVersion("react-dom"),
+ typescript: await resolveScenarioPackageVersion("typescript"),
+ "@types/node": require("@types/node/package.json").version,
+ "@types/react": require("@types/react/package.json").version,
+ },
+ files: {
+ "agent/agent.ts":
+ 'import { defineAgent } from "eve";\nexport default defineAgent({ model: "openai/gpt-5.4" });\n',
+ "apps/web/app/layout.jsx":
+ "export default function Layout({ children }) { return <html><body>{children}</body></html>; }\n",
+ "apps/web/app/page.jsx":
+ "export default function Page() { return <main>Web Chat service</main>; }\n",
+ },
+ });
+ const contexts = createSetupContexts({
+ appRoot,
+ asker: headlessAsker(),
+ environment: integrationSetupEnvironment("cli-missing", { kind: "unresolved" }),
+ prompter: createFakePrompter().prompter,
+ resolveVercelProject: async () => ({ orgId: "team", projectId: "project" }),
+ });
+ await applyWebSetup({ hosting: "vercel", packageManager: "pnpm" }, contexts.apply);
+ const configured = await runFile(
+ process.execPath,
+ [
+ "--input-type=module",
+ "-e",
+ 'const { default: config } = await import("./vercel.ts"); console.log(JSON.stringify(config.services.web));',
+ ],
+ { cwd: appRoot },
+ );
+ const webService = JSON.parse(configured.stdout) as { root: string; buildCommand?: string };
+ const webRoot = join(appRoot, webService.root);
+ // Vercel synthesizes this nested package when no app manifest/build command exists.
+ await writeFile(
+ join(webRoot, "package.json"),
+ JSON.stringify({ scripts: { "vercel-build": "next build" } }),
+ );
+ const command = webService.buildCommand ?? "pnpm run vercel-build";
+
+ await runCommand(command, {
+ cwd: webRoot,
+ env: {
+ ...process.env,
+ NEXT_TELEMETRY_DISABLED: "1",
+ // The test runner's workspace executables must not mask a missing app binary.
+ PATH: process.env.PATH?.split(delimiter)
+ .filter((entry) => !entry.includes("node_modules"))
+ .join(delimiter),
+ },
+ maxBuffer: 10 * 1024 * 1024,
+ });
+
+ const manifest = JSON.parse(
+ await readFile(join(webRoot, ".next", "prerender-manifest.json"), "utf8"),
+ );
+ expect(manifest.routes["/"]).toBeDefined();
+}, 120_000);