Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(control-ui): r1-b3 preserve connector detail actions
Josué015a90df2a33
diff --git a/control-ui/components/McpServerTable.tsx b/control-ui/components/McpServerTable.tsxindex e60cdfcf0..87ccf7fc5 100644--- a/control-ui/components/McpServerTable.tsx+++ b/control-ui/components/McpServerTable.tsx@@ -2,6 +2,7 @@import React, { useMemo, useState } from 'react'import { DataTable } from '@clerum/frontend-table-system'+import { copyTextToClipboard } from '@lib/clipboard'import type {ConnectorAccessSummary,ConnectorContextBinding,@@ -16,7 +17,7 @@ import { SkeletonTableRows } from './SkeletonTableRows'import { TableHeaderRow } from './TableHeaderRow'import type { TableHeaderColumn } from './TableHeaderRow/types'import { TablePanelHeader } from './TablePanelHeader'-import { IconRefresh, IconX } from './icons'+import { IconCopy, IconRefresh, IconX } from './icons'const ENABLED_TOOLTIP = 'Enabled controls whether this server is available to contexts and agents.'type ConnectorSortKey =@@ -102,10 +103,55 @@ function StatusBadge({ status }: { status?: McpServerStatus }) {)}+function CopyableValue({+ copyLabel,+ copied,+ href,+ onCopy,+ value,+}: {+ copyLabel: string+ copied: boolean+ href?: string+ onCopy: () => void+ value: string+}) {+ if (!value) return <span className="cu-muted">—</span>+ return (+ <span className="cu-copy-field">+ {href ? (+ <a+ className="cu-copy-field__value cu-link cu-cell-truncate"+ href={href}+ rel="noreferrer"+ target="_blank"+ title={value}+ >+ {value}+ </a>+ ) : (+ <span className="cu-copy-field__value cu-cell-truncate" title={value}>+ {value}+ </span>+ )}+ <button+ aria-label={copied ? `${copyLabel} copied` : `Copy ${copyLabel}`}+ className="cu-btn cu-btn--icon cu-btn--ghost"+ onClick={onCopy}+ title={copied ? 'Copied' : `Copy ${copyLabel}`}+ type="button"+ >+ <IconCopy height={14} width={14} />+ </button>+ </span>+ )+}+export function McpServerTable({items,accessByConnectorKey,contexts = [],+ onOpenContext,onAddToContexts,onRemoveFromContext,updatingContextMembershipKey,@@ -125,6 +171,10 @@ export function McpServerTable({const [serverKeyAddingContexts, setServerKeyAddingContexts] = useState<string | null>(null)const [serverKeyViewingAccess, setServerKeyViewingAccess] = useState<string | null>(null)const [selectedContextNamesToAdd, setSelectedContextNamesToAdd] = useState<string[]>([])+ const [copiedValueKey, setCopiedValueKey] = useState<string | null>(null)+ const accessDialogRef = React.useRef<HTMLElement | null>(null)+ const accessCloseButtonRef = React.useRef<HTMLButtonElement | null>(null)+ const accessOpenerRef = React.useRef<HTMLElement | null>(null)const rows = useMemo(() =>items.map(item => {@@ -216,6 +266,40 @@ export function McpServerTable({return () => clearInterval(id)}, [onRefresh])+ React.useEffect(() => {+ if (!serverKeyViewingAccess) return+ accessCloseButtonRef.current?.focus()+ const onKeyDown = (event: KeyboardEvent) => {+ if (event.key === 'Escape') {+ event.preventDefault()+ setServerKeyViewingAccess(null)+ return+ }+ if (event.key !== 'Tab') return+ const focusable = Array.from(+ accessDialogRef.current?.querySelectorAll<HTMLElement>(+ 'a[href], button:not(:disabled), input:not(:disabled), [tabindex]:not([tabindex="-1"])'+ ) ?? []+ )+ const first = focusable[0]+ const last = focusable.at(-1)+ if (!first || !last) return+ if (event.shiftKey && document.activeElement === first) {+ event.preventDefault()+ last.focus()+ } else if (!event.shiftKey && document.activeElement === last) {+ event.preventDefault()+ first.focus()+ }+ }+ window.addEventListener('keydown', onKeyDown)+ const opener = accessOpenerRef.current+ return () => {+ window.removeEventListener('keydown', onKeyDown)+ opener?.focus()+ }+ }, [serverKeyViewingAccess])+function toggleSort(key: ConnectorSortKey) {if (sortKey === key) {setSortDirection(direction => (direction === 'asc' ? 'desc' : 'asc'))@@ -267,6 +351,16 @@ export function McpServerTable({setServerKeyAddingContexts(null)}+ async function copyValue(copyKey: string, value: string) {+ if (await copyTextToClipboard(value)) setCopiedValueKey(copyKey)+ }++ function openAccessDetails(key: string) {+ accessOpenerRef.current =+ document.activeElement instanceof HTMLElement ? document.activeElement : null+ setServerKeyViewingAccess(key)+ }+const isInitialLoad = loading && items.length === 0return (@@ -388,14 +482,23 @@ export function McpServerTable({<TransportBadge type={spec.transport?.type} /></td><td className="cu-code-text">- <span className="cu-cell-truncate" title={spec.transport?.url || spec.image}>- {spec.transport?.url || spec.image || '—'}- </span>+ <CopyableValue+ copied={copiedValueKey === `${key}/endpoint`}+ copyLabel="endpoint"+ href={spec.transport?.url}+ onCopy={() =>+ void copyValue(`${key}/endpoint`, spec.transport?.url || spec.image || '')+ }+ value={spec.transport?.url || spec.image || ''}+ /></td><td className="cu-code-text">- <span className="cu-cell-truncate" title={spec.image || undefined}>- {spec.image || '—'}- </span>+ <CopyableValue+ copied={copiedValueKey === `${key}/image`}+ copyLabel="image reference"+ onCopy={() => void copyValue(`${key}/image`, spec.image || '')}+ value={spec.image || ''}+ /></td><td>{assignedContexts.length} context{assignedContexts.length === 1 ? '' : 's'} ·{' '}@@ -449,7 +552,7 @@ export function McpServerTable({{key: 'view-access',label: 'View access details',- onClick: () => setServerKeyViewingAccess(key),+ onClick: () => openAccessDetails(key),},...(onRemoveFromContext? assignedContexts.map(context => ({@@ -580,21 +683,25 @@ export function McpServerTable({const access = accessByConnectorKey?.[row.key]const linkedContexts = contextsForConnector(row.name)const groups = [- { key: 'contexts', label: 'Contexts', items: linkedContexts.map(item => item.name) },+ {+ key: 'contexts',+ label: 'Contexts',+ items: linkedContexts.map(item => ({ key: item.name, label: item.name })),+ },{key: 'agents',label: 'Agents',- items: (access?.agents ?? []).map(item => item.label),+ items: (access?.agents ?? []).map(item => ({ key: item.id, label: item.label })),},{key: 'teams',label: 'Teams',- items: (access?.teams ?? []).map(item => item.label),+ items: (access?.teams ?? []).map(item => ({ key: item.id, label: item.label })),},{key: 'users',label: 'Users',- items: (access?.users ?? []).map(item => item.label),+ items: (access?.users ?? []).map(item => ({ key: item.id, label: item.label })),},]return (@@ -609,6 +716,7 @@ export function McpServerTable({aria-labelledby="connector-access-title"aria-modal="true"className="cu-modal-panel"+ ref={accessDialogRef}role="dialog"><div className="cu-modal-panel__header">@@ -626,7 +734,19 @@ export function McpServerTable({{group.items.length ? (<ul className="cu-registry-context-access__list">{group.items.map(item => (- <li key={item}>{item}</li>+ <li key={item.key}>+ {group.key === 'contexts' && onOpenContext ? (+ <button+ className="cu-link"+ onClick={() => onOpenContext(item.label)}+ type="button"+ >+ {item.label}+ </button>+ ) : (+ item.label+ )}+ </li>))}</ul>) : (@@ -639,6 +759,7 @@ export function McpServerTable({<buttonclassName="cu-btn cu-btn--primary"onClick={() => setServerKeyViewingAccess(null)}+ ref={accessCloseButtonRef}type="button">Closediff --git a/control-ui/components/__tests__/McpServerTable.test.tsx b/control-ui/components/__tests__/McpServerTable.test.tsxindex e6448723a..463b29536 100644--- a/control-ui/components/__tests__/McpServerTable.test.tsx+++ b/control-ui/components/__tests__/McpServerTable.test.tsx@@ -282,6 +282,55 @@ describe('McpServerTable — connector access summaries', () => {}})+ it('preserves context navigation and accessible access-dialog focus behavior', () => {+ const onOpenContext = vi.fn()+ render(+ <McpServerTable+ items={[makeItem({ name: 'airtable-server' })]}+ contexts={[makeContextBinding({ name: 'research', mcpServers: ['airtable-server'] })]}+ onOpenContext={onOpenContext}+ />+ )++ const trigger = screen.getByRole('button', {+ name: 'Actions for connector airtable-server',+ })+ fireEvent.click(trigger)+ fireEvent.click(screen.getByRole('menuitem', { name: 'View access details' }))++ const close = screen.getByRole('button', { name: 'Close' })+ const contextLink = screen.getByRole('button', { name: 'research' })+ expect(close).toHaveFocus()+ fireEvent.keyDown(window, { key: 'Tab' })+ expect(contextLink).toHaveFocus()+ fireEvent.keyDown(window, { key: 'Tab', shiftKey: true })+ expect(close).toHaveFocus()+ fireEvent.click(contextLink)+ expect(onOpenContext).toHaveBeenCalledWith('research')++ fireEvent.keyDown(window, { key: 'Escape' })+ expect(screen.queryByRole('dialog', { name: 'Access for airtable-server' })).toBeNull()+ expect(trigger).toHaveFocus()+ })++ it('keeps connector endpoint links and image copy actions available', async () => {+ const writeText = vi.fn().mockResolvedValue(undefined)+ Object.defineProperty(navigator, 'clipboard', {+ configurable: true,+ value: { writeText },+ })+ const image = 'ghcr.io/example/mcp:1.0'+ render(<McpServerTable items={[makeItem({ name: 'airtable-server', image })]} />)++ expect(screen.getByRole('link', { name: /brave-search\.mcp-server/ })).toHaveAttribute(+ 'href',+ 'http://brave-search.mcp-server.svc.cluster.local:3000/mcp'+ )+ fireEvent.click(screen.getByRole('button', { name: 'Copy image reference' }))+ await waitFor(() => expect(writeText).toHaveBeenCalledWith(image))+ expect(screen.getByRole('button', { name: 'image reference copied' })).toBeInTheDocument()+ })+it('renders an empty access state when no principals are mapped', () => {const items = [makeItem({ name: 'unused-server' })]render(<McpServerTable items={items} />)diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 2d040f533..5c845c54f 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.482",+ "version": "0.1.483","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.482",+ "version": "0.1.483","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/frontend-table-system": "file:../packages/frontend-table-system",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 99b0b5f5c..05b818eed 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.482",+ "version": "0.1.483","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",