Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): review follow-ups for the usage, secrets, and GFS listing fixes

M04b8e69afc2d
diff --git a/control-ui/app/secrets/new/page.tsx b/control-ui/app/secrets/new/page.tsx
index 9aea89ff1..bf851b8e5 100644
--- a/control-ui/app/secrets/new/page.tsx
+++ b/control-ui/app/secrets/new/page.tsx
@@ -123,7 +123,7 @@ function CreateSecretPageContent() {
const prefillOwnerRecipe =
scope === 'recipe' ? (searchParams.get('ownerRecipe') ?? '').trim() : ''
const [recipeOwnershipKind, setRecipeOwnershipKind] = useState<'owner-recipe' | 'shared'>(
- prefillOwnerRecipe ? 'owner-recipe' : 'owner-recipe'
+ 'owner-recipe'
)
const [recipeOwnerName, setRecipeOwnerName] = useState(prefillOwnerRecipe)
const [availableRecipes, setAvailableRecipes] = useState<string[]>([])
diff --git a/control-ui/components/GfsBrowser.tsx b/control-ui/components/GfsBrowser.tsx
index d4cf0431e..7c7e0aeda 100644
--- a/control-ui/components/GfsBrowser.tsx
+++ b/control-ui/components/GfsBrowser.tsx
@@ -1741,8 +1741,8 @@ export function GfsBrowser(): React.JSX.Element {
{!loading && items.length > 0 ? (
<p className="cu-gfs-list-count" aria-live="polite">
{nextCursor
- ? `Showing the first ${items.length} items.`
- : `Showing all ${items.length} items.`}
+ ? `Showing the first ${items.length} ${items.length === 1 ? 'item' : 'items'}.`
+ : `Showing all ${items.length} ${items.length === 1 ? 'item' : 'items'}.`}
</p>
) : null}
diff --git a/control-ui/components/__tests__/GfsBrowser.test.tsx b/control-ui/components/__tests__/GfsBrowser.test.tsx
index e0f9a1854..409eec744 100644
--- a/control-ui/components/__tests__/GfsBrowser.test.tsx
+++ b/control-ui/components/__tests__/GfsBrowser.test.tsx
@@ -2622,8 +2622,16 @@ describe('GfsBrowser', () => {
mockApiGet.mockResolvedValueOnce({ items: [child('a.md', 'file', 1)], nextCursor: null })
renderBrowser()
- expect(await screen.findByText('Showing all 1 items.')).toBeTruthy()
+ expect(await screen.findByText('Showing all 1 item.')).toBeTruthy()
expect(screen.queryByText(/truncated at the page cap/)).toBeNull()
expect(screen.queryByRole('button', { name: 'Load more' })).toBeNull()
})
+
+ it('uses the singular item wording for a one-row truncated page', async () => {
+ mockApiGet.mockResolvedValueOnce({ items: [child('a.md', 'file', 1)], nextCursor: 'cursor-1' })
+ renderBrowser()
+
+ expect(await screen.findByText('Showing the first 1 item.')).toBeTruthy()
+ expect(screen.getByRole('button', { name: 'Load more' })).toBeTruthy()
+ })
})
diff --git a/control-ui/lib/__tests__/usageScrollStyles.test.tsx b/control-ui/lib/__tests__/usageScrollStyles.test.tsx
index 8362dea28..b7e77152b 100644
--- a/control-ui/lib/__tests__/usageScrollStyles.test.tsx
+++ b/control-ui/lib/__tests__/usageScrollStyles.test.tsx
@@ -2,7 +2,6 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { cleanup, fireEvent, render, screen } from '@testing-library/react'
import { readFileSync } from 'node:fs'
import { resolve } from 'node:path'
-import { fetchUsageSeries, fetchUsageTotals } from '@lib/api'
import { ToastProvider } from '@/components/Toast'
import { UsageDashboard } from '@/components/UsageDashboard'
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 1b832625f..2c586dcf5 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.671",
+ "version": "0.1.672",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.671",
+ "version": "0.1.672",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 1feab1ab3..5f95c6e06 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.671",
+ "version": "0.1.672",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",