Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(control-ui): align expandable tables with native cells
Josué053cb20dc07f
diff --git a/control-ui/app/globals.css b/control-ui/app/globals.cssindex 56b9cb846..6ef6c1aa1 100644--- a/control-ui/app/globals.css+++ b/control-ui/app/globals.css@@ -11248,15 +11248,6 @@ td.cu-registry-description {gap: var(--cu-space-2);}-.cu-llm-model-table,-.cu-llm-review-table {- --cu-llm-group-provider-width: calc(var(--cu-space-7) * 7);- --cu-llm-group-models-width: calc(var(--cu-space-7) * 3);- --cu-llm-group-actions-width: calc(var(--cu-space-7) * 4);-- table-layout: auto;-}-.cu-llm-model-table {min-width: 68rem;}@@ -11280,21 +11271,6 @@ td.cu-registry-description {min-width: 48rem;}-.cu-llm-model-table > thead > tr > th:first-child,-.cu-llm-review-table > thead > tr > th:first-child {- width: var(--cu-llm-group-provider-width);-}--.cu-llm-model-table > thead > tr > th:nth-child(2),-.cu-llm-review-table > thead > tr > th:nth-child(2) {- width: var(--cu-llm-group-models-width);-}--.cu-llm-model-table > thead > tr > th:last-child,-.cu-llm-review-table > thead > tr > th:last-child {- width: var(--cu-llm-group-actions-width);-}-.cu-llm-review-table .cu-llm-model-row > td:first-child {padding-left: 0.85rem;}@@ -11402,7 +11378,6 @@ td.cu-registry-description {}.cu-llm-model-group .eft-table-group__summary-row > td {- padding: 0;background: var(--cu-bg-elevated);}@@ -11411,17 +11386,8 @@ td.cu-registry-description {}.cu-llm-model-group__toggle {- position: relative;- display: block;- width: 100%;min-height: calc(var(--cu-space-5) * 2.6);- padding: var(--cu-space-3);- border: 0;- background: transparent;color: var(--cu-text);- cursor: pointer;- font: inherit;- text-align: left;}.cu-llm-model-group__toggle:focus-visible {@@ -11429,33 +11395,6 @@ td.cu-registry-description {outline-offset: -2px;}-.cu-llm-model-group .eft-table-group__indicator {- position: absolute;- top: 50%;- left: var(--cu-space-3);- display: inline-flex;- color: var(--cu-text-muted);- transform: translateY(-50%);-}--.cu-llm-model-group__toggle[aria-expanded='true'] .eft-table-group__indicator {- transform: translateY(-50%) rotate(90deg);-}--.cu-llm-model-group__toggle .eft-table-group__summary {- display: grid;- width: 100%;- grid-template-columns:- calc(var(--cu-space-7) + var(--cu-space-3))- minmax(0, calc(var(--cu-llm-group-provider-width) - var(--cu-space-7) - var(--cu-space-3)))- var(--cu-llm-group-models-width) minmax(0, 1fr) var(--cu-llm-group-actions-width);- align-items: center;-}--.cu-llm-model-group__toggle .cu-llm-provider-icon {- justify-self: end;-}-.cu-llm-model-group__provider {min-width: 0;padding-left: var(--cu-space-2);@@ -11466,6 +11405,7 @@ td.cu-registry-description {}.cu-llm-model-group__count {+ display: inline-flex;padding: calc(var(--cu-space-1) / 2) var(--cu-space-2);border: 1px solid var(--cu-border-subtle);border-radius: var(--cu-radius-sm);@@ -11487,12 +11427,14 @@ td.cu-registry-description {}.cu-llm-model-group__action {- justify-self: end;- margin-left: 0;font-weight: 600;white-space: nowrap;}+.cu-llm-model-group__action-cell {+ text-align: right;+}+.cu-llm-model-row > td:first-child {padding-left: calc(var(--cu-space-5) * 2.8);}diff --git a/control-ui/components/LlmDiscoveryPanel/index.tsx b/control-ui/components/LlmDiscoveryPanel/index.tsxindex f331e6a4a..0d4a9941c 100644--- a/control-ui/components/LlmDiscoveryPanel/index.tsx+++ b/control-ui/components/LlmDiscoveryPanel/index.tsx@@ -427,19 +427,41 @@ export function LlmDiscoveryPanel({groupId={provider}key={provider}onExpandedChange={nextExpanded => setProviderExpanded(provider, nextExpanded)}- summary={- <>- <LlmProviderIcon provider={provider} label={providerLabel} />- <span className="cu-llm-model-group__provider">{providerLabel}</span>- <span className="cu-llm-model-group__count">- {models.length} model{models.length === 1 ? '' : 's'}- </span>- <span className="cu-llm-model-group__summary">Awaiting review</span>- <span className="cu-llm-model-group__action" aria-hidden="true">- {expanded ? 'Hide models' : 'Show models'}- </span>- </>- }+ summaryCells={[+ {+ key: 'provider',+ colSpan: 2,+ content: (+ <>+ <LlmProviderIcon provider={provider} label={providerLabel} />+ <span className="cu-llm-model-group__provider">{providerLabel}</span>+ </>+ ),+ },+ {+ key: 'models',+ content: (+ <span className="cu-llm-model-group__count">+ {models.length} model{models.length === 1 ? '' : 's'}+ </span>+ ),+ },+ {+ key: 'details',+ content: (+ <span className="cu-llm-model-group__summary">Awaiting review</span>+ ),+ },+ {+ key: 'actions',+ className: 'cu-llm-model-group__action-cell',+ content: (+ <span className="cu-llm-model-group__action" aria-hidden="true">+ {expanded ? 'Hide models' : 'Show models'}+ </span>+ ),+ },+ ]}>{models.map(model => (<tr key={model.id} className="cu-table__row cu-llm-model-row">diff --git a/control-ui/components/LlmModelTable.tsx b/control-ui/components/LlmModelTable.tsxindex e6d1a2a74..5a2743ae2 100644--- a/control-ui/components/LlmModelTable.tsx+++ b/control-ui/components/LlmModelTable.tsx@@ -397,23 +397,46 @@ export function LlmModelTable({groupId={provider}key={provider}onExpandedChange={nextExpanded => setProviderExpanded(provider, nextExpanded)}- summary={- <>- <LlmProviderIcon provider={provider} label={providerLabel} />- <span className="cu-llm-model-group__provider">{providerLabel}</span>- <span className="cu-llm-model-group__count">- {providerModels.length} model{providerModels.length === 1 ? '' : 's'}- </span>- <span className="cu-llm-model-group__summary">- {enabledCount} enabled- {staleCount > 0 ? ` · ${staleCount} stale` : ''}- {hasFilteredModels ? ` · ${models.length} matching` : ''}- </span>- <span className="cu-llm-model-group__action" aria-hidden="true">- {expanded ? 'Hide models' : 'Show models'}- </span>- </>- }+ summaryCells={[+ {+ key: 'provider',+ content: (+ <>+ <LlmProviderIcon provider={provider} label={providerLabel} />+ <span className="cu-llm-model-group__provider">{providerLabel}</span>+ </>+ ),+ },+ {+ key: 'models',+ content: (+ <span className="cu-llm-model-group__count">+ {providerModels.length} model{providerModels.length === 1 ? '' : 's'}+ </span>+ ),+ },+ {+ key: 'availability',+ colSpan: 4,+ content: (+ <span className="cu-llm-model-group__summary">+ {enabledCount} enabled+ {staleCount > 0 ? ` · ${staleCount} stale` : ''}+ {hasFilteredModels ? ` · ${models.length} matching` : ''}+ </span>+ ),+ },+ {+ key: 'actions',+ colSpan: 2,+ className: 'cu-llm-model-group__action-cell',+ content: (+ <span className="cu-llm-model-group__action" aria-hidden="true">+ {expanded ? 'Hide models' : 'Show models'}+ </span>+ ),+ },+ ]}>{models.map((model: DisplayModel) => (<tr key={model.id} className="cu-table__row cu-llm-model-row">diff --git a/control-ui/components/__tests__/FrontendComponents.test.tsx b/control-ui/components/__tests__/FrontendComponents.test.tsxindex e332f80e8..a49b6e7d7 100644--- a/control-ui/components/__tests__/FrontendComponents.test.tsx+++ b/control-ui/components/__tests__/FrontendComponents.test.tsx@@ -117,6 +117,99 @@ describe('shared frontend components', () => {expect(onAlphaExpandedChange).toHaveBeenLastCalledWith(false)})+ it.each([+ { label: 'five columns', colSpan: 5, spans: [2, 1, 2] },+ { label: 'seven columns', colSpan: 7, spans: [1, 2, 1, 3] },+ ])(+ 'aligns grouped summaries with arbitrary $label through native cells',+ ({ colSpan, spans }) => {+ const onExpandedChange = vi.fn()+ render(+ <DataTable>+ <thead>+ <tr>+ {spans.map((span, index) => (+ <TableHeaderCell+ colSpan={span}+ key={`header-${index}`}+ label={`Header ${index + 1}`}+ />+ ))}+ </tr>+ </thead>+ <GroupedTableBody+ colSpan={colSpan}+ disclosureLabel={() => 'Expand provider records'}+ expanded={false}+ groupId={`provider-${colSpan}`}+ onExpandedChange={onExpandedChange}+ summaryCells={spans.map((span, index) => ({+ key: `cell-${index}`,+ colSpan: span,+ content:+ index === spans.length - 1 ? (+ <button type="button">Inspect provider</button>+ ) : (+ `Summary ${index + 1}`+ ),+ }))}+ >+ <tr>+ <td colSpan={colSpan}>Provider child</td>+ </tr>+ </GroupedTableBody>+ </DataTable>+ )++ const disclosure = screen.getByRole('button', { name: 'Expand provider records' })+ const summaryRow = disclosure.closest('tr')+ expect(summaryRow).not.toBeNull()+ expect(Array.from(summaryRow?.cells ?? []).map(cell => cell.colSpan)).toEqual(spans)++ fireEvent.click(screen.getByText('Summary 2'))+ expect(onExpandedChange).not.toHaveBeenCalled()++ fireEvent.click(disclosure)+ expect(onExpandedChange).toHaveBeenCalledOnce()+ expect(onExpandedChange).toHaveBeenLastCalledWith(true)++ fireEvent.click(screen.getByRole('button', { name: 'Inspect provider' }))+ expect(onExpandedChange).toHaveBeenCalledOnce()+ }+ )++ it('rejects grouped summary-cell spans that cannot match the table columns', () => {+ const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => undefined)+ const preventReportedError = (event: ErrorEvent) => event.preventDefault()+ window.addEventListener('error', preventReportedError)+ try {+ expect(() =>+ render(+ <DataTable>+ <GroupedTableBody+ colSpan={4}+ disclosureLabel={() => 'Expand invalid records'}+ expanded={false}+ groupId="invalid"+ onExpandedChange={() => undefined}+ summaryCells={[+ { key: 'provider', content: 'Provider' },+ { key: 'details', colSpan: 2, content: 'Details' },+ ]}+ >+ <tr>+ <td colSpan={4}>Invalid child</td>+ </tr>+ </GroupedTableBody>+ </DataTable>+ )+ ).toThrow('GroupedTableBody summary cell spans (3) must equal colSpan (4).')+ } finally {+ window.removeEventListener('error', preventReportedError)+ errorSpy.mockRestore()+ }+ })+it('uses unique, labelled rowgroup relationships across table instances', () => {render(<>diff --git a/control-ui/components/__tests__/LlmDiscoveryPanel.test.tsx b/control-ui/components/__tests__/LlmDiscoveryPanel.test.tsxindex dce8661c8..1ce760677 100644--- a/control-ui/components/__tests__/LlmDiscoveryPanel.test.tsx+++ b/control-ui/components/__tests__/LlmDiscoveryPanel.test.tsx@@ -98,6 +98,10 @@ describe('LlmDiscoveryPanel merged lifecycle workflow', () => {'aria-expanded','false')+ const summaryRow = screen+ .getByRole('button', { name: 'Expand OpenAI review models' })+ .closest('tr')+ expect(Array.from(summaryRow?.cells ?? []).map(cell => cell.colSpan)).toEqual([2, 1, 1, 1])fireEvent.click(screen.getByRole('button', { name: 'Expand OpenAI review models' }))expect(screen.getByText('gpt-5')).toBeInTheDocument()expect(screen.queryByText('claude-retired')).toBeNull()diff --git a/control-ui/components/__tests__/LlmModelTable.test.tsx b/control-ui/components/__tests__/LlmModelTable.test.tsxindex f418b109c..55f6aff42 100644--- a/control-ui/components/__tests__/LlmModelTable.test.tsx+++ b/control-ui/components/__tests__/LlmModelTable.test.tsx@@ -371,6 +371,8 @@ describe('LlmModelTable provider groups', () => {'aria-expanded','false')+ const summaryRow = screen.getByRole('button', { name: 'Expand Anthropic models' }).closest('tr')+ expect(Array.from(summaryRow?.cells ?? []).map(cell => cell.colSpan)).toEqual([1, 1, 4, 2])expect(screen.queryByText('claude-sonnet-4-6')).toBeNull()expect(screen.queryByText('gpt-5')).toBeNull()@@ -391,15 +393,16 @@ describe('LlmModelTable provider groups', () => {{ ...baseModel, id: 'disabled-model', model: 'claude-haiku', enabled: false },])- const summary = screen.getByRole('button', { name: 'Expand Anthropic models' })+ const summary = screen.getByRole('button', { name: 'Expand Anthropic models' }).closest('tr')+ expect(summary).not.toBeNull()expect(summary).toHaveTextContent('2 models')expect(summary).toHaveTextContent('1 enabled')expect(summary).toHaveTextContent('1 stale')fireEvent.change(screen.getByLabelText('Search models'), { target: { value: 'haiku' } })- expect(screen.getByRole('button', { name: 'Collapse Anthropic models' })).toHaveTextContent(- '1 matching'- )+ expect(+ screen.getByRole('button', { name: 'Collapse Anthropic models' }).closest('tr')+ ).toHaveTextContent('1 matching')expect(screen.getByText('claude-haiku')).toBeInTheDocument()})@@ -421,9 +424,9 @@ describe('LlmModelTable provider groups', () => {expect(screen.getByText('gpt-5')).toBeInTheDocument()expect(screen.queryByRole('button', { name: /Anthropic models/ })).toBeNull()- expect(screen.getByRole('button', { name: 'Collapse OpenAI models' })).toHaveTextContent(- '1 matching'- )+ expect(+ screen.getByRole('button', { name: 'Collapse OpenAI models' }).closest('tr')+ ).toHaveTextContent('1 matching')fireEvent.change(screen.getByLabelText('Search models'), { target: { value: '' } })expect(screen.getByRole('button', { name: 'Collapse OpenAI models' })).toBeInTheDocument()diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 0539a8260..1f3a0a35e 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.582",+ "version": "0.1.583","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.582",+ "version": "0.1.583","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/frontend-components": "file:../packages/frontend-components",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 9a5d2a3b3..1131e44d9 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.582",+ "version": "0.1.583","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",diff --git a/docs/agents/control-ui-rules.md b/docs/agents/control-ui-rules.mdindex 12fadc7f9..65e41486a 100644--- a/docs/agents/control-ui-rules.md+++ b/docs/agents/control-ui-rules.md@@ -90,8 +90,10 @@ leaning on either behaviour.ordinary table row-expansion presentations. Both datasets repeat provideridentity across many models, so they render one provider/provider-familysummary row with expandable model child rows through the shared- domain-neutral grouped table primitive. This exception does not apply to any- other table without a separately recorded owner decision.+ domain-neutral grouped table primitive. Their summary cells mirror the+ visible header spans so native table layout owns alignment. This exception+ does not apply to any other table without a separately recorded owner+ decision.## Routingdiff --git a/docs/agents/frontend-style-rules.md b/docs/agents/frontend-style-rules.mdindex fa71535c9..9fd0b65c6 100644--- a/docs/agents/frontend-style-rules.md+++ b/docs/agents/frontend-style-rules.md@@ -147,6 +147,11 @@ application guidance that must be combined with this shared document.presentation. Record the choice in the active specification or decisioncontext when one exists. Expandable rows remain exceptional and must use anexplicit shared primitive rather than changing ordinary `DataTable` rows.+ When a grouped summary exposes column-shaped values, use+ `GroupedTableBody.summaryCells` and mirror the visible header `colSpan`+ values. Native table cells own alignment for every valid column count; do+ not reproduce header lanes with app-specific flex/grid widths or positional+ selectors.- Keep standard rows compact and consistent. Use `TableViewport` for horizontaloverflow and for long-list body scrolling so the page title, toolbar, tabs,and semantic sticky table header remain visible. Embedded/diagnostic viewsdiff --git a/packages/frontend-components/README.md b/packages/frontend-components/README.mdindex 183dc8072..efdbd7f89 100644--- a/packages/frontend-components/README.md+++ b/packages/frontend-components/README.md@@ -16,3 +16,10 @@ implementation is organized under `src/table/` by responsibility: shells,semantic primitives, actions, truncation, sorting, and public types. Consumersmust continue importing from `@clerum/frontend-components`; internal modulepaths are not part of the supported API.++Grouped tables use `GroupedTableBody`. Use `summaryCells` when a summary row+must align with visible column headers: each definition renders a native table+cell and its optional `colSpan` must mirror the corresponding header span. The+component validates that the summary spans cover the complete grouped row, so+new grouped layouts do not need app-specific grid or positional CSS. The+single `summary` prop remains available for intentionally full-width summaries.diff --git a/packages/frontend-components/src/public-api.test.ts b/packages/frontend-components/src/public-api.test.tsindex f8526d41a..c46faf337 100644--- a/packages/frontend-components/src/public-api.test.ts+++ b/packages/frontend-components/src/public-api.test.ts@@ -20,6 +20,7 @@ import type {CellKind,DataViewHeaderProps,GroupedTableBodyProps,+ GroupedTableSummaryCell,RowAction,SortDirection,SortValue,@@ -51,6 +52,7 @@ export type PublicTypeApi = {cellKind: CellKinddataViewHeader: DataViewHeaderPropsgroupedTableBody: GroupedTableBodyProps+ groupedTableSummaryCell: GroupedTableSummaryCellrowAction: RowActionsortDirection: SortDirectionsortValue: SortValuediff --git a/packages/frontend-components/src/table/grouped.tsx b/packages/frontend-components/src/table/grouped.tsxindex 2c490de7b..357268653 100644--- a/packages/frontend-components/src/table/grouped.tsx+++ b/packages/frontend-components/src/table/grouped.tsx@@ -1,6 +1,7 @@'use client'import { Fragment, useId } from 'react'+import type { ReactNode } from 'react'import type { GroupedTableBodyProps } from './types'import { classNames } from './utils'@@ -16,35 +17,66 @@ export function GroupedTableBody({groupId,onExpandedChange,summary,+ summaryCells,}: GroupedTableBodyProps) {const instanceId = useId().replaceAll(':', '')const idBase = `eft-table-group-${instanceId}-${encodeURIComponent(groupId)}`const disclosureId = `${idBase}-disclosure`const childRowsId = `${idBase}-rows`+ const summarySpan = summaryCells?.reduce((total, cell) => total + (cell.colSpan ?? 1), 0)++ if (summaryCells && summarySpan !== colSpan) {+ throw new Error(+ `GroupedTableBody summary cell spans (${summarySpan}) must equal colSpan (${colSpan}).`+ )+ }++ const disclosure = (content: ReactNode) => (+ <button+ aria-controls={childRowsId}+ aria-expanded={expanded}+ aria-label={disclosureLabel(expanded)}+ className={classNames('eft-table-group__disclosure', disclosureClassName)}+ id={disclosureId}+ onClick={event => {+ event.stopPropagation()+ onExpandedChange(!expanded)+ }}+ type="button"+ >+ <span aria-hidden="true" className="eft-table-group__indicator">+ ›+ </span>+ <span className="eft-table-group__summary">{content}</span>+ </button>+ )return (<Fragment><tbody className={classNames('eft-table-group', className)}>- <tr className="eft-table-group__summary-row">- <td colSpan={colSpan}>- <button- aria-controls={childRowsId}- aria-expanded={expanded}- aria-label={disclosureLabel(expanded)}- className={classNames('eft-table-group__disclosure', disclosureClassName)}- id={disclosureId}- onClick={event => {- event.stopPropagation()- onExpandedChange(!expanded)- }}- type="button"- >- <span aria-hidden="true" className="eft-table-group__indicator">- ›- </span>- <span className="eft-table-group__summary">{summary}</span>- </button>- </td>+ <tr+ className={classNames(+ 'eft-table-group__summary-row',+ summaryCells && 'eft-table-group__summary-row--cells'+ )}+ >+ {summaryCells ? (+ summaryCells.map((cell, index) => (+ <td+ className={classNames(+ 'eft-table-group__summary-cell',+ index === 0 && 'eft-table-group__summary-cell--disclosure',+ cell.className+ )}+ colSpan={cell.colSpan}+ key={cell.key}+ >+ {index === 0 ? disclosure(cell.content) : cell.content}+ </td>+ ))+ ) : (+ <td colSpan={colSpan}>{disclosure(summary)}</td>+ )}</tr></tbody><tbodydiff --git a/packages/frontend-components/src/table/types.ts b/packages/frontend-components/src/table/types.tsindex d98d52ae3..eabe65759 100644--- a/packages/frontend-components/src/table/types.ts+++ b/packages/frontend-components/src/table/types.ts@@ -30,7 +30,7 @@ export type TableStateRowProps = {message?: ReactNode}-export type GroupedTableBodyProps = {+type GroupedTableBodyBaseProps = {childBodyClassName?: stringchildHeader?: ReactNodechildren: ReactNode@@ -41,9 +41,27 @@ export type GroupedTableBodyProps = {expanded: booleangroupId: stringonExpandedChange: (expanded: boolean) => void- summary: ReactNode}+export type GroupedTableSummaryCell = {+ className?: string+ colSpan?: number+ content: ReactNode+ key: string+}++export type GroupedTableBodyProps = GroupedTableBodyBaseProps &+ (+ | {+ summary: ReactNode+ summaryCells?: never+ }+ | {+ summary?: never+ summaryCells: readonly GroupedTableSummaryCell[]+ }+ )+export type RowAction = {key: stringlabel: stringdiff --git a/packages/frontend-components/styles.css b/packages/frontend-components/styles.cssindex 25f2d1a8a..e9ab5adad 100644--- a/packages/frontend-components/styles.css+++ b/packages/frontend-components/styles.css@@ -157,6 +157,15 @@.eft-table-group__summary-row > td {padding: 0;}+.eft-table-group__summary-row--cells > .eft-table-group__summary-cell {+ padding: 0.625rem 0.75rem;+}+.eft-table-group__summary-row--cells > .eft-table-group__summary-cell--disclosure {+ padding: 0;+}+.eft-table-group__summary-row--cells .eft-table-group__disclosure {+ padding: 0.625rem 0.75rem;+}.eft-table-group__disclosure {display: flex;width: 100%;