Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(desktop-app): soften over-promising comments (L-A, L-C)

Diego Zacarias059f8e7c27c6
diff --git a/desktop-app/ui/src/__tests__/App.deepLinks.test.tsx b/desktop-app/ui/src/__tests__/App.deepLinks.test.tsx
index 482a4c3d2..d7d3c4e60 100644
--- a/desktop-app/ui/src/__tests__/App.deepLinks.test.tsx
+++ b/desktop-app/ui/src/__tests__/App.deepLinks.test.tsx
@@ -752,9 +752,11 @@ describe('App deep-link orchestration', () => {
})
// Retry clears the failure and re-drives the open in the same commit the
- // predicates go null, so the dialog unmounts as the signal drops: there is
- // no frame with a dialog mounted and the embed shown, and none with the
- // embed hidden and no dialog. Retry never acknowledges (that is Dismiss).
+ // predicates go null, so the dialog unmounts as the signal drops. The
+ // dialog value and the overlay signal are a single derived expression, so
+ // they move in lockstep by construction. The assertions below check the
+ // settled final state (dialog unmounted, signal false), not each render
+ // frame. Retry never acknowledges (that is Dismiss).
await waitFor(() => expect(sandboxUiPageHarness.props?.deepLinkShellOverlayOpen).toBe(false))
expect(confirmDialogHarness.mountedCount).toBe(0)
expect(acknowledgeDeepLink).not.toHaveBeenCalled()
diff --git a/desktop-app/ui/src/pages/__tests__/SandboxUiPage.test.tsx b/desktop-app/ui/src/pages/__tests__/SandboxUiPage.test.tsx
index ea0baef60..8e214c2a7 100644
--- a/desktop-app/ui/src/pages/__tests__/SandboxUiPage.test.tsx
+++ b/desktop-app/ui/src/pages/__tests__/SandboxUiPage.test.tsx
@@ -897,6 +897,12 @@ describe('SandboxUiPage', () => {
expect(sandboxUi.setVisible.mock.calls).toEqual([[true]])
})
+ // This test pins the refcount-like behaviour of the overlay OR: two overlays
+ // open, closing one keeps the embed hidden, closing the last restores it. It
+ // does NOT discriminate the "collapse the whole OR" mutant on its own —
+ // `deepLinkShellOverlayOpen` stays true through every phase here, so that
+ // mutant is caught by the single-overlay tests above, not by this one. Keep
+ // those tests: this one does not subsume them.
it('keeps the native view hidden until the last of several overlays closes', async () => {
sandboxUi.listApps.mockResolvedValueOnce({
apps: [