Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(desktop-ui): distinguish loading/error from empty in Members tab (M2)

Diego Zacarias078883e13ee7
diff --git a/desktop-app/ui/src/components/agents/AgentWorkspace.tsx b/desktop-app/ui/src/components/agents/AgentWorkspace.tsx
index be32a1db0..d1c8941cb 100644
--- a/desktop-app/ui/src/components/agents/AgentWorkspace.tsx
+++ b/desktop-app/ui/src/components/agents/AgentWorkspace.tsx
@@ -83,13 +83,19 @@ export function AgentWorkspace({ mode = 'agents', scrollContainerRef }: AgentWor
} = useNavigationContext()
const { agentNames } = useAgentsDataController()
const { me } = useAuthContext()
- const { accessCatalog } = useContextsDataController()
+ const {
+ accessCatalog,
+ loading: contextsLoading,
+ error: contextsError,
+ } = useContextsDataController()
const {
teams,
currentTeamId,
teamMembers,
teamDirectory,
ensureHydrated: ensureTeamsHydrated,
+ loading: teamsLoading,
+ error: teamsError,
} = useTeamsDataController()
const { agentContextByName, agentDisplayByName, selectedAgentMcpServers } =
useMcpServersDataController({
@@ -525,7 +531,13 @@ export function AgentWorkspace({ mode = 'agents', scrollContainerRef }: AgentWor
<section className="agent-workspace-panel" aria-label="Agent members">
<AgentHero agentName={selectedAgentDisplay} subtitle={routeSubtitle} />
- {scopedMembers.length ? (
+ {(contextsError || teamsError) && !scopedMembers.length ? (
+ // Error before loading/content: a failed access-catalog or team
+ // directory read otherwise rendered a permanent "No members".
+ <StatusBanner tone="error">{contextsError ?? teamsError}</StatusBanner>
+ ) : (contextsLoading || teamsLoading) && !scopedMembers.length ? (
+ <EmptyState title="Loading" body="Fetching members…" />
+ ) : scopedMembers.length ? (
<DataTable className="agent-members-data-table">
<thead>
<tr>
diff --git a/desktop-app/ui/src/components/agents/__tests__/AgentWorkspace.members.test.tsx b/desktop-app/ui/src/components/agents/__tests__/AgentWorkspace.members.test.tsx
new file mode 100644
index 000000000..1eca954f2
--- /dev/null
+++ b/desktop-app/ui/src/components/agents/__tests__/AgentWorkspace.members.test.tsx
@@ -0,0 +1,122 @@
+// @vitest-environment jsdom
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, render, screen, within } from '@testing-library/react'
+import { AgentWorkspace } from '../AgentWorkspace'
+
+// M2 regression: the Members tab used to collapse "loading" and "read failed"
+// into the same empty projection, so a failed access-catalog / team-directory
+// read rendered a permanent "No members" instead of surfacing the error.
+
+const contextsMock = vi.hoisted(() => ({
+ accessCatalog: null as unknown,
+ loading: false,
+ error: null as string | null,
+}))
+
+const teamsMock = vi.hoisted(() => ({
+ loading: false,
+ error: null as string | null,
+}))
+
+vi.mock('@hooks/domain/useAgentsDataController', () => ({
+ useAgentsDataController: () => ({ agentNames: ['trader'] }),
+}))
+vi.mock('@hooks/domain/useContextsDataController', () => ({
+ useContextsDataController: () => ({
+ accessCatalog: contextsMock.accessCatalog,
+ loading: contextsMock.loading,
+ error: contextsMock.error,
+ }),
+}))
+vi.mock('@hooks/domain/useMcpServersDataController', () => ({
+ useMcpServersDataController: () => ({
+ agentContextByName: {},
+ agentDisplayByName: {},
+ selectedAgentMcpServers: [],
+ }),
+}))
+vi.mock('@hooks/domain/useTeamsDataController', () => ({
+ useTeamsDataController: () => ({
+ teams: [],
+ currentTeamId: '',
+ teamMembers: [],
+ teamDirectory: {},
+ ensureHydrated: vi.fn(async () => undefined),
+ loading: teamsMock.loading,
+ error: teamsMock.error,
+ }),
+}))
+vi.mock('@hooks/domain/useConnectorsController', async importActual => ({
+ ...(await importActual<typeof import('@hooks/domain/useConnectorsController')>()),
+ useConnectorsController: () => ({
+ loading: false,
+ error: null,
+ agents: [],
+ pendingKey: null,
+ actionError: null,
+ refresh: vi.fn(),
+ reset: vi.fn(),
+ authorize: vi.fn(),
+ disconnect: vi.fn(),
+ }),
+}))
+vi.mock('@contexts/AuthContext', () => ({
+ useAuthContext: () => ({ me: null }),
+}))
+vi.mock('@contexts/NavigationContext', () => ({
+ useNavigationContext: () => ({
+ selectedAgent: 'trader',
+ selectedAgentRoute: 'members',
+ handleBackToAgents: vi.fn(),
+ handleOpenAgentWorkspace: vi.fn(),
+ handleSelectChatAgent: vi.fn(),
+ }),
+}))
+vi.mock('@contexts/ChatListContext', () => ({
+ useChatListContext: () => ({ sessionStateByChatId: {}, activeChatId: null }),
+}))
+vi.mock('@contexts/McpRuntimeContext', () => ({
+ useMcpRuntimeContext: () => ({ hostRuntimeStatus: null }),
+}))
+vi.mock('@contexts/AgentChatActionsContext', () => ({
+ useAgentChatActionsContext: () => ({ scrollChatToBottom: vi.fn() }),
+}))
+vi.mock('@hooks/useClickOutside', () => ({ useClickOutside: vi.fn() }))
+vi.mock('../ComposerPanel', () => ({ ComposerPanel: () => null }))
+vi.mock('../ChatThread', () => ({ ChatThread: () => null }))
+
+function renderWorkspace() {
+ return render(<AgentWorkspace scrollContainerRef={{ current: null }} />)
+}
+
+describe('AgentWorkspace — Members tab loading/error (M2)', () => {
+ afterEach(() => {
+ cleanup()
+ vi.clearAllMocks()
+ contextsMock.accessCatalog = null
+ contextsMock.loading = false
+ contextsMock.error = null
+ teamsMock.loading = false
+ teamsMock.error = null
+ })
+
+ it('shows an error banner, not "No members", when the contexts read fails', () => {
+ contextsMock.error = 'catalog boom'
+
+ renderWorkspace()
+
+ const panel = screen.getByRole('region', { name: 'Agent members' })
+ expect(within(panel).getByText('catalog boom')).toBeTruthy()
+ expect(within(panel).queryByText('No members')).toBeNull()
+ })
+
+ it('shows an error banner, not "No members", when the team directory read fails', () => {
+ teamsMock.error = 'directory boom'
+
+ renderWorkspace()
+
+ const panel = screen.getByRole('region', { name: 'Agent members' })
+ expect(within(panel).getByText('directory boom')).toBeTruthy()
+ expect(within(panel).queryByText('No members')).toBeNull()
+ })
+})