Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

feat(control-ui): move team rename to scalar dialog

Josué0a2b54762fdd
diff --git a/control-ui/app/profile-admin/teams/[teamId]/page.tsx b/control-ui/app/profile-admin/teams/[teamId]/page.tsx
index 92e23a0e6..7e0507d52 100644
--- a/control-ui/app/profile-admin/teams/[teamId]/page.tsx
+++ b/control-ui/app/profile-admin/teams/[teamId]/page.tsx
@@ -7,6 +7,7 @@ import {
RecordList,
RecordListRow,
RowActionMenu,
+ SingleValueEditDialog,
TableViewport,
} from '@clerum/frontend-components'
import { useConfirmDialog } from '@components/ConfirmDialog'
@@ -24,7 +25,7 @@ import {
import { getAgentDisplayName } from '@lib/agentName'
import { InviteMemberDialog } from '../../../../components/InviteMemberDialog'
import { IconUsers } from '../../../../components/Sidebar/icons'
-import { IconCheck, IconMoreHorizontal, IconX } from '../../../../components/icons'
+import { IconMoreHorizontal, IconX } from '../../../../components/icons'
import {
AdminTeamPendingInvitation,
ContextResource,
@@ -156,8 +157,9 @@ export default function TeamDetailsPage() {
const [deleteTeamDialogError, setDeleteTeamDialogError] = useState('')
const [teamName, setTeamName] = useState('')
- const [editingName, setEditingName] = useState(false)
- const [nameBuffer, setNameBuffer] = useState('')
+ const [renameOpen, setRenameOpen] = useState(false)
+ const [renameError, setRenameError] = useState('')
+ const [renameValid, setRenameValid] = useState(false)
const [members, setMembers] = useState<TeamMember[]>([])
const [pendingInvitations, setPendingInvitations] = useState<AdminTeamPendingInvitation[]>([])
const [resendingInvitationId, setResendingInvitationId] = useState<string | null>(null)
@@ -325,22 +327,23 @@ export default function TeamDetailsPage() {
}
function startEditingName() {
- setNameBuffer(teamName)
- setEditingName(true)
+ setRenameError('')
+ setRenameValid(Boolean(teamName.trim()))
+ setRenameOpen(true)
}
- async function saveTeamName() {
- const trimmed = nameBuffer.trim()
+ async function saveTeamName(value: string) {
+ const trimmed = value.trim()
if (!trimmed || isNew) return
setBusy(true)
- setError('')
+ setRenameError('')
try {
await renameAdminTeam(teamId, trimmed)
setTeamName(trimmed)
- setEditingName(false)
+ setRenameOpen(false)
showToast('Team renamed.', { tone: 'success' })
} catch (e) {
- setError(e instanceof Error ? e.message : 'Failed to rename team')
+ setRenameError(e instanceof Error ? e.message : 'Failed to rename team')
} finally {
setBusy(false)
}
@@ -626,40 +629,7 @@ export default function TeamDetailsPage() {
<DetailPageShell<TeamTab>
activeTab={activeTab}
actions={
- isNew ? null : editingName ? (
- <div className="cu-inline-edit cu-inline-edit--header">
- <input
- className="cu-inline-edit__input"
- value={nameBuffer}
- onChange={e => setNameBuffer(e.target.value)}
- onKeyDown={e => {
- if (e.key === 'Enter') void saveTeamName()
- if (e.key === 'Escape') setEditingName(false)
- }}
- disabled={busy}
- aria-label="Team name"
- autoFocus
- />
- <button
- type="button"
- className="cu-btn cu-btn--icon cu-btn--toolbar cu-inline-edit__save"
- onClick={() => void saveTeamName()}
- disabled={busy || !nameBuffer.trim()}
- aria-label="Save name"
- >
- <IconCheck width={18} height={18} />
- </button>
- <button
- type="button"
- className="cu-btn cu-btn--icon cu-btn--ghost"
- onClick={() => setEditingName(false)}
- disabled={busy}
- aria-label="Cancel editing"
- >
- <IconX width={16} height={16} />
- </button>
- </div>
- ) : (
+ isNew ? null : (
<>
<TeamActionsMenu
busy={busy}
@@ -1412,6 +1382,38 @@ export default function TeamDetailsPage() {
</div>
)}
+ <SingleValueEditDialog
+ discardLabel="Cancel"
+ error={renameError || undefined}
+ initialValue={teamName}
+ isValid={renameValid}
+ onDismiss={() => {
+ if (busy) return
+ setRenameOpen(false)
+ setRenameError('')
+ }}
+ onSave={value => void saveTeamName(value)}
+ open={renameOpen}
+ pending={busy}
+ renderEditor={({ value, onChange, disabled }) => (
+ <div className="cu-field">
+ <label htmlFor="rename-team-name">Team name</label>
+ <input
+ aria-label="Team name"
+ disabled={disabled}
+ id="rename-team-name"
+ onChange={event => {
+ setRenameValid(Boolean(event.target.value.trim()))
+ onChange(event.target.value)
+ }}
+ value={value}
+ />
+ </div>
+ )}
+ saveLabel="Rename team"
+ title="Rename team"
+ />
+
{confirmDialog}
</DetailPageShell>
)
diff --git a/control-ui/components/__tests__/ProfileAdminAgentCompatibility.test.tsx b/control-ui/components/__tests__/ProfileAdminAgentCompatibility.test.tsx
index 1f3029a5b..2a3d00db1 100644
--- a/control-ui/components/__tests__/ProfileAdminAgentCompatibility.test.tsx
+++ b/control-ui/components/__tests__/ProfileAdminAgentCompatibility.test.tsx
@@ -30,7 +30,21 @@ vi.mock('next/navigation', () => ({
}))
vi.mock('@components/DetailPageShell', () => ({
- DetailPageShell: ({ children }: { children: React.ReactNode }) => <main>{children}</main>,
+ DetailPageShell: ({
+ actions,
+ children,
+ title,
+ }: {
+ actions?: React.ReactNode
+ children: React.ReactNode
+ title?: React.ReactNode
+ }) => (
+ <main>
+ <h1>{title}</h1>
+ <div aria-label="Detail actions">{actions}</div>
+ {children}
+ </main>
+ ),
}))
vi.mock('../../lib/api', async () => {
@@ -131,6 +145,36 @@ afterEach(() => {
})
describe('profile-admin agent compatibility access', () => {
+ it('renames a team through the scalar edit dialog and retains failures', async () => {
+ vi.mocked(api.getAdminTeamContexts).mockResolvedValue({ teamId: 'team-1', contextIds: [] })
+ vi.mocked(api.getAdminTeamAgents).mockResolvedValue({
+ teamId: 'team-1',
+ agentNames: [],
+ deletedAgentNames: [],
+ deletedHistoryLimit: 10,
+ })
+ vi.mocked(api.renameAdminTeam)
+ .mockRejectedValueOnce(new Error('Rename failed'))
+ .mockResolvedValueOnce({ id: 'team-1', name: 'Platform Engineering' })
+ renderTeamDetails()
+
+ await screen.findByRole('heading', { name: 'Platform' })
+ fireEvent.click(screen.getByRole('button', { name: 'Team actions' }))
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Rename team' }))
+ const dialog = await screen.findByRole('dialog', { name: 'Rename team' })
+ const input = within(dialog).getByRole('textbox', { name: 'Team name' })
+ expect(input).toHaveValue('Platform')
+ fireEvent.change(input, { target: { value: 'Platform Engineering' } })
+ fireEvent.click(within(dialog).getByRole('button', { name: 'Rename team' }))
+
+ expect(await within(dialog).findByRole('alert')).toHaveTextContent('Rename failed')
+ expect(input).toHaveValue('Platform Engineering')
+ fireEvent.click(within(dialog).getByRole('button', { name: 'Rename team' }))
+ await waitFor(() => expect(api.renameAdminTeam).toHaveBeenCalledTimes(2))
+ await waitFor(() => expect(screen.queryByRole('dialog')).toBeNull())
+ expect(screen.getByText('Team renamed.')).toBeInTheDocument()
+ })
+
it('renders team agent loading skeleton rows as listitems', () => {
vi.mocked(api.getAdminTeamAgents).mockReturnValue(new Promise(() => {}))
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 61b277dec..14a0957d2 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.622",
+ "version": "0.1.623",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.622",
+ "version": "0.1.623",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 51b56ac9e..831456358 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.622",
+ "version": "0.1.623",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",