Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

docs: remove the drag-and-drop design notes

M0ec71ed1bafa
diff --git a/docs/design/gfs-breadcrumb-drop-move.md b/docs/design/gfs-breadcrumb-drop-move.md
deleted file mode 100644
index fa4551b56..000000000
--- a/docs/design/gfs-breadcrumb-drop-move.md
+++ /dev/null
@@ -1,258 +0,0 @@
-# Breadcrumb drop-move — implementation plan (Control UI)
-
-**Sibling doc:** [`gfs-move-forbidden-ux-matrix.md`](./gfs-move-forbidden-ux-matrix.md) —
-the deny-reason → message/visual matrix. This feature MUST reuse those treatments for
-refused breadcrumb drops.
-
-**HARD CONSTRAINT — NO BACKEND CHANGES.** The move PATCH, permission model, and policy
-server contracts are frozen. Everything here is browser/renderer-side. Allowed areas:
-`control-ui/**`, this plan document, and only surface-agnostic pure additions
-to `packages/gfs-interaction-policy` if genuinely needed. Do **not** touch
-`control-api`, `external-rest-api`, `gfs-controller`, `deploy/`, or any DB.
-
----
-
-## 1. Feature
-
-Users drag a file **or folder** from the listing onto a **breadcrumb crumb** — an
-ancestor folder (e.g. `Product` while browsing `main › Product › live tests`) or the
-drive root (`main`) — to move it there. Today the only upward-move path is the row ⋯
-menu → Move dialog. Crumbs are plain buttons (`GfsBrowser.tsx`,
-`cu-gfs-breadcrumb__button`) with no drag handlers, while rows already advertise
-draggability ("Drag {name} into a folder to move it", `GfsBrowser.tsx:2372`).
-
-## 2. Current state (receipts)
-
-| Fact | Where |
-|---|---|
-| Breadcrumb = `<nav aria-label="Breadcrumb">` of per-crumb `<button>`s; click = `goToCrumb(index)`; active crumb carries `aria-current="page"`; only active crumb has ⋯ menu | `control-ui/components/GfsBrowser.tsx` (~line 2255) |
-| Crumb model: `{ id, rid, gfsUri, name, version, isDriveRoot }`; drive root starts synthetic (`id === null`) then receives its real ID and RID from `TreePage.rootResourceId`; `isDriveRoot` remains true — `isDriveRootCrumb` | `GfsBrowser.tsx`, `Crumb`, `createDriveRootCrumb`, root hydration in `load` |
-| Rows: `draggable`, native tooltip, per-row `onDrop` + container `onDrop` → `handleGfsDrop` | `GfsBrowser.tsx:2217, 2372, 2389` |
-| Shared, browser-safe move policy (structure + authority + convergence) already consumed by both UIs | `packages/gfs-interaction-policy/dragPolicy.cjs` |
-| Folder confirmation with numbered-name toggle + impact copy; Move dialog is a separate keyboard path | `control-ui/components/GfsMoveConfirmDialog/index.tsx`, `GfsMoveDialog/index.tsx` |
-| Existing Control UI commit runner sends the listing version and bounds the 409 ladder; it does **not** re-resolve either endpoint or implement Desktop outcome verification | `GfsBrowser.tsx`, `moveResource` |
-| Control UI has one local row drag ref and a blue target ID, **no** `hoverVerdict`, authority probes, cold-hover budget, gesture epochs, or reason-aware announcements | `handleResourceDragStart`, `handleFolderDragOver`, `handleFolderDrop` |
-| Existing row files move directly; folder drops use one confirmation | `handleFolderDrop`, `GfsMoveConfirmDialog` |
-
-## 3. Design
-
-### 3.1 Drop targets and audit decisions (2026-10-23)
-- Every crumb is a drop target: ancestors, the `main` drive root, and the active
- folder. Capture the physical source-parent ID at dragstart; active-crumb drops
- resolve to `same-parent`, with named “already in” info feedback and no PATCH.
-- **Root question resolved:** use the hydrated root ID/RID (not null, a made-up ID,
- or an authority denial). It is a directory destination with canonical path `/`.
- If identity is not available yet, show `unavailable` and retry on drop. Control UI
- is the operator plane: authority is intrinsic, including at root. No affordance
- probe is necessary and no permission denial is fabricated.
-- A visible crumb is an observed ancestor, not an unconditional ancestry proof:
- stream reconstruction or remote moves can change it. Re-resolve both captured
- endpoint identities before admission and again before drag commit; use fresh
- canonical paths with `decideDragPathStructure`. Missing paths defer structure to
- the atomic server guard; failed resolution prevents dispatch with honest feedback.
-
-### 3.2 Extend the existing drag pipeline
-- Crumb and row handlers share one admission function, one drag session/epoch,
- `confirmMoveTarget`, and `moveResource`; do not introduce a separate crumb runner.
-- Hover uses cached observed IDs/paths and shared pure structure policy. No cold
- hover requests are needed for these operator listings, so a Desktop-style hover
- budget and its exhausted-budget scenario are inapplicable here. Unknown ancestry
- remains landable (`checking` / `server-check-required`), never a fake denial.
-- Existing file-to-row drops keep moving directly. **Both files and folders dropped
- onto crumbs get one confirmation**, as requested. Extend the same confirmation
- with source kind for accurate file impact copy and accessible naming; keep the
- existing folder dialog name and copy. Keep numbered naming in that dialog.
-- Drop checks have priority because they are the only network adjudication. A failed
- hover observation does not consume or disable drop-time checking.
-
-### 3.3 Visual and messaging contract
-- Paint `data-drop-state` and `data-drop-reason` on crumbs and rows. Only allowed
- targets get blue. Checking is neutral, unavailable warning, ordinary denials error,
- and `same-parent` neutral/info. Use the existing CSS tokens.
-- Reuse the sibling matrix §3 wording by reason in an app-local browser-safe helper.
- Share hover announcements and drop refusal copy across row/crumb handlers. Hover
- announces through aria-live without toast spam; refused drops use the toast stack
- (which is itself live). Session loss also stays in a persistent page alert.
-- Operator permission denies A6–A8 cannot be produced truthfully from local bits;
- cover their copy mapping in pure tests and surface server refusal honestly. Never
- manufacture missing bits to meet a test. Desktop parity remains out of scope.
-- Keep native row tooltips and extend them to mention breadcrumbs.
-
-### 3.4 Races and convergence
-- Capture crumb ID/RID/URI/version into a destination value synchronously at drop.
- Stop propagation/default on internal crumb drops so the upload container cannot
- process them. Keep click/keyboard breadcrumb navigation intact.
-- A monotonic gesture epoch supersedes pending admission/confirmation/commit reads.
- Dragend clears hover/source presentation but does not invalidate an accepted drop.
- A newer drag invalidates stale reads and confirmation. Unmount invalidates work.
-- Immediately before dispatch, resolve **both endpoints by immutable URI**, validate
- returned identities and destination kind, and use the fresh source version. Do
- not consult a rebuilt trail for the destination (R7-M1). Check epoch after reads
- and immediately before every PATCH; already dispatched requests cannot be recalled.
-- Preserve existing R5/R7 trail reconstruction. Use `planMoveConvergence` to invalidate
- observed old/new parent caches; refresh the live current location after a drag move,
- keeping the user there instead of navigating to the target. Do not claim a failed
- transport dispatch left the resource unchanged; report an unknown outcome.
-
-## 4. Files to touch (allowlist)
-
-| Area | Change |
-|---|---|
-| `control-ui/components/GfsBrowser.tsx` | crumb drag handlers, verdict state per crumb, drop wiring into existing commit path |
-| `control-ui/app/globals.css` | `cu-gfs-breadcrumb__button` drop-state styles (`checking/allowed/denied/unavailable` + reason attribute) |
-| `control-ui/e2e/run-gfs-drag-and-drop.mjs` + component tests | cases below |
-| `packages/gfs-interaction-policy` | ONLY if a pure helper (e.g. root-target facts) is genuinely needed; no signature breaks |
-| `control-ui/lib/gfsDragFeedback*` + colocated types/tests | reason/tone/announcement mapping |
-| `control-ui/components/GfsMoveConfirmDialog/**` | source-kind-aware file confirmation |
-
-Desktop Files and the sibling UX matrix document are owned by another task and must not be edited.
-
-## 5. Test plan
-
-Status recorded 2026-10-23 by the implementing worker (component/pure/gate lanes;
-live lanes pending the owned-environment opt-in — see §8).
-
-- ☑ Drag `abac.md` onto `Product` crumb → confirm dialog shows "Move abac.md to
- Product?" → commit → listing refreshes; file gone from `live tests`, present in
- `Product`. (component: file-kind confirmation + PATCH `newParentId`/fresh
- `ifMatch`; live journey added.)
-- ☑ Drag onto drive-root crumb `main` → moves to root (admin plane). (component:
- hydrated-root admission + PATCH to root id; unhydrated-root hydration retry;
- live journey added.)
-- ☑ Drag onto the ACTIVE crumb → info "already here", no error styling, no PATCH.
- (component + pure tests; live journey added.)
-- ☑ Folder onto ancestor crumb (incl. a crumb above its own parent) → moves;
- descendant targets are impossible by construction (crumbs are ancestors) —
- asserted no `descendant` case can trigger here (pure verdict walk over every
- crumb × file/folder source; live ancestor journey added).
-- ☑ Structural refusal and same-parent info have reason attributes, correct styles,
- toasts and SR wording. Pure copy tests cover `destination-write`, `source-write`,
- and `source-delete`; operator hover never fabricates these permission denials.
-- ☑ Unavailable endpoint → warning, no PATCH; a later drop retries resolution. No
- cold-hover budget exists in this operator surface (audit decision §3.2).
-- ☑ Breadcrumb reconstruction mid-drag → drop commits against captured crumb identity;
- no mis-anchored trail (R5-M1/R7-M1 regression suite stays green; new mid-gesture
- rebuild test pins the captured identity).
-- ☑ Keyboard/access: crumb buttons keep click-navigation; Move dialog unchanged as the
- keyboard path; verdicts announced via aria-live.
-- ☑ Control UI production build + suites green (`npm test` 245 files / 2819 tests,
- `npm run build`, `tsc --noEmit`); Desktop untouched by this task.
-
-## 6. Acceptance criteria
-
-1. From any listing row, a file or folder can be moved to any visible ancestor crumb
- (including root) with one confirmation — no ⋯ menu needed.
-2. Every refused crumb drop explains WHY in plain language (matrix doc), visually and
- to SRs; nothing is silently ignored.
-3. Zero changes outside the allowlist in §4; backend untouched (verifiable via
- `git diff --stat`).
-4. All existing drag-and-drop suites (unit, component, property, Playwright spec)
- remain green; new cases in §5 pass.
-
-## 7. Verification ownership
-
-The runner `e2e/run-gfs-drag-and-drop.mjs` validates Playwright inventory; actual
-journeys belong in `e2e/gfs-drag-and-drop.spec.ts`. Extend both so the gate requires
-the new breadcrumb cases. Component tests own deferred-read/epoch and reconstruction
-races. Live E2E requires configured owned endpoints and credentials; report it
-separately from the production build and permission/unit suites.
-
----
-
-## 8. Implementation notes (2026-10-23, implementing worker)
-
-Refinements recorded against §§3–4 during implementation, cross-checked against
-the audited receipts. Nothing below changes the constraints; each note pins a
-decision the plan left open.
-
-- **Warning toast tone.** The Control UI toast stack only had `info/success/error`,
- but the matrix tone contract (unknown = warning) requires a real warning tone.
- `ToastTone` gained `warning`, painted through the existing `--cu-warning` /
- `--cu-warning-rgb` tokens (`components/Toast/types.ts`, `app/globals.css`).
- No other tone surface changed.
-- **Drop-state vocabulary.** `data-drop-state` on crumbs and rows is one of
- `allowed | checking | denied | unavailable | same-parent`; `data-drop-reason`
- carries the deny reason for `denied` rows/crumbs. Rows keep `data-drop-target`
- (allowed only) so the existing Playwright journeys keep their release signal.
- The dragged row itself is now a deliverable drop zone so a self-drop paints
- and explains (matrix A1); plain file rows remain pass-through non-targets.
-- **Reason mapping home.** `control-ui/lib/gfsDragFeedback.ts` (+ `.types.ts`,
- pure tests) owns reason → message/tone/announcement and the zero-network
- hover verdict (wrapping the shared `decideDragStructure`). The previously
- component-local `structureDenialMessage`/`canonicalPathOf` helpers were
- removed in favor of it. A6–A8 copy is mapped and unit-tested but never
- fabricated from local bits — the operator plane holds intrinsic authority.
-- **Admission reads.** Crumb drops and row FOLDER drops re-resolve both
- endpoints by immutable URI at admission (404 → B4/B5 copy, transport →
- warning, kind/identity mismatch → honest refusal, null path → defer to the
- server guard). Row FILE drops keep moving directly and re-resolve only at
- commit, preserving "files move directly" while still validating before
- dispatch.
-- **Commit revalidation placement.** `moveResource` grew an opt-in
- `revalidate: { epoch }` used by every drag commit path (direct file drops and
- the confirmation's commit). It resolves both endpoints again, validates
- identity + destination kind, re-runs `decideDragPathStructure` on fresh
- paths, and uses the fresh source version for `ifMatch`. The keyboard Move
- dialog path intentionally does not opt in — "preserve Move dialog behavior".
-- **Transport honesty.** A PATCH that fails without an HTTP status (outcome
- unknown) is verified exactly once by resolving the source by URI: parent ==
- destination ⇒ report the move it proved; unchanged path ⇒ warning
- "couldn't complete"; failed verification ⇒ warning "couldn't confirm". The
- PATCH is never repeated. This is a bounded Control-UI-sized version of the
- Desktop B7/B8 semantics, not an import of the Desktop pipeline.
-- **Gesture epochs.** Monotonic counter bumped at dragstart (superseding prior
- admissions and clearing an open confirmation) and at unmount (plus a mounted
- guard). Dragend clears presentation only. The epoch is checked after every
- async read and immediately before each PATCH dispatch.
-- **Root identity.** The unhydrated root paints `unavailable` at hover; the
- drop retries hydration through one bounded `/gfs/tree` read and adopts the
- returned `rootResourceId`/RID (same hydration code path as `load`). Root
- destinations carry `gfs://main/<rid>` and canonical path `/`; no authority
- probe, no fabricated deny.
-- **Convergence.** `planMoveConvergence` now drives old+new parent cache
- invalidation inside `moveResource` (observed old parent = trail parent for
- trail folders, else the current folder), replacing the single
- destination-only cache delete. The live current folder is refreshed; a drag
- move never auto-navigates.
-- **Gate inventory.** `run-gfs-drag-and-drop.mjs` exports
- `REQUIRED_JOURNEY_INVENTORY` and fails the selection phase when the
- breadcrumb lanes (file move, root move, active same-parent, ancestor folder
- move) are absent, with unit tests in `test/__tests__/gfsDragAndDropGate.test.ts`.
-
-### QA corrections (2026-10-23, supervisor review round 1)
-
-- **Drop-boundary capture (R7).** Same-parent/no-op facts and the destination
- identity are computed synchronously in `handleCrumbDrop`; nothing after an
- await reads live trail state for those checks. A trail reconstruction that
- lands while root hydration is pending can no longer turn a captured
- ancestor index into the live active index (regression covered).
-- **Fresh precondition.** The commit re-resolve refuses without a PATCH when
- the fresh source version is missing, negative, or not a safe integer —
- never downgraded to the stale row version — and when the fresh source kind
- no longer matches the captured kind. The destination identity is ALWAYS
- revalidated through its immutable URI; a cached path observation is never a
- substitute.
-- **Live-location convergence.** The commit refresh loads the LIVE
- `currentCrumbRef` location (a render-time crumb could name a folder the
- operator navigated away from mid-commit), and convergence invalidation uses
- the physical old parent captured at the drag boundary (regression:
- navigation mid-commit refreshes the live folder, invalidates the captured
- old parent and the destination, never navigates away).
-- **Unknown transport outcomes.** The single post-transport verification
- proves `moved` only positively: source resolves under the destination's
- CURRENT path (re-resolved by URI) with the exact requested name. A
- differing parent, a source resolved at `/`, an unreachable destination, or
- a failed read all stay UNKNOWN with refresh guidance ("Couldn't confirm the
- move. Refresh before trying again.") and no repeat PATCH — the former
- `move-not-completed` verdict was removed because one GET cannot prove the
- PATCH did not land.
-- **Session loss (A11).** A 401 from any drag-pipeline read — admission,
- commit, or root hydration — classifies as session-lost and raises a
- persistent sign-in alert (plus the announcement wording) instead of a
- connection-flavored warning. The API layer's own unauthorized boundary
- (`AuthExpiredError` + global auth-error handler) is unchanged.
-- **Reason attribute contract.** `data-drop-reason` now carries its reason
- for every defined state: `denied`, `unavailable` (`target-unavailable`),
- and `same-parent`; only `allowed`/`checking` stay reason-free. The shared
- endpoint view/read types moved to `lib/gfsDragFeedback.types.ts` per the
- frontend style rules.
diff --git a/docs/design/gfs-move-forbidden-ux-matrix.md b/docs/design/gfs-move-forbidden-ux-matrix.md
deleted file mode 100644
index 1baaaed29..000000000
--- a/docs/design/gfs-move-forbidden-ux-matrix.md
+++ /dev/null
@@ -1,209 +0,0 @@
-# EvenDrive move-forbidden UX — full case matrix
-
-**Worktree:** `feat/even-drive-drag-and-drop-fix` · **Scope:** Desktop sidebar tree + Files
-panel (Control UI parity noted where it differs)
-**Sibling doc:** [`gfs-breadcrumb-drop-move.md`](./gfs-breadcrumb-drop-move.md) — breadcrumb drop targets; refused drops there MUST use this matrix for messaging.
-**Goal:** every forbidden-move case tells the user WHAT happened and WHY — visually and
-programmatically — instead of the current silent refusal.
-
-**Audit baseline:** `966a3d647`, audited 2026-10-23 against the checked-out
-sources. Line receipts below describe that baseline, before implementation.
-The earlier live example is handoff evidence; this source audit did not access
-or mutate the dev cluster.
-
----
-
-## 1. Why it is silent today (receipts)
-
-The deny **reason is computed and then thrown away** at the UI layer:
-
-| Layer | File | What it does |
-| ------------------ | ----------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| Structure decision | `packages/gfs-interaction-policy/dragPolicy.cjs` → `decideDragStructure` | returns `{kind:'deny', reason:'self'│'cross-drive'│'root-source'│'same-parent'│'descendant'}` or `server-check-required` |
-| Authority decision | `dragPolicy.cjs` → `decideDragAuthority` | returns `{kind:'deny', reason:'destination-write'│'source-write'│'source-delete'}`, `checking`, `unavailable`, `observed-allowed` |
-| Adjudication | `desktop-app/ui/src/gfs/dragAdjudication.ts` | maps probes/session loss to `session-lost`, `unavailable`, `target-unavailable`, `source-location-unknown` |
-| Paint | `desktop-app/ui/src/components/SidebarNav/FileExplorerTree/index.tsx:314-315` | row gets `data-drop-state={allowed│denied│checking│unavailable}` — **reason collapsed to a boolean-ish state** |
-| Speech | `desktop-app/ui/src/gfs/dropVerdict.ts:14-27` (RP-026) | generic only: _"You cannot move into {target}."_ — no reason |
-| CSS | `desktop-app/ui/src/styles.css:1987-2011` | **Tree:** `denied` only de-emphasizes the label (1999) — nearly invisible. **Files grid:** `checking`/`allowed` styles exist; **`denied` has NO style at all** → this is the "no blue highlight and no idea why" bug |
-
-`GfsDropVerdict` already carries denied/unavailable reasons in
-`desktop-app/ui/src/gfs/dragSession.types.ts:61-65`. Both surfaces discard
-them when storing only `verdict.state` (tree `:663-669`, FilesPage
-`:1284-1287`). `moveDenialMessage` already exists in `moveCommit.ts:360`,
-but its copy is generic and both callers toast every refusal as an error.
-Self-hover is skipped entirely (tree `:650`, FilesPage `:1339`). Both use
-`dropEffect=none` for denied hover (tree `:675`, FilesPage `:1364`), which
-can prevent Chromium from delivering the refused drop at all.
-
-**The two symptoms are:**
-
-- Sidebar tree: `denied` ≈ invisible (label dimming only) → "nothing happens".
-- Files panel: `allowed` paints the blue highlight; `denied` has no CSS → no highlight,
- no explanation.
-
-Design rule already in the codebase (RP-026 header comment): _paint the verdict on the
-row for sighted users, speak it for SR users_. The fix keeps that shape but carries the
-**reason** through and adds a **persistent, readable explanation at drop time** (row
-tints alone are too subtle to read a reason from).
-
----
-
-## 2. The two-phase gate (when is a move forbidden?)
-
-A move must pass BOTH phases. The reason shown must name the phase.
-
-**Phase A — drag adjudication (before confirm):** structure check → authority check
-(`decideDragAuthority`: needs `write` + `delete` on the **physical source parent** and
-`write` on the destination; bits may be direct/inherited/team).
-**Phase B — commit (after confirm):** server re-validates atomically (cycle/self guard,
-destination kind, parent permissions) and executes the PATCH (with numbered-name ladder
-on 409).
-
-> Verified live example (dev cluster, 2026-10-23): dragging `live tests` → `Assets`
-> fails Phase A with `source-write`/`source-delete` because `live tests`' physical
-> parent is a nameless folder where the desktop user holds **zero** bits — even though
-> the user holds ALL bits on both `live tests` and `Assets` themselves. `gfs_audit`
-> shows **no mutation rows** → refused client-side, silently.
-
----
-
-## 3. Phase-A matrix — every drag-time forbidden case
-
-| # | Reason (code) | Trigger — what the user did | Underlying rule | Sidebar tree feedback | Files panel feedback | Persistent message (drop) | SR announcement |
-| --- | ---------------------------------------------------------------- | ----------------------------------------------------------------------------------------- | --------------------------------------------------------------- | -------------------------------------------------------------------------------------------- | --------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------- |
-| A1 | `self` | Drop onto the dragged item itself | `dragPolicy.cjs:59` | row `denied` + tooltip | row `denied` | Banner/toast: "You dropped {name} onto itself. Pick a destination folder." | "You cannot move {name} into itself." |
-| A2 | `cross-drive` | Drop across drives | `dragPolicy.cjs:60` | same as A1 | same | "Moving between drives isn't supported." | same, spoken |
-| A3 | `root-source` | Source is the drive root (or virtual root item that is physically root) | `dragPolicy.cjs:61-62` | show `denied` on targets when the source is observed to be root | same | "This location is the top level — it can't be moved." | spoken |
-| A4 | `same-parent` | Target IS the physical parent (no-op move) | `dragPolicy.cjs:64-65` + path form `:118` | row `denied` | row `denied` | "{name} is already in {target}." — **NOT an error tone; info**. Critical with the flat sidebar: e.g. `Assets` physically lives in `Product`, so dragging Assets→Product is a no-op even though it _looks_ like a real move | "{name} is already in {target}." |
-| A5 | `descendant` | Folder dropped into its own subtree | `dragPolicy.cjs:73` | row `denied` on the whole subtree | row `denied`, no blue | "You can't move {name} into a folder inside itself." | spoken |
-| A6 | `destination-write` | No `write` on destination (e.g. read-only share) | `dragPolicy.cjs:146` — checked FIRST (surface the user acts on) | row `denied` — this is the case where the blue highlight must NOT appear | row `denied`, no blue | "You don't have permission to move items into {target}. You need edit access to the destination folder." | spoken with reason |
-| A7 | `source-write` | No `write` on the physical **source parent** | `dragPolicy.cjs:147` | row `denied` | row `denied`, no blue | "You can’t move {name} out of its current folder because you don’t have edit access to the folder that contains it." | spoken |
-| A8 | `source-delete` | `write` but no `delete` on the source parent | `dragPolicy.cjs:148` | row `denied` | row `denied`, no blue | "You can’t move {name} out of its current folder because you don’t have delete access to the folder that contains it." | spoken |
-| A9 | `checking` | Bits not yet known (cold hover) | `dragPolicy.cjs:140` | neutral spinner-tint row | neutral | none (transient) | "Checking whether you can move into {target}…" |
-| A10 | `unavailable` / `target-unavailable` / `source-location-unknown` | Required drop probe failed (network/5xx/429/404); exhausted hover budget stays `checking` | `dragAdjudication.ts:58-98` | failed cold hover currently remains `checking`; any `unavailable` paint must NOT look denied | row `unavailable` | "EvenDrive couldn’t verify this move. Check your connection and try again." For target disappearance: "This folder is no longer available." For an unknown source location: "EvenDrive cannot verify this item’s current location. Refresh and try again." Drop checks remain available after inconclusive hover; a failed required drop check refuses admission. | spoken |
-| A11 | `session-lost` | 401 during probe | `dragAdjudication.ts:58` | gesture ends; re-auth prompt | same | "Your session ended. Sign in again to continue moving files." (session revoked per med-probe-401) | spoken |
-| A12 | `server-check-required` | Ancestry unproved (grants start below root) | `dragPolicy.cjs:82` | row `checking` — NOT denied; stays landable | neutral | none at hover; drop proceeds to server verdict (Phase B) | "Checking…" |
-
----
-
-## 4. Phase-B matrix — commit-time outcomes (after "Move" confirm)
-
-Source of truth: `desktop-app/ui/src/gfs/moveCommit.ts`
-`commitGfsMove` (`:132`), `toastMoveOutcome` (`:323`) and
-`desktop-app/ui/src/gfs/moveCommitRunner.ts` `runGfsMoveCommit` (`:63`).
-There is no `presentMoveCommitOutcome` symbol. The table records the required
-user-facing semantics; the notes distinguish existing behavior and safe copy
-limits from proposed improvements.
-
-| # | Outcome | Trigger | Message (toast) | Tone |
-| --- | -------------------------------------------------------------- | -------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------ |
-| B1 | `committed` (+ optional `renamedTo`) | PATCH 200 | "Moved {source} to {destination}." / "…as {renamed}." | success |
-| B2 | numbered-name conflict resolved | 409 → ladder accepted | same as B1 with "as {renamed}" | success |
-| B3 | conflict ladder exhausted | 409 × N > limit | Existing bounded-ladder result: "The destination changed. Refresh it or choose another folder." Without rename consent: choose another folder or use Move to rename if permitted. | error |
-| B4 | source vanished (404 on source re-resolve/dispatch) | rp-027 | "EvenDrive cannot verify this item’s current location. Refresh and try again." (404 may also mean hidden; do not claim deletion.) | error |
-| B5 | destination vanished (404 on destination) | rp-027 | "This folder is no longer available." (source re-resolve distinguishes the sides; do not claim deletion.) | error |
-| B6 | server structural deny (cycle/kind/parent-permission re-check) | PATCH 403/400 | 400: "The server rejected this destination. Refresh and choose a different folder." 403 (implemented): "EvenDrive could not confirm permission for this move. Refresh and try again." — never names a parent bit without fresh proof, never raw HTTP prose. | 403 → warn (unknown outcome); 400 → error |
-| B7 | transport loss, outcome unknown | fetch threw after dispatch | Existing verification resolves by identity once → B1 or "Couldn’t confirm the move. Refresh before trying again." Do not repeat PATCH. An in-progress notice may precede this verification. | warn when unconfirmed; success if verified |
-| B8 | 5xx | server error | Verify by identity → B1 or "Couldn’t confirm the move. Refresh before trying again." A 5xx does not prove nothing changed. | warn when unconfirmed; success if verified |
-
-> Tone baseline (implemented in `toastMoveOutcome`): the unknown-outcome
-> statuses — `unconfirmed` (B6-403/B7/B8) and `rate-limited` — present as
-> `warn`, because an unconfirmed move has not been shown to fail; every
-> definite negative (B3/B4/B5, B6-400) stays `error`. Dispatch, retry and
-> verification safety are unchanged.
-> | B9 | `session-lost` | 401 at commit | Persistent revoked-session surface: "Your session ended. Sign in again to continue moving files." Do not claim a dispatched move failed if its outcome is unknown. | error |
-> | B10 | user stopped / canceled dialog | Stop / Esc / backdrop | silent or "Move canceled." (per PR's stop-notice pattern) | info |
-
----
-
-## 5. Visual spec (what to change)
-
-1. **Carry the reason**: preserve the existing `GfsDropVerdict.reason` instead of storing only its state;
- `data-drop-reason` attribute next to `data-drop-state` (FileExplorerTree:315, grid
- rows). Tests in `dropVerdict`/RP-026 keep their one-wording-per-verdict contract by
- keying on reason, not surface. Add a shared browser-safe presenter for message and tone; reuse it for hover tooltips, SR and refused drops.
-2. **Give `denied` a real treatment in BOTH surfaces** (today: tree = label dim only,
- grid = nothing):
- - Tree row + grid row: red/neutral inset border and background tint; retain readable labels and existing source-opacity treatment.
- - **Do NOT** use error-red for `same-parent` (A4: info) or `unavailable` (A10:
- warning) — reasons map to tones: deny=error, no-op=info, unknown=warning.
-3. **Drop-time persistent message**: keep internal directory drops deliverable
- (`preventDefault`, `dropEffect='move'`) even for observed denial, so release
- can present the reason. Admission still refuses the mutation. Remove the
- self-hover early return so self drops also paint and explain their reason.
- On a refused DROP, show the reason message from
- the matrix as a toast (reuse the application `pushToast` stack) or the
- `StatusBanner` component — banners for `session-lost` (persistent), toasts for
- one-shot denies. Hover-time stays row-tint-only (no toast spam while dragging over
- many rows).
-4. **SR**: extend `gfsDropVerdictAnnouncement(state, target)` →
- `(state, target, reason, sourceName?)`; on drop, announce the full reason sentence (RP-026
- contract: same wording per reason on every surface).
-5. **Blue highlight rule stays**: only `observed-allowed` paints blue;
- `checking` is neutral, and unknown/unavailable uses warning tokens. The fix is not to show blue more — it's to SAY WHY when it isn't blue.
-
-## 6. Plain-language copy rules (match PR's existing tooltip style)
-
-- Name the **missing access**, not the bit: "edit access" = write, "delete access" =
- delete. Never "source-parent-write".
-- Distinguish the **three places** a move touches: the item, the folder it leaves, the
- folder it enters. A7/A8 messages must mention "the folder that contains it".
-- No-op moves (A4) get info tone + "already there", never "cannot".
-- Unknown (A10) never implies forbidden — say "couldn't verify, try again".
-
-## 7. Implementation and verification handoff
-
-Frontend-only: implement Desktop tree + Files grid feedback; leave Control UI
-breadcrumb work and `docs/design/gfs-breadcrumb-drop-move.md` to their owner.
-No backend, deployment, or server-contract edits. Read `AGENTS.md`,
-`desktop-app/ui/AGENTS.md` and its referenced style documents first.
-
-Use Node 24.22.1 (`/home/pal/.nvm/versions/node/v24.22.1/bin`) and prefix
-**every npm invocation** with `UV_USE_IO_URING=0`. Before counting Desktop
-validation, verify `node --version` and `npm run verify:electron`. Required:
-Desktop `npm run build` (main + renderer), Desktop `npm test`; Control UI
-`npm run build` only if its parity surface changes. Cover reason retention,
-state-to-reason changes, no-op info tone, missing source/destination access,
-self/descendant, unknown warning and the browser drop-delivery contract with
-focused regression tests. Preserve session/gesture ownership checks and
-cold-hover network budgets. Keep session loss visible even when revocation
-invalidates the gesture before the normal drop callback resumes.
-
-Commit only owned paths in logical conventional commits. Do not stage
-`control-ui/next-env.d.ts`, `profile-ui/next-env.d.ts`, generated output or
-`desktop-app/package.json` churn. The checkbox reset is preserved separately
-in `bf469d7d8`. Other agents may commit on this same branch; never reset or
-amend their work. Report tests, commit IDs and any unresolved limitation to
-the supervisor for review before push.
-
-### Desktop implementation baseline (2026-10-23, local commits)
-
-Implemented in `desktop-app/ui` only: the shared presenter
-`src/gfs/dropVerdict.ts` (+ `dropVerdict.types.ts`) owns tone, sentences,
-announcements and the drop-refusal presentation; the tree and the Files grid
-carry the full verdict (`data-drop-state` + `data-drop-reason`), keep denied
-internal hovers deliverable, gate the session-ended banner by the captured
-scope/session identity, and render the session-ended sentence on the revoked
-surfaces themselves. Grid tone tints are grid-scoped in `src/styles.css` so
-they out-rank the row base and hover backgrounds (guarded by
-`src/pages/__tests__/gfsDropTintCascade.test.ts`). Covered by focused unit
-regressions: reason retention, same-state reason changes, no-op info tone,
-missing source/destination access, self/descendant/root-source, unknown
-warning, denied drop-delivery without mutation, SR announcements, and both
-cross-surface tooltip directions. No live-cluster lane was run for this
-baseline; the manual matrix below remains unchecked until it is.
-
-## 8. Manual test matrix (maps to your PR checklist lane 1/3)
-
-Not executed against a live cluster yet — unit-regression coverage for A1/A3–A8
-and A10 exists (see §7); the checkboxes stay open until the manual lane runs.
-
-- ☐ A4 drag `Assets` onto `Product` (physically already inside) → info "already there", NOT red
-- ☐ A7 drag `live tests` onto any folder → refused drop + toast naming "the folder that contains it"
-- ☐ A6 read-only destination share → no blue, reason names destination
-- ☐ A5 folder into own subfolder → refusal names self-containment
-- ☐ A10 kill network mid-hover → warning tone, drop still attempts
-- ☐ B4/B5 vanish source/destination via second user → distinct messages
-- ☐ B7 drop during network cut → "checking whether it completed", then converge
-- ☐ SR: every refused drop announces reason; sighted: every denied row readable
- (row tints, incl. hovered grid rows, verified by the cascade guard unit test)