Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend-components): restore absent secret drafts

Josué11cd7f4a81dc
diff --git a/packages/frontend-components/src/edit/SecretEditField.tsx b/packages/frontend-components/src/edit/SecretEditField.tsx
index 1c1cfad49..52993b480 100644
--- a/packages/frontend-components/src/edit/SecretEditField.tsx
+++ b/packages/frontend-components/src/edit/SecretEditField.tsx
@@ -63,13 +63,10 @@ export function SecretEditField({
</button>
<button
className="eft-dialog__text-button"
- disabled={
- disabled ||
- !existingValue ||
- state.status === 'untouched' ||
- state.status === 'restored'
+ disabled={disabled || state.status === 'untouched' || state.status === 'restored'}
+ onClick={() =>
+ onStateChange(existingValue ? { status: 'restored' } : { status: 'untouched' })
}
- onClick={() => onStateChange({ status: 'restored' })}
type="button"
>
{restoreLabel}
diff --git a/packages/frontend-components/src/edit/__tests__/EditPrimitives.test.tsx b/packages/frontend-components/src/edit/__tests__/EditPrimitives.test.tsx
index 5968e2470..2fd2f7182 100644
--- a/packages/frontend-components/src/edit/__tests__/EditPrimitives.test.tsx
+++ b/packages/frontend-components/src/edit/__tests__/EditPrimitives.test.tsx
@@ -189,6 +189,24 @@ describe('SecretEditField', () => {
)
expect(screen.getByRole('button', { name: 'Restore' })).toBeDisabled()
})
+
+ it('restores the empty original state after drafting a new secret', async () => {
+ const user = userEvent.setup()
+ const onStateChange = vi.fn()
+ render(
+ <SecretEditField
+ existingValue={false}
+ id="new-secret"
+ label="New secret"
+ onStateChange={onStateChange}
+ state={{ status: 'replaced', value: 'draft-value' }}
+ />
+ )
+ const restore = screen.getByRole('button', { name: 'Restore' })
+ expect(restore).toBeEnabled()
+ await user.click(restore)
+ expect(onStateChange).toHaveBeenCalledWith({ status: 'untouched' })
+ })
})
describe('MultiSelectActionDialog', () => {