Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
feat(control-ui): rename merged access tab to Agents at /agents route (D10)
Miguelon Peluchon121ff3af0f15
diff --git a/control-ui/app/constants/createFlowLoading.ts b/control-ui/app/constants/createFlowLoading.tsindex 8016971e5..9bcc47691 100644--- a/control-ui/app/constants/createFlowLoading.ts+++ b/control-ui/app/constants/createFlowLoading.ts@@ -62,7 +62,7 @@ export const CREATE_FLOW_LOADING = {title: 'Create team',subtitle: 'Create a team now. You can assign a leader later.',backLabel: 'Back to teams',- steps: ['Team', 'Members', 'Access'],+ steps: ['Team', 'Members', 'Agents'],stepFlowClassName: 'cu-create-step-flow--3 cu-team-create-panel',},installRegistryEntry: {diff --git a/control-ui/app/profile-admin/teams/[teamId]/[tab]/page.tsx b/control-ui/app/profile-admin/teams/[teamId]/[tab]/page.tsxindex ac04ce05d..307c011c6 100644--- a/control-ui/app/profile-admin/teams/[teamId]/[tab]/page.tsx+++ b/control-ui/app/profile-admin/teams/[teamId]/[tab]/page.tsx@@ -5,7 +5,7 @@ interface TeamTabPageProps {params: Promise<{ tab: string }>}-const TEAM_DETAIL_TABS = ['members', 'access']+const TEAM_DETAIL_TABS = ['members', 'agents']export default async function TeamTabPage({ params }: TeamTabPageProps) {const { tab } = await paramsdiff --git a/control-ui/app/profile-admin/teams/[teamId]/page.tsx b/control-ui/app/profile-admin/teams/[teamId]/page.tsxindex 2a4da6431..4fbbf66b2 100644--- a/control-ui/app/profile-admin/teams/[teamId]/page.tsx+++ b/control-ui/app/profile-admin/teams/[teamId]/page.tsx@@ -45,12 +45,12 @@ import { formatTeamRole, permissionsForTeamRole } from '../../../../lib/teamRoletype Role = 'admin' | 'inviter' | 'member'-type TeamTab = 'members' | 'access'-const TEAM_TABS: TeamTab[] = ['members', 'access']+type TeamTab = 'members' | 'agents'+const TEAM_TABS: TeamTab[] = ['members', 'agents']const TEAM_TAB_LABELS: Record<TeamTab, string> = {members: 'Members',- access: 'Access',+ agents: 'Agents',}function parseTeamTab(value: string | undefined): TeamTab {@@ -588,16 +588,16 @@ export default function TeamDetailsPage() {async function removeAccess(agentName: string) {const target = agentDisplay(agentName)const shouldRemove = await confirm({- title: 'Remove Access',+ title: 'Remove Agent',message: `Remove ${teamName || 'this team'}'s access to ${target}? This revokes the agent and every connector it carries.`,- confirmLabel: 'Remove access',+ confirmLabel: 'Remove',tone: 'danger',})if (!shouldRemove) returnawait saveAccess(grantedAgentNames.filter(name => name !== agentName),- 'Team access updated.'+ 'Team agents updated.')}@@ -1026,7 +1026,7 @@ export default function TeamDetailsPage() {</>)}- {activeTab === 'access' && (+ {activeTab === 'agents' && (<><divstyle={{@@ -1047,7 +1047,7 @@ export default function TeamDetailsPage() {onClick={() => setShowAddContext(true)}disabled={busy}>- Add access+ Add agents</button></div>{initialLoading ? (@@ -1055,7 +1055,7 @@ export default function TeamDetailsPage() {<table className="cu-table"><thead><tr>- <th>Access</th>+ <th>Agent</th><th>Connectors</th><th></th></tr>@@ -1078,14 +1078,14 @@ export default function TeamDetailsPage() {</div>) : grantedAgentNames.length === 0 ? (<div className="cu-empty" style={{ padding: '0.5rem 0' }}>- No access assigned yet.+ No agents assigned yet.</div>) : (<div className="cu-table-wrap"><table className="cu-table"><thead><tr>- <th>Access</th>+ <th>Agent</th><th>Connectors</th><th></th></tr>@@ -1128,7 +1128,7 @@ export default function TeamDetailsPage() {onClick={() => void removeAccess(agentName)}disabled={busy}title="Remove"- aria-label="Remove access"+ aria-label="Remove agent"><IconX width={16} height={16} /></button>@@ -1385,12 +1385,12 @@ export default function TeamDetailsPage() {<divclassName="cu-modal-panel cu-modal-panel--selection"role="dialog"- aria-labelledby="add-access-title"+ aria-labelledby="add-agents-title"onClick={e => e.stopPropagation()}><div className="cu-modal-panel__head">- <strong id="add-access-title" style={{ fontSize: '1rem', lineHeight: 1.35 }}>- Add access+ <strong id="add-agents-title" style={{ fontSize: '1rem', lineHeight: 1.35 }}>+ Add agents</strong><buttontype="button"@@ -1404,9 +1404,9 @@ export default function TeamDetailsPage() {</div><div className="cu-field">- <label htmlFor="team-access-picker">Access</label>+ <label htmlFor="team-agent-picker">Agents</label><SelectionDropdown- id="team-access-picker"+ id="team-agent-picker"inlinevalue={selectedAgentNamesToAdd}onChange={setSelectedAgentNamesToAdd}@@ -1414,10 +1414,10 @@ export default function TeamDetailsPage() {.filter(agentName => !grantedAgentNames.includes(agentName)).sort((a, b) => agentDisplay(a).localeCompare(agentDisplay(b))).map(agentName => ({ value: agentName, label: agentDisplay(agentName) }))}- placeholder="Select access"- searchPlaceholder="Search access..."- selectionLabel="Selected access"- emptyLabel="No additional access available."+ placeholder="Select agents"+ searchPlaceholder="Search agents..."+ selectionLabel="Selected agents"+ emptyLabel="No additional agents available."disabled={busy}/></div>@@ -1437,13 +1437,13 @@ export default function TeamDetailsPage() {onClick={() => {void saveAccess([...grantedAgentNames, ...selectedAgentNamesToAdd],- 'Team access updated.'+ 'Team agents updated.')setShowAddContext(false)}}disabled={busy || selectedAgentNamesToAdd.length === 0}>- Add access+ Add agents</button></div></div>diff --git a/control-ui/app/profile-admin/teams/new/page.tsx b/control-ui/app/profile-admin/teams/new/page.tsxindex e4bd0a47e..e2269cac1 100644--- a/control-ui/app/profile-admin/teams/new/page.tsx+++ b/control-ui/app/profile-admin/teams/new/page.tsx@@ -30,7 +30,7 @@ type Role = 'admin' | 'inviter' | 'member'type TeamCreateStep = 0 | 1 | 2-const STEPS = ['Team', 'Members', 'Access'] as const+const STEPS = ['Team', 'Members', 'Agents'] as constconst STEP_DETAILS = [{@@ -44,8 +44,8 @@ const STEP_DETAILS = [subtitle: 'Choose initial team members and roles.',},{- description: 'Map access',- title: 'Access',+ description: 'Map agent access',+ title: 'Agents',subtitle: 'Choose the agents this team can use — their connectors come along.',},] as const@@ -439,15 +439,15 @@ export default function CreateTeamPage() {{loadingReferenceData ? (<div className="cu-muted cu-muted-note--compact">Loading agents...</div>) : agentOptions.length > 0 ? (- <Field htmlFor="new-team-access-picker" label="Access">+ <Field htmlFor="new-team-agent-picker" label="Agents"><SelectionDropdown- id="new-team-access-picker"+ id="new-team-agent-picker"options={agentOptions}value={selectedAgentNames}onChange={setSelectedAgentNames}- placeholder="Select access"- searchPlaceholder="Search access..."- selectionLabel="Selected access"+ placeholder="Select agents"+ searchPlaceholder="Search agents..."+ selectionLabel="Selected agents"emptyLabel="No agents match your search."disabled={saving}showSelectedChips={false}diff --git a/control-ui/app/profile-admin/users/[userId]/[tab]/page.tsx b/control-ui/app/profile-admin/users/[userId]/[tab]/page.tsxindex c266dafe2..f0486923f 100644--- a/control-ui/app/profile-admin/users/[userId]/[tab]/page.tsx+++ b/control-ui/app/profile-admin/users/[userId]/[tab]/page.tsx@@ -5,7 +5,7 @@ interface UserTabPageProps {params: Promise<{ tab: string }>}-const USER_DETAIL_TABS = ['contact', 'approval-dms', 'communication-channels', 'access', 'teams']+const USER_DETAIL_TABS = ['contact', 'approval-dms', 'communication-channels', 'agents', 'teams']export default async function UserTabPage({ params }: UserTabPageProps) {const { tab } = await paramsdiff --git a/control-ui/app/profile-admin/users/[userId]/page.tsx b/control-ui/app/profile-admin/users/[userId]/page.tsxindex ab2b38e83..e40e60462 100644--- a/control-ui/app/profile-admin/users/[userId]/page.tsx+++ b/control-ui/app/profile-admin/users/[userId]/page.tsx@@ -520,16 +520,16 @@ export default function UserDetailsPage() {async function removeAccess(agentName: string) {const target = agentDisplay(agentName)const shouldRemove = await confirm({- title: 'Remove Access',+ title: 'Remove Agent',message: `Remove ${userName || emailDraft || 'this member'}'s access to ${target}? This revokes the agent and every connector it carries.`,- confirmLabel: 'Remove access',+ confirmLabel: 'Remove',tone: 'danger',})if (!shouldRemove) returnawait saveAccess(grantedAgentNames.filter(name => name !== agentName),- 'Access updated.'+ 'Agents updated.')}@@ -995,7 +995,7 @@ export default function UserDetailsPage() {</>)}- {activeTab === 'access' && (+ {activeTab === 'agents' && (<><divstyle={{@@ -1016,7 +1016,7 @@ export default function UserDetailsPage() {onClick={() => setShowAddContext(true)}disabled={busy}>- Add access+ Add agents</button></div>{initialLoading ? (@@ -1024,7 +1024,7 @@ export default function UserDetailsPage() {<table className="cu-table"><thead><tr>- <th>Access</th>+ <th>Agent</th><th>Connectors</th><th></th></tr>@@ -1047,14 +1047,14 @@ export default function UserDetailsPage() {</div>) : grantedAgentNames.length === 0 ? (<div className="cu-empty" style={{ padding: '0.5rem 0' }}>- No access assigned yet.+ No agents assigned yet.</div>) : (<div className="cu-table-wrap"><table className="cu-table"><thead><tr>- <th>Access</th>+ <th>Agent</th><th>Connectors</th><th></th></tr>@@ -1095,7 +1095,7 @@ export default function UserDetailsPage() {onClick={() => void removeAccess(agentName)}disabled={busy}title="Remove"- aria-label="Remove access"+ aria-label="Remove agent"><IconX width={16} height={16} /></button>@@ -1357,12 +1357,12 @@ export default function UserDetailsPage() {<divclassName="cu-modal-panel cu-modal-panel--selection"role="dialog"- aria-labelledby="add-access-title"+ aria-labelledby="add-agents-title"onClick={e => e.stopPropagation()}><div className="cu-modal-panel__head">- <strong id="add-access-title" style={{ fontSize: '1rem', lineHeight: 1.35 }}>- Add access+ <strong id="add-agents-title" style={{ fontSize: '1rem', lineHeight: 1.35 }}>+ Add agents</strong><buttontype="button"@@ -1376,9 +1376,9 @@ export default function UserDetailsPage() {</div><div className="cu-field">- <label htmlFor="member-access-picker">Access</label>+ <label htmlFor="member-agent-picker">Agents</label><SelectionDropdown- id="member-access-picker"+ id="member-agent-picker"inlinevalue={selectedAgentNamesToAdd}onChange={setSelectedAgentNamesToAdd}@@ -1386,10 +1386,10 @@ export default function UserDetailsPage() {.filter(agentName => !grantedAgentNames.includes(agentName)).sort((a, b) => agentDisplay(a).localeCompare(agentDisplay(b))).map(agentName => ({ value: agentName, label: agentDisplay(agentName) }))}- placeholder="Select access"- searchPlaceholder="Search access..."- selectionLabel="Selected access"- emptyLabel="No additional access available."+ placeholder="Select agents"+ searchPlaceholder="Search agents..."+ selectionLabel="Selected agents"+ emptyLabel="No additional agents available."disabled={busy}/></div>@@ -1409,13 +1409,13 @@ export default function UserDetailsPage() {onClick={() => {void saveAccess([...grantedAgentNames, ...selectedAgentNamesToAdd],- 'Access updated.'+ 'Agents updated.')setShowAddContext(false)}}disabled={busy || selectedAgentNamesToAdd.length === 0}>- Add access+ Add agents</button></div></div>diff --git a/control-ui/components/ProfileAdminHome.tsx b/control-ui/components/ProfileAdminHome.tsxindex 2bf6f3a4f..33b56d740 100644--- a/control-ui/components/ProfileAdminHome.tsx+++ b/control-ui/components/ProfileAdminHome.tsx@@ -32,7 +32,7 @@ import { useToast } from './Toast'import { IconAlertTriangle, IconRefresh, IconX } from './icons'import { CheckboxField } from './ui'-type TeamSortKey = 'members' | 'agents' | 'contexts'+type TeamSortKey = 'members' | 'agents'export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: ProfileAdminHomeProps) {const router = useRouter()@@ -64,7 +64,6 @@ export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: Profileconst [deleteDialogError, setDeleteDialogError] = useState('')const [teamAgentCounts, setTeamAgentCounts] = useState<Record<string, number>>({})- const [teamContextCounts, setTeamContextCounts] = useState<Record<string, number>>({})const [pendingInvitations, setPendingInvitations] = useState<AdminPendingInvitationListItem[]>([])const [resendingInvitationId, setResendingInvitationId] = useState<string | null>(null)const [resendingPasswordSetupUserId, setResendingPasswordSetupUserId] = useState<string | null>(@@ -124,7 +123,6 @@ export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: ProfileArray.isArray(overview.pendingInvitations) ? overview.pendingInvitations : [])setTeamAgentCounts(overview.teamAgentCounts || {})- setTeamContextCounts(overview.teamContextCounts || {})} catch (e) {setError(e instanceof Error ? e.message : 'Failed to load data')} finally {@@ -186,17 +184,15 @@ export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: Profilelet countDiff = 0if (teamSortKey === 'members') {countDiff = a.memberCount - b.memberCount- } else if (teamSortKey === 'agents') {- countDiff = (teamAgentCounts[a.id] ?? 0) - (teamAgentCounts[b.id] ?? 0)} else {- countDiff = (teamContextCounts[a.id] ?? 0) - (teamContextCounts[b.id] ?? 0)+ countDiff = (teamAgentCounts[a.id] ?? 0) - (teamAgentCounts[b.id] ?? 0)}countDiff *= directionif (countDiff !== 0) return countDiffreturn a.name.localeCompare(b.name)})return sorted- }, [filteredTeams, teamAgentCounts, teamContextCounts, teamSortDir, teamSortKey])+ }, [filteredTeams, teamAgentCounts, teamSortDir, teamSortKey])const sortedUsers = useMemo(() => {const sorted = [...visibleUsers]@@ -591,9 +587,6 @@ export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: Profile<th style={{ width: '5rem', textAlign: 'right' }}>{renderTeamSortButton('agents', 'Agents')}</th>- <th style={{ width: '5rem', textAlign: 'right' }}>- {renderTeamSortButton('contexts', 'Access')}- </th><th style={{ width: '4.5rem', textAlign: 'right' }} aria-label="Actions" /></tr></thead>@@ -618,9 +611,6 @@ export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: Profile<th style={{ width: '5rem', textAlign: 'right' }}>{renderTeamSortButton('agents', 'Agents')}</th>- <th style={{ width: '5rem', textAlign: 'right' }}>- {renderTeamSortButton('contexts', 'Access')}- </th><th style={{ width: '4.5rem', textAlign: 'right' }} aria-label="Actions" /></tr></thead>@@ -665,15 +655,6 @@ export function ProfileAdminHome({ activeTab, highlightedAdminId = '' }: Profile>{teamAgentCounts[team.id] ?? 0}</td>- <td- style={{- fontVariantNumeric: 'tabular-nums',- color: 'var(--cu-text-muted)',- textAlign: 'right',- }}- >- {teamContextCounts[team.id] ?? 0}- </td><td style={{ textAlign: 'right' }}><buttontype="button"diff --git a/control-ui/e2e/qa-recorder-member-access-multi.spec.ts b/control-ui/e2e/qa-recorder-member-access-multi.spec.tsindex 5018b4602..67e248d40 100644--- a/control-ui/e2e/qa-recorder-member-access-multi.spec.ts+++ b/control-ui/e2e/qa-recorder-member-access-multi.spec.ts@@ -1,12 +1,13 @@// control-ui/e2e/qa-recorder-member-access-multi.spec.ts//// Optional QA recorder journey (MUTATING). Requires QA_RECORDER_CONFIRM_MUTATIONS=1.-// Records the member detail Access tab multi-select add flow (D8): two-// host-backed scopes are seeded out-of-band (one context + one host each),-// then the "Add access" picker — options are AGENT display names — selects-// BOTH at once and submits — toast "Access updated." — and both rows render-// in the Access/Connectors table with the agent display names (never the raw-// contextIds). Each row is then removed through its confirm dialog. The tab's+// Records the member detail Agents tab multi-select add flow (D8 semantics,+// D10 name): two host-backed scopes are seeded out-of-band (one context ++// one host each), then the "Add agents" picker — options are AGENT display+// names — selects BOTH at once and submits — toast "Agents updated." — and+// both rows render in the Agent/Connectors table with the agent display+// names (never the raw contextIds). Each row is then removed through its+// confirm dialog. The tab's// writes are D8 composite writes (agents AND contexts mappings), so the// member's original contextIds AND agentNames are restored and the seeded// hosts + contexts are deleted in the finally (hosts before contexts).@@ -26,8 +27,8 @@ import {uniqueE2EName,} from './qa-recorder-helpers'-test.describe('optional QA recorder: Control UI member Access multi-select', () => {- test('records adding and removing two member access scopes in one picker submit', async ({+test.describe('optional QA recorder: Control UI member Agents multi-select', () => {+ test('records adding and removing two member agents in one picker submit', async ({page,}, testInfo) => {requireRecorderConfirm(@@ -77,10 +78,10 @@ test.describe('optional QA recorder: Control UI member Access multi-select', ()const memberTabs = page.getByRole('tablist', { name: 'Member sections' })await expect(memberTabs).toBeVisible({ timeout: 20_000 })- const accessTab = memberTabs.getByRole('tab', { name: 'Access', exact: true })- await expect(accessTab).toBeVisible()- await accessTab.click()- await expect(page).toHaveURL(/\/users-and-teams\/users\/[^/]+\/access$/, {+ const agentsTab = memberTabs.getByRole('tab', { name: 'Agents', exact: true })+ await expect(agentsTab).toBeVisible()+ await agentsTab.click()+ await expect(page).toHaveURL(/\/users-and-teams\/users\/[^/]+\/agents$/, {timeout: 20_000,})await expect(@@ -151,11 +152,11 @@ test.describe('optional QA recorder: Control UI member Access multi-select', ()})).toBeVisible({ timeout: 20_000 })- await page.getByRole('button', { name: 'Add access', exact: true }).click()- const dialog = page.getByRole('dialog', { name: 'Add access' })+ await page.getByRole('button', { name: 'Add agents', exact: true }).click()+ const dialog = page.getByRole('dialog', { name: 'Add agents' })await expect(dialog).toBeVisible()- await expect(dialog.getByLabel('Access')).toBeVisible()- await expect(dialog.locator('#member-access-picker')).toBeVisible()+ await expect(dialog.getByLabel('Agents')).toBeVisible()+ await expect(dialog.locator('#member-agent-picker')).toBeVisible()const optionA = dialog.getByRole('option', { name: hostDisplayA, exact: true })const optionB = dialog.getByRole('option', { name: hostDisplayB, exact: true })await expect(optionA).toBeVisible({ timeout: 20_000 })@@ -165,17 +166,17 @@ test.describe('optional QA recorder: Control UI member Access multi-select', ()await expect(optionA).toHaveAttribute('aria-selected', 'true')await expect(optionB).toHaveAttribute('aria-selected', 'true')await screenshotAndLog(page, testInfo, `${journey}-add-modal`)- await dialog.getByRole('button', { name: 'Add access', exact: true }).click()+ await dialog.getByRole('button', { name: 'Add agents', exact: true }).click()// One toast, both rows — D8 renders one table row per granted agent,// each labelled with its agent display name, never the raw wire// contextId.await expect(- page.getByRole('status').filter({ hasText: 'Access updated.' }).first()+ page.getByRole('status').filter({ hasText: 'Agents updated.' }).first()).toBeVisible({timeout: 20_000,})- await expect(page.getByRole('columnheader', { name: 'Access', exact: true })).toBeVisible()+ await expect(page.getByRole('columnheader', { name: 'Agent', exact: true })).toBeVisible()await expect(page.getByRole('columnheader', { name: 'Connectors', exact: true })).toBeVisible()@@ -193,16 +194,16 @@ test.describe('optional QA recorder: Control UI member Access multi-select', ()// Remove both rows: confirm dialog → toast → row gone, one at a time.for (const row of [rowA, rowB]) {- await row.getByLabel('Remove access').click()- const confirmDialog = page.getByRole('alertdialog', { name: 'Remove Access' })+ await row.getByLabel('Remove agent').click()+ const confirmDialog = page.getByRole('alertdialog', { name: 'Remove Agent' })await expect(confirmDialog).toBeVisible()- await confirmDialog.getByRole('button', { name: 'Remove access', exact: true }).click()+ await confirmDialog.getByRole('button', { name: 'Remove', exact: true }).click()await expect(- page.getByRole('status').filter({ hasText: 'Access updated.' }).first()+ page.getByRole('status').filter({ hasText: 'Agents updated.' }).first()).toBeVisible({timeout: 20_000,})- await expect(row.getByLabel('Remove access')).toHaveCount(0)+ await expect(row.getByLabel('Remove agent')).toHaveCount(0)}await screenshotAndLog(page, testInfo, `${journey}-removed`)} finally {diff --git a/control-ui/e2e/qa-recorder-member-access.spec.ts b/control-ui/e2e/qa-recorder-member-access.spec.tsindex ac4e91cbc..272c9033c 100644--- a/control-ui/e2e/qa-recorder-member-access.spec.ts+++ b/control-ui/e2e/qa-recorder-member-access.spec.ts@@ -1,14 +1,15 @@// control-ui/e2e/qa-recorder-member-access.spec.ts//// Optional QA recorder journey (MUTATING). Requires QA_RECORDER_CONFIRM_MUTATIONS=1.-// Records the E6 "Access" rename evidence in Users & Teams — the Teams table-// 'Access' column header (no 'Contexts' header on either table) — then the-// member detail Access tab (D8): a Control-API-seeded scope granted via PUT-// /users/<id>/contexts is shown as an agent row in the Access/Connectors-// table, labelled by the owning host's display name (never the raw-// contextId), the 'Add access' picker modal opens (agent display names) and-// cancels, and removal confirms ("Remove Access") → toasts "Access updated."-// → clears the row. The tab's writes are D8 composite writes (agents AND+// Records the D10 "Agents" rename evidence in Users & Teams — the Teams+// table 'Agents' column header (no 'Contexts' header on either table) — then+// the member detail Agents tab (D8 semantics, D10 name): a+// Control-API-seeded scope granted via PUT /users/<id>/contexts is shown as+// an agent row in the Agent/Connectors table, labelled by the owning host's+// display name (never the raw contextId), the 'Add agents' picker modal+// opens (agent display names) and cancels, and removal confirms ("Remove+// Agent") → toasts "Agents updated." → clears the row. The tab's writes are+// D8 composite writes (agents AND// contexts mappings), so the member's original contextIds AND agentNames are// restored and the seeded host + context are deleted in the finally (hosts// before contexts).@@ -28,8 +29,8 @@ import {uniqueE2EName,} from './qa-recorder-helpers'-test.describe('optional QA recorder: Control UI member Access tab', () => {- test('records the Users & Teams Access headers and the member access round-trip', async ({+test.describe('optional QA recorder: Control UI member Agents tab', () => {+ test('records the Users & Teams Agents headers and the member agents round-trip', async ({page,}, testInfo) => {requireRecorderConfirm(@@ -52,7 +53,7 @@ test.describe('optional QA recorder: Control UI member Access tab', () => {try {await loginThroughUi(page, credentials)- // E6 evidence part 1 — Users table carries no 'Contexts' header.+ // D10 evidence part 1 — Users table carries no 'Contexts' header.await page.getByRole('link', { name: 'Users & Teams', exact: true }).click()await expect(page).toHaveURL(/\/users-and-teams\/users$/, { timeout: 20_000 })await expect(page.getByRole('button', { name: 'Create member', exact: true })).toBeVisible({@@ -61,7 +62,7 @@ test.describe('optional QA recorder: Control UI member Access tab', () => {await expect(page.getByRole('columnheader', { name: 'Contexts' })).toHaveCount(0)await screenshotAndLog(page, testInfo, `${journey}-users-table`)- // E6 evidence part 2 — Teams table column header is 'Access' (a sort+ // D10 evidence part 2 — Teams table column header is 'Agents' (a sort// button), still with no 'Contexts' header.const teamsTab = page.getByRole('tab', { name: 'Teams', exact: true })await expect(teamsTab).toBeEnabled({ timeout: 20_000 })@@ -71,7 +72,7 @@ test.describe('optional QA recorder: Control UI member Access tab', () => {// fresh environment shows the empty state instead.const teamsTable = page.locator('table', { hasText: 'Team name' })if (await teamsTable.isVisible({ timeout: 5_000 }).catch(() => false)) {- await expect(teamsTable.getByRole('button', { name: 'Sort by access' })).toBeVisible()+ await expect(teamsTable.getByRole('button', { name: 'Sort by agents' })).toBeVisible()} else {await expect(page.getByText('No teams yet.', { exact: true })).toBeVisible()}@@ -101,10 +102,10 @@ test.describe('optional QA recorder: Control UI member Access tab', () => {const memberTabs = page.getByRole('tablist', { name: 'Member sections' })await expect(memberTabs).toBeVisible({ timeout: 20_000 })- const accessTab = memberTabs.getByRole('tab', { name: 'Access', exact: true })- await expect(accessTab).toBeVisible()- await accessTab.click()- await expect(page).toHaveURL(/\/users-and-teams\/users\/[^/]+\/access$/, {+ const agentsTab = memberTabs.getByRole('tab', { name: 'Agents', exact: true })+ await expect(agentsTab).toBeVisible()+ await agentsTab.click()+ await expect(page).toHaveURL(/\/users-and-teams\/users\/[^/]+\/agents$/, {timeout: 20_000,})await expect(@@ -179,7 +180,7 @@ test.describe('optional QA recorder: Control UI member Access tab', () => {exact: true,})).toBeVisible({ timeout: 20_000 })- await expect(page.getByRole('columnheader', { name: 'Access', exact: true })).toBeVisible({+ await expect(page.getByRole('columnheader', { name: 'Agent', exact: true })).toBeVisible({timeout: 20_000,})await expect(@@ -192,29 +193,29 @@ test.describe('optional QA recorder: Control UI member Access tab', () => {await expect(row).not.toContainText(contextId)await screenshotAndLog(page, testInfo, `${journey}-granted`)- // 'Add access' picker modal opens and cancels. The picker is still- // labelled 'Access' but its options are agent display names.- await page.getByRole('button', { name: 'Add access', exact: true }).click()- const dialog = page.getByRole('dialog', { name: 'Add access' })+ // 'Add agents' picker modal opens and cancels. The picker is labelled+ // 'Agents' and its options are agent display names.+ await page.getByRole('button', { name: 'Add agents', exact: true }).click()+ const dialog = page.getByRole('dialog', { name: 'Add agents' })await expect(dialog).toBeVisible()- await expect(dialog.getByLabel('Access')).toBeVisible()- await expect(dialog.locator('#member-access-picker')).toBeVisible()+ await expect(dialog.getByLabel('Agents')).toBeVisible()+ await expect(dialog.locator('#member-agent-picker')).toBeVisible()await screenshotAndLog(page, testInfo, `${journey}-add-modal`)await dialog.getByRole('button', { name: 'Cancel', exact: true }).click()await expect(dialog).toHaveCount(0)// Remove the row: confirm dialog → toast → row gone.- await row.getByLabel('Remove access').click()- const confirmDialog = page.getByRole('alertdialog', { name: 'Remove Access' })+ await row.getByLabel('Remove agent').click()+ const confirmDialog = page.getByRole('alertdialog', { name: 'Remove Agent' })await expect(confirmDialog).toBeVisible()await expect(confirmDialog).toContainText('This revokes the agent and every connector it carries.')- await confirmDialog.getByRole('button', { name: 'Remove access', exact: true }).click()- await expect(page.getByRole('status').filter({ hasText: 'Access updated.' })).toBeVisible({+ await confirmDialog.getByRole('button', { name: 'Remove', exact: true }).click()+ await expect(page.getByRole('status').filter({ hasText: 'Agents updated.' })).toBeVisible({timeout: 20_000,})- await expect(row.getByLabel('Remove access')).toHaveCount(0)+ await expect(row.getByLabel('Remove agent')).toHaveCount(0)await screenshotAndLog(page, testInfo, `${journey}-removed`)} finally {if (userId && originalContextIds !== null) {diff --git a/control-ui/e2e/qa-recorder-member-removed-access.spec.ts b/control-ui/e2e/qa-recorder-member-removed-access.spec.tsindex 164a02aff..fb4c86888 100644--- a/control-ui/e2e/qa-recorder-member-removed-access.spec.ts+++ b/control-ui/e2e/qa-recorder-member-removed-access.spec.ts@@ -1,8 +1,8 @@// control-ui/e2e/qa-recorder-member-removed-access.spec.ts//// MUTATING journey: seeds an access scope for the first member, deletes the-// backing context out-of-band, and proves the Access tab shows-// bookkeeping and is never rendered).+// backing context out-of-band, and proves the Agents tab renders no+// deleted-scope bookkeeping (no tombstone row is ever rendered).//// Contract: docs/testing/optional-playwright-qa-recorder.md ("Extending the// recorder").@@ -125,9 +125,9 @@ test.describe('optional QA recorder: Control UI member removed access', () => {300)- // The Access tab renders the orphaned mapping under "Removed access".+ // The Agents tab never renders the orphaned mapping.await page.goto(- `${CONTROL_UI_URL}/users-and-teams/users/${encodeURIComponent(userId)}/access`+ `${CONTROL_UI_URL}/users-and-teams/users/${encodeURIComponent(userId)}/agents`)await expect(page.getByText('Agents this member may use — and the connectors each one carries.', {@@ -145,7 +145,7 @@ test.describe('optional QA recorder: Control UI member removed access', () => {.filter({ has: page.getByRole('cell', { name: hostDisplayName, exact: true }) })).toHaveCount(0)await expect(page.getByText(contextId)).toHaveCount(0)- await expect(page.getByText('No access assigned yet.', { exact: true })).toBeVisible()+ await expect(page.getByText('No agents assigned yet.', { exact: true })).toBeVisible()await screenshotAndLog(page, testInfo, `${journey}-deleted-scope`)// Restore: the member's original contextIds, which never contained thediff --git a/control-ui/e2e/qa-recorder-onboarding-combo.spec.ts b/control-ui/e2e/qa-recorder-onboarding-combo.spec.tsindex df5880891..c01777e41 100644--- a/control-ui/e2e/qa-recorder-onboarding-combo.spec.ts+++ b/control-ui/e2e/qa-recorder-onboarding-combo.spec.ts@@ -67,8 +67,9 @@ test.describe('optional QA recorder: Control UI onboarding combo', () => {await page.getByLabel('Team name').fill(teamName)await page.getByRole('button', { name: 'Continue', exact: true }).click()await page.getByRole('button', { name: 'Skip', exact: true }).click()- // The Access step is the last one (D8 merged the Agents step in); its- // primary action creates the team directly — no further Skip exists.+ // The Agents step is the last one (D10 renamed the merged Access step+ // in); its primary action creates the team directly — no further Skip+ // exists.await page.getByRole('button', { name: 'Create team', exact: true }).click()await expect(page).toHaveURL(/\/users-and-teams\/teams$/, { timeout: 20_000 })teamId = await findTeamIdByName(page.request, teamName)@@ -113,7 +114,7 @@ test.describe('optional QA recorder: Control UI onboarding combo', () => {})expect(ctxRes.status, `create context: ${JSON.stringify(ctxRes.data)}`).toBeLessThan(300)- // D8: the Access tab manages agents — grant rides an agent that owns+ // D8: the Agents tab manages agents — grant rides an agent that owns// the scope, so seed one host bound to the context.const agentName = uniqueE2EName('qa-recorder-combo-agent')const hostRes = await api(page.request, 'POST', '/api/v1/admin/hosts', {@@ -127,27 +128,27 @@ test.describe('optional QA recorder: Control UI onboarding combo', () => {})expect(hostRes.status, `create host: ${JSON.stringify(hostRes.data)}`).toBeLessThan(300)- // step 5: grant the access scope to the team from the team Access tab.+ // step 5: grant the access scope to the team from the team Agents tab.await page.goto(- `${CONTROL_UI_URL}/users-and-teams/teams/${encodeURIComponent(teamId)}/access`+ `${CONTROL_UI_URL}/users-and-teams/teams/${encodeURIComponent(teamId)}/agents`)- await expect(page).toHaveURL(/\/users-and-teams\/teams\/.+\/access$/, {+ await expect(page).toHaveURL(/\/users-and-teams\/teams\/.+\/agents$/, {timeout: 20_000,})await expect(page.getByText('Members, connector access, and agents.', { exact: true })).toBeVisible({ timeout: 20_000 })- await page.getByRole('button', { name: 'Add access', exact: true }).click()- await expect(page.locator('#team-access-picker')).toBeVisible({ timeout: 5_000 })- await page.locator('#team-access-picker').fill(agentName)+ await page.getByRole('button', { name: 'Add agents', exact: true }).click()+ await expect(page.locator('#team-agent-picker')).toBeVisible({ timeout: 5_000 })+ await page.locator('#team-agent-picker').fill(agentName)const accessOption = page.getByRole('option', { name: agentName, exact: true })await expect(accessOption).toBeVisible({ timeout: 10_000 })await accessOption.click()await page.getByRole('dialog')- .getByRole('button', { name: 'Add access', exact: true })+ .getByRole('button', { name: 'Add agents', exact: true }).click()- await expect(page.getByText('Team access updated.', { exact: true })).toBeVisible({+ await expect(page.getByText('Team agents updated.', { exact: true })).toBeVisible({timeout: 15_000,})diff --git a/control-ui/e2e/qa-recorder-team-access-shared-label.spec.ts b/control-ui/e2e/qa-recorder-team-access-shared-label.spec.tsindex f498ecdc4..91231ab52 100644--- a/control-ui/e2e/qa-recorder-team-access-shared-label.spec.ts+++ b/control-ui/e2e/qa-recorder-team-access-shared-label.spec.ts@@ -9,8 +9,9 @@// and never the raw contextId. Removal of ONE agent confirms with that// agent's own display name; the shared scope stays mapped for the other// agent, and the union resolves it back to BOTH owners, so both rows remain.-// The team, hosts, and context are deleted via the Control API in the-// finally (hosts before the context).+// Recorded on the team Agents tab (D8 semantics, D10 name). The team, hosts,+// and context are deleted via the Control API in the finally (hosts before+// the context).//// Contract: docs/testing/optional-playwright-qa-recorder.md ("Extending the// recorder").@@ -27,8 +28,8 @@ import {uniqueE2EName,} from './qa-recorder-helpers'-test.describe('optional QA recorder: Control UI team Access shared-scope rows', () => {- test('records the per-agent shared-scope rows on the team Access tab and a single-agent removal', async ({+test.describe('optional QA recorder: Control UI team Agents shared-scope rows', () => {+ test('records the per-agent shared-scope rows on the team Agents tab and a single-agent removal', async ({page,}, testInfo) => {requireRecorderConfirm(@@ -57,7 +58,7 @@ test.describe('optional QA recorder: Control UI team Access shared-scope rows',await loginThroughUi(page, credentials)// Stage the team and its shared scope out-of-band; the behavior under- // test is the Access tab presentation and removal round-trip.+ // test is the Agents tab presentation and removal round-trip.const teamRes = await api<{ id?: string }>(page.request, 'POST', '/api/v1/admin/teams', {name: teamName,})@@ -100,7 +101,7 @@ test.describe('optional QA recorder: Control UI team Access shared-scope rows',300)- // Open the team from the Users & Teams directory and switch to Access.+ // Open the team from the Users & Teams directory and switch to Agents.await page.getByRole('link', { name: 'Users & Teams', exact: true }).click()await expect(page).toHaveURL(/\/users-and-teams\/users$/, { timeout: 20_000 })const teamsTab = page.getByRole('tab', { name: 'Teams', exact: true })@@ -115,9 +116,9 @@ test.describe('optional QA recorder: Control UI team Access shared-scope rows',timeout: 20_000,})- const accessTab = page.getByRole('tab', { name: 'Access', exact: true })- await accessTab.click()- await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/access$/, {+ const agentsTab = page.getByRole('tab', { name: 'Agents', exact: true })+ await agentsTab.click()+ await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/agents$/, {timeout: 20_000,})@@ -147,8 +148,8 @@ test.describe('optional QA recorder: Control UI team Access shared-scope rows',// label, not the raw id). Confirming revokes A's agent mapping, but// the shared scope stays mapped for B and the D8 union resolves it// back to BOTH owners, so both rows remain after the toast.- await rowA.getByLabel('Remove access').click()- const confirmDialog = page.getByRole('alertdialog', { name: 'Remove Access' })+ await rowA.getByLabel('Remove agent').click()+ const confirmDialog = page.getByRole('alertdialog', { name: 'Remove Agent' })await expect(confirmDialog).toBeVisible()await expect(confirmDialog).toContainText(hostDisplayA)await expect(confirmDialog).not.toContainText(joinedLabel)@@ -157,9 +158,9 @@ test.describe('optional QA recorder: Control UI team Access shared-scope rows','This revokes the agent and every connector it carries.')await screenshotAndLog(page, testInfo, `${journey}-remove-confirm`)- await confirmDialog.getByRole('button', { name: 'Remove access', exact: true }).click()+ await confirmDialog.getByRole('button', { name: 'Remove', exact: true }).click()await expect(- page.getByRole('status').filter({ hasText: 'Team access updated.' })+ page.getByRole('status').filter({ hasText: 'Team agents updated.' })).toBeVisible({ timeout: 20_000 })await expect(rowA).toBeVisible({ timeout: 20_000 })await expect(rowB).toBeVisible({ timeout: 20_000 })diff --git a/control-ui/e2e/qa-recorder-team-access.spec.ts b/control-ui/e2e/qa-recorder-team-access.spec.tsindex ab4bdb56c..a78249c78 100644--- a/control-ui/e2e/qa-recorder-team-access.spec.ts+++ b/control-ui/e2e/qa-recorder-team-access.spec.ts@@ -2,14 +2,15 @@//// Optional QA recorder journey (MUTATING). Requires QA_RECORDER_CONFIRM_MUTATIONS=1.// Creates a team through the Control API, seeds a host-backed access scope,-// grants it via PUT /teams/<id>/contexts, then records the team detail Access-// tab (D8): subtitle "Members, connector access, and agents.", intro "Agents-// this team may use — and the connectors each one carries.", the Access /-// Connectors table whose rows are granted agents labelled by display name-// (never the raw contextId), the 'Add access' modal assertions, removal with-// the "Team access updated." toast, and the legacy /contexts and /agents deep-// links redirecting to /access. The team, host, and context are deleted via-// the Control API in the finally (hosts before contexts).+// grants it via PUT /teams/<id>/contexts, then records the team detail Agents+// tab (D8 semantics, D10 name): subtitle "Members, connector access, and+// agents.", intro "Agents this team may use — and the connectors each one+// carries.", the Agent / Connectors table whose rows are granted agents+// labelled by display name (never the raw contextId), the 'Add agents' modal+// assertions, removal with the "Team agents updated." toast, and the legacy+// /contexts and /access deep links redirecting to /agents. The team, host,+// and context are deleted via the Control API in the finally (hosts before+// contexts).//// Contract: docs/testing/optional-playwright-qa-recorder.md ("Extending the// recorder").@@ -26,8 +27,8 @@ import {uniqueE2EName,} from './qa-recorder-helpers'-test.describe('optional QA recorder: Control UI team Access tab', () => {- test('records granting, reviewing, and removing team access plus the legacy redirect', async ({+test.describe('optional QA recorder: Control UI team Agents tab', () => {+ test('records granting, reviewing, and removing team agents plus the legacy redirect', async ({page,}, testInfo) => {requireRecorderConfirm(@@ -50,7 +51,7 @@ test.describe('optional QA recorder: Control UI team Access tab', () => {await loginThroughUi(page, credentials)// Stage the team and its host-backed access scope out-of-band; the- // behavior under test is the Access tab round-trip.+ // behavior under test is the Agents tab round-trip.const teamRes = await api<{ id?: string }>(page.request, 'POST', '/api/v1/admin/teams', {name: teamName,})@@ -88,7 +89,7 @@ test.describe('optional QA recorder: Control UI team Access tab', () => {300)- // Open the team from the Users & Teams directory and switch to Access.+ // Open the team from the Users & Teams directory and switch to Agents.await page.getByRole('link', { name: 'Users & Teams', exact: true }).click()await expect(page).toHaveURL(/\/users-and-teams\/users$/, { timeout: 20_000 })const teamsTab = page.getByRole('tab', { name: 'Teams', exact: true })@@ -107,9 +108,9 @@ test.describe('optional QA recorder: Control UI team Access tab', () => {teamId = decodeURIComponent(match?.[1] || '')}- const accessTab = page.getByRole('tab', { name: 'Access', exact: true })- await accessTab.click()- await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/access$/, {+ const agentsTab = page.getByRole('tab', { name: 'Agents', exact: true })+ await agentsTab.click()+ await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/agents$/, {timeout: 20_000,})@@ -124,7 +125,7 @@ test.describe('optional QA recorder: Control UI team Access tab', () => {exact: true,})).toBeVisible()- await expect(page.getByRole('columnheader', { name: 'Access', exact: true })).toBeVisible()+ await expect(page.getByRole('columnheader', { name: 'Agent', exact: true })).toBeVisible()await expect(page.getByRole('columnheader', { name: 'Connectors', exact: true })).toBeVisible()@@ -135,46 +136,46 @@ test.describe('optional QA recorder: Control UI team Access tab', () => {await expect(row).not.toContainText(contextId)await screenshotAndLog(page, testInfo, `${journey}-granted`)- // 'Add access' picker modal assertions, then cancel. The picker is- // still labelled 'Access' but its options are agent display names.- await page.getByRole('button', { name: 'Add access', exact: true }).click()- const dialog = page.getByRole('dialog', { name: 'Add access' })+ // 'Add agents' picker modal assertions, then cancel. The picker is+ // labelled 'Agents' and its options are agent display names.+ await page.getByRole('button', { name: 'Add agents', exact: true }).click()+ const dialog = page.getByRole('dialog', { name: 'Add agents' })await expect(dialog).toBeVisible()- await expect(dialog.getByLabel('Access')).toBeVisible()- await expect(dialog.locator('#team-access-picker')).toBeVisible()- await expect(dialog.getByRole('button', { name: 'Add access', exact: true })).toBeVisible()+ await expect(dialog.getByLabel('Agents')).toBeVisible()+ await expect(dialog.locator('#team-agent-picker')).toBeVisible()+ await expect(dialog.getByRole('button', { name: 'Add agents', exact: true })).toBeVisible()await screenshotAndLog(page, testInfo, `${journey}-add-modal`)await dialog.getByRole('button', { name: 'Cancel', exact: true }).click()await expect(dialog).toHaveCount(0)// Remove the row: confirm dialog → toast → row gone.- await row.getByLabel('Remove access').click()- const confirmDialog = page.getByRole('alertdialog', { name: 'Remove Access' })+ await row.getByLabel('Remove agent').click()+ const confirmDialog = page.getByRole('alertdialog', { name: 'Remove Agent' })await expect(confirmDialog).toBeVisible()await expect(confirmDialog).toContainText('This revokes the agent and every connector it carries.')- await confirmDialog.getByRole('button', { name: 'Remove access', exact: true }).click()+ await confirmDialog.getByRole('button', { name: 'Remove', exact: true }).click()await expect(- page.getByRole('status').filter({ hasText: 'Team access updated.' })+ page.getByRole('status').filter({ hasText: 'Team agents updated.' })).toBeVisible({ timeout: 20_000 })// Removed mappings leave no residue (D9): deleted history is backend// bookkeeping and is no longer rendered.- await expect(row.getByLabel('Remove access')).toHaveCount(0)- await expect(page.getByText('No access assigned yet.', { exact: true })).toBeVisible()+ await expect(row.getByLabel('Remove agent')).toHaveCount(0)+ await expect(page.getByText('No agents assigned yet.', { exact: true })).toBeVisible()await screenshotAndLog(page, testInfo, `${journey}-removed`)- // Legacy /contexts and /agents deep links redirect to /access.+ // Legacy /contexts and /access deep links redirect to /agents.await page.goto(`${CONTROL_UI_URL}/users-and-teams/teams/${encodeURIComponent(teamId)}/contexts`)- await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/access$/, {+ await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/agents$/, {timeout: 20_000,})await page.goto(- `${CONTROL_UI_URL}/users-and-teams/teams/${encodeURIComponent(teamId)}/agents`+ `${CONTROL_UI_URL}/users-and-teams/teams/${encodeURIComponent(teamId)}/access`)- await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/access$/, {+ await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/agents$/, {timeout: 20_000,})await screenshotAndLog(page, testInfo, `${journey}-legacy-redirect`)diff --git a/control-ui/e2e/qa-recorder-team-create.spec.ts b/control-ui/e2e/qa-recorder-team-create.spec.tsindex 9a07ffa84..238a6f494 100644--- a/control-ui/e2e/qa-recorder-team-create.spec.ts+++ b/control-ui/e2e/qa-recorder-team-create.spec.ts@@ -1,9 +1,9 @@// control-ui/e2e/qa-recorder-team-create.spec.ts//// Optional QA recorder journey (MUTATING). Requires QA_RECORDER_CONFIRM_MUTATIONS=1.-// Creates an empty team through the 3-step create-team wizard (D8 rail:-// Team → Members → Access; skipping the Access step creates the team with no-// access), tours its detail tabs (Members + Access — the separate Agents tab+// Creates an empty team through the 3-step create-team wizard (rail: Team →+// Members → Agents; skipping the Agents step creates the team with no+// agents), tours its detail tabs (Members + Agents — the separate Access tab// is gone), then deletes the team via the Control API.import { type Page, expect, test } from '@playwright/test'import {@@ -65,8 +65,8 @@ test.describe('optional QA recorder: Control UI team creation', () => {page.getByText('Choose initial team members and roles.', { exact: true })).toBeVisible({ timeout: 20_000 })- // Step 2 (Access, last step) — agent picker; skipping it creates the- // team with no access. There is no fourth step.+ // Step 2 (Agents, last step) — agent picker; skipping it creates the+ // team with no agents. There is no fourth step.await continueWizard(page)await expect(page.getByText('Choose the agents this team can use — their connectors come along.', {@@ -92,19 +92,19 @@ test.describe('optional QA recorder: Control UI team creation', () => {timeout: 20_000,})- const accessTab = page.getByRole('tab', { name: 'Access', exact: true })- await accessTab.click()- await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/access$/, {+ const agentsTab = page.getByRole('tab', { name: 'Agents', exact: true })+ await agentsTab.click()+ await expect(page).toHaveURL(/\/users-and-teams\/teams\/[^/]+\/agents$/, {timeout: 20_000,})- await expect(accessTab).toHaveAttribute('aria-selected', 'true')- await expect(page.getByRole('button', { name: 'Add access', exact: true })).toBeVisible({+ await expect(agentsTab).toHaveAttribute('aria-selected', 'true')+ await expect(page.getByRole('button', { name: 'Add agents', exact: true })).toBeVisible({timeout: 20_000,})- // D8: the separate Agents tab is gone — the detail tour is Members +- // Access only.- await expect(page.getByRole('tab', { name: 'Agents', exact: true })).toHaveCount(0)+ // D10: the separate Access tab is gone — the detail tour is Members ++ // Agents only.+ await expect(page.getByRole('tab', { name: 'Access', exact: true })).toHaveCount(0)const membersTab = page.getByRole('tab', { name: 'Members', exact: true })await membersTab.click()diff --git a/control-ui/next.config.js b/control-ui/next.config.jsindex 9dd2333b8..4f53e9d5f 100644--- a/control-ui/next.config.js+++ b/control-ui/next.config.js@@ -139,26 +139,26 @@ const nextConfig = {destination: '/connectors/:name/edit/access',permanent: true,},- // Users & Teams "Contexts" tabs renamed to "Access".+ // Users & Teams access tabs consolidated onto "Agents" (D10): the old+ // "Contexts" and "Access" tab URLs all land on the Agents tab.{source: '/users-and-teams/users/:id/contexts',- destination: '/users-and-teams/users/:id/access',+ destination: '/users-and-teams/users/:id/agents',permanent: true,},{source: '/users-and-teams/teams/:id/contexts',- destination: '/users-and-teams/teams/:id/access',+ destination: '/users-and-teams/teams/:id/agents',permanent: true,},- // The member/team "Agents" tabs folded into "Access" (D8).{- source: '/users-and-teams/users/:id/agents',- destination: '/users-and-teams/users/:id/access',+ source: '/users-and-teams/users/:id/access',+ destination: '/users-and-teams/users/:id/agents',permanent: true,},{- source: '/users-and-teams/teams/:id/agents',- destination: '/users-and-teams/teams/:id/access',+ source: '/users-and-teams/teams/:id/access',+ destination: '/users-and-teams/teams/:id/agents',permanent: true,},{ source: '/marketplace', destination: '/marketplace/connectors', permanent: true },diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 8d1df5173..d5b00a90d 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.474",+ "version": "0.1.475","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.474",+ "version": "0.1.475","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/llm-providers": "file:../packages/llm-providers",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 543e0c7c0..ef4523a71 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.474",+ "version": "0.1.475","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",diff --git a/docs/features/control-ui-context-removal.md b/docs/features/control-ui-context-removal.mdindex 3350c8cf3..2a73c77d1 100644--- a/docs/features/control-ui-context-removal.md+++ b/docs/features/control-ui-context-removal.md@@ -80,6 +80,7 @@ Old `/contexts/*` bookmarks are redirected (see §6.3), not 404'd. For the full| D4 | Access model naming | Users/teams "Contexts" tabs → **"Access"** tabs; rows labeled with resolved agent names; writes unchanged || D5 | Context deletion guardrail | Moot: after Category A removal there is **no user-facing context-delete path** left in the UI || D6 | Multi-agent GFS mounts via context detail | **Accepted loss** of that surface (was the only multi-agent mount UI). Single-agent GFS access continues via existing GFS grant surfaces; documented for product follow-up |+| D10 | Access tab naming (supersedes D8's naming) | Operator correction: the merged tab is **"Agents"** at the `agents` route — NOT "Access". Semantics unchanged from D8 (agent rows + Connectors column + composite write); copy is agent-flavored (`Add agents`, `Remove Agent` confirm, `Agents updated.` / `Team agents updated.` toasts, `Agent` column header, `No agents assigned yet.`). Team wizard step is `Agents`; teams table shows a single sortable `Agents` column (teamAgentCounts). Redirects: `/contexts` AND `/access` tab URLs → `…/agents` || D9 | Deleted-mapping history in UI | **Removed entirely.** The "Removed access" tombstone section (backend `deletedContextIds`/`deletedAgentNames` soft-delete history) is operator noise — internal reconciliation bookkeeping, not actionable state — so the Access tabs no longer render it. The backend keeps its guard data untouched; the UI just stops displaying archaeology. Verified by the rewritten `member-removed-access` journey (deleted scope ⇒ zero residue: no section, no row, no raw id) || D8 | Member/team Access tabs | **One concept: agents.** The Access tab lists agents (display name + Connectors column with the same pill/hover as the Agents table; click → agent's Connectors tab). The separate member/team "Agents" tabs are folded in (old URLs redirect to `…/access`). Writes are composite: granting agent X updates BOTH `PUT /{users,teams}/:id/agents` and `PUT /{users,teams}/:id/contexts` (scope synced, legacy scope-only mappings preserved), so whichever table the runtime enforces, the grant works. Granted rows = agent mapping ∪ agents resolved from legacy scope mappings; tombstones show deleted agents (+ unowned deleted scopes). The team wizard collapses to `Team → Members → Access` with an agent picker. Wire frozen — both endpoints already existed || D7 | Connector access-grid people | The connectors list + connector-edit Access tab derive Teams/Users from the **agent-centric grants** (`/admin/agents/:name/{users,teams}`) merged across the connector's agents — NOT from the legacy scope-centric `/admin/contexts/:id/{users,teams}`. The operator's chain: connector → agent (scope allowlist) → user/team (Access/Agents tabs). Connector↔user/team direct grants remain out of scope (would need backend) |@@ -285,6 +286,7 @@ Tests updated in the same commit: `HostTable.test.tsx` (hover card now asserts a| 2026-08-27 | e2e | Video-format answer + MP4 pipeline: Playwright/Chromium records **WebM** natively (not MP4) — `qa:recorder:convert-mp4` added (`scripts/qa-recorder/convert-videos-mp4.sh`, ffmpeg H.264 + faststart, `--replace` to drop originals; round-trip verified against a synthetic clip). Recorder doc + §9 updated. **No video evidence exists yet anywhere in `.local-notes/` — zero journeys have been executed in this lane; videos are produced only when a journey runs against a live cluster.** || 2026-08-28 | e2e | **Execution campaign (mock-backed).** Full T2 bootstrap was ruled out on this host (7 GB RAM, ~3 available → OOM risk; both minikube profiles Stopped, stale branch.mk ownership → fail-closed per repo rules). Instead: built `scripts/qa-recorder/mock-control-api.mjs` — an in-memory control-api implementing the audited wire contract (auth cookie, resourceVersion/409 semantics, users/teams contexts mappings with deleted-history, hosts/contexts/mcp-servers CRUD, registry entries + install, budgets, recipes, rotation `DeploymentReady` simulation) — and ran the REAL control-ui dev server against it. Environment fights solved along the way: mock must bind dual-stack (`localhost` → `::1` first for Playwright's request context); Next dev daemon ignores env/port and grabs its own port (verify + set `CONTROL_UI_URL` per run); each playwright invocation wipes the outputDir (run batches in ONE invocation, copy evidence out after). Spec fixes found by real rendering: connectors rows use `role="button"` (kills `row` role; target `Expand/Collapse connector <name>`), team Access rows are `listitem`s, sort headers expose `Sort by access …` aria-names, tombstone rows persist after removal (assert actionability, not absence), toasts stack (`.last()`), 10s auto-refresh detaches click targets (retry), journeys must re-navigate after seeding (login pre-seed landing makes sidebar clicks no-ops). || 2026-08-28 | e2e | **Two REAL production bugs found by the journeys, fixed in `f2eebbc8a`:** (1) member detail page crashed wholesale — `accessLabeler` useMemo was declared after its consumer in `availableContextOptions` (TDZ ReferenceError; no unit tests covered those pages); (2) connectors-page search-by-agent silently broke in the Phase-1 rework (`summary.agents` emptied while the search haystack still reads it). Both fixed; search-by-agent locked with a new unit regression test (`McpServerTable.test.tsx`); unit suite now **1701/1701**, `tsc` clean. |+| 2026-08-28 | D10 | Operator renamed the merged tab back to **Agents** (D8 semantics, new name): route `agents`, agent-flavored copy, wizard `Team → Members → Agents`, single `Agents` column on the teams table, redirects `/contexts` + `/access` → `/agents`. One post-merge formatting miss (users `[tab]` route list) was caught live by the journeys and fixed. Verified: `tsc` clean + all 7 affected recorder journeys green against the mock stack (full unit rerun was interrupted by an operator abort; suite was green at D9 and no unit-covered code changed since). || 2026-08-28 | D9 | Operator review killed the "Removed access" tombstone section on member/team Access tabs (backend soft-delete history = bookkeeping, not UI). Section + dead CSS removed from both pages; `member-removed-access` journey rewritten to assert ZERO residue after an out-of-band scope deletion (no heading, no row, no raw id, clean empty state); `team-access` comment updated. Verified: `tsc` clean, unit suite green, 4 affected recorder journeys green against the mock stack (member-access ×3 incl. removed-access, team-access). || 2026-08-28 | D8 | **Access tabs = agents** (operator-approved design): member + team Access tabs rebuilt as agent tables with the shared Connectors column (extracted `components/ConnectorCountCell.tsx`, now also used by the Agents list — same pill, same hover, same click-through); separate "Agents" tabs folded in with legacy redirects; team wizard collapsed to 3 steps with an agent picker; writes are composite (`agents` + `contexts` mappings synced, legacy scope-only mappings preserved). Verified: `tsc` clean, unit suite green (2 known load flakes pass solo), and all 7 affected recorder journeys re-executed green against the mock stack (member-access ×3, team-access ×2, team-create, onboarding-combo). Spec fallout updated incl. api-client agent-mapping helpers and restore-agentNames hygiene. || 2026-08-28 | D7 | **Connector access grid now rides agent grants** (operator decision after flow review): connectors list + connector-edit Access tab fetch Teams/Users via `GET /admin/agents/:name/{users,teams}` merged across each connector's agents, replacing the legacy scope-centric `GET /admin/contexts/:id/{users,teams}` reads. Wire untouched (both endpoints already existed); `getContextUsers/getContextTeams` no longer called from the connectors surfaces. Mock control-api gained the agent-grant endpoints (reverse of the Users & Teams mappings). Verified: `tsc` clean, unit suite 1701/1701 (one unrelated 5s-timeout flake re-run green), and the affected recorder journeys re-executed green against the live mock stack (connectors-agent-access, connector-edit ×2 incl. the rotation journey). Canonical chain documented as: connector → agent (scope allowlist) → user/team (grants). |diff --git a/tests/e2e/playwright/control-ui/member-access-shared-label.spec.ts b/tests/e2e/playwright/control-ui/member-access-shared-label.spec.tsindex 5a5d707dc..d1cfc9473 100644--- a/tests/e2e/playwright/control-ui/member-access-shared-label.spec.ts+++ b/tests/e2e/playwright/control-ui/member-access-shared-label.spec.ts@@ -1,8 +1,8 @@/**- * Control UI — Member Access tab shared-scope rows (D8)+ * Control UI — Member Agents tab shared-scope rows (D8)** A single access scope (Context) may back multiple hosts. Under the D8- * agent-centric Access tab the granted set is the member↔agent mapping UNION+ * agent-centric Agents tab the granted set is the member↔agent mapping UNION* legacy scope mappings resolved to their owning agents, so a scope shared by* two hosts renders as TWO table rows — one per agent display name — never a* joined "A, B" label and never the raw wire contextId. Revoking one agent@@ -27,7 +27,7 @@ let userId = ''let originalContextIds: string[] = []let originalAgentNames: string[] = []-test.describe('Control UI — Member Access shared scope rows', () => {+test.describe('Control UI — Member Agents shared scope rows', () => {test.describe.configure({ mode: 'serial' })test.beforeAll(async () => {@@ -86,7 +86,7 @@ test.describe('Control UI — Member Access shared scope rows', () => {test('renders one row per owning agent, not a joined label or raw ids', async ({authedPage,}) => {- await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/access`)+ await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/agents`)await expect(authedPage.getByText('Agents this member may use — and the connectors each one carries.')).toBeVisible({ timeout: 15_000 })@@ -111,15 +111,15 @@ test.describe('Control UI — Member Access shared scope rows', () => {test('remove confirm names the single agent; the shared scope keeps both rows', async ({authedPage,}) => {- await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/access`)+ await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/agents`)const rowA = authedPage.getByRole('row').filter({ has: authedPage.getByRole('cell', { name: HOST_DISPLAY_A, exact: true }) })await expect(rowA).toBeVisible({ timeout: 15_000 })- await rowA.getByLabel('Remove access').click()+ await rowA.getByLabel('Remove agent').click()- const confirmDialog = authedPage.getByRole('alertdialog', { name: 'Remove Access' })+ const confirmDialog = authedPage.getByRole('alertdialog', { name: 'Remove Agent' })await expect(confirmDialog).toBeVisible()await expect(confirmDialog).toContainText(HOST_DISPLAY_A)await expect(confirmDialog).not.toContainText(JOINED_LABEL)@@ -128,9 +128,9 @@ test.describe('Control UI — Member Access shared scope rows', () => {'This revokes the agent and every connector it carries.')- await confirmDialog.getByRole('button', { name: 'Remove access', exact: true }).click()+ await confirmDialog.getByRole('button', { name: 'Remove', exact: true }).click()- await expect(authedPage.getByRole('status').filter({ hasText: 'Access updated.' })).toBeVisible(+ await expect(authedPage.getByRole('status').filter({ hasText: 'Agents updated.' })).toBeVisible({ timeout: 15_000 })diff --git a/tests/e2e/playwright/control-ui/member-access-tab.spec.ts b/tests/e2e/playwright/control-ui/member-access-tab.spec.tsindex df0df480c..01c3d3dda 100644--- a/tests/e2e/playwright/control-ui/member-access-tab.spec.ts+++ b/tests/e2e/playwright/control-ui/member-access-tab.spec.ts@@ -1,12 +1,13 @@/**- * Control UI — Member detail Access tab tests+ * Control UI — Member detail Agents tab tests*- * The member "Access" tab (the former "Contexts" tab) presents granted access- * as one table row per agent (D8): the Access/Connectors columns, the owning- * host's display name (spec.host) in cell 1 — never the raw wire contextId —- * and the shared Connectors count cell in cell 2. The add/remove flows are D8- * composite writes (user-agents AND user-contexts mappings), so cleanup- * restores both the original contextIds and the original agentNames.+ * The member "Agents" tab (the former "Access" tab, originally "Contexts")+ * presents granted access as one table row per agent (D8): the+ * Agent/Connectors columns, the owning host's display name (spec.host) in+ * cell 1 — never the raw wire contextId — and the shared Connectors count+ * cell in cell 2. The add/remove flows are D8 composite writes (user-agents+ * AND user-contexts mappings), so cleanup restores both the original+ * contextIds and the original agentNames.*/import { controlApi } from '../helpers/api-client'import { expect, test } from '../helpers/auth-fixture'@@ -21,7 +22,7 @@ let userId = ''let originalContextIds: string[] = []let originalAgentNames: string[] = []-test.describe('Control UI — Member Access tab', () => {+test.describe('Control UI — Member Agents tab', () => {test.describe.configure({ mode: 'serial' })test.beforeAll(async () => {@@ -71,16 +72,14 @@ test.describe('Control UI — Member Access tab', () => {})test('shows the agent display name, not the raw scope id', async ({ authedPage }) => {- await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/access`)+ await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/agents`)await expect(authedPage.getByText('Agents this member may use — and the connectors each one carries.')).toBeVisible({ timeout: 15_000 })- // D8: granted access renders as a real table — Access/Connectors columns,+ // D8: granted access renders as a real table — Agent/Connectors columns,// one row per granted agent, labelled by its display name.- await expect(- authedPage.getByRole('columnheader', { name: 'Access', exact: true })- ).toBeVisible()+ await expect(authedPage.getByRole('columnheader', { name: 'Agent', exact: true })).toBeVisible()await expect(authedPage.getByRole('columnheader', { name: 'Connectors', exact: true })).toBeVisible()@@ -91,47 +90,47 @@ test.describe('Control UI — Member Access tab', () => {await expect(row).not.toContainText(CONTEXT_ID)})- test("'Add access' opens the access picker modal", async ({ authedPage }) => {- await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/access`)+ test("'Add agents' opens the agent picker modal", async ({ authedPage }) => {+ await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/agents`)await expect(authedPage.getByText('Agents this member may use — and the connectors each one carries.')).toBeVisible({ timeout: 15_000 })- await authedPage.getByRole('button', { name: 'Add access', exact: true }).click()+ await authedPage.getByRole('button', { name: 'Add agents', exact: true }).click()- const dialog = authedPage.getByRole('dialog', { name: 'Add access' })+ const dialog = authedPage.getByRole('dialog', { name: 'Add agents' })await expect(dialog).toBeVisible()- await expect(dialog.getByLabel('Access')).toBeVisible()- await expect(dialog.locator('#member-access-picker')).toBeVisible()- await expect(dialog.getByRole('button', { name: 'Add access', exact: true })).toBeVisible()+ await expect(dialog.getByLabel('Agents')).toBeVisible()+ await expect(dialog.locator('#member-agent-picker')).toBeVisible()+ await expect(dialog.getByRole('button', { name: 'Add agents', exact: true })).toBeVisible()await dialog.getByRole('button', { name: 'Cancel', exact: true }).click()await expect(dialog).toHaveCount(0)})- test('removing access confirms, toasts, and clears the mapping via the API', async ({+ test('removing an agent confirms, toasts, and clears the mapping via the API', async ({authedPage,}) => {- await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/access`)+ await authedPage.goto(`/users-and-teams/users/${encodeURIComponent(userId)}/agents`)const row = authedPage.getByRole('row').filter({ has: authedPage.getByRole('cell', { name: HOST_DISPLAY_NAME, exact: true }) })await expect(row).toBeVisible({ timeout: 15_000 })- await row.getByLabel('Remove access').click()+ await row.getByLabel('Remove agent').click()- const confirmDialog = authedPage.getByRole('alertdialog', { name: 'Remove Access' })+ const confirmDialog = authedPage.getByRole('alertdialog', { name: 'Remove Agent' })await expect(confirmDialog).toBeVisible()await expect(confirmDialog).toContainText('This revokes the agent and every connector it carries.')- await confirmDialog.getByRole('button', { name: 'Remove access', exact: true }).click()+ await confirmDialog.getByRole('button', { name: 'Remove', exact: true }).click()- await expect(authedPage.getByRole('status').filter({ hasText: 'Access updated.' })).toBeVisible(+ await expect(authedPage.getByRole('status').filter({ hasText: 'Agents updated.' })).toBeVisible({ timeout: 15_000 })await expect(row).toHaveCount(0)if (originalContextIds.length === 0 && originalAgentNames.length === 0) {- await expect(authedPage.getByText('No access assigned yet.')).toBeVisible()+ await expect(authedPage.getByText('No agents assigned yet.')).toBeVisible()}const { contextIds } = await controlApi.getUserContexts(userId)diff --git a/tests/e2e/playwright/control-ui/team-access-tab.spec.ts b/tests/e2e/playwright/control-ui/team-access-tab.spec.tsindex 3f363a16f..091bf7cef 100644--- a/tests/e2e/playwright/control-ui/team-access-tab.spec.ts+++ b/tests/e2e/playwright/control-ui/team-access-tab.spec.ts@@ -1,12 +1,13 @@/**- * Control UI — Team detail Access tab tests+ * Control UI — Team detail Agents tab tests*- * The team "Access" tab (the former "Contexts" tab) presents granted access- * as one table row per agent (D8): the Access/Connectors columns, the agent- * display name in cell 1 (never the raw scope id), the shared Connectors- * count cell in cell 2. The add/remove flows round-trip the D8 composite- * write (team-agents AND team-contexts mappings), and the legacy /contexts- * and /agents deep links redirect to /access.+ * The team "Agents" tab (the former "Access" tab, originally "Contexts")+ * presents granted access as one table row per agent (D8): the+ * Agent/Connectors columns, the agent display name in cell 1 (never the raw+ * scope id), the shared Connectors count cell in cell 2. The add/remove+ * flows round-trip the D8 composite write (team-agents AND team-contexts+ * mappings), and the legacy /contexts and /access deep links redirect to+ * /agents.*/import { controlApi } from '../helpers/api-client'import { expect, test } from '../helpers/auth-fixture'@@ -20,7 +21,7 @@ const HOST_DISPLAY_NAME = `e2e-team-access-agent-${RUN}`let teamId = ''-test.describe('Control UI — Team Access tab', () => {+test.describe('Control UI — Team Agents tab', () => {test.describe.configure({ mode: 'serial' })test.beforeAll(async () => {@@ -50,7 +51,7 @@ test.describe('Control UI — Team Access tab', () => {})test('shows the agent display name, not the raw scope id', async ({ authedPage }) => {- await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/access`)+ await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/agents`)await expect(authedPage.getByText('Members, connector access, and agents.')).toBeVisible({timeout: 15_000,})@@ -58,11 +59,9 @@ test.describe('Control UI — Team Access tab', () => {authedPage.getByText('Agents this team may use — and the connectors each one carries.')).toBeVisible()- // D8: granted access renders as a real table — Access/Connectors columns,+ // D8: granted access renders as a real table — Agent/Connectors columns,// one row per granted agent, labelled by its display name.- await expect(- authedPage.getByRole('columnheader', { name: 'Access', exact: true })- ).toBeVisible()+ await expect(authedPage.getByRole('columnheader', { name: 'Agent', exact: true })).toBeVisible()await expect(authedPage.getByRole('columnheader', { name: 'Connectors', exact: true })).toBeVisible()@@ -73,46 +72,46 @@ test.describe('Control UI — Team Access tab', () => {await expect(row).not.toContainText(CONTEXT_ID)})- test("'Add access' opens the access picker modal", async ({ authedPage }) => {- await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/access`)+ test("'Add agents' opens the agent picker modal", async ({ authedPage }) => {+ await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/agents`)await expect(authedPage.getByText('Agents this team may use — and the connectors each one carries.')).toBeVisible({ timeout: 15_000 })- await authedPage.getByRole('button', { name: 'Add access', exact: true }).click()+ await authedPage.getByRole('button', { name: 'Add agents', exact: true }).click()- const dialog = authedPage.getByRole('dialog', { name: 'Add access' })+ const dialog = authedPage.getByRole('dialog', { name: 'Add agents' })await expect(dialog).toBeVisible()- await expect(dialog.getByLabel('Access')).toBeVisible()- await expect(dialog.locator('#team-access-picker')).toBeVisible()- await expect(dialog.getByRole('button', { name: 'Add access', exact: true })).toBeVisible()+ await expect(dialog.getByLabel('Agents')).toBeVisible()+ await expect(dialog.locator('#team-agent-picker')).toBeVisible()+ await expect(dialog.getByRole('button', { name: 'Add agents', exact: true })).toBeVisible()await dialog.getByRole('button', { name: 'Cancel', exact: true }).click()await expect(dialog).toHaveCount(0)})- test('removing access confirms, toasts, and clears the mapping via the API', async ({+ test('removing an agent confirms, toasts, and clears the mapping via the API', async ({authedPage,}) => {- await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/access`)+ await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/agents`)const row = authedPage.getByRole('row').filter({ has: authedPage.getByRole('cell', { name: HOST_DISPLAY_NAME, exact: true }) })await expect(row).toBeVisible({ timeout: 15_000 })- await row.getByLabel('Remove access').click()+ await row.getByLabel('Remove agent').click()- const confirmDialog = authedPage.getByRole('alertdialog', { name: 'Remove Access' })+ const confirmDialog = authedPage.getByRole('alertdialog', { name: 'Remove Agent' })await expect(confirmDialog).toBeVisible()await expect(confirmDialog).toContainText('This revokes the agent and every connector it carries.')- await confirmDialog.getByRole('button', { name: 'Remove access', exact: true }).click()+ await confirmDialog.getByRole('button', { name: 'Remove', exact: true }).click()await expect(- authedPage.getByRole('status').filter({ hasText: 'Team access updated.' })+ authedPage.getByRole('status').filter({ hasText: 'Team agents updated.' })).toBeVisible({ timeout: 15_000 })await expect(row).toHaveCount(0)- await expect(authedPage.getByText('No access assigned yet.')).toBeVisible()+ await expect(authedPage.getByText('No agents assigned yet.')).toBeVisible()const { contextIds } = await controlApi.getTeamContexts(teamId)expect(contextIds ?? []).not.toContain(CONTEXT_ID)@@ -120,17 +119,17 @@ test.describe('Control UI — Team Access tab', () => {expect(agentNames ?? []).not.toContain(HOST_NAME)})- test('legacy /contexts deep link redirects to /access', async ({ authedPage }) => {+ test('legacy /contexts deep link redirects to /agents', async ({ authedPage }) => {await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/contexts`)- await authedPage.waitForURL('**/users-and-teams/teams/*/access', { timeout: 15_000 })- expect(authedPage.url()).toContain(`/teams/${teamId}/access`)+ await authedPage.waitForURL('**/users-and-teams/teams/*/agents', { timeout: 15_000 })+ expect(authedPage.url()).toContain(`/teams/${teamId}/agents`)})- test('legacy /agents deep link redirects to /access (D8 folded the Agents tab)', async ({+ test('legacy /access deep link redirects to /agents (D10 renamed the Access tab)', async ({authedPage,}) => {- await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/agents`)- await authedPage.waitForURL('**/users-and-teams/teams/*/access', { timeout: 15_000 })- expect(authedPage.url()).toContain(`/teams/${teamId}/access`)+ await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/access`)+ await authedPage.waitForURL('**/users-and-teams/teams/*/agents', { timeout: 15_000 })+ expect(authedPage.url()).toContain(`/teams/${teamId}/agents`)})})diff --git a/tests/e2e/playwright/control-ui/team-create-wizard.spec.ts b/tests/e2e/playwright/control-ui/team-create-wizard.spec.tsindex b40eed7ad..5a7bba89c 100644--- a/tests/e2e/playwright/control-ui/team-create-wizard.spec.ts+++ b/tests/e2e/playwright/control-ui/team-create-wizard.spec.ts@@ -1,10 +1,11 @@/**- * Control UI — Team create wizard Access step tests+ * Control UI — Team create wizard Agents step tests*- * The wizard rail is Team → Members → Access (D8 dropped the fourth step);- * the Access step offers agent display names (not raw scope ids) and a- * selection made there lands on the created team as BOTH the team-contexts- * and team-agents mappings (D8 composite write).+ * The wizard rail is Team → Members → Agents (D8 dropped the fourth step;+ * D10 renamed the merged Access step to Agents); the Agents step offers+ * agent display names (not raw scope ids) and a selection made there lands+ * on the created team as BOTH the team-contexts and team-agents mappings+ * (D8 composite write).*/import { controlApi } from '../helpers/api-client'import { expect, test } from '../helpers/auth-fixture'@@ -59,17 +60,17 @@ test.describe('Control UI — Team create wizard', () => {await controlApi.ensureContextDeleted(CONTEXT_NAME)})- test('Access step grants by agent display name and lands the mapping on the team', async ({+ test('Agents step grants by agent display name and lands the mapping on the team', async ({authedPage,}) => {test.setTimeout(120_000)await authedPage.goto('/users-and-teams/teams/new')- // D8 rail: three steps, no fourth.+ // Three steps, no fourth (D8; D10 renamed the last step to Agents).await expect(authedPage.locator('.cu-agent-step-rail__title')).toHaveText(['Team','Members',- 'Access',+ 'Agents',])// Step 0 — Team identity@@ -82,8 +83,8 @@ test.describe('Control UI — Team create wizard', () => {authedPage.getByText('Choose the agents this team can use — their connectors come along.')).toBeVisible({ timeout: 15_000 })- // Step 2 (last) — Access: options are agent display names, never raw ids- await authedPage.locator('#new-team-access-picker').click()+ // Step 2 (last) — Agents: options are agent display names, never raw ids+ await authedPage.locator('#new-team-agent-picker').click()const seededOption = authedPage.getByRole('option', {name: HOST_DISPLAY_NAME,exact: true,@@ -91,7 +92,7 @@ test.describe('Control UI — Team create wizard', () => {await expect(seededOption).toBeVisible({ timeout: 15_000 })await expect(authedPage.getByRole('option', { name: CONTEXT_ID, exact: true })).toHaveCount(0)await seededOption.click()- await expect(authedPage.locator('#new-team-access-picker')).toContainText(HOST_DISPLAY_NAME)+ await expect(authedPage.locator('#new-team-agent-picker')).toContainText(HOST_DISPLAY_NAME)await authedPage.keyboard.press('Escape')// Last step: the primary action creates the team (no fourth step).@@ -107,7 +108,7 @@ test.describe('Control UI — Team create wizard', () => {const { agentNames } = await controlApi.getTeamAgents(teamId)expect(agentNames ?? []).toContain(HOST_NAME)- await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/access`)+ await authedPage.goto(`/users-and-teams/teams/${encodeURIComponent(teamId)}/agents`)// D8: one table row per granted agent, labelled by its display name.const row = authedPage.getByRole('row')diff --git a/tests/e2e/playwright/control-ui/users-teams-access-column.spec.ts b/tests/e2e/playwright/control-ui/users-teams-access-column.spec.tsindex 68c235629..2eba9f2a6 100644--- a/tests/e2e/playwright/control-ui/users-teams-access-column.spec.ts+++ b/tests/e2e/playwright/control-ui/users-teams-access-column.spec.ts@@ -1,36 +1,38 @@/**- * Control UI — Users and Teams Access column tests+ * Control UI — Users and Teams Agents column tests*- * The Teams table exposes a sortable "Access" column (the former "Contexts"- * count column) and neither the Teams nor the Users table keeps a "Contexts"- * header anywhere.+ * The Teams table exposes a sortable "Agents" column (the former "Access"+ * column, before that the "Contexts" count column) and neither the Teams nor+ * the Users table keeps a "Contexts" header anywhere.*/import { expect, test } from '../helpers/auth-fixture'-test.describe('Control UI — Users and Teams Access column', () => {- test('Teams table has a sortable Access column and no Contexts header', async ({+test.describe('Control UI — Users and Teams Agents column', () => {+ test('Teams table has a sortable Agents column and no Contexts header', async ({authedPage,}) => {await authedPage.goto('/users-and-teams/teams')- const accessHeader = authedPage.getByRole('button', { name: /^Sort by access/ })- await expect(accessHeader).toBeVisible({ timeout: 15_000 })+ const agentsHeader = authedPage.getByRole('button', { name: /^Sort by agents/ })+ await expect(agentsHeader).toBeVisible({ timeout: 15_000 })// Let the skeleton table swap for real data before counting rows.await expect(authedPage.locator('.cu-skeleton')).toHaveCount(0, { timeout: 15_000 })await expect(authedPage.locator('th', { hasText: 'Contexts' })).toHaveCount(0)+ // The old "Access" column is gone (D10 renamed it to Agents).+ await expect(authedPage.locator('th', { hasText: 'Access' })).toHaveCount(0)const rows = authedPage.getByRole('row')const rowCountBefore = await rows.count()// First click: inactive → descending (aria-label announces the next direction)- await accessHeader.click()- await expect(accessHeader).toHaveAttribute('aria-label', 'Sort by access ascending')+ await agentsHeader.click()+ await expect(agentsHeader).toHaveAttribute('aria-label', 'Sort by agents ascending')const rowCountAfterFirst = await rows.count()expect(rowCountAfterFirst).toBe(rowCountBefore)// Second click: descending → ascending- await accessHeader.click()- await expect(accessHeader).toHaveAttribute('aria-label', 'Sort by access descending')+ await agentsHeader.click()+ await expect(agentsHeader).toHaveAttribute('aria-label', 'Sort by agents descending')const rowCountAfterSecond = await rows.count()expect(rowCountAfterSecond).toBe(rowCountBefore)})diff --git a/tests/e2e/playwright/package-lock.json b/tests/e2e/playwright/package-lock.jsonindex fe1b86930..7dfdb1655 100644--- a/tests/e2e/playwright/package-lock.json+++ b/tests/e2e/playwright/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-playwright-tests",- "version": "0.1.25",+ "version": "0.1.26","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-playwright-tests",- "version": "0.1.25",+ "version": "0.1.26","devDependencies": {"@playwright/test": "^1.50.0","@types/node": "^22.0.0"diff --git a/tests/e2e/playwright/package.json b/tests/e2e/playwright/package.jsonindex c818479fa..cf4da438d 100644--- a/tests/e2e/playwright/package.json+++ b/tests/e2e/playwright/package.json@@ -1,6 +1,6 @@{"name": "clerum-playwright-tests",- "version": "0.1.25",+ "version": "0.1.26","private": true,"description": "Playwright E2E tests for Control UI and Desktop App","scripts": {