Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(frontend-components): run table action tests by default

Josué126f489bd1c7
diff --git a/packages/frontend-components/package.json b/packages/frontend-components/package.json
index f1af50cc6..12fcb3e3c 100644
--- a/packages/frontend-components/package.json
+++ b/packages/frontend-components/package.json
@@ -25,6 +25,6 @@
},
"scripts": {
"build": "tsc --noEmit --skipLibCheck --types react,react-dom --jsx react-jsx --module esnext --moduleResolution bundler --target es2022 src/index.tsx",
- "test": "tsc --noEmit --skipLibCheck --types react,react-dom --jsx react-jsx --module esnext --moduleResolution bundler --target es2022 src/index.tsx src/public-api.test.ts && vitest run --environment jsdom src/edit"
+ "test": "tsc --noEmit --skipLibCheck --types react,react-dom --jsx react-jsx --module esnext --moduleResolution bundler --target es2022 src/index.tsx src/public-api.contract.ts && vitest run --environment jsdom src"
}
}
diff --git a/packages/frontend-components/src/public-api.test.ts b/packages/frontend-components/src/public-api.contract.ts
similarity index 100%
rename from packages/frontend-components/src/public-api.test.ts
rename to packages/frontend-components/src/public-api.contract.ts
diff --git a/packages/frontend-components/src/table/__tests__/row-actions.test.tsx b/packages/frontend-components/src/table/__tests__/row-actions.test.tsx
new file mode 100644
index 000000000..8569e2fb0
--- /dev/null
+++ b/packages/frontend-components/src/table/__tests__/row-actions.test.tsx
@@ -0,0 +1,61 @@
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import '@testing-library/jest-dom/vitest'
+import { cleanup, fireEvent, render, screen, within } from '@testing-library/react'
+import userEvent from '@testing-library/user-event'
+import { RowActionMenu } from '../row-actions'
+
+afterEach(cleanup)
+
+function renderActionCell({ hasLink = false }: { hasLink?: boolean } = {}) {
+ const onNavigate = vi.fn()
+ const onSelect = vi.fn()
+ const view = render(
+ <table>
+ <tbody>
+ <tr onClick={onNavigate}>
+ <td data-testid="actions-cell">
+ {hasLink ? <a href="/details">Details</a> : null}
+ <RowActionMenu
+ actions={[{ key: 'open', label: 'Open record', onSelect }]}
+ ariaLabel="Row actions"
+ />
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ )
+ return { ...view, onNavigate, onSelect }
+}
+
+describe('RowActionMenu table-cell interaction', () => {
+ it('opens from the empty actions cell without adding a cell tab stop or navigating the row', async () => {
+ const user = userEvent.setup()
+ const { onNavigate, onSelect } = renderActionCell()
+ const cell = screen.getByTestId('actions-cell')
+
+ fireEvent.click(cell)
+
+ const menu = await screen.findByRole('menu')
+ expect(within(menu).getByRole('menuitem', { name: 'Open record' })).toBeInTheDocument()
+ expect(screen.getByRole('button', { name: 'Row actions' })).toHaveAttribute('aria-expanded', 'true')
+ expect(cell).not.toHaveAttribute('tabindex')
+ expect(onNavigate).not.toHaveBeenCalled()
+
+ await user.click(within(menu).getByRole('menuitem', { name: 'Open record' }))
+ expect(onSelect).toHaveBeenCalledOnce()
+ expect(onNavigate).not.toHaveBeenCalled()
+ })
+
+ it('does not widen a mixed-control cell but keeps its real menu trigger operable', async () => {
+ const user = userEvent.setup()
+ const { onNavigate } = renderActionCell({ hasLink: true })
+ const cell = screen.getByTestId('actions-cell')
+
+ fireEvent.click(cell)
+ expect(screen.queryByRole('menu')).not.toBeInTheDocument()
+ expect(onNavigate).toHaveBeenCalledOnce()
+
+ await user.click(screen.getByRole('button', { name: 'Row actions' }))
+ expect(await screen.findByRole('menu')).toBeInTheDocument()
+ })
+})