Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(desktop-ui): pre976-20261009-01 observe chat action failures

Josué16de744a7a64
diff --git a/desktop-app/ui/src/hooks/__tests__/chatActionConsumers.test.tsx b/desktop-app/ui/src/hooks/__tests__/chatActionConsumers.test.tsx
new file mode 100644
index 000000000..d77a4ef9c
--- /dev/null
+++ b/desktop-app/ui/src/hooks/__tests__/chatActionConsumers.test.tsx
@@ -0,0 +1,137 @@
+// @vitest-environment jsdom
+import { afterEach, beforeEach, expect, it, vi } from 'vitest'
+import {
+ act,
+ cleanup,
+ fireEvent,
+ render,
+ renderHook,
+ screen,
+ waitFor,
+} from '@testing-library/react'
+import { ChatThread } from '@components/agents/ChatThread'
+import { FleetBoard } from '@components/agents/FleetBoard'
+import { renderController } from '../domain/__tests__/__fixtures__/controllerHarness'
+import { installMockClerum, uninstallMockClerum } from '../domain/__tests__/__fixtures__/mockClerum'
+import { useAgentChatActionsValue } from '../useAgentChatActionsValue'
+import type { useAppController } from '../useAppController'
+
+const live = vi.hoisted(() => ({ vm: null as any, actions: null as any }))
+vi.mock('@contexts/NavigationContext', () => ({ useNavigationContext: () => live.vm }))
+vi.mock('@contexts/NotificationsContext', () => ({ useNotificationsContext: () => live.vm }))
+vi.mock('@contexts/AgentChatActionsContext', () => ({
+ useAgentChatActionsContext: () => live.actions,
+}))
+vi.mock('@contexts/ChatComposerStateContext', () => ({
+ useChatComposerStateContext: () => live.vm,
+}))
+vi.mock('@contexts/ChatThreadStateContext', () => ({ useChatThreadStateContext: () => live.vm }))
+vi.mock('@contexts/ChatListContext', () => ({ useChatListContext: () => live.vm }))
+vi.mock('@contexts/McpRuntimeContext', () => ({ useMcpRuntimeContext: () => live.vm }))
+vi.mock('@contexts/AgentActivityContext', () => ({ useAgentActivityContext: () => live.vm }))
+vi.mock('@hooks/domain/useAgentsDataController', () => ({ useAgentsDataController: () => live.vm }))
+vi.mock('@hooks/domain/useTeamsDataController', () => ({
+ useTeamsDataController: () => ({
+ teams: [],
+ currentTeamId: 'team-1',
+ teamDirectory: {},
+ ensureHydrated: async () => undefined,
+ }),
+}))
+vi.mock('@hooks/domain/useMcpServersDataController', () => ({
+ useMcpServersDataController: () => ({
+ agentMcpServerCountByAgent: {},
+ agentMcpServersByAgent: {},
+ mcpServerMappingUnavailableMessage: '',
+ }),
+}))
+vi.mock('@components/agents/InFlightAssistantPlaceholder', () => ({
+ InFlightAssistantPlaceholder: () => null,
+}))
+vi.mock('@components/agents/NudgeArea', () => ({ NudgeArea: () => null }))
+vi.mock('@components/agents/ChatStateBadge', () => ({ ChatStateBadge: () => null }))
+
+beforeEach(() => {
+ Object.defineProperty(HTMLElement.prototype, 'scrollIntoView', {
+ configurable: true,
+ value: vi.fn(),
+ })
+})
+afterEach(() => {
+ cleanup()
+ vi.restoreAllMocks()
+ uninstallMockClerum()
+ Reflect.deleteProperty(HTMLElement.prototype, 'scrollIntoView')
+})
+
+async function mountActions() {
+ const clerum = installMockClerum()
+ for (const chat of ['chat-1', 'chat-2']) {
+ await clerum.chat.create('agent-x', chat)
+ await clerum.chat.upsertMessages('agent-x', chat, [
+ { id: `${chat}-history`, role: 'user', content: `${chat} real history`, timestamp: 1 },
+ ])
+ }
+ clerum.chat.getIndex.mockImplementation(agent => clerum.readIndex(agent))
+ const app = renderController({ loadMenuData: false })
+ await waitFor(() => expect(app.result.current.chatListLoading).toBe(false))
+ const vm = { ...app.result.current, pushToast: app.spies.pushToast }
+ const actions = renderHook(() =>
+ useAgentChatActionsValue(vm as unknown as ReturnType<typeof useAppController>)
+ )
+ live.vm = {
+ ...vm,
+ activeMessages: vm.chatMessages,
+ groupedMessages: [],
+ semanticModelsByMessageId: new Map(),
+ selectedAgent: 'agent-x',
+ agentNames: ['agent-x'],
+ agentDisplayByName: { 'agent-x': 'Agent X' },
+ userAgentNames: ['agent-x'],
+ teamAgentNames: [],
+ agentLastActiveByAgent: {},
+ handleSelectChatAgent: vi.fn(),
+ }
+ live.actions = actions.result.current
+ return { app, clerum }
+}
+
+it('observes a ChatThread conversation click through the real stable action', async () => {
+ const { app, clerum } = await mountActions()
+ clerum.chat.setLastActive.mockRejectedValueOnce(new Error('sidebar switch failed'))
+ render(<ChatThread />)
+ const button = document.querySelector<HTMLButtonElement>('.agent-dedicated-session-title-btn')!
+ expect(button).toBeTruthy()
+ const target =
+ live.vm.chatList.find((chat: any) => chat.title === button.textContent)?.id ??
+ live.vm.chatList[0].id
+ fireEvent.click(button)
+ await waitFor(() =>
+ expect(app.spies.pushToast).toHaveBeenCalledWith(
+ 'Could not open conversation: sidebar switch failed',
+ 'error'
+ )
+ )
+ expect(app.spies.pushToast).toHaveBeenCalledTimes(1)
+ expect(app.result.current.activeChatId).toBe(target)
+ expect(app.result.current.chatMessages).toEqual([])
+ expect(app.result.current.chatMessagesLoading).toBe(false)
+})
+
+it('observes a FleetBoard New chat click through the real stable create action', async () => {
+ const { app, clerum } = await mountActions()
+ clerum.chat.create.mockRejectedValueOnce(new Error('fleet create failed'))
+ render(<FleetBoard />)
+ fireEvent.click(screen.getByRole('button', { name: /More actions for/ }))
+ fireEvent.click(screen.getByRole('button', { name: 'New chat' }))
+ await waitFor(() =>
+ expect(app.spies.pushToast).toHaveBeenCalledWith(
+ 'Could not create conversation: fleet create failed',
+ 'error'
+ )
+ )
+ expect(app.spies.pushToast).toHaveBeenCalledTimes(1)
+ expect(app.result.current.activeChatId).toBeNull()
+ expect(app.result.current.chatMessages).toEqual([])
+ expect(app.result.current.chatMessagesLoading).toBe(false)
+})
diff --git a/desktop-app/ui/src/hooks/domain/useAgentChatController.ts b/desktop-app/ui/src/hooks/domain/useAgentChatController.ts
index 59c268ace..63c993712 100644
--- a/desktop-app/ui/src/hooks/domain/useAgentChatController.ts
+++ b/desktop-app/ui/src/hooks/domain/useAgentChatController.ts
@@ -1277,9 +1277,16 @@ export function useAgentChatController({
)
return
autoSelectedChatIdRef.current = null
- await switchToChat(selectedAgent, chatId)
+ await switchToChat(selectedAgent, chatId, {
+ onCurrentError: error => {
+ pushToast(
+ `Could not open conversation: ${error instanceof Error ? error.message : String(error)}`,
+ 'error'
+ )
+ },
+ }).catch(() => undefined)
},
- [selectedAgent, isHostAccessBlocked, isChatDeleted, switchToChat]
+ [selectedAgent, isHostAccessBlocked, isChatDeleted, switchToChat, pushToast]
)
const handleLoadOlderMessages = useCallback(async () => {
diff --git a/desktop-app/ui/src/hooks/useAgentChatActionsValue.ts b/desktop-app/ui/src/hooks/useAgentChatActionsValue.ts
index 97de28c15..7f916cffc 100644
--- a/desktop-app/ui/src/hooks/useAgentChatActionsValue.ts
+++ b/desktop-app/ui/src/hooks/useAgentChatActionsValue.ts
@@ -15,7 +15,18 @@ type AppVm = ReturnType<typeof useAppController>
export function useAgentChatActionsValue(vm: AppVm): AgentChatActionsContextValue {
const chatEndRef = vm.chatEndRef
const scrollChatToBottom = useStableCallback(vm.scrollChatToBottom)
- const handleCreateChat = useStableCallback(vm.handleCreateChat)
+ // This context is the UI-event boundary; the underlying create API retains
+ // rejection for programmatic awaiters and restoration remains controller-owned.
+ const handleCreateChat = useStableCallback(async () => {
+ try {
+ await vm.handleCreateChat()
+ } catch (error) {
+ vm.pushToast(
+ `Could not create conversation: ${error instanceof Error ? error.message : String(error)}`,
+ 'error'
+ )
+ }
+ })
const handleRenameChat = useStableCallback(vm.handleRenameChat)
const handleRenameChatForAgent = useStableCallback(vm.handleRenameChatForAgent)
const captureChatDeleteFence = useStableCallback(vm.captureChatDeleteFence)