Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): r2-l1 hide unavailable member create badge

Josué17f18bac16e5
diff --git a/control-ui/components/ControlAdminsPanel/index.tsx b/control-ui/components/ControlAdminsPanel/index.tsx
index 2cf0c2d25..ec095a248 100644
--- a/control-ui/components/ControlAdminsPanel/index.tsx
+++ b/control-ui/components/ControlAdminsPanel/index.tsx
@@ -387,6 +387,9 @@ export function ControlAdminsPanel({
filteredAdmins.map(admin => {
const currentAdmin = isCurrentAdmin(admin)
const label = admin.email ? `${admin.username} (${admin.email})` : admin.username
+ const memberCreationUnavailable = !admin.email || admin.passwordPending
+ const memberAccessDisabled = !admin.memberId && memberCreationUnavailable
+ const canCreateMember = !admin.memberId && !memberCreationUnavailable
return (
<tr
key={admin.id}
@@ -443,12 +446,12 @@ export function ControlAdminsPanel({
<button
type="button"
className="cu-btn cu-btn--icon cu-btn--toolbar"
- disabled={!admin.memberId && (!admin.email || admin.passwordPending)}
+ disabled={memberAccessDisabled}
onClick={() => openMemberAccess(admin)}
aria-label={memberAccessActionLabel(admin)}
title={memberAccessActionLabel(admin)}
>
- <IconUsers createBadge={!admin.memberId} relationshipRole="member" />
+ <IconUsers createBadge={canCreateMember} relationshipRole="member" />
</button>
{admin.gfsOperatorLink?.status === 'active' ? (
<button
diff --git a/control-ui/components/__tests__/ControlAdminsPanel.gfsOperatorLink.test.tsx b/control-ui/components/__tests__/ControlAdminsPanel.gfsOperatorLink.test.tsx
index 31c28ad95..52408a157 100644
--- a/control-ui/components/__tests__/ControlAdminsPanel.gfsOperatorLink.test.tsx
+++ b/control-ui/components/__tests__/ControlAdminsPanel.gfsOperatorLink.test.tsx
@@ -235,7 +235,7 @@ describe('ControlAdminsPanel GFS operator link lifecycle', () => {
})
expect(createMemberButton).toBeDisabled()
expect(createMemberButton).toHaveAttribute('title', 'Email required to create member')
- expect(createMemberButton.querySelector('svg')).toHaveAttribute('data-create-badge', 'true')
+ expect(createMemberButton.querySelector('svg')).not.toHaveAttribute('data-create-badge')
fireEvent.click(createMemberButton)
expect(mockPush).not.toHaveBeenCalled()
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 3ba55bed4..d78e06eee 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.436",
+ "version": "0.1.437",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.436",
+ "version": "0.1.437",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/llm-providers": "file:../packages/llm-providers",
diff --git a/control-ui/package.json b/control-ui/package.json
index ff6ae447e..40f7fe21e 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.436",
+ "version": "0.1.437",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",