Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(web-search): address title and argument review findings

Alfredo Lopez21bcb43e122b
diff --git a/mcp-servers/web-search/package-lock.json b/mcp-servers/web-search/package-lock.json
index 99feada2e..d4962bcdf 100644
--- a/mcp-servers/web-search/package-lock.json
+++ b/mcp-servers/web-search/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "@clerum/web-search-mcp",
- "version": "1.0.12",
+ "version": "1.0.14",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@clerum/web-search-mcp",
- "version": "1.0.12",
+ "version": "1.0.14",
"dependencies": {
"@modelcontextprotocol/sdk": "^1.12.1",
"express": "^4.21.2"
diff --git a/mcp-servers/web-search/package.json b/mcp-servers/web-search/package.json
index 214a33e63..5e0e8b118 100644
--- a/mcp-servers/web-search/package.json
+++ b/mcp-servers/web-search/package.json
@@ -1,6 +1,6 @@
{
"name": "@clerum/web-search-mcp",
- "version": "1.0.12",
+ "version": "1.0.14",
"type": "module",
"main": "dist/index.js",
"scripts": {
diff --git a/mcp-servers/web-search/src/fetchPage.ts b/mcp-servers/web-search/src/fetchPage.ts
index 3dcb0a8d7..c18c0ba19 100644
--- a/mcp-servers/web-search/src/fetchPage.ts
+++ b/mcp-servers/web-search/src/fetchPage.ts
@@ -42,8 +42,11 @@ function titleText(html: string): string {
// HTML tag names are ASCII-case-insensitive. Unicode lowercasing can expand
// characters and invalidate offsets subsequently applied to the original HTML.
const lower = html.replace(/[A-Z]/g, character => character.toLowerCase())
- const start = lower.indexOf('<title')
- if (start === -1 || !/[\s>]/.test(lower[start + 6] ?? '')) return ''
+ let start = lower.indexOf('<title')
+ while (start !== -1 && !/[\s>]/.test(lower[start + 6] ?? '')) {
+ start = lower.indexOf('<title', start + 6)
+ }
+ if (start === -1) return ''
const body = lower.indexOf('>', start + 6)
const end = lower.indexOf('</title>', body + 1)
return body < 0 || end < 0 ? '' : pageText(html.slice(body + 1, end))
@@ -145,7 +148,7 @@ export async function fetchPage(
callerSignal?: AbortSignal
): Promise<{ title: string; content: string }> {
if (!Number.isInteger(maxChars) || maxChars < 100 || maxChars > 100000)
- throw new FetchPageError('invalid_url')
+ throw new FetchPageError('invalid_max_chars')
if (active >= FETCH_PAGE_LIMITS.maxConcurrent) throw new FetchPageError('busy')
active++
const controller = new AbortController()
diff --git a/mcp-servers/web-search/src/fetchPageError.ts b/mcp-servers/web-search/src/fetchPageError.ts
index d5b9a713d..1b92e215b 100644
--- a/mcp-servers/web-search/src/fetchPageError.ts
+++ b/mcp-servers/web-search/src/fetchPageError.ts
@@ -1,5 +1,6 @@
export type FetchPageErrorCode =
| 'invalid_url'
+ | 'invalid_max_chars'
| 'destination_blocked'
| 'redirect_limit'
| 'deadline_exceeded'
diff --git a/mcp-servers/web-search/test/fetchPage.test.mjs b/mcp-servers/web-search/test/fetchPage.test.mjs
index a167fd8ea..8e59befe4 100644
--- a/mcp-servers/web-search/test/fetchPage.test.mjs
+++ b/mcp-servers/web-search/test/fetchPage.test.mjs
@@ -189,3 +189,26 @@ for (const [html, expectedTitle] of [
assert.equal((await fetchPage('http://8.8.8.8', 100)).title, expectedTitle)
})
}
+
+for (const prefix of ['<titleish></titleish>', '<titlex>'.repeat(10000)]) {
+ test(`title scanning continues past invalid prefixes (${prefix.length} characters)`, async t => {
+ upstream(t, [{ body: `${prefix}<TITLE>Actual</TITLE>` }])
+ assert.equal((await fetchPage('http://8.8.8.8', 100)).title, 'Actual')
+ })
+}
+
+test('invalid maxChars has its own safe error and never connects', async t => {
+ const requests = upstream(t, [])
+ for (const maxChars of [99, 100001, 100.5, NaN, Infinity]) {
+ await assert.rejects(fetchPage('http://8.8.8.8', maxChars), {
+ code: 'invalid_max_chars',
+ message: 'invalid_max_chars',
+ })
+ }
+ assert.equal(requests.length, 0)
+})
+
+test('comment-like text in an attribute does not hide the real title', async t => {
+ upstream(t, [{ body: '<meta name="description" content="<!--"><title>Actual</title>' }])
+ assert.equal((await fetchPage('http://8.8.8.8', 100)).title, 'Actual')
+})