Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(desktop-e2e): expect a blocked send, not a refused picker, on an unverified image model

Alfredo Lopez21da9803b2bc
diff --git a/desktop-app/test/e2e-playwright/qa-recorder-image-capabilities.spec.ts b/desktop-app/test/e2e-playwright/qa-recorder-image-capabilities.spec.ts
index ea9bd6404..b74809b36 100644
--- a/desktop-app/test/e2e-playwright/qa-recorder-image-capabilities.spec.ts
+++ b/desktop-app/test/e2e-playwright/qa-recorder-image-capabilities.spec.ts
@@ -376,45 +376,6 @@ async function expectImageSendBlocked(
await expect(sendButton(page)).toBeDisabled()
}
-/**
- * A model with no image evidence must refuse the picker itself: the native file
- * chooser must never open, and the composer must say why.
- *
- * The bounded `waitForEvent('filechooser')` is a race against the product's own
- * signal, not a sleep used as readiness: if the picker opened, the event fires
- * within milliseconds and the assertion below fails.
- */
-async function expectUploadRefused(page: Page, model: string, messagePattern: RegExp) {
- const attachButton = page.getByRole('button', { name: 'Add context' })
- await expect(attachButton).toBeEnabled()
- await attachButton.click()
- const uploadItem = page.getByRole('menuitem', { name: 'Upload Files' })
- await expect(uploadItem).toBeVisible({ timeout: 15_000 })
-
- let chooserOpened = false
- const chooserProbe = page.waitForEvent('filechooser', { timeout: 2_000 }).then(
- () => {
- chooserOpened = true
- },
- () => undefined
- )
-
- await uploadItem.click()
- const notice = page.getByRole('alert').filter({ hasText: messagePattern })
- await expect(notice).toBeVisible()
- await expect(notice).toContainText(model)
- await expect(notice).toContainText(messagePattern)
-
- await chooserProbe
- expect(chooserOpened, `${model} must not open the native file picker`).toBe(false)
- await expect(attachmentChips(page)).toHaveCount(0)
-
- // Close the composer menu again through an ordinary click, the same way a
- // user dismisses it, so the next step starts from a clean composer.
- await composer(page).click()
- await expect(uploadItem).toHaveCount(0)
-}
-
/** Exactly one exchange in this chat, and the answer is not empty. */
async function expectSingleExchange(page: Page) {
await expect(page.getByTestId('message-list')).toBeVisible({ timeout: 20_000 })
@@ -645,22 +606,38 @@ test('image-capabilities fixture: image capability gates the composer and the pr
await assertBinding()
await openConfiguredAgentChat(page, env.hostRef)
- await test.step('a model with no image evidence refuses the picker and sends nothing', async () => {
+ await test.step('a model with no image evidence keeps the PNG and sends nothing', async () => {
await startBlankChat(page)
await selectModel(page, env.unknownModel, 'unknown')
// The chip is where the capability projection is rendered (#735).
await expect(modelChip(page)).toHaveAttribute('title', /not verified/i)
- await expectUploadRefused(page, env.unknownModel, /not verified/i)
- await expect(page.locator('[data-chat-message-id]')).toHaveCount(0)
+ // Capability gates sending, never selecting (#678): the picker attaches
+ // the PNG, and the send is refused with a notice naming the model.
+ await attachFixturePng(page, visualFixture)
+ await composer(page).fill(VISUAL_PROMPT)
+ await expectImageSendBlocked(
+ page,
+ env.unknownModel,
+ VISUAL_PROMPT,
+ visualFixture.fileName,
+ /not verified/i
+ )
- // The refused picker must not have produced any provider attempt carrying
+ // The blocked send must not have produced any provider attempt carrying
// pixels, and nothing at all may have carried an image during launch,
- // sign-in or navigation.
+ // sign-in or navigation. The chip and notice asserted above prove the
+ // image was attached and the send was attempted.
const afterUnknown = readImageCapabilityEvidence(env)
const appended = appendedAttempts(baseline, afterUnknown)
expect(appended.filter(row => row.imageSha256 !== null)).toHaveLength(0)
expect(afterUnknown.counters.imageAttempts - baseline.counters.imageAttempts).toBe(0)
+
+ // Leave a clean composer for the next step.
+ await page.getByRole('button', { name: `Remove ${visualFixture.fileName}` }).click()
+ await expect(attachmentChips(page)).toHaveCount(0)
+ await composer(page).fill('')
+ await expect(capabilityNotice(page)).toHaveCount(0)
})
await test.step('an image-capable model accepts the PNG while a text-only model refuses to send it', async () => {