Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(workflow-recipes): requeue when the legacy internet NP delete fails
Alfredo Lopez24f54f8406c7
diff --git a/workflow-recipes/package-lock.json b/workflow-recipes/package-lock.jsonindex 3a8869085..ffa689614 100644--- a/workflow-recipes/package-lock.json+++ b/workflow-recipes/package-lock.json@@ -1,12 +1,12 @@{"name": "workload-recipes-controller",- "version": "0.1.410",+ "version": "0.1.411","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "workload-recipes-controller",- "version": "0.1.410",+ "version": "0.1.411","license": "SEE LICENSE IN LICENSE","dependencies": {"@aws-sdk/client-s3": "^3.1009.0",diff --git a/workflow-recipes/package.json b/workflow-recipes/package.jsonindex 8238903a1..ffaa72798 100644--- a/workflow-recipes/package.json+++ b/workflow-recipes/package.json@@ -1,6 +1,6 @@{"name": "workload-recipes-controller",- "version": "0.1.410",+ "version": "0.1.411","description": "Workload Recipes Controller (WRC) - WorkloadRecipe lifecycle management and MCP server interface","main": "dist/main.js","engines": {diff --git a/workflow-recipes/src/workflow/workflowReconciler.test.ts b/workflow-recipes/src/workflow/workflowReconciler.test.tsindex 96a1b3079..0fc956ec2 100644--- a/workflow-recipes/src/workflow/workflowReconciler.test.ts+++ b/workflow-recipes/src/workflow/workflowReconciler.test.ts@@ -1,4 +1,4 @@-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'+import { beforeEach, describe, expect, it, vi } from 'vitest'import { buildMcpHostHeadlessService } from './podFactory'import { buildMcpHostServiceName } from './resourceNames'import { WorkflowReconciler, type WorkflowReconcilerDeps } from './workflowReconciler'diff --git a/workflow-recipes/src/workflow/workflowReconciler.ts b/workflow-recipes/src/workflow/workflowReconciler.tsindex 7d19661e0..c13509a84 100644--- a/workflow-recipes/src/workflow/workflowReconciler.ts+++ b/workflow-recipes/src/workflow/workflowReconciler.ts@@ -3213,13 +3213,13 @@ export class WorkflowReconciler {private async pruneLegacyMcpServersInternetEgressPolicy(recipeName: string,recipeUid?: string- ): Promise<void> {+ ): Promise<{ retryPending: boolean }> {const key = this.legacyMcpServersInternetEgressKey(recipeName, recipeUid)if (this.prunedLegacyMcpServersInternetEgress.has(key)) {this.log.debug('Skipping legacy mcp-servers internet NP delete; already observed gone', {recipe: recipeName,})- return+ return { retryPending: false }}const outcome = await observeNamespacedDelete(() =>this.deps.networkingApi.deleteNamespacedNetworkPolicy({@@ -3233,7 +3233,7 @@ export class WorkflowReconciler {...deleteOutcomeFields(outcome),error: outcome.error instanceof Error ? outcome.error.message : String(outcome.error),})- return+ return { retryPending: true }}this.log.info('Legacy mcp-servers internet NP delete', {recipe: recipeName,@@ -3242,6 +3242,7 @@ export class WorkflowReconciler {if (shouldRecordDelete(outcome)) {this.prunedLegacyMcpServersInternetEgress.add(key)}+ return { retryPending: false }}private needsRuntimeHttpEgressRefresh(spec: WorkflowRecipeSpec): boolean {@@ -3430,7 +3431,8 @@ export class WorkflowReconciler {})if (prune.retryPending) summary.retryPending = true- await this.pruneLegacyMcpServersInternetEgressPolicy(recipeName, recipeUid)+ const legacy = await this.pruneLegacyMcpServersInternetEgressPolicy(recipeName, recipeUid)+ if (legacy.retryPending) summary.retryPending = truereturn summary}diff --git a/workflow-recipes/tests/unit/workflow/workflowReconciler.test.ts b/workflow-recipes/tests/unit/workflow/workflowReconciler.test.tsindex 4ff44c5ad..bec33d15e 100644--- a/workflow-recipes/tests/unit/workflow/workflowReconciler.test.ts+++ b/workflow-recipes/tests/unit/workflow/workflowReconciler.test.ts@@ -3478,6 +3478,23 @@ describe('WorkflowReconciler — reconcile loop', () => {expect(apiserver.live.has(apiserver.key(SANDBOX, GROK_PROXY))).toBe(true)})+ it('marks retryPending when the legacy internet NP DELETE fails', async () => {+ const apiserver = makeApiserverNetworkingApi()+ apiserver.api.deleteNamespacedNetworkPolicy.mockImplementation(+ async ({ name, namespace }: { name: string; namespace: string }) => {+ if (name === `${RECIPE}-mcp-servers-egress-internet`) {+ throw { code: 403, message: 'forbidden' }+ }+ if (!apiserver.live.delete(apiserver.key(namespace, name))) throw { code: 404 }+ return {}+ }+ )+ const reconciler = new WorkflowReconciler(makeDeps({ networkingApi: apiserver.api as never }))++ const summary = await applyPolicies(reconciler)+ expect(summary.retryPending).toBe(true)+ })+it('keeps the apply outcome when the prune LIST fails', async () => {const apiserver = makeApiserverNetworkingApi()seedLivePolicy(apiserver, GROK_PROXY, WRC_LABELS)