Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(desktop): r4-h1 preserve notification rail on app reopen
Josué270fdff2cfea
diff --git a/desktop-app/ui/src/App.tsx b/desktop-app/ui/src/App.tsxindex 80856d1f1..79a5a819a 100644--- a/desktop-app/ui/src/App.tsx+++ b/desktop-app/ui/src/App.tsx@@ -772,7 +772,6 @@ export function App() {const handleSandboxUiOpening = React.useCallback((app: ActiveSandboxUiApp) => {setSandboxUiMounted(false)- setNotificationTrayLeft(null)setActiveSandboxUiApp(app)}, [])@@ -783,7 +782,6 @@ export function App() {const handleSandboxUiClosed = React.useCallback(() => {setActiveSandboxUiApp(null)setSandboxUiMounted(false)- setNotificationTrayLeft(null)setSandboxUiConversationOrigin(null)setHeaderShellOverlayOpen(false)setSidebarSettingsMenuOpen(false)@@ -792,7 +790,6 @@ export function App() {const handleSandboxUiRemoved = React.useCallback(() => {setActiveSandboxUiApp(null)setSandboxUiMounted(false)- setNotificationTrayLeft(null)setSandboxUiConversationOrigin(null)setHeaderShellOverlayOpen(false)setSidebarSettingsMenuOpen(false)diff --git a/desktop-app/ui/src/__tests__/App.chatDrawer.test.tsx b/desktop-app/ui/src/__tests__/App.chatDrawer.test.tsxindex 319b2cc6d..fbe3d2083 100644--- a/desktop-app/ui/src/__tests__/App.chatDrawer.test.tsx+++ b/desktop-app/ui/src/__tests__/App.chatDrawer.test.tsx@@ -446,6 +446,42 @@ describe('App chat drawer — reopen preserves the last-viewed chat', () => {expect(appHeaderHarness.props?.notificationTrayLeft).toBe(716)})+ it('keeps the notification rail boundary through a same-edge app reopen', () => {+ currentController = makeController({ navItem: DESKTOP_ROUTES.apps } as Partial<AppController>)+ render(<App />)++ act(() => {+ sidebarHarness.props?.onOpenSandboxUiApp?.({+ appRef: 'ns/app-a',+ label: 'App A',+ defaultPath: '/',+ })+ sandboxUiPageHarness.props?.onEmbedSlotRightChange?.(716)+ })+ expect(appHeaderHarness.props?.notificationTrayLeft).toBe(716)++ act(() => sandboxUiPageHarness.props?.onEmbeddedAppBack?.())+ expect(appHeaderHarness.props?.notificationTrayMode).toBe('overlay')+ expect(appHeaderHarness.props?.notificationTrayLeft).toBeNull()++ act(() => {+ sidebarHarness.props?.onOpenSandboxUiApp?.({+ appRef: 'ns/app-b',+ label: 'App B',+ defaultPath: '/',+ })+ })++ // The real SandboxUiPage producer dedupes its unchanged 716px slot edge+ // until its next lifecycle. The titlebar must retain the existing boundary+ // while the refreshed embedded app reaches readiness.+ expect(appHeaderHarness.props?.notificationTrayMode).toBe('drawer')+ expect(appHeaderHarness.props?.notificationTrayLeft).toBe(716)++ act(() => sandboxUiPageHarness.props?.onEmbedSlotRightChange?.(744))+ expect(appHeaderHarness.props?.notificationTrayLeft).toBe(744)+ })+// #2 — reconciler covers the drawer (minispec 04 approach A). The ChatThread// session list moves `vm.activeChatId` via switchToChat WITHOUT touching// chatViewTabs. Simulate that (mutate activeChatId as the vm would) and assert