Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(gfs): align delegation controls

Miguelon Peluchon2987121e46ef
diff --git a/control-ui/app/globals.css b/control-ui/app/globals.css
index 58450684b..f9c40f304 100644
--- a/control-ui/app/globals.css
+++ b/control-ui/app/globals.css
@@ -12109,9 +12109,10 @@ button.cu-gfs-tree__button:focus-visible,
min-height: 2.125rem;
flex: 1 1 8.75rem;
padding: 0 var(--cu-space-1);
- border: 0;
- background: transparent;
- box-shadow: none;
+ border: 0 !important;
+ border-radius: 0;
+ background: transparent !important;
+ box-shadow: none !important;
}
.cu-body .cu-gfs-subject-picker__input.cu-input:focus {
@@ -12206,6 +12207,17 @@ button.cu-gfs-tree__button:focus-visible,
color: var(--cu-warning);
}
+.cu-gfs-subject-picker__avatar--agent,
+.cu-gfs-subject-picker__avatar--workflow {
+ background: rgba(var(--cu-success-rgb), 0.15);
+ color: var(--cu-success);
+}
+
+.cu-gfs-subject-picker__avatar svg {
+ width: 1rem;
+ height: 1rem;
+}
+
.cu-gfs-subject-picker__type {
color: var(--cu-text-muted);
font-size: 0.68rem;
diff --git a/control-ui/components/GfsSubjectPicker/index.tsx b/control-ui/components/GfsSubjectPicker/index.tsx
index eb9c1f30a..ff61eba40 100644
--- a/control-ui/components/GfsSubjectPicker/index.tsx
+++ b/control-ui/components/GfsSubjectPicker/index.tsx
@@ -2,6 +2,7 @@
import { useEffect, useMemo, useRef, useState } from 'react'
import type { SelectionDropdownOption } from '@components/SelectionDropdown/types'
+import { IconRobot, IconShield, IconUsers, IconWorkflow } from '@components/Sidebar/icons'
import { IconX } from '@components/icons'
import { Button, TextInput } from '@components/ui'
import type { GfsSubjectPickerProps } from './types'
@@ -16,6 +17,25 @@ function optionMatches(option: SelectionDropdownOption, query: string): boolean
.some(value => String(value).toLowerCase().includes(normalized))
}
+function subjectAvatarClass(option: SelectionDropdownOption): string {
+ return `cu-gfs-subject-picker__avatar cu-gfs-subject-picker__avatar--${option.badge?.toLowerCase() || 'user'}`
+}
+
+function subjectAvatarContent(option: SelectionDropdownOption): React.ReactNode {
+ switch (option.badge?.toLowerCase()) {
+ case 'agent':
+ return <IconRobot />
+ case 'operator':
+ return <IconShield />
+ case 'team':
+ return <IconUsers />
+ case 'workflow':
+ return <IconWorkflow />
+ default:
+ return option.label.charAt(0).toUpperCase()
+ }
+}
+
export function GfsSubjectPicker({
disabled = false,
loading = false,
@@ -83,11 +103,8 @@ export function GfsSubjectPicker({
{selected.map(subject =>
subject ? (
<span className="cu-gfs-subject-picker__chip" key={subject.value}>
- <span
- className={`cu-gfs-subject-picker__avatar cu-gfs-subject-picker__avatar--${subject.badge?.toLowerCase()}`}
- aria-hidden="true"
- >
- {subject.label.charAt(0).toUpperCase()}
+ <span className={subjectAvatarClass(subject)} aria-hidden="true">
+ {subjectAvatarContent(subject)}
</span>
<span className="cu-gfs-subject-picker__chip-label">{subject.label}</span>
<Button
@@ -116,6 +133,15 @@ export function GfsSubjectPicker({
setOpen(true)
}}
onFocus={() => setOpen(true)}
+ onKeyDown={event => {
+ if (event.key === 'Escape') {
+ setOpen(false)
+ return
+ }
+ if (event.key === 'Backspace' && !query && value.length > 0) {
+ clearSubject(value[value.length - 1] ?? '')
+ }
+ }}
placeholder={selected.length > 0 ? '' : SUBJECT_PICKER_LABEL}
role="combobox"
value={query}
@@ -149,11 +175,8 @@ export function GfsSubjectPicker({
role="option"
variant="ghost"
>
- <span
- className={`cu-gfs-subject-picker__avatar cu-gfs-subject-picker__avatar--${option.badge?.toLowerCase()}`}
- aria-hidden="true"
- >
- {option.label.charAt(0).toUpperCase()}
+ <span className={subjectAvatarClass(option)} aria-hidden="true">
+ {subjectAvatarContent(option)}
</span>
<span className="cu-gfs-subject-picker__option-copy">
<span>{option.label}</span>
diff --git a/control-ui/components/__tests__/GfsSubjectPicker.test.tsx b/control-ui/components/__tests__/GfsSubjectPicker.test.tsx
index 033d516a9..34c9923f7 100644
--- a/control-ui/components/__tests__/GfsSubjectPicker.test.tsx
+++ b/control-ui/components/__tests__/GfsSubjectPicker.test.tsx
@@ -8,6 +8,7 @@ const options = [
{ value: 'user:ada', label: 'Ada Lovelace', badge: 'User' },
{ value: 'team:research', label: 'Research', badge: 'Team' },
{ value: 'host:first-party', label: 'First-party agent runtime', badge: 'Agent' },
+ { value: 'host:workflow', label: 'Workflow runtime', badge: 'Workflow' },
]
function ControlledSubjectPicker() {
@@ -38,4 +39,23 @@ describe('GfsSubjectPicker', () => {
expect(combobox).toHaveFocus()
expect(screen.getByRole('button', { name: 'Remove Research' })).toBeTruthy()
})
+
+ it('renders entity-specific icons in the available subject options', async () => {
+ const user = userEvent.setup({ delay: null })
+ render(<ControlledSubjectPicker />)
+
+ await user.click(
+ screen.getByRole('combobox', { name: 'Add people, teams, agents, or workflows' })
+ )
+ expect(screen.getByRole('option', { name: 'Research' }).querySelector('svg')).not.toBeNull()
+ expect(
+ screen.getByRole('option', { name: 'First-party agent runtime' }).querySelector('svg')
+ ).not.toBeNull()
+ expect(
+ screen.getByRole('option', { name: 'Workflow runtime' }).querySelector('svg')
+ ).not.toBeNull()
+ expect(screen.getByRole('option', { name: 'Ada Lovelace' }).textContent).toContain(
+ 'Ada Lovelace'
+ )
+ })
})
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 2c6910463..6a2c37b1d 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.452",
+ "version": "0.1.453",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.452",
+ "version": "0.1.453",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/llm-providers": "file:../packages/llm-providers",
diff --git a/control-ui/package.json b/control-ui/package.json
index 24b4ddf96..5d0f54fc2 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.452",
+ "version": "0.1.453",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",
diff --git a/desktop-app/test/e2e-playwright/gfs-desktop-operator-parity.test.ts b/desktop-app/test/e2e-playwright/gfs-desktop-operator-parity.test.ts
index 69b8b5096..d322c7654 100644
--- a/desktop-app/test/e2e-playwright/gfs-desktop-operator-parity.test.ts
+++ b/desktop-app/test/e2e-playwright/gfs-desktop-operator-parity.test.ts
@@ -494,7 +494,10 @@ test.describe.serial('GFS Desktop linked-operator parity', () => {
dialog = await openResourceManage(page, shareFolder)
await selectOrdinarySubject(page, operatorJourney.ordinaryEmail)
- await dialog.getByRole('button', { name: 'Create share', exact: true }).click()
+ await dialog
+ .getByRole('button', { name: `Options for ${shareFolder.name}`, exact: true })
+ .click()
+ await dialog.getByRole('menuitem', { name: 'Create share', exact: true }).click()
await expectToast(page, '1 share created')
await expect
.poll(() => operatorJourney.findShare(shareFolder.resourceId), {
diff --git a/desktop-app/ui/src/components/GfsResourceMenu/index.tsx b/desktop-app/ui/src/components/GfsResourceMenu/index.tsx
index c6fb50056..49768733a 100644
--- a/desktop-app/ui/src/components/GfsResourceMenu/index.tsx
+++ b/desktop-app/ui/src/components/GfsResourceMenu/index.tsx
@@ -6,9 +6,11 @@ import { useClickOutside } from '@hooks/useClickOutside'
import type { GfsResourceMenuProps } from './types'
export function GfsResourceMenu({
+ createShareDisabled = false,
resourceName,
onManage,
onCopyLink,
+ onCreateShare,
onCreateFolder,
onDelete,
onOpen,
@@ -106,6 +108,15 @@ export function GfsResourceMenu({
Manage
</MenuItem>
) : null}
+ {onCreateShare ? (
+ <MenuItem
+ disabled={createShareDisabled}
+ role="menuitem"
+ onClick={() => runAction(onCreateShare)}
+ >
+ Create share
+ </MenuItem>
+ ) : null}
{onOpen ? (
<MenuItem role="menuitem" onClick={() => runAction(onOpen)}>
Open folder
diff --git a/desktop-app/ui/src/components/GfsResourceMenu/types.ts b/desktop-app/ui/src/components/GfsResourceMenu/types.ts
index b4ca9834d..de3ea3000 100644
--- a/desktop-app/ui/src/components/GfsResourceMenu/types.ts
+++ b/desktop-app/ui/src/components/GfsResourceMenu/types.ts
@@ -1,7 +1,9 @@
export type GfsResourceMenuProps = {
+ createShareDisabled?: boolean
resourceName: string
onManage?: () => void
onCopyLink: () => void
+ onCreateShare?: () => void
onCreateFolder?: () => void
onDelete?: () => void
onOpen?: () => void
diff --git a/desktop-app/ui/src/gfs/__tests__/delegation.test.tsx b/desktop-app/ui/src/gfs/__tests__/delegation.test.tsx
index 090ff47a3..0cb560ce0 100644
--- a/desktop-app/ui/src/gfs/__tests__/delegation.test.tsx
+++ b/desktop-app/ui/src/gfs/__tests__/delegation.test.tsx
@@ -61,8 +61,10 @@ describe('GfsDelegationPanel', () => {
await waitFor(() => expect(onGrant).toHaveBeenCalledWith(['user:u2'], ['read'], false))
})
- it('shows Create share only when the caller holds the share bit', () => {
+ it('registers Create share only when the caller holds the share bit', async () => {
const onCreateShare = vi.fn().mockResolvedValue(undefined)
+ let createShareAction: (() => void) | null = null
+ let createShareDisabled = true
render(
<GfsDelegationPanel
affordances={{ canDelegate: true, grantableBits: ['read', 'share'], canCreateShare: true }}
@@ -70,9 +72,23 @@ describe('GfsDelegationPanel', () => {
isDirectory={false}
onGrant={vi.fn()}
onCreateShare={onCreateShare}
+ onCreateShareActionChange={(action, disabled) => {
+ createShareAction = action
+ createShareDisabled = disabled
+ }}
/>
)
- expect(screen.getByRole('button', { name: 'Create share' })).toBeTruthy()
+ expect(screen.queryByRole('button', { name: 'Create share' })).toBeNull()
+ expect(createShareDisabled).toBe(true)
+
+ fireEvent.focus(screen.getByRole('combobox', { name: PICKER_LABEL }))
+ fireEvent.click(screen.getByRole('option', { name: /Core Team/ }))
+ await waitFor(() => {
+ expect(createShareDisabled).toBe(false)
+ expect(createShareAction).not.toBeNull()
+ })
+ createShareAction?.()
+ await waitFor(() => expect(onCreateShare).toHaveBeenCalledWith(['team:team-1']))
})
it('surfaces a server no-escalation rejection mapped to its human message (fail-loud)', async () => {
@@ -192,7 +208,7 @@ describe('GfsDelegationPanel', () => {
expect(screen.getByText(/limited to read and write/i)).toBeTruthy()
expect(screen.getByRole('button', { name: 'Read' })).toBeTruthy()
expect(screen.queryByRole('button', { name: /2 permissions/ })).toBeNull()
- expect(screen.getByRole('button', { name: 'Create share' })).toHaveProperty('disabled', true)
+ expect(screen.queryByRole('button', { name: 'Create share' })).toBeNull()
fireEvent.click(screen.getByRole('button', { name: 'Grant access' }))
await waitFor(() =>
diff --git a/desktop-app/ui/src/gfs/delegation.tsx b/desktop-app/ui/src/gfs/delegation.tsx
index 2725472b2..2a57a0615 100644
--- a/desktop-app/ui/src/gfs/delegation.tsx
+++ b/desktop-app/ui/src/gfs/delegation.tsx
@@ -1,4 +1,4 @@
-import { useState } from 'react'
+import { useEffect, useRef, useState } from 'react'
import { Button, StatusBanner } from '@components/Common'
import { describeGfsGrantError } from '@lib/gfsGrantErrors'
import { GfsPermissionDropdown } from '@/gfs/GfsPermissionDropdown'
@@ -39,6 +39,7 @@ export function GfsDelegationPanel({
isDirectory,
onGrant,
onCreateShare,
+ onCreateShareActionChange,
}: GfsDelegationPanelProps) {
const [subjectKeys, setSubjectKeys] = useState<string[]>([])
const [bits, setBits] = useState<string[]>(() =>
@@ -47,16 +48,7 @@ export function GfsDelegationPanel({
const [inherit, setInherit] = useState(true)
const [busy, setBusy] = useState(false)
const [error, setError] = useState<string | null>(null)
-
- // A Leader without manage_acl (canDelegate=false) sees no controls.
- if (!affordances.canDelegate) {
- return (
- <div className="da-gfs-delegation__empty" role="note">
- <strong>Read-only access</strong>
- <span>You do not have delegation rights on this folder.</span>
- </div>
- )
- }
+ const createShareActionRef = useRef<() => void>(() => undefined)
const grantableBits = affordances.grantableBits
const hasHost = subjectKeys.some(key => key.startsWith(HOST_SUBJECT_KEY_PREFIX))
@@ -66,6 +58,11 @@ export function GfsDelegationPanel({
const visiblePermissionBits = hasHost
? HOST_PERMISSION_BITS.filter(bit => grantableBits.includes(bit))
: grantableBits
+ const canCreateShare =
+ Boolean(onCreateShare && affordances.canCreateShare) &&
+ !busy &&
+ !hasHost &&
+ subjectKeys.length > 0
function changeSubjects(nextKeys: string[]) {
setSubjectKeys(nextKeys)
@@ -96,6 +93,27 @@ export function GfsDelegationPanel({
}
}
+ createShareActionRef.current = () => {
+ if (!onCreateShare || !canCreateShare) return
+ void run(() => onCreateShare(subjectKeys))
+ }
+
+ useEffect(() => {
+ if (!onCreateShareActionChange) return
+ onCreateShareActionChange(() => createShareActionRef.current(), !canCreateShare)
+ return () => onCreateShareActionChange(null, true)
+ }, [canCreateShare, onCreateShareActionChange])
+
+ // A Leader without manage_acl (canDelegate=false) sees no controls.
+ if (!affordances.canDelegate) {
+ return (
+ <div className="da-gfs-delegation__empty" role="note">
+ <strong>Read-only access</strong>
+ <span>You do not have delegation rights on this folder.</span>
+ </div>
+ )
+ }
+
return (
<div className="da-gfs-delegation">
<div className="da-gfs-delegation__composer">
@@ -139,16 +157,6 @@ export function GfsDelegationPanel({
>
Grant access
</Button>
- {onCreateShare && affordances.canCreateShare ? (
- <Button
- type="button"
- variant="outline"
- disabled={busy || hasHost || subjectKeys.length === 0}
- onClick={() => run(() => onCreateShare(subjectKeys))}
- >
- Create share
- </Button>
- ) : null}
</div>
{error !== null && <StatusBanner tone="error" text={error} />}
</div>
@@ -157,6 +165,7 @@ export function GfsDelegationPanel({
export type {
DelegationAffordances,
+ GfsCreateShareActionChange,
GfsAgentSubjectOption,
GfsDelegationPanelProps,
GfsDelegationSubjectOption,
diff --git a/desktop-app/ui/src/gfs/delegation.types.ts b/desktop-app/ui/src/gfs/delegation.types.ts
index b7a608e9b..d49166da3 100644
--- a/desktop-app/ui/src/gfs/delegation.types.ts
+++ b/desktop-app/ui/src/gfs/delegation.types.ts
@@ -15,6 +15,8 @@ export interface GfsDelegationSubjectOption {
badge?: string
}
+export type GfsCreateShareActionChange = (action: (() => void) | null, disabled: boolean) => void
+
export interface GfsDelegationPanelProps {
affordances: DelegationAffordances
subjectOptions: GfsDelegationSubjectOption[]
@@ -24,6 +26,7 @@ export interface GfsDelegationPanelProps {
isDirectory: boolean
onGrant: (subjectKeys: string[], bits: string[], inherit: boolean) => Promise<void>
onCreateShare?: (subjectKeys: string[]) => Promise<void>
+ onCreateShareActionChange?: GfsCreateShareActionChange
}
/**
diff --git a/desktop-app/ui/src/pages/FilesPage.tsx b/desktop-app/ui/src/pages/FilesPage.tsx
index 2e9164f1d..369660f90 100644
--- a/desktop-app/ui/src/pages/FilesPage.tsx
+++ b/desktop-app/ui/src/pages/FilesPage.tsx
@@ -1,4 +1,11 @@
-import { type DragEvent as ReactDragEvent, useEffect, useMemo, useRef, useState } from 'react'
+import {
+ type DragEvent as ReactDragEvent,
+ useCallback,
+ useEffect,
+ useMemo,
+ useRef,
+ useState,
+} from 'react'
import { useQuery, useQueryClient } from '@tanstack/react-query'
import { Button, EmptyState, IconButton, StatusBanner, TextInput } from '@components/Common'
import { ConfirmDialog } from '@components/ConfirmDialog'
@@ -28,6 +35,7 @@ import { formatSharedFileSize } from '@lib/sharedFiles'
import { GfsGrantList } from '@/gfs/GfsGrantList'
import {
type GfsAgentSubjectOption,
+ type GfsCreateShareActionChange,
GfsDelegationPanel,
type GfsDelegationSubjectOption,
} from '@/gfs/delegation'
@@ -145,6 +153,15 @@ export function FilesPage({ pushToast, pendingGfsUri, onPendingGfsUriHandled }:
const [renameDraft, setRenameDraft] = useState('')
const [openLinkOpen, setOpenLinkOpen] = useState(false)
const [manageOpen, setManageOpen] = useState(false)
+ const createShareActionRef = useRef<(() => void) | null>(null)
+ const [createShareDisabled, setCreateShareDisabled] = useState(true)
+ const handleCreateShareActionChange = useCallback<GfsCreateShareActionChange>(
+ (action, disabled) => {
+ createShareActionRef.current = action
+ setCreateShareDisabled(disabled)
+ },
+ []
+ )
const [filePreview, setFilePreview] = useState<GfsPreviewResource | null>(null)
const [dragActive, setDragActive] = useState(false)
const [droppedUploadCount, setDroppedUploadCount] = useState(0)
@@ -1001,8 +1018,10 @@ export function FilesPage({ pushToast, pendingGfsUri, onPendingGfsUriHandled }:
<span className="da-gfs-manage-dialog__title-row">
<h3>{current.name}</h3>
<GfsResourceMenu
+ createShareDisabled={createShareDisabled}
resourceName={current.name}
onCopyLink={() => void handleCopyLink(current.gfsUri)}
+ onCreateShare={() => createShareActionRef.current?.()}
onCreateFolder={
currentIsFolder && canWriteCurrent
? () => {
@@ -1164,6 +1183,7 @@ export function FilesPage({ pushToast, pendingGfsUri, onPendingGfsUriHandled }:
isDirectory={currentIsFolder}
onGrant={handleGrant}
onCreateShare={affordances.canCreateShare ? handleCreateShare : undefined}
+ onCreateShareActionChange={handleCreateShareActionChange}
/>
</>
) : (
diff --git a/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx b/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx
index 48bcbe48b..e872e7004 100644
--- a/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx
+++ b/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx
@@ -323,11 +323,7 @@ describe('FilesPage', () => {
expect(deleteResource).toHaveBeenCalledWith('folder-1', 7)
})
- it('shortens oversized file names before uploading through Desktop GFS', async () => {
- const createFile = vi.fn(
- async (_parentResourceId: string, _name: string, _encodedData: string) => undefined
- )
- const pushToast = vi.fn()
+ it('does not render a folder upload control inside the manage dialog', async () => {
hookMock.useGfsBrowserController.mockReturnValue({
...baseController(),
current: {
@@ -343,32 +339,13 @@ describe('FilesPage', () => {
grantableBits: [],
canCreateShare: false,
},
- createFile,
})
- renderFilesPage(pushToast)
+ renderFilesPage()
await openManageDialog('Team folder')
- const rawName = `quarterly-${'very-long-'.repeat(32)}report.txt`
- await act(async () => {
- fireEvent.change(screen.getByLabelText('Upload file'), {
- target: {
- files: [new File(['desktop upload'], rawName, { type: 'text/plain' })],
- },
- })
- await Promise.resolve()
- })
-
- await waitFor(() => expect(createFile).toHaveBeenCalled())
- const uploadCall = createFile.mock.calls[0]
- expect(uploadCall).toBeTruthy()
- const [parentResourceId, uploadedName, encodedData] = uploadCall!
- expect(parentResourceId).toBe('folder-1')
- expect(uploadedName).not.toBe(rawName)
- expect(uploadedName).toHaveLength(255)
- expect(uploadedName).toMatch(/-[0-9a-f]{12}\.txt$/)
- expect(encodedData).toBe('ZGVza3RvcCB1cGxvYWQ=')
- expect(pushToast).toHaveBeenCalledWith(`Uploaded ${uploadedName}`, 'success')
+ expect(screen.queryByRole('button', { name: 'Upload file' })).toBeNull()
+ expect(screen.queryByLabelText('Upload file')).toBeNull()
})
it('uploads dropped images and Markdown files into the open writable folder', async () => {
@@ -969,6 +946,86 @@ describe('FilesPage', () => {
expect(pushToast).toHaveBeenCalledWith('Access granted to 1 subject', 'success')
})
+ it('creates a share from the manage dialog resource menu', async () => {
+ Object.defineProperty(window, 'clerum', {
+ configurable: true,
+ value: {
+ agents: { listMine: vi.fn(async () => []) },
+ team: {
+ directory: vi.fn(async () => ({
+ currentTeamId: 'team-1',
+ items: [
+ {
+ team: { id: 'team-1', name: 'Core Team', role: 'admin' },
+ members: [
+ {
+ id: 'user-2',
+ email: '[email protected]',
+ name: 'Test Two',
+ role: 'member',
+ status: 'active',
+ },
+ ],
+ contextIds: [],
+ agentNames: [],
+ },
+ ],
+ })),
+ },
+ },
+ })
+ const createShare = vi.fn(async () => undefined)
+ const pushToast = vi.fn()
+ hookMock.useGfsBrowserController.mockReturnValue({
+ ...baseController(),
+ current: {
+ resourceId: 'folder-1',
+ gfsUri: 'gfs://main/folder',
+ name: 'Team folder',
+ kind: 'directory',
+ },
+ affordances: {
+ held: ['read', 'share', 'manage_acl'],
+ canDelegate: true,
+ grantableBits: ['read', 'share'],
+ canCreateShare: true,
+ },
+ createShare,
+ })
+
+ renderFilesPage(pushToast)
+ await openManageDialog('Team folder')
+
+ const dialog = screen.getByRole('dialog', { name: 'Manage folder Team folder' })
+ const menuTrigger = within(dialog).getByRole('button', { name: 'Options for Team folder' })
+ await act(async () => {
+ fireEvent.click(menuTrigger)
+ })
+ expect(within(dialog).getByRole('menuitem', { name: 'Create share' })).toHaveProperty(
+ 'disabled',
+ true
+ )
+ await act(async () => {
+ fireEvent.click(menuTrigger)
+ })
+
+ const picker = await screen.findByRole('combobox', { name: 'Add people, teams, or agents' })
+ fireEvent.focus(picker)
+ fireEvent.click(await screen.findByRole('option', { name: /Test Two/ }))
+
+ await act(async () => {
+ fireEvent.click(menuTrigger)
+ })
+ const createShareItem = within(dialog).getByRole('menuitem', { name: 'Create share' })
+ expect(createShareItem).toHaveProperty('disabled', false)
+ await act(async () => {
+ fireEvent.click(createShareItem)
+ })
+
+ await waitFor(() => expect(createShare).toHaveBeenCalledWith(['user:user-2']))
+ expect(pushToast).toHaveBeenCalledWith('1 share created', 'success')
+ })
+
it('issues ONE atomic bulk grant and does not refetch or toast when it is rejected', async () => {
Object.defineProperty(window, 'clerum', {
configurable: true,
diff --git a/desktop-app/ui/src/styles.css b/desktop-app/ui/src/styles.css
index 516d8a6d1..7a479a609 100644
--- a/desktop-app/ui/src/styles.css
+++ b/desktop-app/ui/src/styles.css
@@ -13740,6 +13740,7 @@ pre {
display: flex;
flex-wrap: wrap;
gap: var(--space-2);
+ justify-content: flex-end;
}
.da-gfs-footer-actions {