Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(control-api): r7-m14 verify external stream limiter identity

Josué2db9b6ce6674
diff --git a/control-api/package-lock.json b/control-api/package-lock.json
index 255a7e696..7bc4125fe 100644
--- a/control-api/package-lock.json
+++ b/control-api/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-api",
- "version": "0.1.686",
+ "version": "0.1.687",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-api",
- "version": "0.1.686",
+ "version": "0.1.687",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/grok-provider-attempt-contract": "file:../packages/grok-provider-attempt-contract",
diff --git a/control-api/package.json b/control-api/package.json
index c80efb5a9..d2e83ca3a 100644
--- a/control-api/package.json
+++ b/control-api/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-api",
- "version": "0.1.686",
+ "version": "0.1.687",
"description": "Internal Clerum control plane REST API + UI for managing CRDs and secrets",
"main": "dist/main.js",
"engines": {
diff --git a/control-api/test/routes.externalEntityChanges.rateLimit.test.ts b/control-api/test/routes.externalEntityChanges.rateLimit.test.ts
index ee0c8a089..c47680540 100644
--- a/control-api/test/routes.externalEntityChanges.rateLimit.test.ts
+++ b/control-api/test/routes.externalEntityChanges.rateLimit.test.ts
@@ -1,10 +1,11 @@
-import { describe, expect, it, vi } from 'vitest'
-import type { Router } from 'express'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+import type { Request, Router } from 'express'
type LimiterOptions = {
bucketType: string
maxPerMinute: number
onBackendUnavailable: 'process-memory' | 'closed'
+ getBucketKey: (req: Request) => string | null
}
const captured = vi.hoisted(() => [] as LimiterOptions[])
@@ -46,6 +47,10 @@ type RouteLayer = {
}
describe('external entity-change stream rate-limit policy', () => {
+ beforeEach(() => {
+ captured.length = 0
+ })
+
it('fails closed when the shared rate-limit backend cannot count the user request', () => {
const router: Router = createExternalEntityChangesRouter()
const route = (router.stack as RouteLayer[]).find(
@@ -60,4 +65,22 @@ describe('external entity-change stream rate-limit policy', () => {
})
expect(route?.stack.some(layer => 'limiterOptions' in (layer.handle as object))).toBe(true)
})
+
+ it('isolates the external stream bucket by authenticated user principal', () => {
+ const router: Router = createExternalEntityChangesRouter()
+ const route = (router.stack as RouteLayer[]).find(
+ layer => layer.route?.path === '/external/entity-changes/stream'
+ )?.route
+ const bucketKey = captured[0]?.getBucketKey
+
+ expect(route).toBeDefined()
+ expect(bucketKey).toBeTypeOf('function')
+ expect(bucketKey?.({ externalAuth: { userId: 'user-a' } } as unknown as Request)).toBe(
+ 'user:user-a:entity-changes'
+ )
+ expect(bucketKey?.({ externalAuth: { userId: 'user-b' } } as unknown as Request)).toBe(
+ 'user:user-b:entity-changes'
+ )
+ expect(bucketKey?.({} as Request)).toBeNull()
+ })
})