Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): simplify connector table columns

Josué34365efc3bf2
diff --git a/control-ui/components/McpServerTable.tsx b/control-ui/components/McpServerTable.tsx
index b7c887a93..967fe1712 100644
--- a/control-ui/components/McpServerTable.tsx
+++ b/control-ui/components/McpServerTable.tsx
@@ -1,10 +1,9 @@
'use client'
import React, { useMemo, useState } from 'react'
-import { DataTable, TableRow, TableStateRow } from '@clerum/frontend-components'
+import { DataTable, TableRow, TableStateRow, TruncatedText } from '@clerum/frontend-components'
import { copyTextToClipboard } from '@lib/clipboard'
import type {
- ConnectorAccessSummary,
ConnectorContextBinding,
McpServerStatus,
McpServerTableProps,
@@ -19,39 +18,19 @@ import { TablePanelHeader } from './TablePanelHeader'
import { IconCopy, IconRefresh, IconX } from './icons'
const ENABLED_TOOLTIP = 'Enabled controls whether this server is available to contexts and agents.'
-type ConnectorSortKey =
- | 'name'
- | 'description'
- | 'transport'
- | 'endpoint'
- | 'image'
- | 'access'
- | 'managed'
- | 'enabled'
- | 'status'
+type ConnectorSortKey = 'name' | 'description' | 'endpoint' | 'managed' | 'enabled' | 'status'
type SortDirection = 'asc' | 'desc'
const CONNECTOR_COLUMNS: TableHeaderColumn[] = [
{ key: 'name', label: 'Name' },
{ key: 'description', label: 'Description' },
- { key: 'transport', label: 'Transport' },
{ key: 'endpoint', label: 'Endpoint' },
- { key: 'image', label: 'Image' },
- { key: 'access', label: 'Access' },
{ key: 'managed', label: 'Managed' },
{ key: 'enabled', label: 'Enabled', title: ENABLED_TOOLTIP },
{ key: 'status', label: 'Status' },
{ key: 'actions', align: 'right', ariaLabel: 'Actions' },
]
-function TransportBadge({ type }: { type?: string }) {
- return type ? (
- <span className={`cu-connector-badge cu-connector-badge--transport-${type}`}>{type}</span>
- ) : (
- <span className="cu-muted">—</span>
- )
-}
-
function BoolBadge({
value,
trueLabel,
@@ -218,10 +197,6 @@ export function McpServerTable({
})
const direction = sortDirection === 'asc' ? 1 : -1
return [...matchingRows].sort((left, right) => {
- const leftAccess = accessByConnectorKey?.[left.key]
- const rightAccess = accessByConnectorKey?.[right.key]
- const accessCount = (access?: ConnectorAccessSummary) =>
- (access?.agents.length ?? 0) + (access?.teams.length ?? 0) + (access?.users.length ?? 0)
const comparison =
sortKey === 'name'
? left.name.localeCompare(right.name, undefined, { sensitivity: 'base' })
@@ -231,27 +206,19 @@ export function McpServerTable({
undefined,
{ sensitivity: 'base' }
)
- : sortKey === 'transport'
- ? (left.item.spec?.transport?.type ?? '').localeCompare(
- right.item.spec?.transport?.type ?? ''
+ : sortKey === 'endpoint'
+ ? (left.item.spec?.transport?.url ?? left.item.spec?.image ?? '').localeCompare(
+ right.item.spec?.transport?.url ?? right.item.spec?.image ?? ''
)
- : sortKey === 'endpoint'
- ? (left.item.spec?.transport?.url ?? left.item.spec?.image ?? '').localeCompare(
- right.item.spec?.transport?.url ?? right.item.spec?.image ?? ''
- )
- : sortKey === 'image'
- ? (left.item.spec?.image ?? '').localeCompare(right.item.spec?.image ?? '')
- : sortKey === 'access'
- ? accessCount(leftAccess) - accessCount(rightAccess)
- : sortKey === 'managed'
- ? Number((left.item.spec?.managed ?? true) === true) -
- Number((right.item.spec?.managed ?? true) === true)
- : sortKey === 'enabled'
- ? Number((left.item.spec?.enabled ?? true) === true) -
- Number((right.item.spec?.enabled ?? true) === true)
- : getStatusLabel(left.item.status).localeCompare(
- getStatusLabel(right.item.status)
- )
+ : sortKey === 'managed'
+ ? Number((left.item.spec?.managed ?? true) === true) -
+ Number((right.item.spec?.managed ?? true) === true)
+ : sortKey === 'enabled'
+ ? Number((left.item.spec?.enabled ?? true) === true) -
+ Number((right.item.spec?.enabled ?? true) === true)
+ : getStatusLabel(left.item.status).localeCompare(
+ getStatusLabel(right.item.status)
+ )
if (comparison !== 0) return comparison * direction
return left.key.localeCompare(right.key)
})
@@ -432,7 +399,6 @@ export function McpServerTable({
const spec = item.spec || {}
const assignedContexts = contextsForConnector(name)
const contextMembershipBusy = updatingContextMembershipKey === key
- const access = accessByConnectorKey?.[key]
return (
<TableRow
className={onEdit ? 'cu-table__row cu-table__row--clickable' : undefined}
@@ -440,13 +406,8 @@ export function McpServerTable({
onNavigate={onEdit ? () => onEdit({ namespace, name }) : undefined}
>
<td>{name}</td>
- <td>
- <span className="cu-cell-truncate" title={spec.description}>
- {spec.description || '—'}
- </span>
- </td>
- <td>
- <TransportBadge type={spec.transport?.type} />
+ <td className="cu-registry-description">
+ <TruncatedText value={spec.description} />
</td>
<td className="cu-code-text">
<CopyableValue
@@ -459,27 +420,6 @@ export function McpServerTable({
value={spec.transport?.url || spec.image || ''}
/>
</td>
- <td className="cu-code-text">
- <CopyableValue
- copied={copiedValueKey === `${key}/image`}
- copyLabel="image reference"
- onCopy={() => void copyValue(`${key}/image`, spec.image || '')}
- value={spec.image || ''}
- />
- </td>
- <td>
- {assignedContexts.length} context{assignedContexts.length === 1 ? '' : 's'} ·{' '}
- {(access?.agents.length ?? 0) +
- (access?.teams.length ?? 0) +
- (access?.users.length ?? 0)}{' '}
- principal
- {(access?.agents.length ?? 0) +
- (access?.teams.length ?? 0) +
- (access?.users.length ?? 0) ===
- 1
- ? ''
- : 's'}
- </td>
<td>
<BoolBadge value={spec.managed} trueLabel="Yes" falseLabel="No" />
</td>
diff --git a/control-ui/components/__tests__/McpServerTable.test.tsx b/control-ui/components/__tests__/McpServerTable.test.tsx
index 54ca5ab99..097c4b825 100644
--- a/control-ui/components/__tests__/McpServerTable.test.tsx
+++ b/control-ui/components/__tests__/McpServerTable.test.tsx
@@ -228,7 +228,24 @@ describe('McpServerTable — marketplace-aligned rows', () => {
const row = screen.getByText('brave-search').closest('tr')
expect(row).not.toBeNull()
expect(row).toHaveTextContent('Search the public web.')
- expect(within(row!).getByTitle('Search the public web.')).toBeInTheDocument()
+ expect(within(row!).getByText('Search the public web.')).toHaveClass(
+ 'eft-truncated-text__value'
+ )
+ })
+
+ it('truncates long connector descriptions with a hoverable full-value affordance', async () => {
+ const longDescription =
+ 'Searches the public web with a long connector description that should be bounded in tables.'
+ render(
+ <McpServerTable items={[makeItem({ name: 'brave-search', description: longDescription })]} />
+ )
+
+ const description = screen.getByText(
+ 'Searches the public web with a long connector description that should be bounded...'
+ )
+ expect(description).toHaveClass('eft-truncated-text__value')
+ fireEvent.mouseEnter(description)
+ expect(await screen.findByRole('tooltip')).toHaveTextContent(longDescription)
})
})
@@ -316,17 +333,14 @@ describe('McpServerTable — connector access summaries', () => {
expect(trigger).toHaveFocus()
})
- it('keeps connector endpoint links and image copy actions available', async () => {
+ it('keeps connector endpoint links and copy actions available', async () => {
const onEdit = vi.fn()
const writeText = vi.fn().mockResolvedValue(undefined)
Object.defineProperty(navigator, 'clipboard', {
configurable: true,
value: { writeText },
})
- const image = 'ghcr.io/example/mcp:1.0'
- render(
- <McpServerTable items={[makeItem({ name: 'airtable-server', image })]} onEdit={onEdit} />
- )
+ render(<McpServerTable items={[makeItem({ name: 'airtable-server' })]} onEdit={onEdit} />)
const endpointLink = screen.getByRole('link', { name: /brave-search\.mcp-server/ })
expect(endpointLink).toHaveAttribute(
@@ -335,11 +349,15 @@ describe('McpServerTable — connector access summaries', () => {
)
fireEvent.click(endpointLink)
fireEvent.keyDown(endpointLink, { key: 'Enter' })
- const copyButton = screen.getByRole('button', { name: 'Copy image reference' })
+ const copyButton = screen.getByRole('button', { name: 'Copy endpoint' })
fireEvent.click(copyButton)
fireEvent.keyDown(copyButton, { key: 'Enter' })
- await waitFor(() => expect(writeText).toHaveBeenCalledWith(image))
- expect(screen.getByRole('button', { name: 'image reference copied' })).toBeInTheDocument()
+ await waitFor(() =>
+ expect(writeText).toHaveBeenCalledWith(
+ 'http://brave-search.mcp-server.svc.cluster.local:3000/mcp'
+ )
+ )
+ expect(screen.getByRole('button', { name: 'endpoint copied' })).toBeInTheDocument()
expect(onEdit).not.toHaveBeenCalled()
})
@@ -354,18 +372,19 @@ describe('McpServerTable — connector access summaries', () => {
expect(screen.getByText('No users linked.')).toBeInTheDocument()
})
- it('shows endpoint, image, transport, and managed as explicit columns', () => {
+ it('shows the compact connector columns and omits removed metadata columns', () => {
const image =
'us-central1-docker.pkg.dev/example-project/example/nginx-egress-proxy:sha-3cbdf33'
const url = 'http://brave-search.mcp-server.svc.cluster.local:3000/mcp'
render(<McpServerTable items={[makeItem({ name: 'airtable-server', image })]} />)
expect(screen.getByRole('columnheader', { name: /Endpoint/i })).toBeInTheDocument()
- expect(screen.getByRole('columnheader', { name: /Image/i })).toBeInTheDocument()
- expect(screen.getByRole('columnheader', { name: /Transport/i })).toBeInTheDocument()
+ expect(screen.queryByRole('columnheader', { name: /Image/i })).toBeNull()
+ expect(screen.queryByRole('columnheader', { name: /Transport/i })).toBeNull()
+ expect(screen.queryByRole('columnheader', { name: /Access/i })).toBeNull()
expect(screen.getByRole('columnheader', { name: /Managed/i })).toBeInTheDocument()
expect(screen.getByTitle(url)).toBeInTheDocument()
- expect(screen.getByTitle(image)).toBeInTheDocument()
+ expect(screen.queryByTitle(image)).toBeNull()
})
it('filters rows by agent, user, and team access labels', () => {
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 7a0a35099..b9d0b01d7 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.517",
+ "version": "0.1.518",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.517",
+ "version": "0.1.518",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index a0990a217..34ed82714 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.517",
+ "version": "0.1.518",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",