Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(control-ui): reject unmodeled registry managed writes

M3504da4cd97d
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 9a81dd1b5..57cae3b83 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.664",
+ "version": "0.1.665",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.664",
+ "version": "0.1.665",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index fa162db2a..d14ca7a0f 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.664",
+ "version": "0.1.665",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",
diff --git a/control-ui/test/__tests__/registryMcpServerProducer.test.ts b/control-ui/test/__tests__/registryMcpServerProducer.test.ts
new file mode 100644
index 000000000..166a6fb83
--- /dev/null
+++ b/control-ui/test/__tests__/registryMcpServerProducer.test.ts
@@ -0,0 +1,24 @@
+import { expect, it } from 'vitest'
+import { readFileSync } from 'node:fs'
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+import { registryMcpServerManaged } from '../fixtures/registryMcpServerProducer'
+
+const REGISTRY_PATH = path.resolve(
+ path.dirname(fileURLToPath(import.meta.url)),
+ '../../../control-api/src/routes/admin/registry.ts'
+)
+
+it('rejects a later computed managed write in the registry producer', () => {
+ const source = readFileSync(REGISTRY_PATH, 'utf8')
+ const marker = ' // Local plugins whose image lives on the evenfire registry'
+ expect(source).toContain(marker)
+ const changedSource = source.replace(
+ marker,
+ ` mcpServerSpec['managed'] = false\n\n${marker}`
+ )
+
+ expect(() => registryMcpServerManaged(changedSource)).toThrow(
+ /unsupported registry managed write.*mcpServerSpec\['managed'\] = false/i
+ )
+})
diff --git a/control-ui/test/fixtures/registryMcpServerProducer.ts b/control-ui/test/fixtures/registryMcpServerProducer.ts
index d8a3f1c0f..434d085af 100644
--- a/control-ui/test/fixtures/registryMcpServerProducer.ts
+++ b/control-ui/test/fixtures/registryMcpServerProducer.ts
@@ -19,7 +19,7 @@ const GATEWAY_PATH = path.resolve(
)
/** Execute the registry install producer's Secret-name and envSecret expressions. */
-function registrySecretFactory(): {
+function registrySecretFactory(registrySource?: string): {
name: (serverName: string) => string
envSecret: (secretName: string, keyNames: string[]) => EnvSecret
managed: () => boolean
@@ -27,19 +27,31 @@ function registrySecretFactory(): {
} {
const source = ts.createSourceFile(
REGISTRY_PATH,
- readFileSync(REGISTRY_PATH, 'utf8'),
+ registrySource ?? readFileSync(REGISTRY_PATH, 'utf8'),
ts.ScriptTarget.Latest,
true
)
const assignments: ts.Expression[] = []
const secretNames: ts.Expression[] = []
const managedExpressions: ts.Expression[] = []
- const managedReassignments: ts.BinaryExpression[] = []
+ const unsupportedManagedWrites: ts.Node[] = []
const registryLabels: ts.Expression[] = []
const registryAnnotations: ts.Expression[] = []
const registryResourceMetadata: ts.Expression[] = []
let catalogAnnotations: ts.FunctionDeclaration | undefined
+ function canWriteManaged(node: ts.Node): boolean {
+ if (
+ ts.isPropertyAccessExpression(node) &&
+ node.expression.getText(source) === 'mcpServerSpec'
+ ) {
+ return node.name.text === 'managed'
+ }
+ // Even a dynamic key might resolve to "managed" at runtime. No computed
+ // writes are modeled by the fixture, so every one must fail closed.
+ return ts.isElementAccessExpression(node) && node.expression.getText(source) === 'mcpServerSpec'
+ }
+
function visit(node: ts.Node): void {
if (
ts.isVariableDeclaration(node) &&
@@ -87,8 +99,31 @@ function registrySecretFactory(): {
assignments.push(node.right)
}
}
- if (ts.isBinaryExpression(node) && node.left.getText(source) === 'mcpServerSpec.managed') {
- managedReassignments.push(node)
+ if (
+ ts.isBinaryExpression(node) &&
+ node.operatorToken.kind >= ts.SyntaxKind.FirstAssignment &&
+ node.operatorToken.kind <= ts.SyntaxKind.LastAssignment &&
+ (canWriteManaged(node.left) || node.left.getText(source) === 'mcpServerSpec')
+ ) {
+ unsupportedManagedWrites.push(node)
+ }
+ if (
+ ((ts.isPrefixUnaryExpression(node) || ts.isPostfixUnaryExpression(node)) &&
+ (node.operator === ts.SyntaxKind.PlusPlusToken ||
+ node.operator === ts.SyntaxKind.MinusMinusToken) &&
+ canWriteManaged(node.operand)) ||
+ (ts.isDeleteExpression(node) && canWriteManaged(node.expression))
+ ) {
+ unsupportedManagedWrites.push(node)
+ }
+ if (
+ ts.isCallExpression(node) &&
+ node.arguments[0]?.getText(source) === 'mcpServerSpec' &&
+ ['Object.assign', 'Object.defineProperty', 'Object.defineProperties', 'Reflect.set'].includes(
+ node.expression.getText(source)
+ )
+ ) {
+ unsupportedManagedWrites.push(node)
}
if (
ts.isCallExpression(node) &&
@@ -112,12 +147,18 @@ function registrySecretFactory(): {
ts.forEachChild(node, visit)
}
visit(source)
+ if (unsupportedManagedWrites.length > 0) {
+ const write = unsupportedManagedWrites[0]
+ const line = source.getLineAndCharacterOfPosition(write.getStart(source)).line + 1
+ throw new Error(
+ `Unsupported registry managed write at ${path.basename(REGISTRY_PATH)}:${line}: ${write.getText(source)}`
+ )
+ }
if (
assignments.length !== 1 ||
!ts.isObjectLiteralExpression(assignments[0]) ||
secretNames.length !== 1 ||
managedExpressions.length !== 1 ||
- managedReassignments.length !== 0 ||
registryAnnotations.length !== 1 ||
registryResourceMetadata.length !== 1 ||
!catalogAnnotations
@@ -251,8 +292,12 @@ export function registrySecretName(serverName: string): string {
return registrySecret.name(serverName)
}
-export function registryMcpServerManaged(): boolean {
- return registrySecret.managed()
+/** Optional source input supports contract mutation tests without writing to
+ * the backend producer file. Ordinary fixtures use the checkout's source. */
+export function registryMcpServerManaged(registrySource?: string): boolean {
+ return registrySource === undefined
+ ? registrySecret.managed()
+ : registrySecretFactory(registrySource).managed()
}
export function registryMcpServerMetadata(