Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(e2e): parse runtime completion with service metric labels

Alfredo Lopez3bc88eb8cccc
diff --git a/host-context-controller/package-lock.json b/host-context-controller/package-lock.json
index 049ea56b4..81b65874d 100644
--- a/host-context-controller/package-lock.json
+++ b/host-context-controller/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-host-context-controller",
- "version": "0.1.316",
+ "version": "0.1.317",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-host-context-controller",
- "version": "0.1.316",
+ "version": "0.1.317",
"license": "SEE LICENSE IN LICENSE",
"dependencies": {
"@clerum/codex-catalog-projection": "file:../packages/codex-catalog-projection",
diff --git a/host-context-controller/package.json b/host-context-controller/package.json
index ad1265e2a..331c8e952 100644
--- a/host-context-controller/package.json
+++ b/host-context-controller/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-host-context-controller",
- "version": "0.1.316",
+ "version": "0.1.317",
"description": "Host Context Controller - provides McpServer CRDs to mcp-host via REST API",
"main": "dist/main.js",
"engines": {
diff --git a/host-context-controller/src/runtimeMetricProbe.test.ts b/host-context-controller/src/runtimeMetricProbe.test.ts
new file mode 100644
index 000000000..84b85ebe4
--- /dev/null
+++ b/host-context-controller/src/runtimeMetricProbe.test.ts
@@ -0,0 +1,124 @@
+import { afterEach, describe, expect, it } from 'vitest'
+import { readFileSync } from 'node:fs'
+import { resolve } from 'node:path'
+import { runInNewContext } from 'node:vm'
+import { initialConvergenceLastSuccessTimestampSeconds, registry } from './metrics'
+
+const source = readFileSync(
+ resolve(__dirname, '../../scripts/e2e/_lib/hcc-watch-runtime-metric.cjs'),
+ 'utf8'
+)
+const name = 'clerum_hcc_initial_convergence_last_success_timestamp_seconds'
+
+class ProbeExit extends Error {
+ constructor(readonly status: number) {
+ super('probe exited')
+ }
+}
+
+function probe(body: string, statusCode = 200, threshold = new Date(100000).toISOString()): number {
+ const events = new Map<string, (value?: unknown) => void>()
+ const response = {
+ statusCode,
+ on(event: string, callback: (value?: unknown) => void) {
+ events.set(event, callback)
+ return response
+ },
+ }
+ const request = {
+ on() {
+ return request
+ },
+ }
+ try {
+ runInNewContext(source, {
+ AbortSignal,
+ process: {
+ argv: ['node', '-', threshold],
+ exit(status: number) {
+ throw new ProbeExit(status)
+ },
+ },
+ require(module: string) {
+ if (module === './dist/config') return { config: { port: 19081 } }
+ if (module === 'node:http')
+ return {
+ get(
+ options: { port: number; path: string },
+ callback: (value: typeof response) => void
+ ) {
+ expect(options.port).toBe(19081)
+ expect(options.path).toBe('/metrics')
+ callback(response)
+ return request
+ },
+ }
+ throw new Error('unexpected probe dependency')
+ },
+ })
+ events.get('data')?.(body)
+ events.get('end')?.()
+ return 0
+ } catch (error) {
+ if (error instanceof ProbeExit) return error.status
+ throw error
+ }
+}
+
+afterEach(() => initialConvergenceLastSuccessTimestampSeconds.remove({ lane: 'McpServer' }))
+
+describe('runtime completion probe', () => {
+ it('accepts the actual HCC registry rendering with its default service label', async () => {
+ initialConvergenceLastSuccessTimestampSeconds.set({ lane: 'McpServer' }, 123)
+ const body = await registry.metrics()
+ expect(body).toContain('service="host-context-controller"')
+ expect(probe(body)).toBe(0)
+ })
+
+ it.each([
+ 'lane="McpServer"',
+ 'lane="McpServer",service="host-context-controller"',
+ 'service="host-context-controller",lane="McpServer"',
+ 'other="a,b", lane = "McpServer",service="host-context-controller"',
+ String.raw`quoted="a\"b",escaped="a\\b\nc",lane="McpServer"`,
+ ])('accepts valid label order/additions: %s', labels => {
+ expect(probe(`${name}{${labels}} 1.23e2\n`)).toBe(0)
+ })
+
+ it('preserves the exact threshold and metric/lane selection', () => {
+ expect(probe(`${name}{lane="McpServer"} 100\n`)).toBe(0)
+ expect(
+ probe(
+ `${name}_other{lane="McpServer"} 999\n${name}{lane="NetworkPolicy"} 999\n${name}{lane="McpServer"} 99\n`
+ )
+ ).toBe(1)
+ expect(probe(`${name}_other{lane="McpServer"} 999\n`)).toBe(1)
+ })
+
+ it.each([
+ '',
+ `${name}{lane="NetworkPolicy"} 123`,
+ `${name}{service="host-context-controller"} 123`,
+ `${name}{lane="McpServer"} 123\n${name}{service="other",lane="McpServer"} 124`,
+ `${name}{lane="McpServer",lane="McpServer"} 123`,
+ `${name}{lane="McpServer",extra="a",extra="b"} 123`,
+ `${name}{lane="McpServer"} NaN`,
+ `${name}{lane="McpServer"} +Inf`,
+ `${name}{lane="McpServer"} 1e999`,
+ `${name}{lane="McpServer"} 1e+`,
+ `${name}{lane="McpServer"} 1.2.3`,
+ `${name}{lane="McpServer"} 123 garbage`,
+ `${name}{lane="McpServer",} 123`,
+ `${name}{lane="McpServer",bad} 123`,
+ `${name}{lane="McpServer} 123`,
+ String.raw`${name}{lane="McpServer",bad="invalid\t"} 123`,
+ `${name}{lane="McpServer"} 99.999`,
+ ])('rejects missing, ambiguous, malformed or stale sample %#', body => {
+ expect(probe(body)).toBe(1)
+ })
+
+ it('rejects HTTP failure and an invalid completion threshold', () => {
+ expect(probe(`${name}{lane="McpServer"} 123`, 503)).toBe(1)
+ expect(probe(`${name}{lane="McpServer"} 123`, 200, 'invalid')).toBe(1)
+ })
+})
diff --git a/scripts/e2e/_lib/hcc-watch-runtime-metric.cjs b/scripts/e2e/_lib/hcc-watch-runtime-metric.cjs
index cd61ddb7d..3d5523fc2 100644
--- a/scripts/e2e/_lib/hcc-watch-runtime-metric.cjs
+++ b/scripts/e2e/_lib/hcc-watch-runtime-metric.cjs
@@ -2,6 +2,43 @@
// Reuse the deployed config parser; never infer a different listener port.
const { config } = require('./dist/config')
const http = require('node:http')
+
+function completedRuntimeSample(body) {
+ const name = 'clerum_hcc_initial_convergence_last_success_timestamp_seconds'
+ const samplePattern = new RegExp(`^${name}\\{(.*)\\}[ \\t]+([^ \\t]+)[ \\t]*$`)
+ const labelPattern =
+ /[ \t]*([a-zA-Z_][a-zA-Z0-9_]*)[ \t]*=[ \t]*"((?:\\[\\"n]|[^"\\\n])*)"[ \t]*/y
+ let selected = null
+ for (const raw of body.split('\n')) {
+ const line = raw.trimEnd()
+ if (!line.startsWith(name) || !['{', ' ', '\t', undefined].includes(line[name.length])) continue
+ const sample = samplePattern.exec(line)
+ if (!sample) return null
+ const labels = new Map()
+ let offset = 0
+ while (offset < sample[1].length) {
+ labelPattern.lastIndex = offset
+ const label = labelPattern.exec(sample[1])
+ if (!label || labels.has(label[1])) return null
+ labels.set(
+ label[1],
+ label[2].replace(/\\([\\"n])/g, (_escape, char) => (char === 'n' ? '\n' : char))
+ )
+ offset = labelPattern.lastIndex
+ if (offset < sample[1].length) {
+ if (sample[1][offset++] !== ',' || offset === sample[1].length) return null
+ }
+ }
+ if (labels.get('lane') !== 'McpServer') continue
+ if (selected !== null || !/^[+-]?(?:\d+(?:\.\d*)?|\.\d+)(?:[eE][+-]?\d+)?$/.test(sample[2]))
+ return null
+ const value = Number(sample[2])
+ if (!Number.isFinite(value)) return null
+ selected = value
+ }
+ return selected
+}
+
const threshold = Date.parse(process.argv[2]) / 1000
if (!Number.isFinite(threshold)) process.exit(1)
http
@@ -19,10 +56,8 @@ http
})
response.on('error', () => process.exit(1))
response.on('end', () => {
- const sample = body.match(
- /^clerum_hcc_initial_convergence_last_success_timestamp_seconds\{lane="McpServer"\} ([0-9.e+]+)$/m
- )
- if (response.statusCode !== 200 || !sample || Number(sample[1]) < threshold) process.exit(1)
+ const sample = completedRuntimeSample(body)
+ if (response.statusCode !== 200 || sample === null || sample < threshold) process.exit(1)
})
}
)