Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(desktop): polish GFS resource menus

M3bf398c4613e
diff --git a/desktop-app/ui/src/components/GfsResourceMenu/GfsResourceMenu.test.tsx b/desktop-app/ui/src/components/GfsResourceMenu/GfsResourceMenu.test.tsx
new file mode 100644
index 000000000..537338bd9
--- /dev/null
+++ b/desktop-app/ui/src/components/GfsResourceMenu/GfsResourceMenu.test.tsx
@@ -0,0 +1,39 @@
+// @vitest-environment jsdom
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, fireEvent, render, screen } from '@testing-library/react'
+import { GfsResourceMenu } from './index'
+
+describe('GfsResourceMenu', () => {
+ afterEach(() => {
+ cleanup()
+ })
+
+ it('uses a vertical kebab and presents a compact menu panel', () => {
+ render(
+ <GfsResourceMenu
+ onCopyLink={vi.fn()}
+ onDelete={vi.fn()}
+ onPreview={vi.fn()}
+ resourceName="report.txt"
+ />
+ )
+
+ const trigger = screen.getByRole('button', { name: 'Options for report.txt' })
+ const dotPositions = Array.from(trigger.querySelectorAll('circle')).map(circle => [
+ circle.getAttribute('cx'),
+ circle.getAttribute('cy'),
+ ])
+ expect(dotPositions).toEqual([
+ ['12', '5'],
+ ['12', '12'],
+ ['12', '19'],
+ ])
+
+ fireEvent.click(trigger)
+
+ const menu = screen.getByRole('menu')
+ expect(menu.tagName).toBe('DIV')
+ expect(menu.classList.contains('da-gfs-resource-menu__panel')).toBe(true)
+ expect(screen.getByRole('menuitem', { name: 'Preview' })).toBeTruthy()
+ })
+})
diff --git a/desktop-app/ui/src/components/GfsResourceMenu/index.tsx b/desktop-app/ui/src/components/GfsResourceMenu/index.tsx
index 83ce6af60..67d3c86c1 100644
--- a/desktop-app/ui/src/components/GfsResourceMenu/index.tsx
+++ b/desktop-app/ui/src/components/GfsResourceMenu/index.tsx
@@ -1,7 +1,7 @@
import { useCallback, useEffect, useRef, useState } from 'react'
import type { KeyboardEvent as ReactKeyboardEvent } from 'react'
import { IconButton, MenuItem } from '@components/Common'
-import { IconMoreHorizontal } from '@components/SidebarNav/icons'
+import { IconMoreVertical } from '@components/SidebarNav/icons'
import { useClickOutside } from '@hooks/useClickOutside'
import type { GfsResourceMenuProps } from './types'
@@ -98,10 +98,10 @@ export function GfsResourceMenu({
size="sm"
variant="ghost"
>
- <IconMoreHorizontal />
+ <IconMoreVertical />
</IconButton>
{open ? (
- <span className="da-gfs-resource-menu__panel" role="menu">
+ <div className="da-gfs-resource-menu__panel" role="menu">
{onManage ? (
<MenuItem role="menuitem" onClick={() => runAction(onManage)}>
Manage
@@ -152,7 +152,7 @@ export function GfsResourceMenu({
Delete
</MenuItem>
) : null}
- </span>
+ </div>
) : null}
</span>
)
diff --git a/desktop-app/ui/src/components/SidebarNav/icons.tsx b/desktop-app/ui/src/components/SidebarNav/icons.tsx
index 054ee7399..60cc3d333 100644
--- a/desktop-app/ui/src/components/SidebarNav/icons.tsx
+++ b/desktop-app/ui/src/components/SidebarNav/icons.tsx
@@ -255,6 +255,16 @@ export function IconMoreHorizontal(props: IconProps) {
)
}
+export function IconMoreVertical(props: IconProps) {
+ return (
+ <svg viewBox="0 0 24 24" aria-hidden="true" {...BASE_STROKE_PROPS} {...props}>
+ <circle cx="12" cy="5" r="1" fill="currentColor" stroke="none" />
+ <circle cx="12" cy="12" r="1" fill="currentColor" stroke="none" />
+ <circle cx="12" cy="19" r="1" fill="currentColor" stroke="none" />
+ </svg>
+ )
+}
+
export function IconGrid(props: IconProps) {
return (
<svg viewBox="0 0 24 24" aria-hidden="true" {...BASE_STROKE_PROPS} {...props}>
diff --git a/desktop-app/ui/src/styles.css b/desktop-app/ui/src/styles.css
index 6f7ce694b..608810a74 100644
--- a/desktop-app/ui/src/styles.css
+++ b/desktop-app/ui/src/styles.css
@@ -14747,16 +14747,48 @@ pre {
right: 0;
z-index: calc(var(--layer-dropdown) + 30);
width: max-content;
- min-width: 180px;
+ min-width: 184px;
+ max-width: min(260px, calc(100vw - var(--space-4)));
display: grid;
gap: var(--space-0-5);
padding: var(--space-1);
- border: 1px solid rgba(var(--edge-rgb), 0.38);
- border-radius: var(--radius-md);
+ border: 1px solid rgba(var(--edge-rgb), 0.46);
+ border-radius: var(--radius-sm);
background: var(--bg-elev-2);
box-shadow: var(--shadow-hard);
}
+.da-gfs-resource-menu__panel .ui-menu-item {
+ min-height: 34px;
+ padding: var(--space-1-5) var(--space-2-5);
+ border-radius: calc(var(--radius-sm) - 2px);
+ color: var(--text);
+ font-size: var(--font-size-md);
+ line-height: var(--line-height-tight);
+}
+
+.da-gfs-resource-menu__panel .ui-menu-item:hover:enabled,
+.da-gfs-resource-menu__panel .ui-menu-item:focus-visible {
+ border-color: transparent;
+ background: var(--surface-hover);
+ color: var(--text);
+}
+
+.da-gfs-resource-menu__panel .ui-menu-item--danger {
+ color: var(--danger);
+}
+
+.da-gfs-resource-menu__panel .ui-menu-item--danger:hover:enabled,
+.da-gfs-resource-menu__panel .ui-menu-item--danger:focus-visible {
+ background: rgba(var(--danger-rgb), 0.12);
+ color: var(--danger);
+}
+
+.da-gfs-drive__grid .da-gfs-resource-menu__panel {
+ top: auto;
+ bottom: calc(100% + var(--space-1));
+}
+
.da-gfs-link-modal {
position: fixed;
inset: 0;