Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(gfs): make absent HTTP status checks CodeQL-safe

Alfredo Lopez3c39a5eb3691
diff --git a/control-ui/lib/gfsFileUpload.ts b/control-ui/lib/gfsFileUpload.ts
index cdad63feb..a841cbe0c 100644
--- a/control-ui/lib/gfsFileUpload.ts
+++ b/control-ui/lib/gfsFileUpload.ts
@@ -303,7 +303,10 @@ function retryAfterOf(error: unknown): number | undefined {
function ambiguousLifecycleError(error: unknown): boolean {
const status = statusOf(error)
- return status === undefined || status === 408 || (status !== undefined && status >= 500)
+ // Transport failures have no HTTP status; keep them ambiguous so completion
+ // reconciles durable state instead of assuming that the request was lost.
+ if (typeof status !== 'number') return true
+ return status === 408 || status >= 500
}
function terminalReconciliationError(error: unknown): boolean {
diff --git a/desktop-app/src/gfs/upload.ts b/desktop-app/src/gfs/upload.ts
index 223156274..9bc2ed225 100644
--- a/desktop-app/src/gfs/upload.ts
+++ b/desktop-app/src/gfs/upload.ts
@@ -293,7 +293,10 @@ function ambiguousLifecycleError(error: unknown): boolean {
error && typeof error === 'object' && typeof (error as { status?: unknown }).status === 'number'
? Number((error as { status: number }).status)
: undefined
- return status === undefined || status === 408 || (status !== undefined && status >= 500)
+ // Transport failures have no HTTP status; keep them ambiguous so completion
+ // reconciles durable state instead of assuming that the request was lost.
+ if (typeof status !== 'number') return true
+ return status === 408 || status >= 500
}
function terminalReconciliationError(error: unknown): boolean {