Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): check connector secret name availability before create

M432459a75c65
diff --git a/control-ui/app/secrets/new/page.tsx b/control-ui/app/secrets/new/page.tsx
index 05403685a..f528fb83b 100644
--- a/control-ui/app/secrets/new/page.tsx
+++ b/control-ui/app/secrets/new/page.tsx
@@ -23,6 +23,7 @@ import {
createRecipeSecret,
getRecipes,
getRegistryCredentialSchema,
+ listMcpSecrets,
} from '@lib/api'
import { isValidDNSSubdomain } from '@lib/k8sValidation'
import { createEmptyLlmKeyDraft, validateLlmSecretData } from '@lib/llm'
@@ -92,6 +93,7 @@ function CreateSecretPageContent() {
const registryEntryVersion =
scope === 'mcp' ? (searchParams.get('registryVersion') ?? '').trim() : ''
const [mcpName, setMcpName] = useState(prefillMcpName)
+ const [mcpNameTaken, setMcpNameTaken] = useState(false)
const [mcpRows, setMcpRows] = useState<CredentialDraftRow[]>(() => [
createSecretDraftRow('mcp-secret-row-0'),
])
@@ -192,9 +194,37 @@ function CreateSecretPageContent() {
return Object.values(llmKeyDraft).some(value => value.trim().length > 0) && !saving
}, [llmKeyDraft, llmName, saving])
+ // Creating a connector secret whose name already exists can only 409 —
+ // the backend refuses duplicates by design. Check the provisioned listing
+ // while the operator types so the wizard never walks them into that wall.
+ useEffect(() => {
+ if (scope !== 'mcp') return
+ const candidate = mcpName.trim()
+ if (!candidate || !MCP_SECRET_NAME_PATTERN.test(candidate)) {
+ setMcpNameTaken(false)
+ return
+ }
+ let cancelled = false
+ const timer = setTimeout(() => {
+ listMcpSecrets()
+ .then(result => {
+ if (cancelled) return
+ setMcpNameTaken((result.items ?? []).some(item => item.name === candidate))
+ })
+ .catch(() => {
+ if (!cancelled) setMcpNameTaken(false)
+ })
+ }, 300)
+ return () => {
+ cancelled = true
+ clearTimeout(timer)
+ }
+ }, [mcpName, scope])
+
const mcpCanSubmit = useMemo(() => {
if (!mcpName.trim()) return false
if (!MCP_SECRET_NAME_PATTERN.test(mcpName.trim()) || mcpName.trim().length > 253) return false
+ if (mcpNameTaken) return false
const hasValues = mcpRows.some(
row => row.secretKey.trim().length > 0 && row.value.trim().length > 0
)
@@ -202,7 +232,7 @@ function CreateSecretPageContent() {
!mcpCredentialSchema?.required ||
areRequiredCredentialRowsComplete(mcpRows, mcpCredentialSchema.keys)
return hasValues && schemaComplete && !saving
- }, [mcpCredentialSchema, mcpName, mcpRows, saving])
+ }, [mcpCredentialSchema, mcpName, mcpNameTaken, mcpRows, saving])
const recipeCanSubmit = useMemo(() => {
if (!recipeName.trim()) return false
@@ -241,6 +271,7 @@ function CreateSecretPageContent() {
step === 0
? activeSecretName.length > 0 &&
activeNameValid &&
+ (scope !== 'mcp' || !mcpNameTaken) &&
(scope !== 'recipe' ||
recipeOwnershipKind === 'shared' ||
recipeOwnerName.trim().length > 0)
@@ -315,6 +346,10 @@ function CreateSecretPageContent() {
}
}
+ function nameTakenMessage(secretName: string): string {
+ return `A connector secret named "${secretName}" already exists. Rotate its values instead of creating it again.`
+ }
+
async function saveMcpSecretResource() {
const secretName = mcpName.trim()
if (!secretName) {
@@ -336,6 +371,18 @@ function CreateSecretPageContent() {
setError('Provide at least one key and value.')
return
}
+ // Re-check at submit: a secret may have been created after the debounced
+ // availability check ran, and POSTing a duplicate can only 409.
+ try {
+ const provisioned = await listMcpSecrets()
+ if ((provisioned.items ?? []).some(item => item.name === secretName)) {
+ setMcpNameTaken(true)
+ setError(nameTakenMessage(secretName))
+ return
+ }
+ } catch {
+ // Availability is advisory; let the create attempt surface real errors.
+ }
setSaving(true)
setError('')
@@ -344,7 +391,8 @@ function CreateSecretPageContent() {
showToast(`Secret ${secretName} created.`, { tone: 'success' })
router.push(secretsListPath)
} catch (saveError) {
- setError(saveError instanceof Error ? saveError.message : 'Failed to create secret')
+ const message = saveError instanceof Error ? saveError.message : 'Failed to create secret'
+ setError(/already exists/i.test(message) ? nameTakenMessage(secretName) : message)
} finally {
setSaving(false)
}
@@ -509,9 +557,11 @@ function CreateSecretPageContent() {
<Field
description="Kubernetes resource name: lowercase alphanumeric and hyphens, max 253 chars."
error={
- activeNameInvalid
- ? 'Name must match the Kubernetes DNS name format.'
- : undefined
+ mcpNameTaken
+ ? `A connector secret named "${mcpName.trim()}" already exists.`
+ : activeNameInvalid
+ ? 'Name must match the Kubernetes DNS name format.'
+ : undefined
}
errorId="mcp-secret-name-error"
htmlFor="mcp-secret-name"
@@ -520,9 +570,11 @@ function CreateSecretPageContent() {
>
<TextInput
id="mcp-secret-name"
- invalid={activeNameInvalid}
- aria-invalid={activeNameInvalid || undefined}
- aria-describedby={activeNameInvalid ? 'mcp-secret-name-error' : undefined}
+ invalid={activeNameInvalid || mcpNameTaken}
+ aria-invalid={activeNameInvalid || mcpNameTaken || undefined}
+ aria-describedby={
+ activeNameInvalid || mcpNameTaken ? 'mcp-secret-name-error' : undefined
+ }
monospace
value={mcpName}
onChange={event => setMcpName(event.target.value)}
@@ -531,6 +583,19 @@ function CreateSecretPageContent() {
autoFocus
/>
</Field>
+ {mcpNameTaken ? (
+ <div>
+ <button
+ type="button"
+ className="cu-btn cu-btn--ghost cu-btn--sm"
+ onClick={() =>
+ router.push(CONTROL_ROUTES.secrets.editConnector(mcpName.trim()))
+ }
+ >
+ Rotate its values instead
+ </button>
+ </div>
+ ) : null}
</div>
) : null}
diff --git a/control-ui/components/__tests__/CreateSecretPage.mcp.test.tsx b/control-ui/components/__tests__/CreateSecretPage.mcp.test.tsx
new file mode 100644
index 000000000..486b26a5d
--- /dev/null
+++ b/control-ui/components/__tests__/CreateSecretPage.mcp.test.tsx
@@ -0,0 +1,108 @@
+import type React from 'react'
+import type { ReactNode } from 'react'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, fireEvent, render as rtlRender, screen, waitFor } from '@testing-library/react'
+import { ToastProvider } from '@components/Toast'
+import { createMcpSecret, listMcpSecrets } from '@lib/api'
+import CreateSecretPage from '../../app/secrets/new/page'
+
+const mockPush = vi.fn()
+let searchParams = new URLSearchParams('scope=mcp')
+
+vi.mock('next/navigation', () => ({
+ useRouter: () => ({
+ push: mockPush,
+ }),
+ useSearchParams: () => searchParams,
+}))
+
+vi.mock('@components/AuthGate', () => ({
+ AuthGate: ({ children }: { children: React.ReactNode }) => <>{children}</>,
+}))
+
+vi.mock('@components/DashboardLayout', () => ({
+ DashboardLayout: ({ children }: { children: React.ReactNode }) => <>{children}</>,
+}))
+
+vi.mock('@lib/api', async () => {
+ const actual = await vi.importActual<typeof import('@lib/api')>('@lib/api')
+ return {
+ ...actual,
+ createMcpSecret: vi.fn(),
+ listMcpSecrets: vi.fn(),
+ }
+})
+
+const mockCreateMcpSecret = vi.mocked(createMcpSecret)
+const mockListMcpSecrets = vi.mocked(listMcpSecrets)
+
+function render(children: ReactNode) {
+ return rtlRender(<ToastProvider>{children}</ToastProvider>)
+}
+
+const secretNameInput = () => screen.getByLabelText(/Secret name\*?/i)
+
+describe('Create connector secret flow — name availability', () => {
+ beforeEach(() => {
+ vi.useRealTimers()
+ mockPush.mockClear()
+ mockCreateMcpSecret.mockReset()
+ mockListMcpSecrets.mockReset()
+ mockListMcpSecrets.mockResolvedValue({ items: [] })
+ searchParams = new URLSearchParams('scope=mcp')
+ })
+
+ afterEach(() => {
+ cleanup()
+ })
+
+ it('flags a name that already exists and offers rotation instead of a doomed create', async () => {
+ mockListMcpSecrets.mockResolvedValue({ items: [{ name: 'dfg', keys: ['api-key'] }] })
+ render(<CreateSecretPage />)
+
+ fireEvent.change(secretNameInput(), { target: { value: 'dfg' } })
+
+ expect(
+ await screen.findByText('A connector secret named "dfg" already exists.')
+ ).toBeInTheDocument()
+ expect(screen.getByRole('button', { name: 'Continue' })).toBeDisabled()
+
+ fireEvent.click(screen.getByRole('button', { name: 'Rotate its values instead' }))
+ expect(mockPush).toHaveBeenCalledWith('/secrets/connector/dfg/edit')
+ expect(mockCreateMcpSecret).not.toHaveBeenCalled()
+ })
+
+ it('keeps the create flow available for a name nothing holds yet', async () => {
+ render(<CreateSecretPage />)
+
+ fireEvent.change(secretNameInput(), { target: { value: 'brand-new-creds' } })
+ fireEvent.click(screen.getByRole('button', { name: 'Continue' }))
+
+ fireEvent.change(screen.getByPlaceholderText('API_KEY'), { target: { value: 'api-key' } })
+ fireEvent.change(screen.getByPlaceholderText('secret value'), { target: { value: 'tok' } })
+ mockCreateMcpSecret.mockResolvedValue({ name: 'brand-new-creds', namespace: 'mcp-server' })
+ fireEvent.click(screen.getByRole('button', { name: 'Create secret' }))
+
+ await waitFor(() => {
+ expect(mockCreateMcpSecret).toHaveBeenCalledWith('brand-new-creds', { 'api-key': 'tok' })
+ })
+ })
+
+ it('refuses at submit when the name was taken after the debounce check', async () => {
+ render(<CreateSecretPage />)
+
+ fireEvent.change(secretNameInput(), { target: { value: 'dfg' } })
+ // Availability check still says free; the secret appears before submit.
+ fireEvent.click(screen.getByRole('button', { name: 'Continue' }))
+ fireEvent.change(screen.getByPlaceholderText('API_KEY'), { target: { value: 'api-key' } })
+ fireEvent.change(screen.getByPlaceholderText('secret value'), { target: { value: 'tok' } })
+
+ mockListMcpSecrets.mockResolvedValue({ items: [{ name: 'dfg', keys: ['api-key'] }] })
+ fireEvent.click(screen.getByRole('button', { name: 'Create secret' }))
+
+ await waitFor(() => {
+ expect(screen.getByText(/already exists\. Rotate its values/i)).toBeInTheDocument()
+ })
+ expect(mockCreateMcpSecret).not.toHaveBeenCalled()
+ })
+})
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 8fea81289..99dd39c39 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.745",
+ "version": "0.1.746",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.745",
+ "version": "0.1.746",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index bc2c54b6a..342a94f15 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.745",
+ "version": "0.1.746",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",