Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
test(control-ui): migrate registry-install e2e to agent-access install flows
Miguelon Peluchon4335547fe064
diff --git a/control-ui/e2e/registry-install.spec.ts b/control-ui/e2e/registry-install.spec.tsindex 02b5ce8b1..7239ee48b 100644--- a/control-ui/e2e/registry-install.spec.ts+++ b/control-ui/e2e/registry-install.spec.ts@@ -553,9 +553,6 @@ async function submitRegistryInstallForm(await installForm.locator('#ri-name').clear()await installForm.locator('#ri-name').fill(serverName)await installForm.getByRole('button', { name: 'Continue' }).click()- await installForm.locator('#ri-context').click()- await installForm.getByRole('option', { name: 'context1', exact: true }).click()- await installForm.getByRole('button', { name: 'Continue' }).click()const credentialInputs = installForm.locator('fieldset input')for (let i = 0; i < (await credentialInputs.count()); i += 1) {await credentialInputs.nth(i).fill('e2e-test-value')@@ -1409,10 +1406,8 @@ test.describe('H. Control-UI Smoke Tests', () => {await nameInput.clear()await nameInput.fill(serverName)- // Advance through Context to Credentials and fill fields if present.- await installForm.getByRole('button', { name: 'Continue' }).click()- await installForm.locator('#ri-context').click()- await installForm.getByRole('option', { name: 'context1', exact: true }).click()+ // Advance to Credentials and fill fields if present. The access scope is+ // provisioned silently by the app; no context selection exists anymore.await installForm.getByRole('button', { name: 'Continue' }).click()const credFieldset = installForm.locator('fieldset')if ((await credFieldset.count()) > 0) {@@ -1771,14 +1766,9 @@ test.describe('J. Operator Egress Editor Journeys', () => {await page.getByPlaceholder('us-central1-docker.pkg.dev/my-project/repo/mcp-server:latest').fill('clerum/mock-mcp-server:test')- await expect(page.getByRole('button', { name: 'context1' })).toBeVisible({- timeout: 15_000,- })- await page.getByRole('button', { name: 'Continue' }).click()- await expect(page.getByRole('heading', { name: 'Runtime settings' })).toBeVisible()- await page.getByRole('button', { name: 'Continue' }).click()- await expect(page.getByRole('heading', { name: 'Network egress' })).toBeVisible()+ // Egress lives in the Advanced options disclosure on the Connector step.+ await page.getByText('Advanced options').click()const egressSection = page.locator('section', { hasText: 'External Egress' })await egressSection.locator('select').first().selectOption('exact-host')await egressSection@@ -1787,13 +1777,18 @@ test.describe('J. Operator Egress Editor Journeys', () => {await egressSection.locator('input[placeholder="443"]').fill('443')await expect(egressSection.getByRole('status')).toContainText('1 domain(s) x 1 port(s)')+ // The Access step is optional (no agents required) — continue through it.+ await page.getByRole('button', { name: 'Continue' }).click()+ await expect(page.getByRole('heading', { name: 'Agent access' })).toBeVisible()+ await page.getByRole('button', { name: 'Continue' }).click()+ await expect(page.getByRole('heading', { name: 'Secrets and environment' })).toBeVisible()+const createResponse = page.waitForResponse(response =>response.url().includes('/admin/mcp-servers') && response.request().method() === 'POST',{ timeout: 30_000 })- await page.getByRole('button', { name: 'Continue' }).click()- await expect(page.getByRole('heading', { name: 'Secrets and environment' })).toBeVisible()+ await page.getByRole('radio', { name: 'No credentials required' }).check()await page.getByRole('button', { name: 'Create connector' }).click()expect((await createResponse).status()).toBe(201)await expect(page).toHaveURL(/\/mcp-servers$/)@@ -1828,26 +1823,26 @@ test.describe('J. Operator Egress Editor Journeys', () => {await page.getByPlaceholder('us-central1-docker.pkg.dev/my-project/repo/mcp-server:latest').fill('clerum/mock-mcp-server:test')- await expect(page.getByRole('button', { name: 'context1' })).toBeVisible({- timeout: 15_000,- })- await page.getByRole('button', { name: 'Continue' }).click()- await expect(page.getByRole('heading', { name: 'Runtime settings' })).toBeVisible()- await page.getByRole('button', { name: 'Continue' }).click()- await expect(page.getByRole('heading', { name: 'Network egress' })).toBeVisible()+ // Egress lives in the Advanced options disclosure on the Connector step.+ await page.getByText('Advanced options').click()const egressSection = page.locator('section', { hasText: 'External Egress' })await egressSection.locator('select').first().selectOption('public-web')await expect(egressSection.getByRole('alert')).toContainText('Public web egress allows')await expect(egressSection.getByRole('status')).toContainText('1 public-web binding')+ // The Access step is optional (no agents required) — continue through it.+ await page.getByRole('button', { name: 'Continue' }).click()+ await expect(page.getByRole('heading', { name: 'Agent access' })).toBeVisible()+ await page.getByRole('button', { name: 'Continue' }).click()+ await expect(page.getByRole('heading', { name: 'Secrets and environment' })).toBeVisible()+const createResponse = page.waitForResponse(response =>response.url().includes('/admin/mcp-servers') && response.request().method() === 'POST',{ timeout: 30_000 })- await page.getByRole('button', { name: 'Continue' }).click()- await expect(page.getByRole('heading', { name: 'Secrets and environment' })).toBeVisible()+ await page.getByRole('radio', { name: 'No credentials required' }).check()await page.getByRole('button', { name: 'Create connector' }).click()expect((await createResponse).status()).toBe(201)await expect(page).toHaveURL(/\/mcp-servers$/)@@ -2169,9 +2164,6 @@ test.describe('J. Operator Egress Editor Journeys', () => {await expect(installForm.locator('#ri-name')).toBeVisible({ timeout: 10_000 })await installForm.locator('#ri-name').fill(deferredMcpServerName)await installForm.getByRole('button', { name: 'Continue' }).click()- await installForm.locator('#ri-context').click()- await installForm.getByRole('option', { name: 'context1', exact: true }).click()- await installForm.getByRole('button', { name: 'Continue' }).click()await expect(installForm.getByText(/Leave all credential fields empty to install now/)).toBeVisible()diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 96ceb6eb7..4f486ae9d 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.462",+ "version": "0.1.463","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.462",+ "version": "0.1.463","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/llm-providers": "file:../packages/llm-providers",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 3c4d24ff2..72b9a4ca7 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.462",+ "version": "0.1.463","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",diff --git a/docs/features/control-ui-context-removal.md b/docs/features/control-ui-context-removal.mdindex 2c124d0e4..5a2c75471 100644--- a/docs/features/control-ui-context-removal.md+++ b/docs/features/control-ui-context-removal.md@@ -196,6 +196,7 @@ Tests updated in the same commit: `HostTable.test.tsx` (hover card now asserts a| 2026-08-26 | 2 | Category C implemented. Member + team detail "Contexts" tabs → route `access` / label **"Access"**; rows show resolved labels (owning agent name(s) → context `displayName` → muted raw id), no `/contexts` links; confirm/toast/error copy reworded ("Access updated.", "Removed access"); add-modal relabeled with resolved-label picker, writing context IDs unchanged. Team wizard step "Contexts" → **"Access"**. Legacy `ProfileAdminPanel.tsx` deleted (zero importers). `ProfileAdminHome` "Contexts" column → **"Access"** (same sort/count source). Redirects for `/users-and-teams/{users,teams}/:id/contexts` → `…/access`. No backend changes (GET/PUT `/admin/{users,teams}/:id/contexts` payloads byte-identical). || 2026-08-26 | 3 | Category A implemented + e2e migration for phases 0–3. Deleted: `/contexts` pages (`page`, `new`, `[name]`, `[name]/[tab]`), `components/ContextTable.tsx`, sidebar item/type/order, `DashboardLayout` branch, `CONTROL_ROUTES.contexts` builders, `createFlowLoading.createContext`, stale `/contexts/:name/shared-files` redirect. Added `app/contexts/[[...slug]]/page.tsx` legacy resolver (slug → owning agent's Connectors tab via `spec.contextRef` join; unknown/`new`/failures → `/agents`). Tests: contexts suites + `ContextTable.test.tsx` deleted; **spec-preservation contract re-homed** to `HostDetailsPage.connectors.test.tsx` (unknown `spec.gfs` + `resourceVersion` survive agent-side connector PUTs); RFC1123 generation stays covered by `lib/__tests__/agentContext.test.ts`; `Sidebar.test.tsx` order, `AuthContext.test.tsx` URL fixture updated. E2e: main `contexts.spec.ts` rewritten as redirect/no-sidebar regression; `auth.spec.ts`, `channels.spec.ts`, `mcp-servers.spec.ts`, `helpers/selectors.ts` cleaned. QA-recorder: 4 context specs deleted + their npm scripts; connector-edit/navigation/onboarding-combo/team-create/create-form-smoke/connectors/shared-fs-upload migrated to agent-access flows (API-created contexts where a context fixture is needed). Full vitest + `tsc` green. No backend changes. || 2026-08-26 | 4 | Category D + close-out. SFS list column → "Mounted by" with mount refs resolved to owning agent names (failure-tolerant hosts/contexts enrichment); SFS create subtitle + loading-skeleton copy reworded; SFS detail chip "not mounted by any agent" / "mounted by <agents>" (invisible scopes don't count); recipe editor L1 banner speaks "shared connector scope" (JSON keys untouched); workflow-run infra error → "connector access"; workflow access panel description reworded; dead `ResourceTable.tsx` deleted. New shared `lib/accessScopeLabels.ts` (scope id → agent/display label join) now backs users/teams Access tabs and SFS surfaces. Residual sweep: missed "Contexts:" meta line on connector egress tab removed; `createFlowLoading` SFS copy fixed; verified remaining "context" strings are all §3 exclusions (LLM prompt "User context", guardrail `may_add context`, service name `host-context-controller`, internal identifiers). **Verification:** full vitest 1700/1700, `tsc --noEmit` clean, `next build` compiles with `/contexts/[[...slug]]` as the only contexts route. No backend changes. |+| 2026-08-26 | 4 | Product e2e `control-ui/e2e/registry-install.spec.ts` migrated: install flows drop the removed Context step (one fewer Continue; access scope is provisioned silently); J1 manual-create flows rewritten to the current form (egress via "Advanced options" disclosure on the Connector step, optional Access step passed through, "No credentials required" radio before submit). API-level sections (contextRef payloads, context1 allowlist assertions) intentionally unchanged — the backend contract is untouched. Full vitest 1700/1700 + `tsc` green after migration. |## 11. Open questions / follow-ups (non-blocking)