Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(desktop): r7-l16 stop entity streams on renderer reload
Josué4698a9ccdee3
diff --git a/desktop-app/src/__tests__/ipc.entityChanges.test.ts b/desktop-app/src/__tests__/ipc.entityChanges.test.tsnew file mode 100644index 000000000..9c1981c42--- /dev/null+++ b/desktop-app/src/__tests__/ipc.entityChanges.test.ts@@ -0,0 +1,61 @@+import { beforeAll, describe, expect, it, vi } from 'vitest'+import { EventEmitter } from 'node:events'+import type { AppService } from '../appService.js'++type Handler = (event: unknown, payload?: unknown) => Promise<unknown>++const electron = vi.hoisted(() => ({ handlers: new Map<string, Handler>() }))++vi.mock('electron', () => ({+ BrowserWindow: { fromWebContents: vi.fn(), getAllWindows: vi.fn(() => []) },+ Notification: vi.fn(),+ app: { on: vi.fn(), getPath: vi.fn(), getVersion: vi.fn() },+ clipboard: { writeText: vi.fn() },+ dialog: { showSaveDialog: vi.fn() },+ ipcMain: {+ handle: vi.fn((channel: string, handler: Handler) => {+ electron.handlers.set(channel, handler)+ }),+ on: vi.fn(),+ removeHandler: vi.fn(),+ },+}))+vi.mock('../appService.js', () => ({ AppService: class {} }))++const service = {+ startEntityChangeStream: vi.fn(),+ stopEntityChangeStreamsForOwner: vi.fn(),+}++function entityChangesStartHandler(): Handler {+ const registered = electron.handlers.get('entityChanges:streamStart')+ if (!registered) throw new Error('no IPC handler registered for entityChanges:streamStart')+ return registered+}++beforeAll(async () => {+ const { registerIpcHandlers } = await import('../ipc.js')+ registerIpcHandlers(service as unknown as AppService)+})++describe('entityChanges:streamStart renderer lifecycle', () => {+ it('releases subscribers on main-frame reload and permits the new renderer to resubscribe', async () => {+ const sender = Object.assign(new EventEmitter(), { id: 71, send: vi.fn() })+ const event = { sender, senderFrame: { url: 'file:///app/index.html' } }++ await entityChangesStartHandler()(event)+ expect(service.startEntityChangeStream).toHaveBeenCalledTimes(1)++ sender.emit('did-start-navigation', {}, 'file:///app/child', false, false)+ expect(service.stopEntityChangeStreamsForOwner).not.toHaveBeenCalled()++ sender.emit('did-start-navigation', {}, 'file:///app/index.html', false, true)+ expect(service.stopEntityChangeStreamsForOwner).toHaveBeenCalledTimes(1)+ expect(service.stopEntityChangeStreamsForOwner).toHaveBeenCalledWith(71)++ await entityChangesStartHandler()(event)+ expect(service.startEntityChangeStream).toHaveBeenCalledTimes(2)+ sender.emit('destroyed')+ expect(service.stopEntityChangeStreamsForOwner).toHaveBeenCalledTimes(2)+ })+})diff --git a/desktop-app/src/ipc.ts b/desktop-app/src/ipc.tsindex d1a7c1976..57a72c40f 100644--- a/desktop-app/src/ipc.ts+++ b/desktop-app/src/ipc.ts@@ -837,10 +837,28 @@ export function registerIpcHandlers(service: AppService): void {})if (!entityChangeOwnerCleanupRegistered.has(ownerId)) {entityChangeOwnerCleanupRegistered.add(ownerId)- event.sender.once('destroyed', () => {+ let cleanedUp = false+ const cleanup = () => {+ if (cleanedUp) return+ cleanedUp = trueservice.stopEntityChangeStreamsForOwner(ownerId)entityChangeOwnerCleanupRegistered.delete(ownerId)- })+ event.sender.removeListener('did-start-navigation', onMainFrameNavigation)+ event.sender.removeListener('render-process-gone', onRendererProcessGone)+ event.sender.removeListener('destroyed', cleanup)+ }+ const onMainFrameNavigation = (+ _navigationEvent: Electron.Event,+ _navigationUrl: string,+ _isInPlace: boolean,+ isMainFrame: boolean+ ) => {+ if (isMainFrame) cleanup()+ }+ const onRendererProcessGone = (_event: Electron.Event) => cleanup()+ event.sender.on('did-start-navigation', onMainFrameNavigation)+ event.sender.on('render-process-gone', onRendererProcessGone)+ event.sender.once('destroyed', cleanup)}return { streamId }})