Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend): r1-m2 keep table states in semantic rows

Josué47d81e469979
diff --git a/control-ui/app/shared-filesystems/page.tsx b/control-ui/app/shared-filesystems/page.tsx
index 1055406d7..2ff4eef0e 100644
--- a/control-ui/app/shared-filesystems/page.tsx
+++ b/control-ui/app/shared-filesystems/page.tsx
@@ -2,11 +2,15 @@
import React, { useCallback, useEffect, useRef, useState } from 'react'
import { useRouter } from 'next/navigation'
-import { DataTable, RowActionMenu, useTableSort } from '@clerum/frontend-table-system'
+import {
+ DataTable,
+ RowActionMenu,
+ TableStateRow,
+ useTableSort,
+} from '@clerum/frontend-table-system'
import { DashboardLayout } from '@components/DashboardLayout'
import { SectionSearchInput } from '@components/SectionSearchInput'
import { IconSharedFiles } from '@components/Sidebar/icons'
-import { SkeletonTableRows } from '@components/SkeletonTableRows'
import { TableHeaderRow } from '@components/TableHeaderRow'
import type { TableHeaderColumn } from '@components/TableHeaderRow/types'
import { TablePanelHeader } from '@components/TablePanelHeader'
@@ -230,100 +234,105 @@ export default function SharedFileSystemsPage() {
</div>
) : null}
- {filteredItems.length === 0 && !loading ? (
- <div className="cu-card__body">
- <div className="cu-empty">
- {normalizedSearch ? (
- 'No shared files match this search.'
+ <div className="eft-table-viewport cu-table-wrap">
+ <DataTable className="eft-table cu-table cu-table--header-band">
+ <thead>
+ <TableHeaderRow columns={columns} />
+ </thead>
+ <tbody>
+ {isInitialLoad ? (
+ <TableStateRow
+ colSpan={columns.length}
+ kind="loading"
+ message="Loading agent files…"
+ />
+ ) : error && fileSystemSort.sortedRows.length === 0 ? (
+ <TableStateRow colSpan={columns.length} kind="error" message={error} />
+ ) : filteredItems.length === 0 ? (
+ <TableStateRow
+ colSpan={columns.length}
+ message={
+ normalizedSearch ? (
+ 'No shared files match this search.'
+ ) : (
+ <>
+ No SharedFileSystems yet. Click <strong>New</strong> to create one
+ </>
+ )
+ }
+ />
) : (
- <>
- No SharedFileSystems yet. Click <strong>New</strong> to create one
- </>
+ fileSystemSort.sortedRows.map(item => {
+ const name = item.metadata?.name || ''
+ const isDeleting = deletingNames.has(name)
+ const status = item.status || {}
+ const mountedBy = status.mountedByContexts || []
+ const phase = status.phase || 'Unknown'
+ const phaseClass =
+ phase === 'Ready'
+ ? 'cu-badge cu-badge--ok'
+ : phase === 'Failed' || phase === 'Degraded'
+ ? 'cu-badge cu-badge--error'
+ : 'cu-badge'
+ return (
+ <tr
+ key={name}
+ className="cu-table__row cu-table__row--clickable"
+ onClick={() => {
+ if (!isDeleting) {
+ router.push(CONTROL_ROUTES.agentFiles.detail(name))
+ }
+ }}
+ onKeyDown={e => {
+ if (isDeleting) return
+ if (e.key === 'Enter' || e.key === ' ') {
+ e.preventDefault()
+ router.push(CONTROL_ROUTES.agentFiles.detail(name))
+ }
+ }}
+ tabIndex={0}
+ role="link"
+ aria-label={`Open shared filesystem ${name}`}
+ >
+ <td>
+ <span className="cu-link">{name}</span>
+ </td>
+ <td>
+ <span className={phaseClass}>{phase}</span>
+ </td>
+ <td>{status.capacity || item.spec?.size || '—'}</td>
+ <td>{status.storageClassName || item.spec?.storageClassName || '—'}</td>
+ <td>
+ {mountedBy.length === 0
+ ? '—'
+ : mountedBy.map(c => `${c.namespace}/${c.name}`).join(', ')}
+ </td>
+ <td style={{ textAlign: 'right' }} onClick={e => e.stopPropagation()}>
+ <RowActionMenu
+ ariaLabel={`Actions for shared filesystem ${name}`}
+ actions={[
+ {
+ key: 'view',
+ label: 'View details',
+ onSelect: () => router.push(CONTROL_ROUTES.agentFiles.detail(name)),
+ },
+ {
+ key: 'delete',
+ label: isDeleting ? 'Deleting…' : 'Delete',
+ danger: true,
+ disabled: isDeleting,
+ onSelect: () => setDeleteTarget(name),
+ },
+ ]}
+ />
+ </td>
+ </tr>
+ )
+ })
)}
- </div>
- </div>
- ) : (
- <div className="eft-table-viewport cu-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band">
- <thead>
- <TableHeaderRow columns={columns} />
- </thead>
- <tbody>
- {isInitialLoad ? (
- <SkeletonTableRows columns={columns.length} rows={5} />
- ) : (
- fileSystemSort.sortedRows.map(item => {
- const name = item.metadata?.name || ''
- const isDeleting = deletingNames.has(name)
- const status = item.status || {}
- const mountedBy = status.mountedByContexts || []
- const phase = status.phase || 'Unknown'
- const phaseClass =
- phase === 'Ready'
- ? 'cu-badge cu-badge--ok'
- : phase === 'Failed' || phase === 'Degraded'
- ? 'cu-badge cu-badge--error'
- : 'cu-badge'
- return (
- <tr
- key={name}
- className="cu-table__row cu-table__row--clickable"
- onClick={() => {
- if (!isDeleting) {
- router.push(CONTROL_ROUTES.agentFiles.detail(name))
- }
- }}
- onKeyDown={e => {
- if (isDeleting) return
- if (e.key === 'Enter' || e.key === ' ') {
- e.preventDefault()
- router.push(CONTROL_ROUTES.agentFiles.detail(name))
- }
- }}
- tabIndex={0}
- role="link"
- aria-label={`Open shared filesystem ${name}`}
- >
- <td>
- <span className="cu-link">{name}</span>
- </td>
- <td>
- <span className={phaseClass}>{phase}</span>
- </td>
- <td>{status.capacity || item.spec?.size || '—'}</td>
- <td>{status.storageClassName || item.spec?.storageClassName || '—'}</td>
- <td>
- {mountedBy.length === 0
- ? '—'
- : mountedBy.map(c => `${c.namespace}/${c.name}`).join(', ')}
- </td>
- <td style={{ textAlign: 'right' }} onClick={e => e.stopPropagation()}>
- <RowActionMenu
- ariaLabel={`Actions for shared filesystem ${name}`}
- actions={[
- {
- key: 'view',
- label: 'View details',
- onSelect: () => router.push(CONTROL_ROUTES.agentFiles.detail(name)),
- },
- {
- key: 'delete',
- label: isDeleting ? 'Deleting…' : 'Delete',
- danger: true,
- disabled: isDeleting,
- onSelect: () => setDeleteTarget(name),
- },
- ]}
- />
- </td>
- </tr>
- )
- })
- )}
- </tbody>
- </DataTable>
- </div>
- )}
+ </tbody>
+ </DataTable>
+ </div>
</div>
{deleteTarget ? (
diff --git a/control-ui/components/GuardrailHooksTable.tsx b/control-ui/components/GuardrailHooksTable.tsx
index 1b153de6f..66e4ba2dc 100644
--- a/control-ui/components/GuardrailHooksTable.tsx
+++ b/control-ui/components/GuardrailHooksTable.tsx
@@ -2,7 +2,7 @@
import React, { useMemo, useState } from 'react'
import { useRouter } from 'next/navigation'
-import { DataTable, useTableSort } from '@clerum/frontend-table-system'
+import { DataTable, TableStateRow, useTableSort } from '@clerum/frontend-table-system'
import { RowActionsMenu } from '@components/RowActionsMenu'
import { CONTROL_ROUTES } from '@constants/routes'
import type { LlmHookStatus } from '../lib/api'
@@ -13,7 +13,6 @@ import type {
} from './GuardrailHooksTable.types'
import { SectionSearchInput } from './SectionSearchInput'
import { IconShield } from './Sidebar/icons'
-import { SkeletonTableRows } from './SkeletonTableRows'
import { TableHeaderRow } from './TableHeaderRow'
import type { TableHeaderColumn } from './TableHeaderRow/types'
import { TablePanelHeader } from './TablePanelHeader'
@@ -204,29 +203,27 @@ export function GuardrailHooksTable({
</>
}
/>
- {isInitialLoad ? (
- <div className="eft-table-viewport cu-table-wrap cu-guardrails-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-guardrails-table">
- <thead>
- <TableHeaderRow columns={columns} />
- </thead>
- <tbody>
- <SkeletonTableRows columns={columns.length} rows={5} />
- </tbody>
- </DataTable>
- </div>
- ) : filteredRows.length === 0 ? (
- <div className="cu-empty">
- {normalizedSearch ? 'No guardrails match this search.' : 'No guardrails installed.'}
- </div>
- ) : (
- <div className="eft-table-viewport cu-table-wrap cu-guardrails-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-guardrails-table">
- <thead>
- <TableHeaderRow columns={columns} />
- </thead>
- <tbody>
- {hookSort.sortedRows.map(({ key, name, item }) => {
+ <div className="eft-table-viewport cu-table-wrap cu-guardrails-table-wrap">
+ <DataTable className="eft-table cu-table cu-table--header-band cu-guardrails-table">
+ <thead>
+ <TableHeaderRow columns={columns} />
+ </thead>
+ <tbody>
+ {isInitialLoad ? (
+ <TableStateRow
+ colSpan={columns.length}
+ kind="loading"
+ message="Loading guardrails…"
+ />
+ ) : filteredRows.length === 0 ? (
+ <TableStateRow
+ colSpan={columns.length}
+ message={
+ normalizedSearch ? 'No guardrails match this search.' : 'No guardrails installed.'
+ }
+ />
+ ) : (
+ hookSort.sortedRows.map(({ key, name, item }) => {
const spec = (item.spec || {}) as LlmHookSpecView
const lifecycle = (spec.lifecyclePoints || []).join(', ')
return (
@@ -286,11 +283,11 @@ export function GuardrailHooksTable({
</td>
</tr>
)
- })}
- </tbody>
- </DataTable>
- </div>
- )}
+ })
+ )}
+ </tbody>
+ </DataTable>
+ </div>
</div>
)
}
diff --git a/control-ui/components/McpServerTable.tsx b/control-ui/components/McpServerTable.tsx
index cf7b064b9..b2766b947 100644
--- a/control-ui/components/McpServerTable.tsx
+++ b/control-ui/components/McpServerTable.tsx
@@ -1,7 +1,7 @@
'use client'
import React, { useMemo, useState } from 'react'
-import { DataTable } from '@clerum/frontend-table-system'
+import { DataTable, TableStateRow } from '@clerum/frontend-table-system'
import { copyTextToClipboard } from '@lib/clipboard'
import type {
ConnectorAccessSummary,
@@ -13,7 +13,6 @@ import { RowActionsMenu } from './RowActionsMenu'
import { SectionSearchInput } from './SectionSearchInput'
import { SelectionDropdown } from './SelectionDropdown'
import { IconCable } from './Sidebar/icons'
-import { SkeletonTableRows } from './SkeletonTableRows'
import { TableHeaderRow } from './TableHeaderRow'
import type { TableHeaderColumn } from './TableHeaderRow/types'
import { TablePanelHeader } from './TablePanelHeader'
@@ -411,29 +410,27 @@ export function McpServerTable({
}
/>
{detailContent ? <div className="cu-card__body">{detailContent}</div> : null}
- {isInitialLoad ? (
- <div className="eft-table-viewport cu-table-wrap cu-connectors-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-connectors-table">
- <thead>
- <TableHeaderRow columns={columns} />
- </thead>
- <tbody>
- <SkeletonTableRows columns={columns.length} rows={5} />
- </tbody>
- </DataTable>
- </div>
- ) : filteredRows.length === 0 ? (
- <div className="cu-empty">
- {normalizedSearch ? 'No connectors match this search.' : 'No connectors found.'}
- </div>
- ) : (
- <div className="eft-table-viewport cu-table-wrap cu-connectors-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-connectors-table">
- <thead>
- <TableHeaderRow columns={columns} />
- </thead>
- <tbody>
- {filteredRows.map(({ key, namespace, name, item }) => {
+ <div className="eft-table-viewport cu-table-wrap cu-connectors-table-wrap">
+ <DataTable className="eft-table cu-table cu-table--header-band cu-connectors-table">
+ <thead>
+ <TableHeaderRow columns={columns} />
+ </thead>
+ <tbody>
+ {isInitialLoad ? (
+ <TableStateRow
+ colSpan={columns.length}
+ kind="loading"
+ message="Loading connectors…"
+ />
+ ) : filteredRows.length === 0 ? (
+ <TableStateRow
+ colSpan={columns.length}
+ message={
+ normalizedSearch ? 'No connectors match this search.' : 'No connectors found.'
+ }
+ />
+ ) : (
+ filteredRows.map(({ key, namespace, name, item }) => {
const spec = item.spec || {}
const assignedContexts = contextsForConnector(name)
const contextMembershipBusy = updatingContextMembershipKey === key
@@ -562,11 +559,11 @@ export function McpServerTable({
</td>
</tr>
)
- })}
- </tbody>
- </DataTable>
- </div>
- )}
+ })
+ )}
+ </tbody>
+ </DataTable>
+ </div>
{serverKeyAddingContexts
? (() => {
const row = rows.find(candidate => candidate.key === serverKeyAddingContexts)
diff --git a/control-ui/components/RecipesTab.tsx b/control-ui/components/RecipesTab.tsx
index d39463250..c3fbd291d 100644
--- a/control-ui/components/RecipesTab.tsx
+++ b/control-ui/components/RecipesTab.tsx
@@ -2,14 +2,13 @@
import { useMemo, useState } from 'react'
import { useRouter } from 'next/navigation'
-import { DataTable, useTableSort } from '@clerum/frontend-table-system'
+import { DataTable, TableStateRow, useTableSort } from '@clerum/frontend-table-system'
import { CONTROL_ROUTES } from '@constants/routes'
import { DEFAULT_WORKFLOW_RECIPE_NAMESPACE } from '@constants/workflowRecipes'
import type { WorkflowRecipeResource } from '../lib/api'
import { PluginsEmptyState } from './PluginsEmptyState'
import { SectionSearchInput } from './SectionSearchInput'
import { IconWorkflow } from './Sidebar/icons'
-import { SkeletonTableRows } from './SkeletonTableRows'
import { TableHeaderRow } from './TableHeaderRow'
import type { TableHeaderColumn } from './TableHeaderRow/types'
import { TablePanelHeader } from './TablePanelHeader'
@@ -128,29 +127,23 @@ export function RecipesTab({ items, loading, error, onInstall, onRefresh }: Prop
/>
{error ? <div className="cu-banner cu-banner--error cu-table-error">{error}</div> : null}
- {isInitialLoad ? (
- <div className="eft-table-viewport cu-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-installed-plugins-table">
- <thead>
- <TableHeaderRow columns={columns} />
- </thead>
- <tbody>
- <SkeletonTableRows columns={columns.length} rows={4} />
- </tbody>
- </DataTable>
- </div>
- ) : filteredItems.length === 0 ? (
- <div className="cu-empty">
- {normalizedSearch ? 'No plugins match this search.' : <PluginsEmptyState />}
- </div>
- ) : (
- <div className="eft-table-viewport cu-table-wrap">
- <DataTable className="eft-table cu-table cu-table--header-band cu-installed-plugins-table">
- <thead>
- <TableHeaderRow columns={columns} />
- </thead>
- <tbody>
- {recipeSort.sortedRows.map(item => {
+ <div className="eft-table-viewport cu-table-wrap">
+ <DataTable className="eft-table cu-table cu-table--header-band cu-installed-plugins-table">
+ <thead>
+ <TableHeaderRow columns={columns} />
+ </thead>
+ <tbody>
+ {isInitialLoad ? (
+ <TableStateRow colSpan={columns.length} kind="loading" message="Loading plugins…" />
+ ) : error && recipeSort.sortedRows.length === 0 ? (
+ <TableStateRow colSpan={columns.length} kind="error" message={error} />
+ ) : filteredItems.length === 0 ? (
+ <TableStateRow
+ colSpan={columns.length}
+ message={normalizedSearch ? 'No plugins match this search.' : <PluginsEmptyState />}
+ />
+ ) : (
+ recipeSort.sortedRows.map(item => {
const name = item.metadata?.name ?? '(unnamed)'
const namespace = item.metadata?.namespace ?? DEFAULT_WORKFLOW_RECIPE_NAMESPACE
const key = `${namespace}/${name}`
@@ -187,11 +180,11 @@ export function RecipesTab({ items, loading, error, onInstall, onRefresh }: Prop
<td className="cu-installed-plugin__created">{created}</td>
</tr>
)
- })}
- </tbody>
- </DataTable>
- </div>
- )}
+ })
+ )}
+ </tbody>
+ </DataTable>
+ </div>
</div>
)
}
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index baecef5b5..24615ea4a 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.484",
+ "version": "0.1.485",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.484",
+ "version": "0.1.485",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-table-system": "file:../packages/frontend-table-system",
diff --git a/control-ui/package.json b/control-ui/package.json
index f47200c93..c9e857936 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.484",
+ "version": "0.1.485",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",
diff --git a/profile-ui/app/members/page.tsx b/profile-ui/app/members/page.tsx
index 0218cca51..83aeb3b5a 100644
--- a/profile-ui/app/members/page.tsx
+++ b/profile-ui/app/members/page.tsx
@@ -6,6 +6,7 @@ import {
DataTable,
RowActionMenu,
TableHeaderCell,
+ TableStateRow,
useTableSort,
} from '@clerum/frontend-table-system'
import { useAuth } from '@components/AuthContext'
@@ -13,7 +14,6 @@ import { AuthGate } from '@components/AuthGate'
import { Button } from '@components/Button'
import { useConfirmDialog } from '@components/ConfirmDialog'
import { useProfileAccess } from '@components/ProfileAccessContext'
-import { ProfileBodySkeleton } from '@components/ProfileBodySkeleton'
import { ProfileShell } from '@components/ProfileShell'
import { useToast } from '@components/Toast'
import { IconAlertTriangle, IconRefresh, IconTrash } from '@components/icons'
@@ -171,15 +171,6 @@ export default function MembersPage() {
</div>
</header>
- {state === 'loading' ? (
- <ProfileBodySkeleton
- label="Loading members"
- sections={[
- { title: 'Pending invitations', rows: 2 },
- { title: 'Members', rows: 4 },
- ]}
- />
- ) : null}
{error ? <div className="message message--error">{error}</div> : null}
{state !== 'loading' && manageableTeams.length === 0 ? (
@@ -188,43 +179,49 @@ export default function MembersPage() {
</div>
) : null}
- {state === 'ready' && invitations.length > 0 ? (
- <section className="section members-section">
- <div className="settings-section-head">
- <div>
- <h2 className="section-title">Pending invitations</h2>
- </div>
+ <section className="section members-section">
+ <div className="settings-section-head">
+ <div>
+ <h2 className="section-title">Pending invitations</h2>
</div>
- <div className="eft-table-viewport">
- <DataTable className="eft-table eft-table--wide">
- <thead>
- <tr>
- <TableHeaderCell
- activeDirection={
- invitationSort.key === 'email' ? invitationSort.direction : null
- }
- label="Email"
- onSort={() => invitationSort.sortBy('email')}
- />
- <TableHeaderCell
- activeDirection={
- invitationSort.key === 'teams' ? invitationSort.direction : null
- }
- label="Teams"
- onSort={() => invitationSort.sortBy('teams')}
- />
- <TableHeaderCell
- activeDirection={
- invitationSort.key === 'expires' ? invitationSort.direction : null
- }
- label="Expires"
- onSort={() => invitationSort.sortBy('expires')}
- />
- <th></th>
- </tr>
- </thead>
- <tbody>
- {invitationSort.sortedRows.map(invitation => (
+ </div>
+ <div className="eft-table-viewport">
+ <DataTable className="eft-table eft-table--wide">
+ <thead>
+ <tr>
+ <TableHeaderCell
+ activeDirection={
+ invitationSort.key === 'email' ? invitationSort.direction : null
+ }
+ label="Email"
+ onSort={() => invitationSort.sortBy('email')}
+ />
+ <TableHeaderCell
+ activeDirection={
+ invitationSort.key === 'teams' ? invitationSort.direction : null
+ }
+ label="Teams"
+ onSort={() => invitationSort.sortBy('teams')}
+ />
+ <TableHeaderCell
+ activeDirection={
+ invitationSort.key === 'expires' ? invitationSort.direction : null
+ }
+ label="Expires"
+ onSort={() => invitationSort.sortBy('expires')}
+ />
+ <th></th>
+ </tr>
+ </thead>
+ <tbody>
+ {state === 'loading' ? (
+ <TableStateRow colSpan={4} kind="loading" message="Loading invitations…" />
+ ) : state === 'error' ? (
+ <TableStateRow colSpan={4} kind="error" message="Invitations unavailable." />
+ ) : invitationSort.sortedRows.length === 0 ? (
+ <TableStateRow colSpan={4} message="No pending invitations." />
+ ) : (
+ invitationSort.sortedRows.map(invitation => (
<tr key={invitation.id}>
<td>{invitation.email}</td>
<td>{invitation.teams.map(team => team.name).join(', ')}</td>
@@ -250,39 +247,45 @@ export default function MembersPage() {
/>
</td>
</tr>
- ))}
- </tbody>
- </DataTable>
- </div>
- </section>
- ) : null}
+ ))
+ )}
+ </tbody>
+ </DataTable>
+ </div>
+ </section>
- {state !== 'loading' ? (
- <section className="section members-section">
- <div className="eft-table-viewport">
- <DataTable className="eft-table eft-table--wide">
- <thead>
- <tr>
- <TableHeaderCell
- activeDirection={memberSort.key === 'name' ? memberSort.direction : null}
- label="Member"
- onSort={() => memberSort.sortBy('name')}
- />
- <TableHeaderCell
- activeDirection={memberSort.key === 'email' ? memberSort.direction : null}
- label="Email"
- onSort={() => memberSort.sortBy('email')}
- />
- <TableHeaderCell
- activeDirection={memberSort.key === 'teams' ? memberSort.direction : null}
- label="Teams"
- onSort={() => memberSort.sortBy('teams')}
- />
- <th></th>
- </tr>
- </thead>
- <tbody>
- {memberSort.sortedRows.map(member => {
+ <section className="section members-section">
+ <div className="eft-table-viewport">
+ <DataTable className="eft-table eft-table--wide">
+ <thead>
+ <tr>
+ <TableHeaderCell
+ activeDirection={memberSort.key === 'name' ? memberSort.direction : null}
+ label="Member"
+ onSort={() => memberSort.sortBy('name')}
+ />
+ <TableHeaderCell
+ activeDirection={memberSort.key === 'email' ? memberSort.direction : null}
+ label="Email"
+ onSort={() => memberSort.sortBy('email')}
+ />
+ <TableHeaderCell
+ activeDirection={memberSort.key === 'teams' ? memberSort.direction : null}
+ label="Teams"
+ onSort={() => memberSort.sortBy('teams')}
+ />
+ <th></th>
+ </tr>
+ </thead>
+ <tbody>
+ {state === 'loading' ? (
+ <TableStateRow colSpan={4} kind="loading" message="Loading members…" />
+ ) : state === 'error' ? (
+ <TableStateRow colSpan={4} kind="error" message="Members unavailable." />
+ ) : memberSort.sortedRows.length === 0 ? (
+ <TableStateRow colSpan={4} message="No members are visible for your teams." />
+ ) : (
+ memberSort.sortedRows.map(member => {
const deleteAllowed = canDeleteMemberAccount(member, currentUserId)
return (
<tr
@@ -339,17 +342,12 @@ export default function MembersPage() {
</td>
</tr>
)
- })}
- {state === 'ready' && members.length === 0 ? (
- <tr>
- <td colSpan={4}>No members are visible for your teams.</td>
- </tr>
- ) : null}
- </tbody>
- </DataTable>
- </div>
- </section>
- ) : null}
+ })
+ )}
+ </tbody>
+ </DataTable>
+ </div>
+ </section>
{confirmDialog}
</div>
diff --git a/profile-ui/package-lock.json b/profile-ui/package-lock.json
index d2e6cca97..d108d47c4 100644
--- a/profile-ui/package-lock.json
+++ b/profile-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.128",
+ "version": "0.1.129",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-profile-ui",
- "version": "0.1.128",
+ "version": "0.1.129",
"dependencies": {
"@clerum/desktop-app-links": "file:../packages/desktop-app-links",
"@clerum/frontend-table-system": "file:../packages/frontend-table-system",
diff --git a/profile-ui/package.json b/profile-ui/package.json
index e61f44139..1abd3d19a 100644
--- a/profile-ui/package.json
+++ b/profile-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-profile-ui",
- "version": "0.1.128",
+ "version": "0.1.129",
"private": true,
"scripts": {
"dev": "next dev",
diff --git a/scripts/style-rules/rules.test.mjs b/scripts/style-rules/rules.test.mjs
index 86ccb00d9..4524dab23 100644
--- a/scripts/style-rules/rules.test.mjs
+++ b/scripts/style-rules/rules.test.mjs
@@ -100,3 +100,17 @@ test('ordinary web record tables keep an explicit sorting model', () => {
assert.match(source, /onSort/, `${file} must expose sortable headers`)
}
})
+
+test('primary record tables keep headers mounted through data states', () => {
+ const statefulTables = [
+ 'control-ui/app/shared-filesystems/page.tsx',
+ 'control-ui/components/GuardrailHooksTable.tsx',
+ 'control-ui/components/McpServerTable.tsx',
+ 'control-ui/components/RecipesTab.tsx',
+ 'profile-ui/app/members/page.tsx',
+ ]
+
+ for (const file of statefulTables) {
+ assert.match(readFileSync(file, 'utf8'), /TableStateRow/, `${file} must render table state rows`)
+ }
+})