Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(rpc-proxy): strip line breaks from user-derived path segments in the rename log

Diego Zacarias47e83c007a54
diff --git a/external-rest-api/src/releaseManifest.ts b/external-rest-api/src/releaseManifest.ts
index 295c18ae0..32601823b 100644
--- a/external-rest-api/src/releaseManifest.ts
+++ b/external-rest-api/src/releaseManifest.ts
@@ -9,7 +9,7 @@ export type ReleaseManifest = {
export const releaseManifest: ReleaseManifest = {
releaseId: 'v0.8.0',
externalRestApiVersion: '0.1.81',
- rpcProxyVersion: '0.1.74',
+ rpcProxyVersion: '0.1.75',
desktopVersion: '0.8.0',
minimumDesktopVersion: '0.1.252',
}
diff --git a/rpc-proxy/package-lock.json b/rpc-proxy/package-lock.json
index 4f42492aa..2139130c6 100644
--- a/rpc-proxy/package-lock.json
+++ b/rpc-proxy/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-rpc-proxy",
- "version": "0.1.74",
+ "version": "0.1.75",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-rpc-proxy",
- "version": "0.1.74",
+ "version": "0.1.75",
"dependencies": {
"cors": "^2.8.5",
"express": "^4.21.2",
diff --git a/rpc-proxy/package.json b/rpc-proxy/package.json
index 63c9c0741..f5ae06d26 100644
--- a/rpc-proxy/package.json
+++ b/rpc-proxy/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-rpc-proxy",
- "version": "0.1.74",
+ "version": "0.1.75",
"description": "External-facing RPC proxy for tenant-scoped MCP access",
"main": "dist/main.js",
"engines": {
diff --git a/rpc-proxy/src/routes/rpc.ts b/rpc-proxy/src/routes/rpc.ts
index 48ade1fc8..29a8f95c8 100644
--- a/rpc-proxy/src/routes/rpc.ts
+++ b/rpc-proxy/src/routes/rpc.ts
@@ -58,6 +58,14 @@ function isSafeUpstreamAgentSegment(value: string): boolean {
return isSafeUpstreamPathSegment(value) && value.length <= 200 && !value.includes(':')
}
+// Strip line breaks before interpolating a user-derived value into a log line.
+// Path segments logged below are already rejected for control chars by
+// isSafeUpstreamPathSegment, so this is defense in depth: it guarantees a logged
+// value can never forge an extra log line even if a caller logs before that guard.
+function logSafe(value: string): string {
+ return value.replace(/[\r\n]+/g, ' ')
+}
+
function parseUnsignedIntegerQuery(value: unknown): number | undefined | null {
if (value === undefined) return undefined
if (typeof value !== 'string' || !/^\d+$/.test(value)) return null
@@ -999,7 +1007,7 @@ export function createRpcRouter(): Router {
const baseUrl = host.url.replace(/\/+$/, '')
// Never log the raw title (spec 15 §5): titles are user content.
console.info(
- `[RPC_PROXY] user=${auth.sub} host=${hostRef} method=rename-session agent=${agent} chatId=${chatId}`
+ `[RPC_PROXY] user=${auth.sub} host=${logSafe(hostRef)} method=rename-session agent=${logSafe(agent)} chatId=${logSafe(chatId)}`
)
try {
// Only host.headers carry the edge identity (x-clerum-edge-user-id and