Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(minikube): accept local image manifests without registry tag

Alfredo Lopez47ec081109b9
diff --git a/scripts/minikube/t2-common.sh b/scripts/minikube/t2-common.sh
index 8c93741ea..7d8286624 100755
--- a/scripts/minikube/t2-common.sh
+++ b/scripts/minikube/t2-common.sh
@@ -322,7 +322,10 @@ except (OSError, ValueError):
raise SystemExit("invalid")
source = payload.get("imageSource") or payload.get("source") or payload.get("mode") or ""
tag = payload.get("imageTag") or payload.get("tag") or ""
-if not source or not tag:
+# Local images deliberately have no registry tag; build-images.sh records an
+# empty imageTag and image-mode.sh treats that as the local coordinate. A tag
+# is mandatory only for the ghcr acquisition mode.
+if not source or (source == "ghcr" and not tag):
raise SystemExit("missing")
print(source + "\t" + tag)
PY
diff --git a/scripts/tests/test-minikube-t2-scenarios.sh b/scripts/tests/test-minikube-t2-scenarios.sh
index fc23fd375..c4ce262ad 100755
--- a/scripts/tests/test-minikube-t2-scenarios.sh
+++ b/scripts/tests/test-minikube-t2-scenarios.sh
@@ -134,11 +134,17 @@ expect_code IMAGE_MANIFEST_MISMATCH stale-image stale-image \
bash -c 'source "$1"; T2_IMAGE_SOURCE=local; T2_IMAGE_TAG=old; t2_image_check' bash "$COMMON"
invalid_manifest="$tmp/invalid-image-manifest.json"
-printf '{"imageSource":"local","imageTag":""}\n' >"$invalid_manifest"
+printf '{"imageSource":"ghcr","imageTag":""}\n' >"$invalid_manifest"
bootstrap_manifest_state="$(env "${repo_env[@]}" T2_IMAGE_MANIFEST="$invalid_manifest" T2_BOOTSTRAP_REQUIRED=true \
bash -c 'source "$1"; T2_BOOTSTRAP_REQUIRED=true; t2_image_check; printf "%s" "$T2_PLAN_STATE"' bash "$COMMON")"
[ "$bootstrap_manifest_state" = full-bootstrap ] || fail "invalid bootstrap manifest selected $bootstrap_manifest_state instead of full-bootstrap"
+local_manifest="$tmp/local-image-manifest.json"
+printf '{"imageSource":"local","imageTag":""}\n' >"$local_manifest"
+local_manifest_state="$(env "${repo_env[@]}" T2_IMAGE_MANIFEST="$local_manifest" T2_BOOTSTRAP_REQUIRED=false \
+ bash -c 'source "$1"; t2_image_check; printf "%s\t%s" "$T2_IMAGE_SOURCE" "$T2_IMAGE_TAG"' bash "$COMMON")"
+[ "$local_manifest_state" = $'local\t' ] || fail "local manifest with an empty tag was rejected: $local_manifest_state"
+
expect_code SECRET_MISSING missing-secret missing-secret \
env "${repo_env[@]}" T2_BOOTSTRAP_REQUIRED=false T2_REQUIRED_NAMESPACES=control-plane \
T2_REQUIRED_SERVICES=control-plane/control-api T2_REQUIRED_SECRETS=control-plane/absent \