Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(external-rest-api): preserve password authority responses

Josué4fa9531a83a7
diff --git a/external-rest-api/package-lock.json b/external-rest-api/package-lock.json
index 2b51e3ec9..fce3f950d 100644
--- a/external-rest-api/package-lock.json
+++ b/external-rest-api/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-external-rest-api",
- "version": "0.1.104",
+ "version": "0.1.105",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-external-rest-api",
- "version": "0.1.104",
+ "version": "0.1.105",
"dependencies": {
"@clerum/jwt-key-policy": "file:../packages/jwt-key-policy",
"cors": "^2.8.5",
diff --git a/external-rest-api/package.json b/external-rest-api/package.json
index 817d9395e..9333effc9 100644
--- a/external-rest-api/package.json
+++ b/external-rest-api/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-external-rest-api",
- "version": "0.1.104",
+ "version": "0.1.105",
"description": "External REST API for profile, team management, and RPC token brokerage",
"main": "dist/main.js",
"engines": {
diff --git a/external-rest-api/src/releaseManifest.ts b/external-rest-api/src/releaseManifest.ts
index c43b2ae76..cdafea33e 100644
--- a/external-rest-api/src/releaseManifest.ts
+++ b/external-rest-api/src/releaseManifest.ts
@@ -8,7 +8,7 @@ export type ReleaseManifest = {
export const releaseManifest: ReleaseManifest = {
releaseId: 'v0.10.0',
- externalRestApiVersion: '0.1.104',
+ externalRestApiVersion: '0.1.105',
rpcProxyVersion: '0.1.126',
desktopVersion: '0.10.0',
minimumDesktopVersion: '0.1.252',
diff --git a/external-rest-api/src/routes/me.ts b/external-rest-api/src/routes/me.ts
index 79410f4a4..8ec0b29c5 100644
--- a/external-rest-api/src/routes/me.ts
+++ b/external-rest-api/src/routes/me.ts
@@ -1,5 +1,6 @@
import { Router } from 'express'
import { ControlApiError } from '../controlApiClient.js'
+import { sendPasswordAuthorityError } from '../http/passwordAdmissionError.js'
import {
type AuthedRequest,
extractAuthToken,
@@ -170,6 +171,7 @@ export function createMeRouter(): Router {
res.status(400).json({ error: 'Password must be between 8 and 256 characters' })
return
}
+ if (sendPasswordAuthorityError(error, res)) return
next(error)
}
})
diff --git a/external-rest-api/test/routes.accessForwarding.test.ts b/external-rest-api/test/routes.accessForwarding.test.ts
index 79861606b..bc9d83972 100644
--- a/external-rest-api/test/routes.accessForwarding.test.ts
+++ b/external-rest-api/test/routes.accessForwarding.test.ts
@@ -76,7 +76,11 @@ describe('routes/access forwarding', () => {
return app
}
- async function preparePasswordApiError(response: { status: number; body: unknown }) {
+ async function preparePasswordApiError(response: {
+ status: number
+ body: unknown
+ headers?: Record<string, string>
+ }) {
authTokenMock.verifyToken.mockReturnValue(claims)
const actualService = await vi.importActual<typeof import('../src/services/meService.js')>(
'../src/services/meService.js'
@@ -85,7 +89,7 @@ describe('routes/access forwarding', () => {
return vi.spyOn(globalThis, 'fetch').mockResolvedValue(
new Response(JSON.stringify(response.body), {
status: response.status,
- headers: { 'content-type': 'application/json' },
+ headers: { 'content-type': 'application/json', ...response.headers },
})
)
}
@@ -203,6 +207,72 @@ describe('routes/access forwarding', () => {
}
})
+ it('maps password-work contention to a sanitized 429 and permits a later retry', async () => {
+ const upstreamFetch = await preparePasswordApiError({
+ status: 429,
+ body: { error: 'verification_busy', internal: 'owner row details' },
+ headers: { 'retry-after': '13', 'x-ratelimit-remaining': '0' },
+ })
+ const app = appWith(createMeRouter)
+
+ try {
+ const denied = await request(app)
+ .put('/me/password')
+ .set('authorization', 'Bearer good-token')
+ .send({ currentPassword: 'synthetic-current', newPassword: 'synthetic-next-password' })
+ .expect(429)
+
+ expect(denied.body).toEqual({ error: 'rate_limited', retryAfterSeconds: 13 })
+ expect(denied.headers['retry-after']).toBe('13')
+ expect(denied.headers['x-ratelimit-remaining']).toBeUndefined()
+ expect(JSON.stringify(denied.body)).not.toContain('verification_busy')
+ expect(JSON.stringify(denied.body)).not.toContain('owner row')
+ expect(upstreamFetch).toHaveBeenCalledTimes(1)
+
+ upstreamFetch.mockResolvedValueOnce(
+ new Response(JSON.stringify({ updated: true }), {
+ status: 200,
+ headers: { 'content-type': 'application/json' },
+ })
+ )
+ await request(app)
+ .put('/me/password')
+ .set('authorization', 'Bearer good-token')
+ .send({ currentPassword: 'synthetic-current', newPassword: 'synthetic-next-password' })
+ .expect(200)
+ .expect({ updated: true })
+ expect(upstreamFetch).toHaveBeenCalledTimes(2)
+ } finally {
+ upstreamFetch.mockRestore()
+ }
+ })
+
+ it('maps password authority outage to a sanitized bounded 503', async () => {
+ const upstreamFetch = await preparePasswordApiError({
+ status: 503,
+ body: { error: 'authority_failure', sql: 'private query text' },
+ headers: { 'retry-after': '1200', 'x-ratelimit-remaining': '0' },
+ })
+ const app = appWith(createMeRouter)
+
+ try {
+ const response = await request(app)
+ .put('/me/password')
+ .set('authorization', 'Bearer good-token')
+ .send({ currentPassword: 'synthetic-current', newPassword: 'synthetic-next-password' })
+ .expect(503)
+
+ expect(response.body).toEqual({ error: 'authority_unavailable', retryAfterSeconds: 900 })
+ expect(response.headers['retry-after']).toBe('900')
+ expect(response.headers['x-ratelimit-remaining']).toBeUndefined()
+ expect(JSON.stringify(response.body)).not.toContain('authority_failure')
+ expect(JSON.stringify(response.body)).not.toContain('private query')
+ expect(upstreamFetch).toHaveBeenCalledOnce()
+ } finally {
+ upstreamFetch.mockRestore()
+ }
+ })
+
it('rate limits initial /me/teams/directory per authenticated user', async () => {
authTokenMock.verifyToken.mockReturnValue({
...claims,