Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): Secrets connector tab affordances and footer copy

M50df97ea39f2
diff --git a/control-ui/app/constants/routes.ts b/control-ui/app/constants/routes.ts
index 260fe451e..d43146c52 100644
--- a/control-ui/app/constants/routes.ts
+++ b/control-ui/app/constants/routes.ts
@@ -120,6 +120,8 @@ export const CONTROL_ROUTES = {
recipe: '/secrets/recipe',
subscription: '/secrets/llm/subscriptions',
new: (query?: ControlRouteQuery) => withQuery('/secrets/new', query),
+ editConnector: (name: string, query?: ControlRouteQuery) =>
+ withQuery(`/secrets/connector/${segment(name)}/edit`, query),
editRecipe: (name: string, query?: ControlRouteQuery) =>
withQuery(`/secrets/recipe/${segment(name)}/edit`, query),
},
diff --git a/control-ui/app/secrets/connector/[name]/edit/page.tsx b/control-ui/app/secrets/connector/[name]/edit/page.tsx
new file mode 100644
index 000000000..8040d83a1
--- /dev/null
+++ b/control-ui/app/secrets/connector/[name]/edit/page.tsx
@@ -0,0 +1,269 @@
+'use client'
+
+import React, { Suspense, useEffect, useMemo, useRef, useState } from 'react'
+import { useParams, useRouter, useSearchParams } from 'next/navigation'
+import { AuthGate } from '@components/AuthGate'
+import { BodyLoadingSkeleton } from '@components/BodyLoadingSkeleton'
+import { useConfirmDialog } from '@components/ConfirmDialog'
+import { CreatePageHeader } from '@components/CreatePageHeader'
+import { DashboardLayout } from '@components/DashboardLayout'
+import { IconKey } from '@components/Sidebar/icons'
+import { useToast } from '@components/Toast'
+import { IconX } from '@components/icons'
+import { Button, Field, FormSection, TextInput } from '@components/ui'
+import { CONTROL_ROUTES } from '@constants/routes'
+import { type CredentialSchema, getRegistryCredentialSchema, updateMcpSecret } from '@lib/api'
+import { reconcileCredentialRows } from '@lib/registryCredentialDraft'
+import type { CredentialDraftRow } from '@lib/registryCredentialDraft.types'
+
+function createDraftRow(
+ id: string,
+ secretKey = '',
+ value = '',
+ label?: string
+): CredentialDraftRow {
+ return { id, secretKey, value, label }
+}
+
+function EditConnectorSecretContent() {
+ const router = useRouter()
+ const params = useParams<{ name: string }>()
+ const searchParams = useSearchParams()
+ const { confirm, confirmDialog } = useConfirmDialog()
+ const { showToast } = useToast()
+
+ const secretName = useMemo(() => {
+ const raw = params?.name
+ const value = Array.isArray(raw) ? raw[0] : raw
+ try {
+ return decodeURIComponent(value ?? '')
+ } catch {
+ return value ?? ''
+ }
+ }, [params])
+ const registryEntry = (searchParams.get('registryEntry') ?? '').trim()
+ const registryVersion = (searchParams.get('registryVersion') ?? '').trim()
+
+ const [rows, setRows] = useState<CredentialDraftRow[]>(() => [
+ createDraftRow('connector-secret-row-0'),
+ ])
+ const nextRowId = useRef(1)
+ const [credentialSchema, setCredentialSchema] = useState<CredentialSchema | null>(null)
+ const [credentialSchemaLoading, setCredentialSchemaLoading] = useState(false)
+ const [saving, setSaving] = useState(false)
+ const [error, setError] = useState('')
+
+ useEffect(() => {
+ if (!registryEntry || !registryVersion) {
+ setCredentialSchema(null)
+ setCredentialSchemaLoading(false)
+ return
+ }
+
+ let cancelled = false
+ setCredentialSchemaLoading(true)
+ void getRegistryCredentialSchema(registryEntry, registryVersion)
+ .then(schema => {
+ if (cancelled) return
+ setCredentialSchema(schema)
+ if (schema.keys.length === 0) return
+ setRows(current => reconcileCredentialRows(current, schema.keys))
+ })
+ .catch(() => {
+ if (!cancelled) setCredentialSchema(null)
+ })
+ .finally(() => {
+ if (!cancelled) setCredentialSchemaLoading(false)
+ })
+
+ return () => {
+ cancelled = true
+ }
+ }, [registryEntry, registryVersion])
+
+ const canSubmit =
+ !saving && rows.some(row => row.secretKey.trim().length > 0 && row.value.trim().length > 0)
+
+ function backToList() {
+ router.push(CONTROL_ROUTES.secrets.connector)
+ }
+
+ function addDraftRow() {
+ const nextId = nextRowId.current
+ nextRowId.current += 1
+ setRows(current => [...current, createDraftRow(`connector-secret-row-${nextId}`)])
+ }
+
+ function removeDraftRow(index: number) {
+ setRows(current => current.filter((_, itemIndex) => itemIndex !== index))
+ }
+
+ function updateDraftRow(index: number, field: 'secretKey' | 'value', value: string) {
+ setRows(current =>
+ current.map((row, itemIndex) => (itemIndex === index ? { ...row, [field]: value } : row))
+ )
+ }
+
+ async function save() {
+ if (!secretName) {
+ setError('Missing secret name in URL.')
+ return
+ }
+ const data = Object.fromEntries(
+ rows
+ .map(row => [row.secretKey.trim(), row.value.trim()])
+ .filter(([secretKey, value]) => secretKey.length > 0 && value.length > 0)
+ )
+ if (Object.keys(data).length === 0) {
+ setError('Enter at least one key and a new value to update this secret.')
+ return
+ }
+
+ const ok = await confirm({
+ title: 'Update connector secret',
+ message: `Rotate the values you entered in Secret ${secretName}? Connectors that reference it will restart to pick them up.`,
+ confirmLabel: 'Update',
+ })
+ if (!ok) return
+
+ setSaving(true)
+ setError('')
+ try {
+ const result = await updateMcpSecret(secretName, data)
+ const affected = Array.isArray(result.affectedConnectors) ? result.affectedConnectors : []
+ showToast(
+ affected.length > 0
+ ? `Secret ${secretName} updated. Restarting connectors: ${affected.join(', ')}.`
+ : `Secret ${secretName} updated.`,
+ { tone: 'success' }
+ )
+ backToList()
+ } catch (saveError) {
+ setError(saveError instanceof Error ? saveError.message : 'Failed to update secret')
+ } finally {
+ setSaving(false)
+ }
+ }
+
+ return (
+ <AuthGate>
+ <DashboardLayout isDetailPage>
+ <CreatePageHeader
+ icon={<IconKey />}
+ title={`Edit connector secret${secretName ? `: ${secretName}` : ''}`}
+ subtitle="Stored values are never shown. Type a new value to rotate a key — keys you leave blank keep their current value."
+ backLabel="Back to secrets"
+ onBack={backToList}
+ backDisabled={saving}
+ />
+
+ <div className="cu-create-panel">
+ <div className="cu-create-content">
+ {credentialSchemaLoading ? (
+ <p className="cu-muted">Loading connector credential fields…</p>
+ ) : credentialSchema?.keys.length ? (
+ <FormSection title="Secret values">
+ <div className="cu-form-stack">
+ {rows.map((row, index) => (
+ <Field
+ key={row.id}
+ htmlFor={`${row.id}-value`}
+ label={row.label || row.secretKey}
+ >
+ <TextInput
+ id={`${row.id}-value`}
+ value={row.value}
+ onChange={event => updateDraftRow(index, 'value', event.target.value)}
+ placeholder={row.label || 'New credential value'}
+ type="password"
+ autoComplete="off"
+ disabled={saving}
+ />
+ </Field>
+ ))}
+ </div>
+ </FormSection>
+ ) : (
+ <FormSection title="Secret values">
+ <div className="cu-form-grid">
+ {rows.map((row, index) => (
+ <div className="cu-form-inline" key={row.id}>
+ <TextInput
+ monospace
+ value={row.secretKey}
+ onChange={event => updateDraftRow(index, 'secretKey', event.target.value)}
+ placeholder="API_KEY"
+ disabled={saving}
+ />
+ <TextInput
+ monospace
+ value={row.value}
+ onChange={event => updateDraftRow(index, 'value', event.target.value)}
+ placeholder="secret value"
+ type="password"
+ autoComplete="off"
+ disabled={saving}
+ />
+ <button
+ type="button"
+ className="cu-btn cu-btn--icon cu-btn--danger-icon"
+ onClick={() => removeDraftRow(index)}
+ disabled={saving || rows.length === 1}
+ aria-label={`Remove key row ${index + 1}`}
+ title={`Remove key row ${index + 1}`}
+ >
+ <IconX width={16} height={16} />
+ </button>
+ </div>
+ ))}
+ </div>
+
+ <Button type="button" size="sm" onClick={addDraftRow} disabled={saving}>
+ Add key
+ </Button>
+ </FormSection>
+ )}
+
+ {error ? <div className="cu-banner cu-banner--error">{error}</div> : null}
+ </div>
+
+ <div className="cu-create-actions">
+ <Button type="button" variant="ghost" size="sm" onClick={backToList} disabled={saving}>
+ Cancel
+ </Button>
+ <Button
+ type="button"
+ variant="primary"
+ size="sm"
+ onClick={() => void save()}
+ disabled={!canSubmit}
+ >
+ {saving ? 'Saving…' : 'Save changes'}
+ </Button>
+ </div>
+ </div>
+
+ {confirmDialog}
+ </DashboardLayout>
+ </AuthGate>
+ )
+}
+
+export default function EditConnectorSecretPage() {
+ return (
+ <Suspense
+ fallback={
+ <BodyLoadingSkeleton
+ backLabel="Back to secrets"
+ icon={<IconKey />}
+ primaryActionLabel="Save changes"
+ sections={2}
+ subtitle="Load the connector credential fields before editing stored values."
+ title="Edit connector secret"
+ />
+ }
+ >
+ <EditConnectorSecretContent />
+ </Suspense>
+ )
+}
diff --git a/control-ui/components/SecretsTable.tsx b/control-ui/components/SecretsTable.tsx
index e71d07150..66b91b395 100644
--- a/control-ui/components/SecretsTable.tsx
+++ b/control-ui/components/SecretsTable.tsx
@@ -49,10 +49,7 @@ type McpSecretRow = {
}
type RecipeSecretStatus = 'provisioned' | 'missing'
type RecipeSecretRowOwnership =
- | { kind: 'shared' }
- | { kind: 'owner-recipe'; recipeName: string }
- | { kind: 'unlabeled' }
- | null // missing rows: not yet provisioned, ownership chosen at create time.
+ { kind: 'shared' } | { kind: 'owner-recipe'; recipeName: string } | { kind: 'unlabeled' } | null // missing rows: not yet provisioned, ownership chosen at create time.
type RecipeSecretRow = {
name: string
namespace: string
@@ -684,25 +681,62 @@ export function SecretsTable({
: 'Created manually or source unknown.'}
</td>
<td className="cu-table__cell-actions">
- <button
- type="button"
- className="cu-btn cu-btn--primary cu-btn--sm"
- onClick={() => {
- const source =
- row.registrySources.length === 1 ? row.registrySources[0] : undefined
- router.push(
- CONTROL_ROUTES.secrets.new({
- scope: 'mcp',
- name: row.name,
- registryEntry: source?.name,
- registryVersion: source?.version,
- })
- )
- }}
- aria-label={`Add connector secret ${row.name}`}
- >
- Add
- </button>
+ <div style={{ display: 'inline-flex', gap: '0.35rem' }}>
+ <RowActionsMenu
+ ariaLabel={`Actions for connector secret ${row.name}`}
+ horizontalTrigger
+ actions={[
+ {
+ key: 'add',
+ label: 'Add',
+ onClick: () => {
+ const source =
+ row.registrySources.length === 1
+ ? row.registrySources[0]
+ : undefined
+ router.push(
+ CONTROL_ROUTES.secrets.new({
+ scope: 'mcp',
+ name: row.name,
+ registryEntry: source?.name,
+ registryVersion: source?.version,
+ })
+ )
+ },
+ },
+ {
+ key: 'update',
+ label: 'Update',
+ onClick: () => {
+ const source =
+ row.registrySources.length === 1
+ ? row.registrySources[0]
+ : undefined
+ router.push(
+ CONTROL_ROUTES.secrets.editConnector(row.name, {
+ registryEntry: source?.name,
+ registryVersion: source?.version,
+ })
+ )
+ },
+ },
+ {
+ key: 'delete',
+ label: 'Delete',
+ danger: true,
+ // deleteMcpSecret requires the Secret's live
+ // uid/resourceVersion as its CAS precondition.
+ // Connector rows are derived from McpServer
+ // references and no list API returns that
+ // identity, so delete stays inert rather than
+ // issuing an unfenced delete.
+ disabled: true,
+ disabledReason: 'Delete is not available for this secret.',
+ onClick: () => {},
+ },
+ ]}
+ />
+ </div>
</td>
</tr>
))
@@ -866,20 +900,10 @@ export function SecretsTable({
</TableViewport>
)}
- {scope === 'mcp' ? (
- <div className="cu-card__body cu-card__body--auto cu-secrets-message-strip">
- <div className="cu-banner cu-banner--info">
- Connector secret lifecycle in UI currently supports creation. Editing, deleting, and
- listing all secrets in the <code>mcp-server</code> namespace requires backend API
- support.
- </div>
- </div>
- ) : null}
-
{scope === 'recipe' && recipeRows.some(row => row.status === 'missing') ? (
<div className="cu-card__body cu-card__body--auto cu-secrets-message-strip">
<div className="cu-banner cu-banner--info">
- Some recipes reference secrets that don&apos;t exist yet. Click <strong>Add</strong>
+ Some recipes reference secrets that don&apos;t exist yet. Click <strong>Add</strong>{' '}
on a Missing row to provision the Secret in the namespace shown on that row.
</div>
</div>
diff --git a/control-ui/components/__tests__/EditConnectorSecretPage.test.tsx b/control-ui/components/__tests__/EditConnectorSecretPage.test.tsx
new file mode 100644
index 000000000..5f63227b3
--- /dev/null
+++ b/control-ui/components/__tests__/EditConnectorSecretPage.test.tsx
@@ -0,0 +1,169 @@
+import React from 'react'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, fireEvent, render, screen, waitFor, within } from '@testing-library/react'
+import { ToastProvider } from '@components/Toast'
+import EditConnectorSecretPage from '../../app/secrets/connector/[name]/edit/page'
+import { getRegistryCredentialSchema, updateMcpSecret } from '../../lib/api'
+
+const navigation = vi.hoisted(() => ({
+ params: { name: 'linear-credentials' },
+ push: vi.fn(),
+ searchParams: new URLSearchParams(),
+}))
+
+vi.mock('next/navigation', () => ({
+ useParams: () => navigation.params,
+ useRouter: () => ({ push: navigation.push }),
+ useSearchParams: () => navigation.searchParams,
+}))
+
+vi.mock('@components/AuthGate', () => ({
+ AuthGate: ({ children }: { children: React.ReactNode }) => <>{children}</>,
+}))
+
+vi.mock('@components/DashboardLayout', () => ({
+ DashboardLayout: ({ children }: { children: React.ReactNode }) => <>{children}</>,
+}))
+
+vi.mock('../../lib/api', async () => {
+ const actual = await vi.importActual<typeof import('../../lib/api')>('../../lib/api')
+ return {
+ ...actual,
+ getRegistryCredentialSchema: vi.fn(),
+ updateMcpSecret: vi.fn(),
+ }
+})
+
+const getRegistryCredentialSchemaMock = vi.mocked(getRegistryCredentialSchema)
+const updateMcpSecretMock = vi.mocked(updateMcpSecret)
+
+function renderPage() {
+ render(
+ <ToastProvider>
+ <EditConnectorSecretPage />
+ </ToastProvider>
+ )
+}
+
+async function confirmUpdate() {
+ const dialog = await screen.findByRole('alertdialog', { name: 'Update connector secret' })
+ fireEvent.click(within(dialog).getByRole('button', { name: 'Update' }))
+}
+
+describe('EditConnectorSecretPage', () => {
+ beforeEach(() => {
+ getRegistryCredentialSchemaMock.mockReset()
+ updateMcpSecretMock.mockReset()
+ navigation.params = { name: 'linear-credentials' }
+ navigation.searchParams = new URLSearchParams()
+ navigation.push.mockClear()
+ })
+
+ afterEach(() => {
+ cleanup()
+ })
+
+ it('keeps Save disabled until a key and value are both filled', () => {
+ renderPage()
+
+ const save = screen.getByRole('button', { name: 'Save changes' })
+ expect(save).toBeDisabled()
+
+ fireEvent.change(screen.getByPlaceholderText('API_KEY'), { target: { value: 'API_KEY' } })
+ expect(save).toBeDisabled()
+
+ fireEvent.change(screen.getByPlaceholderText('secret value'), {
+ target: { value: 'rotated' },
+ })
+ expect(save).toBeEnabled()
+ })
+
+ it('rotates only the filled keys and reports affected connectors', async () => {
+ updateMcpSecretMock.mockResolvedValue({
+ name: 'linear-credentials',
+ namespace: 'mcp-server',
+ keys: ['API_KEY'],
+ affectedConnectors: ['linear-conn'],
+ })
+ renderPage()
+
+ fireEvent.change(screen.getByPlaceholderText('API_KEY'), { target: { value: 'API_KEY' } })
+ fireEvent.change(screen.getByPlaceholderText('secret value'), { target: { value: 'rotated' } })
+ fireEvent.click(screen.getByRole('button', { name: 'Save changes' }))
+ await confirmUpdate()
+
+ await waitFor(() => {
+ expect(updateMcpSecretMock).toHaveBeenCalledWith('linear-credentials', {
+ API_KEY: 'rotated',
+ })
+ })
+ expect(
+ await screen.findByText(
+ 'Secret linear-credentials updated. Restarting connectors: linear-conn.'
+ )
+ ).toBeInTheDocument()
+ await waitFor(() => {
+ expect(navigation.push).toHaveBeenCalledWith('/secrets/connector')
+ })
+ })
+
+ it('writes nothing when the rotation confirmation is cancelled', async () => {
+ renderPage()
+
+ fireEvent.change(screen.getByPlaceholderText('API_KEY'), { target: { value: 'API_KEY' } })
+ fireEvent.change(screen.getByPlaceholderText('secret value'), { target: { value: 'rotated' } })
+ fireEvent.click(screen.getByRole('button', { name: 'Save changes' }))
+
+ const dialog = await screen.findByRole('alertdialog', { name: 'Update connector secret' })
+ fireEvent.click(within(dialog).getByRole('button', { name: 'Cancel' }))
+
+ await waitFor(() => {
+ expect(screen.queryByRole('alertdialog')).toBeNull()
+ })
+ expect(updateMcpSecretMock).not.toHaveBeenCalled()
+ expect(screen.getByRole('button', { name: 'Save changes' })).toBeInTheDocument()
+ })
+
+ it('surfaces the API error inline instead of navigating away', async () => {
+ updateMcpSecretMock.mockRejectedValue(new Error('Secret not found'))
+ renderPage()
+
+ fireEvent.change(screen.getByPlaceholderText('API_KEY'), { target: { value: 'API_KEY' } })
+ fireEvent.change(screen.getByPlaceholderText('secret value'), { target: { value: 'rotated' } })
+ fireEvent.click(screen.getByRole('button', { name: 'Save changes' }))
+ await confirmUpdate()
+
+ expect(await screen.findByText('Secret not found')).toBeInTheDocument()
+ expect(navigation.push).not.toHaveBeenCalled()
+ })
+
+ it('uses the registry credential schema when the source is known', async () => {
+ navigation.searchParams = new URLSearchParams('registryEntry=mcp-linear&registryVersion=1.4.0')
+ getRegistryCredentialSchemaMock.mockResolvedValue({
+ required: true,
+ authType: 'api-key',
+ keys: [
+ { name: 'api-token', label: 'API token', kind: 'api-key' },
+ { name: 'workspace-id', label: 'Workspace ID', kind: 'text' },
+ ],
+ })
+ updateMcpSecretMock.mockResolvedValue({
+ name: 'linear-credentials',
+ namespace: 'mcp-server',
+ keys: ['api-token', 'workspace-id'],
+ affectedConnectors: [],
+ })
+ renderPage()
+
+ fireEvent.change(await screen.findByLabelText('API token'), { target: { value: 'rotated' } })
+ fireEvent.click(screen.getByRole('button', { name: 'Save changes' }))
+ await confirmUpdate()
+
+ await waitFor(() => {
+ expect(updateMcpSecretMock).toHaveBeenCalledWith('linear-credentials', {
+ 'api-token': 'rotated',
+ })
+ })
+ expect(await screen.findByText('Secret linear-credentials updated.')).toBeInTheDocument()
+ })
+})
diff --git a/control-ui/components/__tests__/SecretsTable.test.tsx b/control-ui/components/__tests__/SecretsTable.test.tsx
index ec63ca92f..7574ec338 100644
--- a/control-ui/components/__tests__/SecretsTable.test.tsx
+++ b/control-ui/components/__tests__/SecretsTable.test.tsx
@@ -604,6 +604,151 @@ describe('SecretsTable — recipe pending refs', () => {
})
})
+describe('SecretsTable — connector row actions', () => {
+ beforeEach(() => {
+ getMcpServersMock.mockReset()
+ getRecipeSecretsMock.mockReset()
+ getRecipesMock.mockReset()
+ mockReplace.mockClear()
+ mockPush.mockClear()
+ })
+
+ afterEach(() => {
+ cleanup()
+ })
+
+ function mockConnectorRow() {
+ getMcpServersMock.mockResolvedValue({
+ items: [
+ {
+ metadata: {
+ name: 'linear-conn',
+ annotations: {
+ 'clerum.io/catalog-id': 'mcp-linear',
+ 'clerum.io/catalog-version': '1.4.0',
+ },
+ },
+ spec: { envSecret: { name: 'linear-credentials' } },
+ },
+ ],
+ })
+ }
+
+ async function openRowMenu() {
+ const trigger = await screen.findByRole('button', {
+ name: 'Actions for connector secret linear-credentials',
+ })
+ fireEvent.click(trigger)
+ }
+
+ it('offers Update and a disabled Delete alongside Add on every connector row', async () => {
+ mockConnectorRow()
+ renderTable()
+ await openRowMenu()
+
+ expect(screen.getByRole('menuitem', { name: 'Add' })).toBeEnabled()
+ expect(screen.getByRole('menuitem', { name: 'Update' })).toBeEnabled()
+ const deleteAction = screen.getByRole('menuitem', { name: /^Delete/ })
+ expect(deleteAction).toHaveAttribute('aria-disabled', 'true')
+ expect(screen.getByText('Delete is not available for this secret.')).toBeInTheDocument()
+ })
+
+ it('keeps the disabled Delete inert instead of confirming or calling the API', async () => {
+ mockConnectorRow()
+ renderTable()
+ await openRowMenu()
+
+ fireEvent.click(screen.getByRole('menuitem', { name: /^Delete/ }))
+
+ expect(screen.queryByRole('alertdialog')).toBeNull()
+ expect(apiSendMock).not.toHaveBeenCalled()
+ })
+
+ it('navigates Update to the connector secret edit page with its registry source', async () => {
+ mockConnectorRow()
+ renderTable()
+ await openRowMenu()
+
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Update' }))
+
+ expect(mockPush).toHaveBeenCalledWith(
+ '/secrets/connector/linear-credentials/edit?registryEntry=mcp-linear&registryVersion=1.4.0'
+ )
+ })
+
+ it('still prefills the create flow from the row Add action', async () => {
+ mockConnectorRow()
+ renderTable()
+ await openRowMenu()
+
+ fireEvent.click(screen.getByRole('menuitem', { name: 'Add' }))
+
+ expect(mockPush).toHaveBeenCalledWith(
+ '/secrets/new?scope=mcp&name=linear-credentials&registryEntry=mcp-linear&registryVersion=1.4.0'
+ )
+ })
+
+ it('does not leak the internal connector lifecycle note', async () => {
+ getMcpServersMock.mockResolvedValue({ items: [] })
+ renderTable()
+
+ await screen.findByText('No connector secrets found.')
+ expect(screen.queryByText(/Connector secret lifecycle/i)).toBeNull()
+ expect(screen.queryByText(/requires backend API support/i)).toBeNull()
+ })
+})
+
+describe('SecretsTable — recipe missing-secret hint copy', () => {
+ beforeEach(() => {
+ getMcpServersMock.mockReset()
+ getRecipeSecretsMock.mockReset()
+ getRecipesMock.mockReset()
+ mockReplace.mockClear()
+ mockPush.mockClear()
+ })
+
+ afterEach(() => {
+ cleanup()
+ })
+
+ it('separates "Add" and "on" in the missing-secret hint (BUG-26)', async () => {
+ getRecipeSecretsMock.mockResolvedValue({ items: [] })
+ getRecipesMock.mockResolvedValue({
+ items: [
+ {
+ metadata: { name: 'hint-recipe' },
+ spec: {
+ steps: [
+ {
+ id: 'snippet',
+ run: {
+ type: 'snippet',
+ capabilities: {
+ secrets: [{ secretRef: { name: 'hint-creds', key: 'apiKey' } }],
+ },
+ },
+ },
+ ],
+ },
+ },
+ ],
+ })
+
+ renderTable('recipe')
+
+ const hint = await waitFor(() => {
+ const match = screen
+ .getAllByText((_, element) => element?.classList.contains('cu-banner') ?? false)
+ .find(element =>
+ (element.textContent ?? '').replace(/\s+/g, ' ').includes('Click Add on a Missing row')
+ )
+ if (!match) throw new Error('missing-secret hint banner not rendered yet')
+ return match
+ })
+ expect(hint.textContent?.replace(/\s+/g, ' ')).not.toMatch(/Addon/)
+ })
+})
+
describe('SecretsTable — LLM empty state', () => {
it('shows LLM API Keys and LLM Subscriptions as sibling top-level scopes', async () => {
rtlRender(
diff --git a/control-ui/e2e/registry-install.spec.ts b/control-ui/e2e/registry-install.spec.ts
index 005adacea..a4ea957c6 100644
--- a/control-ui/e2e/registry-install.spec.ts
+++ b/control-ui/e2e/registry-install.spec.ts
@@ -510,8 +510,7 @@ async function waitForWorkflowRecipeDeleted(token: string, name: string): Promis
function externalEgressReady(server: Record<string, unknown>): boolean {
const status = server.status as
- | { conditions?: Array<{ type?: string; status?: string }> }
- | undefined
+ { conditions?: Array<{ type?: string; status?: string }> } | undefined
return (
status?.conditions?.some(
condition => condition.type === 'ExternalEgressReady' && condition.status === 'True'
@@ -572,8 +571,7 @@ async function submitRegistryInstallForm(
return false
}
const body = response.request().postDataJSON() as
- | { serverName?: string; registryEntryName?: string }
- | undefined
+ { serverName?: string; registryEntryName?: string } | undefined
return body?.serverName === serverName && body?.registryEntryName === registryEntryName
},
{ timeout: 30_000 }
@@ -1429,8 +1427,7 @@ test.describe('H. Control-UI Smoke Tests', () => {
return false
}
const body = r.request().postDataJSON() as
- | { serverName?: string; registryEntryName?: string }
- | undefined
+ { serverName?: string; registryEntryName?: string } | undefined
return body?.serverName === serverName && body?.registryEntryName === 'mcp-filesystem'
},
{ timeout: 30_000 }
@@ -2267,8 +2264,9 @@ test.describe('J. Operator Egress Editor Journeys', () => {
const secretRow = page.locator('tr', { hasText: expectedSecretName })
await expect(secretRow).toBeVisible({ timeout: 15_000 })
await secretRow
- .getByRole('button', { name: `Add connector secret ${expectedSecretName}` })
+ .getByRole('button', { name: `Actions for connector secret ${expectedSecretName}` })
.click()
+ await page.getByRole('menuitem', { name: 'Add', exact: true }).click()
await expect(page).toHaveURL(/\/secrets\/new\?/)
await expect(page.getByRole('heading', { name: 'Create connector secret' })).toBeVisible()
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 982acfe34..6a11d5f01 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.653",
+ "version": "0.1.654",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.653",
+ "version": "0.1.654",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 23fe01de0..956a113f2 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.653",
+ "version": "0.1.654",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",