Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-api): keep OAuth callback URL and PG admin URL out of the public boundary scanner

Diego Zacarias50f1608fc57d
diff --git a/control-api/package-lock.json b/control-api/package-lock.json
index a08b64823..57623924d 100644
--- a/control-api/package-lock.json
+++ b/control-api/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-api",
- "version": "0.1.499",
+ "version": "0.1.500",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-api",
- "version": "0.1.499",
+ "version": "0.1.500",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/image-policy": "file:../packages/image-policy",
diff --git a/control-api/package.json b/control-api/package.json
index 842aace95..8c4e58254 100644
--- a/control-api/package.json
+++ b/control-api/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-api",
- "version": "0.1.499",
+ "version": "0.1.500",
"description": "Internal Clerum control plane REST API + UI for managing CRDs and secrets",
"main": "dist/main.js",
"engines": {
diff --git a/control-api/test/oauth.store.sharedGrants.realPostgres.integration.test.ts b/control-api/test/oauth.store.sharedGrants.realPostgres.integration.test.ts
index 987f95894..bc2b9a799 100644
--- a/control-api/test/oauth.store.sharedGrants.realPostgres.integration.test.ts
+++ b/control-api/test/oauth.store.sharedGrants.realPostgres.integration.test.ts
@@ -10,7 +10,7 @@ import { bootstrapSharedOAuthGrant, getOAuthGrant, upsertOAuthGrant } from '../s
// T1/T5 — shared-identity grant semantics derived from the REAL producer
// (real ON CONFLICT DO NOTHING + CHECK constraints), not a hand-built fixture.
// Gated on a real Postgres, like the other *.realPostgres.integration.test.ts:
-// CONTROL_API_REAL_PG_ADMIN_URL=postgres://user:pass@host:5432 npm test -- \
+// CONTROL_API_REAL_PG_ADMIN_URL=postgres://<user>:<pass>@<host>:5432 npm test -- \
// test/oauth.store.sharedGrants.realPostgres.integration.test.ts
const adminUrl = process.env.CONTROL_API_REAL_PG_ADMIN_URL
const describeRealPostgres = adminUrl ? describe : describe.skip
diff --git a/control-api/test/services.access.mcpInvocable.grantGate.realPostgres.integration.test.ts b/control-api/test/services.access.mcpInvocable.grantGate.realPostgres.integration.test.ts
index 5ffaf094e..6b17a86d7 100644
--- a/control-api/test/services.access.mcpInvocable.grantGate.realPostgres.integration.test.ts
+++ b/control-api/test/services.access.mcpInvocable.grantGate.realPostgres.integration.test.ts
@@ -13,7 +13,7 @@ import { MockGateway } from './mockGateway.js'
// state built by the REAL producers (`upsertOAuthGrant` / `bootstrapSharedOAuthGrant`)
// and read by the REAL `oauthGrantExists` inside the resolver. No hand-built
// oauth_grants rows. Gated on a real Postgres, like the store integration test:
-// CONTROL_API_REAL_PG_ADMIN_URL=postgres://user:pass@host:5432 npm test -- \
+// CONTROL_API_REAL_PG_ADMIN_URL=postgres://<user>:<pass>@<host>:5432 npm test -- \
// test/services.access.mcpInvocable.grantGate.realPostgres.integration.test.ts
const adminUrl = process.env.CONTROL_API_REAL_PG_ADMIN_URL
const describeRealPostgres = adminUrl ? describe : describe.skip
diff --git a/deploy/overlays/minikube/configmaps/control-api-config.yaml b/deploy/overlays/minikube/configmaps/control-api-config.yaml
index f3176219b..2d9abfbb6 100644
--- a/deploy/overlays/minikube/configmaps/control-api-config.yaml
+++ b/deploy/overlays/minikube/configmaps/control-api-config.yaml
@@ -40,7 +40,8 @@ data:
# by the user's browser and NOT matching the provider's registered redirect URI.
# Locally the user consents in their own browser, so the callback must land on
# the port-forwarded loopback. Register this EXACT literal as the redirect URI
- # in each provider's OAuth app: http://127.0.0.1:8090/api/v1/oauth-callback/<oauth.id>.
+ # in each provider's OAuth app: the CONTROL_API_OAUTH_CALLBACK_BASE_URL value
+ # below, suffixed with /api/v1/oauth-callback/<oauth.id>.
# (Distinct from RPC_PROXY_OAUTH_CALLBACK_BASE_URL, which is the legacy
# recipe/embed flow and uses `localhost` — do not conflate them.)
CONTROL_API_OAUTH_CALLBACK_BASE_URL: 'http://127.0.0.1:8090'