Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(gfs): align desktop file columns

Miguelon Peluchon526de0fcca4c
diff --git a/desktop-app/ui/src/pages/FilesPage.tsx b/desktop-app/ui/src/pages/FilesPage.tsx
index 369660f90..903143d77 100644
--- a/desktop-app/ui/src/pages/FilesPage.tsx
+++ b/desktop-app/ui/src/pages/FilesPage.tsx
@@ -799,14 +799,14 @@ export function FilesPage({ pushToast, pendingGfsUri, onPendingGfsUriHandled }:
className="da-grid da-gfs-drive__grid"
style={{
'--da-grid-cols':
- 'calc(var(--space-5) + var(--space-1)) minmax(0, 1fr) minmax(4.5rem, 4.5rem) 4.5rem',
+ 'calc(var(--space-5) + var(--space-1)) minmax(0, 1fr) minmax(4.5rem, auto) 4.5rem',
}}
>
<div className="da-grid__head">
<span className="da-grid__col-header" aria-hidden="true" />
<span className="da-grid__col-header">Name</span>
- <span className="da-grid__col-header da-gfs-drive__type-column da-grid__col-header--right">
- Type
+ <span className="da-grid__col-header da-gfs-drive__size-column da-grid__col-header--right">
+ Size
</span>
<span className="da-grid__col-header da-grid__col-header--right">Actions</span>
</div>
@@ -847,16 +847,9 @@ export function FilesPage({ pushToast, pendingGfsUri, onPendingGfsUriHandled }:
{resource.name || resource.drive}
</Button>
</span>
- <span className="da-gfs-list__meta">
- {resource.kind === 'directory'
- ? resource.coversDescendants
- ? 'Shared folder tree'
- : 'Folder'
- : formatSharedFileSize(resource.bytes)}
- </span>
</span>
- <span className="da-gfs-drive__type da-grid__cell">
- {resource.kind === 'directory' ? 'Folder' : 'File'}
+ <span className="da-gfs-drive__size da-grid__cell da-grid__cell--right">
+ {formatSharedFileSize(resource.bytes)}
</span>
<span className="da-gfs-list__actions da-grid__cell da-grid__cell--right">
{resource.kind === 'file' ? (
diff --git a/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx b/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx
index 89e8850e1..6697e9c32 100644
--- a/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx
+++ b/desktop-app/ui/src/pages/__tests__/FilesPage.test.tsx
@@ -270,6 +270,61 @@ describe('FilesPage', () => {
)
})
+ it('uses a size column and keeps folder rows focused on the icon and name', () => {
+ hookMock.useGfsBrowserController.mockReturnValue({
+ ...baseController(),
+ current: {
+ resourceId: 'parent-1',
+ gfsUri: 'gfs://main/parent-1',
+ name: 'Workspace',
+ kind: 'directory',
+ version: 1,
+ },
+ items: [
+ {
+ resourceId: 'dir-1',
+ rid: 'dir-1',
+ gfsUri: 'gfs://main/dir-1',
+ drive: 'main',
+ parentResourceId: 'parent-1',
+ name: 'Moon',
+ kind: 'directory',
+ path: '/Moon',
+ version: 1,
+ bytes: 0,
+ coversDescendants: true,
+ },
+ {
+ resourceId: 'file-1',
+ rid: 'file-1',
+ gfsUri: 'gfs://main/file-1',
+ drive: 'main',
+ parentResourceId: 'parent-1',
+ name: 'notes.txt',
+ kind: 'file',
+ path: '/notes.txt',
+ version: 1,
+ bytes: 2048,
+ },
+ ],
+ })
+
+ renderFilesPage()
+
+ const header = document.querySelector('.da-gfs-drive__grid .da-grid__head')
+ expect(header?.textContent).toContain('Size')
+ expect(header?.textContent).not.toContain('Type')
+
+ const folderRow = screen.getByText('Moon').closest('.da-grid__row')
+ expect(folderRow?.querySelector('.da-gfs-drive__size')?.textContent).toBe('—')
+ expect(folderRow?.querySelector('.da-gfs-list__meta')).toBeNull()
+ expect(folderRow?.textContent).not.toContain('Folder')
+ expect(folderRow?.textContent).not.toContain('Shared folder tree')
+
+ const fileRow = screen.getByText('notes.txt').closest('.da-grid__row')
+ expect(fileRow?.querySelector('.da-gfs-drive__size')?.textContent).toBe('2.0 KB')
+ })
+
it('shows end-user folder CRUD controls only when held permissions allow them', async () => {
const createFolder = vi.fn(async () => undefined)
const renameResource = vi.fn(async () => undefined)
diff --git a/desktop-app/ui/src/styles.css b/desktop-app/ui/src/styles.css
index 218eda00f..54b6a4b0c 100644
--- a/desktop-app/ui/src/styles.css
+++ b/desktop-app/ui/src/styles.css
@@ -13485,14 +13485,6 @@ pre {
font-weight: 700;
}
-.da-gfs-list__meta {
- color: var(--text-muted);
- font-size: var(--font-size-xs);
- font-weight: 700;
- letter-spacing: 0;
- text-transform: uppercase;
-}
-
.da-gfs-list__actions {
display: flex;
align-items: center;
@@ -14041,7 +14033,7 @@ pre {
font-size: var(--font-size-sm);
}
-.da-gfs-drive__type {
+.da-gfs-drive__size {
min-width: 0;
overflow: hidden;
color: var(--text-muted);
@@ -14865,8 +14857,8 @@ pre {
grid-template-columns: calc(var(--space-5) + var(--space-1)) minmax(0, 1fr) 4.5rem;
}
- .da-gfs-drive__type-column,
- .da-gfs-drive__type {
+ .da-gfs-drive__size-column,
+ .da-gfs-drive__size {
display: none;
}