Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): enable delete and direct rotation for connector secrets

M53f871cdb8c4
diff --git a/control-api/package-lock.json b/control-api/package-lock.json
index da78ca66e..1b6d7666c 100644
--- a/control-api/package-lock.json
+++ b/control-api/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-api",
- "version": "0.1.751",
+ "version": "0.1.752",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-api",
- "version": "0.1.751",
+ "version": "0.1.752",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/grok-provider-attempt-contract": "file:../packages/grok-provider-attempt-contract",
diff --git a/control-api/package.json b/control-api/package.json
index 62fe86662..f24fe4a2f 100644
--- a/control-api/package.json
+++ b/control-api/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-api",
- "version": "0.1.751",
+ "version": "0.1.752",
"description": "Internal Clerum control plane REST API + UI for managing CRDs and secrets",
"main": "dist/main.js",
"engines": {
diff --git a/control-api/src/routes/admin/secrets.ts b/control-api/src/routes/admin/secrets.ts
index 6d2c60d4c..ce9830e2b 100644
--- a/control-api/src/routes/admin/secrets.ts
+++ b/control-api/src/routes/admin/secrets.ts
@@ -583,7 +583,8 @@ export function createAdminSecretsRouter(
// the wizard never writes a CR whose clientIdRef/clientSecretRef dangle. The
// server-side install saga re-verifies existence at submit; this is the UI's
// pre-check. Values are structurally impossible here: listSecrets projects only
- // metadata + key names, and this route forwards only name + keys.
+ // metadata + key names, and this route forwards only name + keys + the
+ // uid/resourceVersion identity the UI needs for compare-and-delete.
router.get(
'/admin/mcp-secrets',
enforceNamespace(config.mcpServersNamespace),
@@ -593,10 +594,18 @@ export function createAdminSecretsRouter(
const record = asRecord(row)
const metadata = asRecord(record?.metadata)
const name = typeof metadata?.name === 'string' ? metadata.name : ''
+ const uid = typeof metadata?.uid === 'string' ? metadata.uid : undefined
+ const resourceVersion =
+ typeof metadata?.resourceVersion === 'string' ? metadata.resourceVersion : undefined
const keys = Array.isArray(record?.keys)
? (record.keys as unknown[]).filter((k): k is string => typeof k === 'string')
: []
- return { name, keys }
+ return {
+ name,
+ keys,
+ ...(uid ? { uid } : {}),
+ ...(resourceVersion ? { resourceVersion } : {}),
+ }
})
res.status(200).json({ items })
})
diff --git a/control-api/test/routes.mcpSecrets.list.test.ts b/control-api/test/routes.mcpSecrets.list.test.ts
index 26c9036db..e6dabb980 100644
--- a/control-api/test/routes.mcpSecrets.list.test.ts
+++ b/control-api/test/routes.mcpSecrets.list.test.ts
@@ -11,12 +11,24 @@ import { SecretService } from '../src/services/secretService.js'
// hand-built row (e.g. one with a stray `data` field the producer never emits)
// would test an impossible leak path instead of the real one.
async function listSecretsOutput(
- secrets: Array<{ name: string; data: Record<string, string> }>
+ secrets: Array<{
+ name: string
+ data: Record<string, string>
+ uid?: string
+ resourceVersion?: string
+ }>
): Promise<unknown[]> {
const fakeCoreApi = {
listNamespacedSecret: async ({ namespace }: { namespace: string }) => ({
items: secrets.map(s => ({
- metadata: { name: s.name, namespace, labels: {}, annotations: {} },
+ metadata: {
+ name: s.name,
+ namespace,
+ ...(s.uid ? { uid: s.uid } : {}),
+ ...(s.resourceVersion ? { resourceVersion: s.resourceVersion } : {}),
+ labels: {},
+ annotations: {},
+ },
type: 'Opaque',
data: s.data,
})),
@@ -70,4 +82,22 @@ describe('GET /admin/mcp-secrets (E-16.1)', () => {
expect(res.body.items[0]).not.toHaveProperty('data')
expect(res.body.items[0]).not.toHaveProperty('stringData')
})
+
+ it('forwards the live uid/resourceVersion identity the UI needs for compare-and-delete', async () => {
+ const rows = await listSecretsOutput([
+ {
+ name: 'asana-creds',
+ data: { api_key: 'a2V5' },
+ uid: 'uid-asana-1',
+ resourceVersion: '42',
+ },
+ { name: 'legacy-creds', data: { api_key: 'a2V5' } },
+ ])
+ const { app } = makeApp(rows)
+ const res = await request(app).get('/admin/mcp-secrets').expect(200)
+ expect(res.body.items).toEqual([
+ { name: 'asana-creds', keys: ['api_key'], uid: 'uid-asana-1', resourceVersion: '42' },
+ { name: 'legacy-creds', keys: ['api_key'] },
+ ])
+ })
})
diff --git a/control-ui/app/secrets/connector/[name]/edit/page.tsx b/control-ui/app/secrets/connector/[name]/edit/page.tsx
index d9bdd572c..756fe19f2 100644
--- a/control-ui/app/secrets/connector/[name]/edit/page.tsx
+++ b/control-ui/app/secrets/connector/[name]/edit/page.tsx
@@ -8,6 +8,7 @@ import { CreatePageHeader } from '@components/CreatePageHeader'
import { DashboardLayout } from '@components/DashboardLayout'
import { IconKey } from '@components/Sidebar/icons'
import { TabBar } from '@components/TabBar'
+import { useToast } from '@components/Toast'
import { UpdateConnectorCredentials } from '@components/UpdateConnectorCredentials'
import {
nonCanonicalEnvSecretName,
@@ -18,8 +19,9 @@ import {
isRecipeOwned,
resolveCredentialSurface,
} from '@components/UpdateConnectorCredentials/resolveCredentialSurface'
+import { Field, TextInput } from '@components/ui'
import { CONTROL_ROUTES } from '@constants/routes'
-import { getMcpServers } from '@lib/api'
+import { getMcpServers, listMcpSecrets, updateMcpSecret } from '@lib/api'
import type { McpServerResource } from '@lib/api'
function serverRefersToSecret(server: McpServerResource, secretName: string): boolean {
@@ -52,11 +54,21 @@ function EditConnectorSecretContent() {
const [servers, setServers] = useState<McpServerResource[] | null>(null)
const [loadError, setLoadError] = useState('')
+ // The provisioned Secret listing: undefined while loading, null when the
+ // Secret does not exist, otherwise its name + key names (never values).
+ const [secretSummary, setSecretSummary] = useState<
+ { name: string; keys: string[] } | null | undefined
+ >(undefined)
+ const [keyValues, setKeyValues] = useState<Record<string, string>>({})
+ const [saving, setSaving] = useState(false)
+ const [saveError, setSaveError] = useState('')
+ const { showToast } = useToast()
useEffect(() => {
if (!secretName) {
setLoadError('Missing secret name in URL.')
setServers([])
+ setSecretSummary(null)
return
}
let cancelled = false
@@ -73,6 +85,15 @@ function EditConnectorSecretContent() {
setServers([])
}
})
+ listMcpSecrets()
+ .then(result => {
+ if (cancelled) return
+ const match = (result.items ?? []).find(item => item.name === secretName)
+ setSecretSummary(match ? { name: match.name, keys: match.keys } : null)
+ })
+ .catch(() => {
+ if (!cancelled) setSecretSummary(null)
+ })
return () => {
cancelled = true
}
@@ -138,13 +159,37 @@ function EditConnectorSecretContent() {
router.push(CONTROL_ROUTES.secrets.connector)
}
+ const filledKeyData = () =>
+ Object.fromEntries(
+ Object.entries(keyValues).filter(([key, value]) => key.length > 0 && value.trim().length > 0)
+ )
+
+ async function saveDirectRotation() {
+ const data = filledKeyData()
+ if (Object.keys(data).length === 0) {
+ setSaveError('Fill in at least one key to rotate its value.')
+ return
+ }
+ setSaving(true)
+ setSaveError('')
+ try {
+ await updateMcpSecret(secretName, data)
+ showToast(`Secret ${secretName} updated.`, { tone: 'success' })
+ backToList()
+ } catch (e) {
+ setSaveError(e instanceof Error ? e.message : 'Failed to update secret')
+ } finally {
+ setSaving(false)
+ }
+ }
+
return (
<AuthGate>
<DashboardLayout isDetailPage>
<CreatePageHeader
icon={<IconKey />}
title={`Edit connector secret${secretName ? `: ${secretName}` : ''}`}
- subtitle="Update the values stored in this Secret through a connector that references it. Values are write-only; the form explains which keys are required."
+ subtitle="Rotate the values stored in this Secret. Values are write-only; only the keys you fill in are replaced."
backLabel="Back to secrets"
onBack={backToList}
/>
@@ -181,10 +226,66 @@ function EditConnectorSecretContent() {
!identityError &&
!serverQueryError &&
!unknownServerError ? (
- <div className="cu-banner cu-banner--error">
- No connector currently references Secret <code>{secretName || '(unnamed)'}</code>.
- Attach it to a connector before rotating it from here.
- </div>
+ secretSummary === undefined ? (
+ <p className="cu-muted" role="status">
+ Loading connector secret…
+ </p>
+ ) : secretSummary === null ? (
+ <div className="cu-banner cu-banner--error">
+ No connector secret named <code>{secretName || '(unnamed)'}</code> exists. It may
+ have been deleted.
+ </div>
+ ) : (
+ <>
+ <h2>Rotate stored values</h2>
+ <p className="cu-muted">
+ No connector references this Secret yet, so changes take effect for the next
+ connector that attaches it. Only the keys you fill in are replaced; every other
+ key already on the Secret is kept.
+ </p>
+ {saveError ? (
+ <div className="cu-banner cu-banner--error" role="alert">
+ {saveError}
+ </div>
+ ) : null}
+ {secretSummary.keys.length === 0 ? (
+ <p className="cu-muted">This Secret has no keys yet.</p>
+ ) : (
+ secretSummary.keys.map(key => (
+ <Field
+ key={key}
+ label={key}
+ htmlFor={`secret-key-${key}`}
+ description="Write-only — leave blank to keep the current value."
+ >
+ <TextInput
+ id={`secret-key-${key}`}
+ type="password"
+ name={key}
+ autoComplete="off"
+ value={keyValues[key] ?? ''}
+ onChange={e =>
+ setKeyValues(current => ({ ...current, [key]: e.target.value }))
+ }
+ />
+ </Field>
+ ))
+ )}
+ <div className="cu-create-actions">
+ <button type="button" className="cu-btn cu-btn--ghost" onClick={backToList}>
+ Cancel
+ </button>
+ <button
+ type="button"
+ className="cu-btn cu-btn--primary"
+ onClick={() => void saveDirectRotation()}
+ disabled={saving || secretSummary.keys.length === 0}
+ >
+ {saving ? 'Saving…' : 'Save'}
+ </button>
+ </div>
+ </>
+ )
) : (
<>
{attachedServers.length > 1 ? (
diff --git a/control-ui/components/SecretsTable.tsx b/control-ui/components/SecretsTable.tsx
index 6fbc47b68..2eb271159 100644
--- a/control-ui/components/SecretsTable.tsx
+++ b/control-ui/components/SecretsTable.tsx
@@ -14,6 +14,7 @@ import {
type RecipeSecretItem,
type SecretIdentity,
apiSend,
+ deleteMcpSecret,
deleteRecipeSecret,
getMcpServers,
getRecipeSecrets,
@@ -46,6 +47,9 @@ type McpSecretRow = {
servers: string[]
registryEntries: string[]
registrySources: Array<{ name: string; version: string }>
+ /** Live Secret identity for compare-and-delete; absent on older backends. */
+ uid?: string
+ resourceVersion?: string
}
type RecipeSecretStatus = 'provisioned' | 'missing'
type RecipeSecretRowOwnership =
@@ -112,6 +116,7 @@ export function SecretsTable({
const [mcpRows, setMcpRows] = useState<McpSecretRow[]>([])
const [mcpLoading, setMcpLoading] = useState(false)
const [mcpError, setMcpError] = useState('')
+ const [mcpDeletingName, setMcpDeletingName] = useState<string | null>(null)
// Recipe secrets state
const [recipeSearchQuery, setRecipeSearchQuery] = useState('')
@@ -256,16 +261,24 @@ export function SecretsTable({
if (item.name) addSecret(item.name)
}
+ const identityByName = new Map(
+ (provisioned.items ?? [])
+ .filter(item => item.name && item.uid && item.resourceVersion)
+ .map(item => [item.name, { uid: item.uid!, resourceVersion: item.resourceVersion! }])
+ )
+
const nextRows = Array.from(usage.entries())
.map(([name, details]) => {
const registrySources = Array.from(details.registrySources.values()).sort((a, b) =>
`${a.name}@${a.version}`.localeCompare(`${b.name}@${b.version}`)
)
+ const identity = identityByName.get(name)
return {
name,
servers: Array.from(details.servers).sort((a, b) => a.localeCompare(b)),
registryEntries: registrySources.map(source => `${source.name}@${source.version}`),
registrySources,
+ ...(identity ? identity : {}),
}
})
.sort((a, b) => a.name.localeCompare(b.name))
@@ -400,6 +413,34 @@ export function SecretsTable({
router.push(CONTROL_ROUTES.secrets.editRecipe(name, Object.fromEntries(qs)))
}
+ async function deleteMcpSecretRow(row: McpSecretRow) {
+ const { name, uid, resourceVersion } = row
+ if (!uid || !resourceVersion) {
+ setMcpError(
+ `Secret ${name} has no current identity. Refresh the page and review the latest state before deleting it.`
+ )
+ return
+ }
+ const ok = await confirm({
+ title: 'Delete connector Secret',
+ message: `Delete connector secret ${name}? Connectors referencing it will fail until they are reconfigured.`,
+ confirmLabel: 'Delete',
+ tone: 'danger',
+ })
+ if (!ok) return
+ setMcpDeletingName(name)
+ setMcpError('')
+ try {
+ await deleteMcpSecret(name, { uid, resourceVersion } satisfies SecretIdentity)
+ showToast(`Secret ${name} deleted.`, { tone: 'success' })
+ await loadMcpSecretReferences()
+ } catch (e) {
+ setMcpError(e instanceof Error ? e.message : 'Failed to delete connector secret')
+ } finally {
+ setMcpDeletingName(null)
+ }
+ }
+
async function deleteRecipeSecretRow(row: RecipeSecretRow) {
const { name, namespace, uid, resourceVersion } = row
if (!uid || !resourceVersion) {
@@ -736,17 +777,18 @@ export function SecretsTable({
},
{
key: 'delete',
- label: 'Delete',
+ label: mcpDeletingName === row.name ? 'Deleting…' : 'Delete',
danger: true,
// deleteMcpSecret requires the Secret's live
// uid/resourceVersion as its CAS precondition.
- // Connector rows are derived from McpServer
- // references and no list API returns that
- // identity, so delete stays inert rather than
+ // The provisioned listing carries it; without it
+ // (older backend) delete stays inert rather than
// issuing an unfenced delete.
- disabled: true,
- disabledReason: 'Delete is not available for this secret.',
- onClick: () => {},
+ disabled:
+ !row.uid || !row.resourceVersion || mcpDeletingName === row.name,
+ disabledReason:
+ 'Refresh to load this Secret identity before deleting it.',
+ onClick: () => void deleteMcpSecretRow(row),
},
]}
/>
diff --git a/control-ui/components/__tests__/EditConnectorSecretPage.test.tsx b/control-ui/components/__tests__/EditConnectorSecretPage.test.tsx
index 5d28765ad..555c6b523 100644
--- a/control-ui/components/__tests__/EditConnectorSecretPage.test.tsx
+++ b/control-ui/components/__tests__/EditConnectorSecretPage.test.tsx
@@ -10,6 +10,7 @@ import {
getMcpServer,
getMcpServers,
getRegistryCredentialSchema,
+ listMcpSecrets,
updateMcpSecret,
} from '../../lib/api'
import { buildMcpServerReference } from '../../test/fixtures/mcpServer'
@@ -45,6 +46,7 @@ vi.mock('../../lib/api', () => ({
getMcpServer: vi.fn(),
getMcpServers: vi.fn(),
getRegistryCredentialSchema: vi.fn(),
+ listMcpSecrets: vi.fn(),
updateMcpSecret: vi.fn(),
}))
@@ -52,6 +54,7 @@ const mockCreateMcpSecret = vi.mocked(createMcpSecret)
const mockGetMcpServer = vi.mocked(getMcpServer)
const mockGetMcpServers = vi.mocked(getMcpServers)
const mockGetRegistryCredentialSchema = vi.mocked(getRegistryCredentialSchema)
+const mockListMcpSecrets = vi.mocked(listMcpSecrets)
const mockUpdateMcpSecret = vi.mocked(updateMcpSecret)
function server(options: {
@@ -132,6 +135,9 @@ beforeEach(() => {
keys: ['api-key'],
affectedConnectors: ['linear-conn'],
})
+ mockListMcpSecrets.mockResolvedValue({
+ items: [{ name: 'linear-credentials', keys: ['api-key', 'refresh-token'] }],
+ })
})
afterEach(() => {
@@ -285,12 +291,43 @@ describe('EditConnectorSecretPage', () => {
expect(mockCreateMcpSecret).not.toHaveBeenCalled()
})
- it('explains when no connector currently references the secret', async () => {
+ it('rotates values directly when no connector references the secret yet', async () => {
mockGetMcpServers.mockResolvedValue({ items: [] })
await renderPage()
- expect(screen.getByText(/No connector currently references Secret/i)).toBeInTheDocument()
- expect(screen.queryByRole('button', { name: 'Rotate credentials' })).not.toBeInTheDocument()
+ expect(screen.getByText('Rotate stored values')).toBeInTheDocument()
+ expect(screen.getByText(/No connector references this Secret yet/i)).toBeInTheDocument()
+ expect(screen.getByLabelText('api-key')).toBeInTheDocument()
+ expect(screen.getByLabelText('refresh-token')).toBeInTheDocument()
+
+ fireEvent.change(screen.getByLabelText('api-key'), { target: { value: 'new-token' } })
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }))
+ await flush()
+
+ expect(mockUpdateMcpSecret).toHaveBeenCalledWith('linear-credentials', {
+ 'api-key': 'new-token',
+ })
+ expect(navigation.push).toHaveBeenCalledWith('/secrets/connector')
+ })
+
+ it('keeps unfilled keys out of the direct rotation and refuses empty saves', async () => {
+ mockGetMcpServers.mockResolvedValue({ items: [] })
+ await renderPage()
+
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }))
+ await flush()
+
+ expect(screen.getByRole('alert')).toHaveTextContent('Fill in at least one key')
+ expect(mockUpdateMcpSecret).not.toHaveBeenCalled()
+ })
+
+ it('explains when the secret itself no longer exists', async () => {
+ mockGetMcpServers.mockResolvedValue({ items: [] })
+ mockListMcpSecrets.mockResolvedValue({ items: [] })
+ await renderPage()
+
+ expect(screen.getByText(/No connector secret named/i)).toBeInTheDocument()
+ expect(screen.queryByRole('button', { name: 'Save' })).not.toBeInTheDocument()
})
it('shows the connector load error without presenting an empty result as verified', async () => {
diff --git a/control-ui/components/__tests__/RegistryConnectorCredentialContract.test.tsx b/control-ui/components/__tests__/RegistryConnectorCredentialContract.test.tsx
index 8af31deef..f8f979444 100644
--- a/control-ui/components/__tests__/RegistryConnectorCredentialContract.test.tsx
+++ b/control-ui/components/__tests__/RegistryConnectorCredentialContract.test.tsx
@@ -6,6 +6,7 @@ import {
getMcpServer,
getMcpServers,
getRegistryCredentialSchema,
+ listMcpSecrets,
updateMcpSecret,
} from '../../lib/api'
import { buildRegistryMcpServerReference } from '../../test/fixtures/mcpServer'
@@ -27,6 +28,7 @@ vi.mock('../../lib/api', () => ({
getMcpServer: vi.fn(),
getMcpServers: vi.fn(),
getRegistryCredentialSchema: vi.fn(),
+ listMcpSecrets: vi.fn(),
updateMcpSecret: vi.fn(),
}))
@@ -41,6 +43,7 @@ beforeEach(() => {
// contract rather than being hidden by a fixture-owned `managed: true`.
expect(connector.spec?.managed).toBe(true)
vi.mocked(getMcpServers).mockResolvedValue({ items: [connector] })
+ vi.mocked(listMcpSecrets).mockResolvedValue({ items: [] })
vi.mocked(getMcpServer).mockResolvedValue(connector)
vi.mocked(getRegistryCredentialSchema).mockResolvedValue({
required: true,
diff --git a/control-ui/components/__tests__/SecretsTable.test.tsx b/control-ui/components/__tests__/SecretsTable.test.tsx
index 45dc6689c..9eefe109d 100644
--- a/control-ui/components/__tests__/SecretsTable.test.tsx
+++ b/control-ui/components/__tests__/SecretsTable.test.tsx
@@ -10,6 +10,7 @@ import {
} from '@testing-library/react'
import {
apiSend,
+ deleteMcpSecret,
deleteRecipeSecret,
getMcpServers,
getRecipeSecrets,
@@ -36,6 +37,7 @@ vi.mock('../../lib/api', async () => {
return {
...actual,
apiSend: vi.fn(),
+ deleteMcpSecret: vi.fn(),
deleteRecipeSecret: vi.fn(),
getMcpServers: vi.fn(),
getRecipeSecrets: vi.fn(),
@@ -45,6 +47,7 @@ vi.mock('../../lib/api', async () => {
})
const apiSendMock = vi.mocked(apiSend)
+const deleteMcpSecretMock = vi.mocked(deleteMcpSecret)
const deleteRecipeSecretMock = vi.mocked(deleteRecipeSecret)
const getMcpServersMock = vi.mocked(getMcpServers)
const getRecipeSecretsMock = vi.mocked(getRecipeSecrets)
@@ -56,10 +59,12 @@ const listMcpSecretsMock = vi.mocked(listMcpSecrets)
beforeEach(() => {
apiSendMock.mockReset()
apiSendMock.mockResolvedValue(undefined as never)
+ deleteMcpSecretMock.mockReset()
+ deleteMcpSecretMock.mockResolvedValue(undefined as never)
deleteRecipeSecretMock.mockReset()
deleteRecipeSecretMock.mockResolvedValue(undefined as never)
// The provisioned listing defaults to empty; connector tests that care
- // about unreferenced secrets override it explicitly.
+ // about unreferenced secrets or delete identity override it explicitly.
listMcpSecretsMock.mockReset()
listMcpSecretsMock.mockResolvedValue({ items: [] })
})
@@ -479,7 +484,7 @@ describe('SecretsTable — connector row actions', () => {
cleanup()
})
- function mockConnectorRow() {
+ function mockConnectorRow(identity?: { uid?: string; resourceVersion?: string }) {
getMcpServersMock.mockResolvedValue({
items: [
buildDirectCrdMcpServerReference({
@@ -492,6 +497,11 @@ describe('SecretsTable — connector row actions', () => {
}),
],
})
+ if (identity) {
+ listMcpSecretsMock.mockResolvedValue({
+ items: [{ name: 'linear-credentials', keys: ['api-key'], ...identity }],
+ })
+ }
}
async function openRowMenu() {
@@ -501,25 +511,52 @@ describe('SecretsTable — connector row actions', () => {
fireEvent.click(trigger)
}
- it('offers Update and a disabled Delete alongside Add on every connector row', async () => {
- mockConnectorRow()
+ it('offers Update, enabled Delete, and Add on a connector row with identity', async () => {
+ mockConnectorRow({
+ uid: 'uid-linear-1',
+ resourceVersion: '42',
+ })
renderTable()
await openRowMenu()
expect(screen.getByRole('menuitem', { name: 'Add' })).toBeEnabled()
expect(screen.getByRole('menuitem', { name: 'Update' })).toBeEnabled()
- const deleteAction = screen.getByRole('menuitem', { name: /^Delete/ })
- expect(deleteAction).toHaveAttribute('aria-disabled', 'true')
- expect(screen.getByText('Delete is not available for this secret.')).toBeInTheDocument()
+ expect(screen.getByRole('menuitem', { name: /^Delete/ })).toBeEnabled()
})
- it('keeps the disabled Delete inert instead of confirming or calling the API', async () => {
- mockConnectorRow()
+ it('deletes a connector secret through its live identity after confirmation', async () => {
+ mockConnectorRow({
+ uid: 'uid-linear-1',
+ resourceVersion: '42',
+ })
+ deleteMcpSecretMock.mockResolvedValue({ name: 'linear-credentials', namespace: 'mcp-servers' })
renderTable()
await openRowMenu()
fireEvent.click(screen.getByRole('menuitem', { name: /^Delete/ }))
+ const dialog = await screen.findByRole('alertdialog')
+ fireEvent.click(within(dialog).getByRole('button', { name: 'Delete' }))
+
+ await waitFor(() => {
+ expect(deleteMcpSecretMock).toHaveBeenCalledWith('linear-credentials', {
+ uid: 'uid-linear-1',
+ resourceVersion: '42',
+ })
+ })
+ })
+ it('keeps Delete disabled without a listing-provided identity', async () => {
+ mockConnectorRow()
+ renderTable()
+ await openRowMenu()
+
+ const deleteAction = screen.getByRole('menuitem', { name: /^Delete/ })
+ expect(deleteAction).toHaveAttribute('aria-disabled', 'true')
+ expect(
+ screen.getByText('Refresh to load this Secret identity before deleting it.')
+ ).toBeInTheDocument()
+
+ fireEvent.click(deleteAction)
expect(screen.queryByRole('alertdialog')).toBeNull()
expect(apiSendMock).not.toHaveBeenCalled()
})
diff --git a/control-ui/lib/oauthInstall.types.ts b/control-ui/lib/oauthInstall.types.ts
index 01a965f42..c8b447b01 100644
--- a/control-ui/lib/oauthInstall.types.ts
+++ b/control-ui/lib/oauthInstall.types.ts
@@ -64,7 +64,11 @@ export type OAuthCredentialManifest = {
}
// GET /admin/mcp-secrets item — names + keys only, never values (E-16.1).
+// `uid`/`resourceVersion` carry the live Secret identity for
+// compare-and-delete; they are optional so older backends still type-check.
export type McpSecretSummary = {
name: string
keys: string[]
+ uid?: string
+ resourceVersion?: string
}
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 89df19642..191082cb1 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.729",
+ "version": "0.1.730",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.729",
+ "version": "0.1.730",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index a23f3ab42..86b2a5f69 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.729",
+ "version": "0.1.730",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",