Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): list unreferenced connector secrets after creation

M59a02fd03b40
diff --git a/control-ui/components/SecretsTable.tsx b/control-ui/components/SecretsTable.tsx
index dd672fd47..6fbc47b68 100644
--- a/control-ui/components/SecretsTable.tsx
+++ b/control-ui/components/SecretsTable.tsx
@@ -18,6 +18,7 @@ import {
getMcpServers,
getRecipeSecrets,
getRecipes,
+ listMcpSecrets,
} from '../lib/api'
import { getProviderLabel, getProvidersWithCompleteCredentials } from '../lib/llm'
import { collectWorkflowRecipeSecretRefs } from '../lib/workflowRecipeSecretRefs'
@@ -48,7 +49,10 @@ type McpSecretRow = {
}
type RecipeSecretStatus = 'provisioned' | 'missing'
type RecipeSecretRowOwnership =
- { kind: 'shared' } | { kind: 'owner-recipe'; recipeName: string } | { kind: 'unlabeled' } | null // missing rows: not yet provisioned, ownership chosen at create time.
+ | { kind: 'shared' }
+ | { kind: 'owner-recipe'; recipeName: string }
+ | { kind: 'unlabeled' }
+ | null // missing rows: not yet provisioned, ownership chosen at create time.
type RecipeSecretRow = {
name: string
namespace: string
@@ -207,7 +211,10 @@ export function SecretsTable({
setMcpLoading(true)
setMcpError('')
try {
- const result = await getMcpServers()
+ // Server references carry the usage columns, but a Secret created
+ // moments ago is referenced by no server yet — the provisioned
+ // listing (names + keys only) keeps it visible immediately.
+ const [result, provisioned] = await Promise.all([getMcpServers(), listMcpSecrets()])
const usage = new Map<
string,
{ servers: Set<string>; registrySources: Map<string, { name: string; version: string }> }
@@ -245,6 +252,10 @@ export function SecretsTable({
}
}
+ for (const item of provisioned.items ?? []) {
+ if (item.name) addSecret(item.name)
+ }
+
const nextRows = Array.from(usage.entries())
.map(([name, details]) => {
const registrySources = Array.from(details.registrySources.values()).sort((a, b) =>
diff --git a/control-ui/components/__tests__/SecretsTable.test.tsx b/control-ui/components/__tests__/SecretsTable.test.tsx
index 1036d559a..45dc6689c 100644
--- a/control-ui/components/__tests__/SecretsTable.test.tsx
+++ b/control-ui/components/__tests__/SecretsTable.test.tsx
@@ -14,6 +14,7 @@ import {
getMcpServers,
getRecipeSecrets,
getRecipes,
+ listMcpSecrets,
} from '../../lib/api'
import {
buildDirectCrdMcpServerReference,
@@ -39,6 +40,7 @@ vi.mock('../../lib/api', async () => {
getMcpServers: vi.fn(),
getRecipeSecrets: vi.fn(),
getRecipes: vi.fn(),
+ listMcpSecrets: vi.fn(),
}
})
@@ -47,6 +49,7 @@ const deleteRecipeSecretMock = vi.mocked(deleteRecipeSecret)
const getMcpServersMock = vi.mocked(getMcpServers)
const getRecipeSecretsMock = vi.mocked(getRecipeSecrets)
const getRecipesMock = vi.mocked(getRecipes)
+const listMcpSecretsMock = vi.mocked(listMcpSecrets)
// apiSend is the shared write path for every scope in this table, so its state
// is reset for the whole file rather than per describe.
@@ -55,6 +58,10 @@ beforeEach(() => {
apiSendMock.mockResolvedValue(undefined as never)
deleteRecipeSecretMock.mockReset()
deleteRecipeSecretMock.mockResolvedValue(undefined as never)
+ // The provisioned listing defaults to empty; connector tests that care
+ // about unreferenced secrets override it explicitly.
+ listMcpSecretsMock.mockReset()
+ listMcpSecretsMock.mockResolvedValue({ items: [] })
})
function renderTable(
@@ -211,6 +218,35 @@ describe('SecretsTable — connector marketplace source', () => {
})
expect(screen.queryByText(/stale@0\.0\.1/)).toBeNull()
})
+
+ it('lists a newly created connector secret that no server references yet', async () => {
+ getMcpServersMock.mockResolvedValue({
+ items: [
+ buildDirectCrdMcpServerReference({
+ name: 'attached-conn',
+ secretName: 'attached-conn-credentials',
+ }),
+ ],
+ })
+ listMcpSecretsMock.mockResolvedValue({
+ items: [
+ { name: 'attached-conn-credentials', keys: ['api-key'] },
+ { name: 'brand-new-conn-credentials', keys: ['api-key'] },
+ ],
+ })
+
+ renderTable()
+
+ const freshRow = await waitFor(() => {
+ const row = screen.getByText('brand-new-conn-credentials').closest('tr')!
+ expect(row).toBeTruthy()
+ return row
+ })
+ expect(within(freshRow).getByText('Not yet attached to a connector.')).toBeInTheDocument()
+ expect(within(freshRow).getByText('Created manually or source unknown.')).toBeInTheDocument()
+ const attachedRow = screen.getByText('attached-conn-credentials').closest('tr')!
+ expect(within(attachedRow).getByText('1 server(s): attached-conn')).toBeInTheDocument()
+ })
})
describe('SecretsTable — recipe deletion identity', () => {
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 131a17269..89df19642 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.728",
+ "version": "0.1.729",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.728",
+ "version": "0.1.729",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 6cda74840..a23f3ab42 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.728",
+ "version": "0.1.729",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",