Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): r1-m2 expose the default model sort

Josué5a5f9775fbbe
diff --git a/control-ui/components/LlmModelTable.tsx b/control-ui/components/LlmModelTable.tsx
index 5ee803dd1..7f3d0d76f 100644
--- a/control-ui/components/LlmModelTable.tsx
+++ b/control-ui/components/LlmModelTable.tsx
@@ -25,7 +25,6 @@ import { IconRefresh } from './icons'
import { SelectInput } from './ui'
type ModelSortKey =
- | 'provider'
| 'model'
| 'credential'
| 'vendor'
@@ -174,11 +173,10 @@ export function LlmModelTable({
}, [filteredItems])
const modelSort = useTableSort<DisplayModel, ModelSortKey>({
rows: displayItems,
- defaultKey: 'provider',
+ defaultKey: 'model',
defaultDirections: { contextWindow: 'desc' },
identity: model => model.id,
accessors: {
- provider: model => getProviderDisplayLabel(catalogGroupKey(model.provider)),
model: model => model.model,
credential: model => model.credentialLabel,
vendor: model => model.vendor,
diff --git a/control-ui/components/__tests__/LlmModelTable.test.tsx b/control-ui/components/__tests__/LlmModelTable.test.tsx
index 454a4fae4..4c38a3a1b 100644
--- a/control-ui/components/__tests__/LlmModelTable.test.tsx
+++ b/control-ui/components/__tests__/LlmModelTable.test.tsx
@@ -498,30 +498,33 @@ describe('LlmModelTable sorting', () => {
expect(screen.getByRole('heading', { name: /LLM Models/ })).toBeInTheDocument()
})
- it('sorts models inside a provider group by model name when ascending', () => {
- const alpha = newModel({ id: 'a', model: 'alpha', display_name: 'Alpha' })
- const bravo = newModel({ id: 'b', model: 'bravo', display_name: 'Bravo' })
- const charlie = newModel({ id: 'c', model: 'charlie', display_name: 'Charlie' })
+ it('exposes model ascending as the initial sort and applies it inside groups', () => {
+ const alpha = newModel({ id: 'z', model: 'alpha', display_name: 'Alpha' })
+ const bravo = newModel({ id: 'm', model: 'bravo', display_name: 'Bravo' })
+ const charlie = newModel({ id: 'a', model: 'charlie', display_name: 'Charlie' })
renderTable([charlie, alpha, bravo])
expandAnthropicModels()
- fireEvent.click(screen.getByRole('button', { name: 'Sort by Model ascending' }))
-
+ expect(screen.getByRole('columnheader', { name: 'Model' })).toHaveAttribute(
+ 'aria-sort',
+ 'ascending'
+ )
expect(expandedRowOrder()).toEqual(['alpha', 'bravo', 'charlie'])
})
- it('toggles a sort header to descending on the second click', () => {
+ it('toggles the active model sort between descending and ascending', () => {
const alpha = newModel({ id: 'a', model: 'alpha' })
const bravo = newModel({ id: 'b', model: 'bravo' })
renderTable([alpha, bravo])
expandAnthropicModels()
- const modelSort = screen.getByRole('button', { name: 'Sort by Model ascending' })
- fireEvent.click(modelSort)
expect(expandedRowOrder()).toEqual(['alpha', 'bravo'])
fireEvent.click(screen.getByRole('button', { name: 'Sort by Model descending' }))
expect(expandedRowOrder()).toEqual(['bravo', 'alpha'])
+
+ fireEvent.click(screen.getByRole('button', { name: 'Sort by Model ascending' }))
+ expect(expandedRowOrder()).toEqual(['alpha', 'bravo'])
})
it('sorts context window descending by default and pushes null values to the end', () => {
@@ -542,8 +545,7 @@ describe('LlmModelTable sorting', () => {
renderTable([alpha, bravo])
expandAnthropicModels()
- // Model asc (default for text columns).
- fireEvent.click(screen.getByRole('button', { name: 'Sort by Model ascending' }))
+ // Model asc is the visible initial sort.
expect(expandedRowOrder()).toEqual(['alpha', 'bravo'])
// Switching to context window uses its natural default (descending) — not
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 74da16267..a2b8166f9 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.578",
+ "version": "0.1.579",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.578",
+ "version": "0.1.579",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 1b1fd6549..ff879807f 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.578",
+ "version": "0.1.579",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",