Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

refactor(frontend): expose primary detail actions

Josué5a85b449cf26
diff --git a/control-ui/app/registry/entries/[name]/[version]/page.tsx b/control-ui/app/registry/entries/[name]/[version]/page.tsx
index 86b0b32bc..017c38098 100644
--- a/control-ui/app/registry/entries/[name]/[version]/page.tsx
+++ b/control-ui/app/registry/entries/[name]/[version]/page.tsx
@@ -27,13 +27,11 @@ import RegistryEntryDetailLoading from './loading'
export const dynamic = 'force-dynamic'
function RegistryEntryActionsMenu({
- onEdit,
onRemove,
removing,
sourceRepoUrl,
canManage,
}: {
- onEdit: () => void
onRemove: () => void
removing: boolean
sourceRepoUrl: string | null
@@ -90,17 +88,6 @@ function RegistryEntryActionsMenu({
) : null}
{canManage ? (
<>
- <button
- type="button"
- className="cu-kebab__item"
- role="menuitem"
- onClick={() => {
- setOpen(false)
- onEdit()
- }}
- >
- Edit
- </button>
<button
type="button"
className="cu-kebab__item cu-kebab__item--danger"
@@ -268,7 +255,7 @@ function RegistryEntryDetailContent() {
}
backLabel="Back to Marketplace"
onBack={backToCatalog}
- titleActions={
+ actions={
entry ? (
<>
{entry.status === 'published' ? (
@@ -287,8 +274,16 @@ function RegistryEntryDetailContent() {
</button>
)
) : null}
+ {canManageEntry ? (
+ <button
+ type="button"
+ className="cu-btn cu-btn--secondary cu-btn--sm"
+ onClick={editEntry}
+ >
+ Edit entry
+ </button>
+ ) : null}
<RegistryEntryActionsMenu
- onEdit={editEntry}
onRemove={() => void handleRemove()}
removing={removing}
sourceRepoUrl={sourceRepoUrl}
diff --git a/control-ui/app/workflow-recipes/[namespace]/[name]/page.tsx b/control-ui/app/workflow-recipes/[namespace]/[name]/page.tsx
index 211aa9fff..ab7cbfeb2 100644
--- a/control-ui/app/workflow-recipes/[namespace]/[name]/page.tsx
+++ b/control-ui/app/workflow-recipes/[namespace]/[name]/page.tsx
@@ -557,7 +557,7 @@ function WorkflowRecipeDetailContent() {
const hideRunButton = !runStatusStillLoading && !runnable
const conditionsCount = extractConditions(recipeStatus).length
const showIntegrations = hasBackgroundOauthClients(recipe)
- const pluginTitleActions = (
+ const pluginHeaderActions = (
<>
{!hideRunButton && (
<button
@@ -570,14 +570,17 @@ function WorkflowRecipeDetailContent() {
Run…
</button>
)}
+ <button
+ type="button"
+ className="cu-btn cu-btn--secondary cu-btn--sm"
+ disabled={!recipe}
+ onClick={() => router.push(CONTROL_ROUTES.plugins.edit(namespace, name))}
+ >
+ Edit plugin
+ </button>
<KebabMenu
ariaLabel="More plugin actions"
items={[
- {
- label: 'Edit',
- disabled: !recipe,
- onClick: () => router.push(CONTROL_ROUTES.plugins.edit(namespace, name)),
- },
...(String(recipeStatus?.phase ?? '') === 'failed'
? [
{
@@ -694,7 +697,7 @@ function WorkflowRecipeDetailContent() {
tabClassName="cu-tabs--compact"
tabs={detailTabs}
title={name || 'Plugin'}
- titleActions={pluginTitleActions}
+ actions={pluginHeaderActions}
>
{activeTab === 'workloads' ? (
<WorkloadsTab
diff --git a/control-ui/components/__tests__/RegistryEntryDetailPage.test.tsx b/control-ui/components/__tests__/RegistryEntryDetailPage.test.tsx
index 9bc6ec8d3..4e59642e4 100644
--- a/control-ui/components/__tests__/RegistryEntryDetailPage.test.tsx
+++ b/control-ui/components/__tests__/RegistryEntryDetailPage.test.tsx
@@ -159,4 +159,21 @@ describe('RegistryEntryDetailPage', () => {
).toBeTruthy()
expect(screen.queryByText('Downloads', { exact: true })).not.toBeInTheDocument()
})
+
+ it('exposes management as a labelled header CTA and keeps secondary actions in overflow', async () => {
+ navigationState.params = { name: 'market-report', version: '1.0.0' }
+ mockGetRegistryCatalog.mockResolvedValueOnce({
+ data: [RECIPE_ENTRY],
+ meta: { total: 1 },
+ categories: ['analytics'],
+ installed: { catalogKeys: [], serverNames: [], recipeKeys: [] },
+ })
+ render(<RegistryEntryDetailPage />)
+
+ const edit = await screen.findByRole('button', { name: 'Edit entry' })
+ expect(edit.closest('.cu-create-top__actions')).not.toBeNull()
+ fireEvent.click(screen.getByRole('button', { name: 'Marketplace entry actions' }))
+ expect(screen.queryByRole('menuitem', { name: 'Edit' })).not.toBeInTheDocument()
+ expect(screen.getByRole('menuitem', { name: 'Remove' })).toBeVisible()
+ })
})
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 5e9f27ea0..61e0d702d 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.618",
+ "version": "0.1.619",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.618",
+ "version": "0.1.619",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 8bfc970f4..ddc02d6f4 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.618",
+ "version": "0.1.619",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",