Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(control-ui): append newly added providers below stored sections
Miguelon Peluchon5b72384fbb39
diff --git a/control-ui/app/secrets/llm/[name]/edit/__tests__/page.test.tsx b/control-ui/app/secrets/llm/[name]/edit/__tests__/page.test.tsxindex 7ad8dfe46..e6bd72d11 100644--- a/control-ui/app/secrets/llm/[name]/edit/__tests__/page.test.tsx+++ b/control-ui/app/secrets/llm/[name]/edit/__tests__/page.test.tsx@@ -483,4 +483,17 @@ describe('Edit LLM secret page — additional provider credentials', () => {).toBeInTheDocument()expect(screen.getByLabelText(/Claude API key/i)).toBeInTheDocument()})++ it('appends a newly added provider below the stored one, whatever the canonical order', async () => {+ // openai canonically precedes zai; the stored zai credentials must stay+ // on top and the session-added OpenAI section must land below them.+ seedSecret(['zai-api-key'])+ await renderEditor()++ fireEvent.click(screen.getByLabelText('Add provider'))+ fireEvent.click(screen.getByRole('option', { name: 'OpenAI' }))++ const titles = document.querySelectorAll('.cu-llm-cred-group__title')+ expect(Array.from(titles).map(entry => entry.textContent)).toEqual(['Z.AI', 'OpenAI'])+ })})diff --git a/control-ui/components/LlmCredentialFields/index.tsx b/control-ui/components/LlmCredentialFields/index.tsxindex de7e9fbb8..00622cb54 100644--- a/control-ui/components/LlmCredentialFields/index.tsx+++ b/control-ui/components/LlmCredentialFields/index.tsx@@ -149,9 +149,16 @@ export function LlmCredentialFields({// Filtering LLM_CREDENTIAL_GROUPS (instead of iterating the sets) keeps the// canonical package order regardless of the order providers were added.+ // Sections for providers the Secret already holds (or that carry typed+ // values) render first; providers surfaced this session through "Add+ // provider" append BELOW them — a newly added provider that canonically+ // precedes a stored one (openai over zai) must not push itself on top of+ // the operator's existing credentials. Array#sort is stable, so each rank+ // keeps its canonical order. In the create flow every section is+ // session-added (rank 1), leaving that order untouched.const visibleGroups = LLM_SECRET_EDITOR_GROUPS.filter(group =>visibleProviders.has(group.provider)- )+ ).sort((a, b) => Number(manuallyAdded.has(a.provider)) - Number(manuallyAdded.has(b.provider)))const addableGroups = LLM_SECRET_EDITOR_GROUPS.filter(group => !visibleProviders.has(group.provider) && !excludedProviderSet.has(group.provider))diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 522870105..bbe61f2ce 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.713",+ "version": "0.1.714","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.713",+ "version": "0.1.714","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/frontend-components": "file:../packages/frontend-components",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 532129fc6..215b5cce3 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.713",+ "version": "0.1.714","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",