Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): r5-l3 preserve empty Markdown fragments

Josué5bed17afb9c8
diff --git a/control-ui/components/MarkdownContent/index.tsx b/control-ui/components/MarkdownContent/index.tsx
index 1349e4cc8..a91eb3947 100644
--- a/control-ui/components/MarkdownContent/index.tsx
+++ b/control-ui/components/MarkdownContent/index.tsx
@@ -34,9 +34,10 @@ function renderMarkdownLink({ children, href }: { children?: React.ReactNode; hr
if (!safeHref) return <span>{children}</span>
const isFragment = safeHref.startsWith('#')
const fragment = safeHref.slice(1)
- const alignedHref = isFragment
- ? `#${fragment.startsWith('user-content-') ? fragment : `user-content-${fragment}`}`
- : safeHref
+ const alignedHref =
+ isFragment && fragment.length > 0
+ ? `#${fragment.startsWith('user-content-') ? fragment : `user-content-${fragment}`}`
+ : safeHref
return (
<a
href={alignedHref}
diff --git a/control-ui/components/__tests__/HostIdentityTab.test.tsx b/control-ui/components/__tests__/HostIdentityTab.test.tsx
index 77f3ee44b..c34765b09 100644
--- a/control-ui/components/__tests__/HostIdentityTab.test.tsx
+++ b/control-ui/components/__tests__/HostIdentityTab.test.tsx
@@ -135,16 +135,18 @@ describe('HostIdentityTab', () => {
it('keeps sanitized heading ids aligned with Markdown fragment links', async () => {
vi.mocked(api.getHostPersonalization).mockResolvedValue({
...initialFiles,
- identity: '## Target heading\n\n[Jump to target](#target-heading)',
+ identity: '## Target heading\n\n[Jump to target](#target-heading)\n\n[Back to top](#)',
})
renderTab()
const heading = await screen.findByRole('heading', { name: 'Target heading' })
const link = screen.getByRole('link', { name: 'Jump to target' })
+ const topLink = screen.getByRole('link', { name: 'Back to top' })
const fragmentId = link.getAttribute('href')?.slice(1)
expect(fragmentId).toBeTruthy()
expect(document.getElementById(fragmentId ?? '')).toBe(heading)
+ expect(topLink).toHaveAttribute('href', '#')
})
it.each(['{Enter}', ' '])(
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index a14cf64c5..23d5c8277 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.651",
+ "version": "0.1.652",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.651",
+ "version": "0.1.652",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index de077ca6a..470dbb936 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.651",
+ "version": "0.1.652",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",