Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
test(desktop): stabilize profile identities and BFF guard observations
Alfredo Lopez602ac9523929
diff --git a/desktop-app/test/subscriptionAdmissionGuard.test.ts b/desktop-app/test/subscriptionAdmissionGuard.test.tsindex 74130d245..57742c1f5 100644--- a/desktop-app/test/subscriptionAdmissionGuard.test.ts+++ b/desktop-app/test/subscriptionAdmissionGuard.test.ts@@ -3,6 +3,8 @@ import fs from 'node:fs'import path from 'node:path'import {isProtectedSubscriptionBusinessPath,+ isSubscriptionAdmissionAuthProbe,+ observeProtectedSubscriptionBusinessAccess,requireSubscriptionAdmissionGuardEnv,} from '../../tests/e2e/playwright/helpers/subscription-admission-guard'@@ -14,16 +16,65 @@ describe('negative subscription admission guard contract', () => {'/api/v1/admin/agents/unit/model','/api/v1/admin/hosts/unit','/api/v1/admin/llm-models',+ '/control-api/api/v1/admin/llm/providers/codex-subscription/connections',+ '/control-api/api/v1/admin/llm/providers/grok-subscription/connections/unit/models',+ '/control-api/api/v1/admin/agents/unit/model',+ '/control-api/api/v1/admin/hosts/unit',+ '/control-api/api/v1/admin/llm-models',])expect(isProtectedSubscriptionBusinessPath(pathname)).toBe(true)for (const pathname of ['/api/v1/admin/auth/me','/secrets/llm/subscriptions','/api/v1/health',+ '/control-api/api/v1/admin/auth/me',+ '/foreign/control-api/api/v1/admin/hosts/unit',+ '/control-api-copy/api/v1/admin/hosts/unit',]) {expect(isProtectedSubscriptionBusinessPath(pathname)).toBe(false)}})+ it('matches the actual BFF auth probe and direct API route without suffix or method widening', () => {+ // This path/status was observed in all three anonymous native guard traces.+ const actual = {+ url: 'http://127.0.0.1:34013/control-api/api/v1/admin/auth/me',+ method: 'GET',+ status: 401,+ }+ expect(isSubscriptionAdmissionAuthProbe(actual.url, actual.method)).toBe(true)+ expect(actual.status).toBe(401)+ expect(+ isSubscriptionAdmissionAuthProbe('http://127.0.0.1:34103/api/v1/admin/auth/me', 'GET')+ ).toBe(true)+ for (const url of [+ 'http://127.0.0.1:34013/foreign/control-api/api/v1/admin/auth/me',+ 'http://127.0.0.1:34013/control-api-copy/api/v1/admin/auth/me',+ 'http://127.0.0.1:34013/control-api/api/v1/admin/auth/me/permissions',+ 'http://127.0.0.1:34013/api/v1/admin/auth/me-copy',+ ])+ expect(isSubscriptionAdmissionAuthProbe(url, 'GET')).toBe(false)+ expect(isSubscriptionAdmissionAuthProbe(actual.url, 'POST')).toBe(false)+ })+ it('captures protected BFF and direct requests so an empty business oracle cannot hide either form', () => {+ let listener: ((request: { url(): string; method(): string }) => void) | undefined+ const attempted = observeProtectedSubscriptionBusinessAccess({+ on: (_event, callback) => {+ listener = callback+ },+ })+ if (!listener) throw new Error('request observer was not installed')+ for (const url of [+ 'http://127.0.0.1:34013/control-api/api/v1/admin/hosts/unit',+ 'http://127.0.0.1:34103/api/v1/admin/llm/providers/codex-subscription/connections',+ 'http://127.0.0.1:34013/control-api/api/v1/admin/auth/me',+ 'http://127.0.0.1:34013/foreign/control-api/api/v1/admin/hosts/unit',+ ])+ listener({ url: () => url, method: () => 'GET' })+ expect(attempted).toEqual([+ 'GET /control-api/api/v1/admin/hosts/unit',+ 'GET /api/v1/admin/llm/providers/codex-subscription/connections',+ ])+ })it('refuses default/shared/remote or unapproved guard targets at config load', () => {expect(() => requireSubscriptionAdmissionGuardEnv({})).toThrow(/E2E_SUBSCRIPTION_ADMISSION_GUARDS/diff --git a/desktop-app/ui/src/hooks/domain/__tests__/useAuthController.desktopEnvironment.test.tsx b/desktop-app/ui/src/hooks/domain/__tests__/useAuthController.desktopEnvironment.test.tsxindex 7f41406fc..c5753181f 100644--- a/desktop-app/ui/src/hooks/domain/__tests__/useAuthController.desktopEnvironment.test.tsx+++ b/desktop-app/ui/src/hooks/domain/__tests__/useAuthController.desktopEnvironment.test.tsx@@ -110,11 +110,29 @@ beforeEach(async () => {},}))runtimeConfigModule = await import('../../../../../src/config')+ // Profile ids combine the app-name slug with Date.now(). Allocate the+ // path-based target's id through a distinct temporary root profile, then+ // discard that placeholder after creating the user-facing path profile.+ await runtimeConfigModule.saveDesktopRuntimeConfig({+ ...targetEnvironment,+ appName: 'Example tenant path',+ })await runtimeConfigModule.saveDesktopRuntimeConfig({...targetEnvironment,externalRestApiBaseUrl: `${targetEnvironment.externalRestApiBaseUrl}/api/v1`,rpcProxyBaseUrl: `${targetEnvironment.rpcProxyBaseUrl}/rpc`,})+ const pathNamePlaceholder = (+ await runtimeConfigModule.getDesktopRuntimeConfigState()+ ).options.find(+ option =>+ option.externalRestApiBaseUrl === targetEnvironment.externalRestApiBaseUrl &&+ option.rpcProxyBaseUrl === targetEnvironment.rpcProxyBaseUrl+ )+ if (!pathNamePlaceholder) {+ throw new Error('The config producer did not retain the distinct path-profile id')+ }+ await runtimeConfigModule.deleteDesktopRuntimeConfigOption(pathNamePlaceholder.id)await runtimeConfigModule.saveDesktopRuntimeConfig(otherEnvironment)mocks.getRuntimeConfigState.mockImplementation(async () =>@@ -239,6 +257,7 @@ describe('Desktop environment handoff', () => {option.rpcProxyBaseUrl === targetEnvironment.rpcProxyBaseUrl)if (!savedTarget) throw new Error('The config producer did not return the saved REST profile')+ expect(savedTarget.id).not.toBe(pathBasedTarget.id)const other = (await runtimeConfigModule!.getDesktopRuntimeConfigState()).options.find(option => option.id !== savedTarget.id && option.id !== '__localhost__')diff --git a/tests/e2e/playwright/control-ui/codex-subscription-admission.spec.ts b/tests/e2e/playwright/control-ui/codex-subscription-admission.spec.tsindex 6acac381d..53a05b350 100644--- a/tests/e2e/playwright/control-ui/codex-subscription-admission.spec.ts+++ b/tests/e2e/playwright/control-ui/codex-subscription-admission.spec.ts@@ -7,7 +7,10 @@* - LLM Models is no longer the ChatGPT assignment owner.*/import { expect, test } from '@playwright/test'-import { observeProtectedSubscriptionBusinessAccess } from '../helpers/subscription-admission-guard'+import {+ isSubscriptionAdmissionAuthProbe,+ observeProtectedSubscriptionBusinessAccess,+} from '../helpers/subscription-admission-guard'test.describe('Codex subscription admission', () => {for (const guard of [@@ -31,10 +34,8 @@ test.describe('Codex subscription admission', () => {page,}) => {const attemptedBusiness = observeProtectedSubscriptionBusinessAccess(page)- const authProbe = page.waitForResponse(- response =>- new URL(response.url()).pathname === '/api/v1/admin/auth/me' &&- response.request().method() === 'GET'+ const authProbe = page.waitForResponse(response =>+ isSubscriptionAdmissionAuthProbe(response.url(), response.request().method()))// Negative deep-link guard: direct access is the behavior under test.await page.goto(guard.path)diff --git a/tests/e2e/playwright/helpers/subscription-admission-guard.ts b/tests/e2e/playwright/helpers/subscription-admission-guard.tsindex 40a2c1ce8..75d686a19 100644--- a/tests/e2e/playwright/helpers/subscription-admission-guard.ts+++ b/tests/e2e/playwright/helpers/subscription-admission-guard.ts@@ -1,13 +1,34 @@-import type { Page } from '@playwright/test'import path from 'node:path'+function controlApiAdminPath(pathname: string): string | null {+ const apiPrefix = '/api/v1/admin/'+ const proxyMount = '/control-api'+ const directPath = pathname.startsWith(`${proxyMount}${apiPrefix}`)+ ? pathname.slice(proxyMount.length)+ : pathname+ return directPath.startsWith(apiPrefix) ? directPath : null+}+export function isSubscriptionAdmissionAuthProbe(url: string, method: string): boolean {+ if (method !== 'GET') return false+ try {+ return controlApiAdminPath(new URL(url).pathname) === '/api/v1/admin/auth/me'+ } catch {+ return false+ }+}/** Observer only: negative guards own waitForResponse on the real auth probe. */export function isProtectedSubscriptionBusinessPath(pathname: string): boolean {+ const directPath = controlApiAdminPath(pathname)+ if (directPath === null) return falsereturn /^\/api\/v1\/admin\/(?:llm\/providers\/(?:codex-subscription|grok-subscription)(?:\/|$)|(?:hosts|agents)(?:\/|$)|llm-models(?:\/|$))/.test(- pathname+ directPath)}-export function observeProtectedSubscriptionBusinessAccess(page: Page): string[] {+type BusinessRequest = { url(): string; method(): string }+type BusinessRequestSource = {+ on(event: 'request', listener: (request: BusinessRequest) => void): unknown+}+export function observeProtectedSubscriptionBusinessAccess(page: BusinessRequestSource): string[] {const attempted: string[] = []page.on('request', request => {const pathname = new URL(request.url()).pathnamediff --git a/tests/e2e/playwright/package-lock.json b/tests/e2e/playwright/package-lock.jsonindex e49ae275f..026390d15 100644--- a/tests/e2e/playwright/package-lock.json+++ b/tests/e2e/playwright/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-playwright-tests",- "version": "0.1.65",+ "version": "0.1.66","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-playwright-tests",- "version": "0.1.65",+ "version": "0.1.66","devDependencies": {"@playwright/test": "^1.50.0","@types/node": "^22.0.0",diff --git a/tests/e2e/playwright/package.json b/tests/e2e/playwright/package.jsonindex 63176346f..602d5ab60 100644--- a/tests/e2e/playwright/package.json+++ b/tests/e2e/playwright/package.json@@ -1,6 +1,6 @@{"name": "clerum-playwright-tests",- "version": "0.1.65",+ "version": "0.1.66","private": true,"description": "Playwright E2E tests for Control UI and Desktop App","scripts": {